[Lldb-commits] [lldb] r369494 - [Symbol] Remove unused clang headers from Type

Author: xiaobai Date: Tue Aug 20 21:56:23 2019 New Revision: 369494 URL: http://llvm.org/viewvc/llvm-project?rev=369494=rev Log: [Symbol] Remove unused clang headers from Type Modified: lldb/trunk/include/lldb/Symbol/Type.h lldb/trunk/source/Symbol/Type.cpp Modified:

[Lldb-commits] [lldb] r369492 - [NFC] Remove unused function GetHexWithFixedSize

Author: jdevlieghere Date: Tue Aug 20 21:55:53 2019 New Revision: 369492 URL: http://llvm.org/viewvc/llvm-project?rev=369492=rev Log: [NFC] Remove unused function GetHexWithFixedSize The implementation of this function was obviously incorrect, as the result variable was never used. This led me

[Lldb-commits] [lldb] r369493 - [NFC] Return llvm::StringRef from StringExtractor::GetStringRef.

Author: jdevlieghere Date: Tue Aug 20 21:55:56 2019 New Revision: 369493 URL: http://llvm.org/viewvc/llvm-project?rev=369493=rev Log: [NFC] Return llvm::StringRef from StringExtractor::GetStringRef. This patch removes the two variant of StringExtractor::GetStringRef that return (non-)const

[Lldb-commits] [lldb] r369491 - [NFC] Simplify code

Author: jdevlieghere Date: Tue Aug 20 21:55:50 2019 New Revision: 369491 URL: http://llvm.org/viewvc/llvm-project?rev=369491=rev Log: [NFC] Simplify code This simplifies the code and updates the comments. Modified: lldb/trunk/source/DataFormatters/ValueObjectPrinter.cpp Modified:

Re: [Lldb-commits] [lldb] r369374 - unittests: Use yaml2obj as a library instead of an external process

Hi Pavel, looks like this broke the lldb-standalone macOS bot. http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-standalone/151/console FAILED: unittests/TestingSupport/CMakeFiles/lldbUtilityHelpers.dir/TestUtilities.cpp.o [trim]

[Lldb-commits] [lldb] r369485 - [NFC] Remove lldb_utility namespace.

Author: jdevlieghere Date: Tue Aug 20 17:50:46 2019 New Revision: 369485 URL: http://llvm.org/viewvc/llvm-project?rev=369485=rev Log: [NFC] Remove lldb_utility namespace. While generating the Doxygen I noticed this lone namespace that has one class and one function in it. This moves them into

[Lldb-commits] [PATCH] D66331: Save / restore selected platform in tests that may change it

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL369484: Update a few tests that may change the platform to save restore (authored by jmolenda, committed by ). Herald

[Lldb-commits] [lldb] r369484 - Update a few tests that may change the platform to save & restore

Author: jmolenda Date: Tue Aug 20 17:27:30 2019 New Revision: 369484 URL: http://llvm.org/viewvc/llvm-project?rev=369484=rev Log: Update a few tests that may change the platform to save & restore the platform in the setUp/tearDown methods. I want to migrate the re-instatement of the correct

[Lldb-commits] [lldb] r369479 - [Doxygen] Document private class members.

Author: jdevlieghere Date: Tue Aug 20 17:10:19 2019 New Revision: 369479 URL: http://llvm.org/viewvc/llvm-project?rev=369479=rev Log: [Doxygen] Document private class members. Given that the C++ documentation is meant for LLDB developers it makes sense to include private class members in the

[Lldb-commits] [lldb] r369477 - [dotest] Don't set the DWARF version override in CFLAGS_EXTRA.

Author: jdevlieghere Date: Tue Aug 20 16:56:32 2019 New Revision: 369477 URL: http://llvm.org/viewvc/llvm-project?rev=369477=rev Log: [dotest] Don't set the DWARF version override in CFLAGS_EXTRA. We cannot override the DWARF version in the CFLAGS_EXTRA because they are used by tests that

[Lldb-commits] [PATCH] D66507: Generalize FindTypes with CompilerContext to support fuzzy lookup

aprantl created this revision. aprantl added reviewers: JDevlieghere, clayborg, jasonmolenda, labath. This patch generalizes the FindTypes with CompilerContext interface to support looking up a type of unknown kind by name, as well as looking up a type inside an unspecified submodule. These

[Lldb-commits] [PATCH] D66102: [Symbol] Decouple clang from CompilerType

aprantl added a comment. Let's pick some random examples: `CompilerType(ClangASTContext::GetASTContext(m_ast_source.m_ast_context), generic_function_type.getAsOpaquePtr())` -> `ClangASTContext::GetASTContext(m_ast_source.m_ast_context).GetCompilerType(generic_function_type)` or

[Lldb-commits] [PATCH] D66102: [Symbol] Decouple clang from CompilerType

xiaobai added a comment. I wouldn't mind adding something to reduce boilerplate, but I'm not sure it would actually look too different. A wrapper function or subclass constructor would need to take a ClangASTContext and a clang::QualType so we could avoid calls to `getAsOpaquePtr()` everywhere

[Lldb-commits] [PATCH] D66102: [Symbol] Decouple clang from CompilerType

aprantl added a comment. Should we add some sort of convenience function or a ClangCompilerType subclass of CompilerType that reduces the amount of boilerplate needed on the RHS? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66102/new/

[Lldb-commits] [PATCH] D66102: [Symbol] Decouple clang from CompilerType

aprantl added a comment. ... or a method ClangASTContext::wrapClangType()? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66102/new/ https://reviews.llvm.org/D66102 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D66250: [JIT][Unwinder] Add Trampoline ObjectFile and UnwindPlan support for FCB

jasonmolenda added a comment. In D66250#1633455 , @clayborg wrote: > Why are we not just using ObjectFileJIT? I am guessing these breakpoint > expressions create one of these by compiling the breakpoint expression and > JIT'ing it just like any other

[Lldb-commits] [lldb] r369461 - [NFC] Fix -Wdocumentation warnings in Utility.

Author: jdevlieghere Date: Tue Aug 20 15:20:46 2019 New Revision: 369461 URL: http://llvm.org/viewvc/llvm-project?rev=369461=rev Log: [NFC] Fix -Wdocumentation warnings in Utility. This patch fixes a bunch of -Wdocumentation warnings in Utility. I'm sure there are still a bunch outdated comments

[Lldb-commits] [lldb] r369456 - [Symbol] Move VerifyDecl to ClangASTContext

Author: xiaobai Date: Tue Aug 20 15:06:13 2019 New Revision: 369456 URL: http://llvm.org/viewvc/llvm-project?rev=369456=rev Log: [Symbol] Move VerifyDecl to ClangASTContext VerifyDecl is specific to clang and is only used in ClangASTContext. Removed:

[Lldb-commits] [PATCH] D66499: [LLDB][Test] Remove `skipIfWindows` for conditional breakpoint test (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rL369453: [LLDB][Test] Remove `skipIfWindows` for conditional breakpoint test (NFC) (authored by mib, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [PATCH] D66499: [LLDB][Test] Remove `skipIfWindows` for conditional breakpoint test (NFC)

mib added a comment. In D66499#1638269 , @stella.stamenova wrote: > LGTM. Please monitor the windows Buildbot to make sure it still passes after > your commit though. Will do! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] r369452 - [NFC] Update RegularExpression documentation

Author: jdevlieghere Date: Tue Aug 20 14:56:49 2019 New Revision: 369452 URL: http://llvm.org/viewvc/llvm-project?rev=369452=rev Log: [NFC] Update RegularExpression documentation Modified: lldb/trunk/include/lldb/Utility/RegularExpression.h Modified:

[Lldb-commits] [PATCH] D66499: [LLDB][Test] Remove `skipIfWindows` for conditional breakpoint test (NFC)

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. LGTM. Please monitor the windows Buildbot to make sure it still passes after your commit though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D66499: [LLDB][Test] Remove `skipIfWindows` for conditional breakpoint test (NFC)

mib created this revision. mib added reviewers: stella.stamenova, jingham. Herald added a project: LLDB. The test for conditional breakpoints on Windows was skipped because there was no expression evaluation support at the time it was written. After removing the annotation and testing it again,

[Lldb-commits] [lldb] r369436 - [Symbol][NFC] Remove references to clang in TypeMap

Author: xiaobai Date: Tue Aug 20 13:44:36 2019 New Revision: 369436 URL: http://llvm.org/viewvc/llvm-project?rev=369436=rev Log: [Symbol][NFC] Remove references to clang in TypeMap Modified: lldb/trunk/source/Symbol/TypeMap.cpp Modified: lldb/trunk/source/Symbol/TypeMap.cpp URL:

[Lldb-commits] [PATCH] D66429: [CMake] Remove LLDB_TEST_USE_CUSTOM_C(XX)_COMPILER

This revision was automatically updated to reflect the committed changes. Closed by commit rL369435: [CMake] Remove LLDB_TEST_USE_CUSTOM_C(XX)_COMPILER (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r369435 - [CMake] Remove LLDB_TEST_USE_CUSTOM_C(XX)_COMPILER

Author: jdevlieghere Date: Tue Aug 20 13:20:20 2019 New Revision: 369435 URL: http://llvm.org/viewvc/llvm-project?rev=369435=rev Log: [CMake] Remove LLDB_TEST_USE_CUSTOM_C(XX)_COMPILER Given that LLDB_TEST_USE_CUSTOM_C_COMPILER and LLDB_TEST_C_COMPILER are both set at configuration time, I don't

[Lldb-commits] [PATCH] D66447: Add char8_t support (C++20)

JDevlieghere added a comment. In D66447#1637640 , @labath wrote: > This looks good to me, but why are we using a nul character to test utf8 > support? Shouldn't we insert some funnier characters too? I mean, one of the > advantages of unicode is that it

[Lldb-commits] [PATCH] D66447: Add char8_t support (C++20)

JDevlieghere updated this revision to Diff 216224. JDevlieghere added a comment. - Remove clean rule - Use more readable names CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66447/new/ https://reviews.llvm.org/D66447 Files: lldb/include/lldb/lldb-enumerations.h

[Lldb-commits] [PATCH] D66250: [JIT][Unwinder] Add Trampoline ObjectFile and UnwindPlan support for FCB

mib marked an inline comment as done. mib added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:3561 + if (UnwindPlanSP plan_sp = func_unwinders_sp->GetTrampolineUnwindPlan()) { +result.GetOutputStream().Printf("Trampoline

[Lldb-commits] [PATCH] D66250: [JIT][Unwinder] Add Trampoline ObjectFile and UnwindPlan support for FCB

shafik added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:3561 + if (UnwindPlanSP plan_sp = func_unwinders_sp->GetTrampolineUnwindPlan()) { +result.GetOutputStream().Printf("Trampoline UnwindPlan:\n"); Curious I

[Lldb-commits] [PATCH] D66248: [JIT][Command] Add "inject-condition" flag to conditional breakpoints

shafik added inline comments. Comment at: lldb/include/lldb/Breakpoint/BreakpointOptions.h:120 + /// BreakpointOptions(const char *condition, bool enabled = true, int32_t ignore = 0, bool one_shot = false, mib wrote: > shafik wrote: > >

[Lldb-commits] [PATCH] D66451: [ClangExpressionParser] Add ClangDeclVendor

This revision was automatically updated to reflect the committed changes. Closed by commit rL369424: [ClangExpressionParser] Add ClangDeclVendor (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r369424 - [ClangExpressionParser] Add ClangDeclVendor

Author: xiaobai Date: Tue Aug 20 11:47:30 2019 New Revision: 369424 URL: http://llvm.org/viewvc/llvm-project?rev=369424=rev Log: [ClangExpressionParser] Add ClangDeclVendor Summary: This introduces a layer between DeclVendor and the currently implemented DeclVendors (ClangModulesDeclVendor and

[Lldb-commits] [PATCH] D66429: [CMake] Remove LLDB_TEST_USE_CUSTOM_C(XX)_COMPILER

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. I think this is actually fine. The change that was needed for multi-configuration generators is how the two default paths for the compilers are set. The USE variables were

[Lldb-commits] [PATCH] D66453: Make the FindTypes(std::vector, ...) API testable in lldb-test

This revision was automatically updated to reflect the committed changes. Closed by commit rL369407: Make the FindTypes(std::vectorCompilerContext, ...) API testable in lldb-test (authored by adrian, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[Lldb-commits] [lldb] r369407 - Make the FindTypes(std::vector, ...) API testable in lldb-test

Author: adrian Date: Tue Aug 20 09:44:25 2019 New Revision: 369407 URL: http://llvm.org/viewvc/llvm-project?rev=369407=rev Log: Make the FindTypes(std::vector, ...) API testable in lldb-test This adds a -compiler-context=<...> option to lldb-test that trakes a comma-separated string that is a

[Lldb-commits] [PATCH] D66248: [JIT][Command] Add "inject-condition" flag to conditional breakpoints

JDevlieghere added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/fast_conditional_breakpoints/TestFastConditionalBreakpoints.py:45 + +def enable_injected_breakpoint_condition(self, cli): +exe =

[Lldb-commits] [PATCH] D66447: Add char8_t support (C++20)

labath added a comment. This looks good to me, but why are we using a nul character to test utf8 support? Shouldn't we insert some funnier characters too? I mean, one of the advantages of unicode is that it should not be affected by the system code pages and such, so hopefully this would not

[Lldb-commits] [PATCH] D66453: Make the FindTypes(std::vector, ...) API testable in lldb-test

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm Comment at: lldb/tools/lldb-test/lldb-test.cpp:33 #include "lldb/Utility/DataExtractor.h" +#include "lldb/Utility/JSON.h" #include "lldb/Utility/State.h"

[Lldb-commits] [PATCH] D66453: Make the FindTypes(std::vector, ...) API testable in lldb-test

JDevlieghere added inline comments. Comment at: lldb/tools/lldb-test/lldb-test.cpp:145 +"compiler-context", +cl::desc("Specify a compiler context as \"[(type,name),...]\"."), +cl::value_desc("context"), cl::sub(SymbolsSubcommand)); aprantl wrote: >

[Lldb-commits] [PATCH] D66447: Add char8_t support (C++20)

JDevlieghere added a comment. In D66447#1636456 , @jblachly wrote: > Thank you for creating a revision and reviewing this. > > I made inline comments on the test harness and Dlang types / qualifiers. > > With removal of the Dlang types, where is the

[Lldb-commits] [PATCH] D66453: Make the FindTypes(std::vector, ...) API testable in lldb-test

aprantl updated this revision to Diff 216174. aprantl added a comment. Address Pavel's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66453/new/ https://reviews.llvm.org/D66453 Files: lldb/lit/SymbolFile/DWARF/compilercontext.ll lldb/lit/SymbolFile/DWARF/lit.local.cfg

[Lldb-commits] [PATCH] D66447: Add char8_t support (C++20)

JDevlieghere updated this revision to Diff 216175. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. - Address Pavel's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66447/new/ https://reviews.llvm.org/D66447 Files:

[Lldb-commits] [PATCH] D66453: Make the FindTypes(std::vector, ...) API testable in lldb-test

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: lldb/tools/lldb-test/lldb-test.cpp:145 +"compiler-context", +cl::desc("Specify a compiler context as \"[(type,name),...]\"."), +cl::value_desc("context"),

[Lldb-commits] [lldb] r369398 - [lldb] Use the new Regex::isValid() with no parameter

Author: jankratochvil Date: Tue Aug 20 09:08:27 2019 New Revision: 369398 URL: http://llvm.org/viewvc/llvm-project?rev=369398=rev Log: [lldb] Use the new Regex::isValid() with no parameter Differential Revision: https://reviews.llvm.org/D66463 Modified:

[Lldb-commits] [PATCH] D66357: Fix GetDIEForDeclContext so it only returns entries matching the provided context

guiandrade updated this revision to Diff 216166. guiandrade marked 3 inline comments as done. guiandrade added a comment. I'm fixing the style issues pointed by @labath, but I acknowledge the flakiness of this test the way it is right now and am open to deleting it. I can also try to spend some

[Lldb-commits] [PATCH] D66398: 2/2: Fix `TestDataFormatterStdList` regression

JDevlieghere accepted this revision. JDevlieghere added inline comments. Comment at: lldb/source/DataFormatters/FormatManager.cpp:950 + RegularExpression any_size_char_arr(llvm::StringRef("char \\[[0-9]+\\]")); +#if 0 // FIXME: unused: + RegularExpression

[Lldb-commits] [PATCH] D66429: [CMake] Remove LLDB_TEST_USE_CUSTOM_C(XX)_COMPILER

JDevlieghere added a comment. In D66429#1636655 , @labath wrote: > That said, I'm not a fan of force-overwriting cache variables specified by > the user, particularly when the same effect can be achieved by *deleting* the > cache variable instead of

[Lldb-commits] [lldb] r369381 - Fix build for r369374

Author: labath Date: Tue Aug 20 06:17:20 2019 New Revision: 369381 URL: http://llvm.org/viewvc/llvm-project?rev=369381=rev Log: Fix build for r369374 This patch added some gtest code to the TestingSupport library. As this is not a unit test, but a unit test library, gtest does not get added to

[Lldb-commits] [lldb] r369379 - Convert minidump unittests to use llvm::yaml::convertYAML

Author: labath Date: Tue Aug 20 05:53:42 2019 New Revision: 369379 URL: http://llvm.org/viewvc/llvm-project?rev=369379=rev Log: Convert minidump unittests to use llvm::yaml::convertYAML previously they used a minidump-specific function for this purpose, but this is no longer needed now that

[Lldb-commits] [PATCH] D65949: unittests: Use yaml2obj as a library instead of an external process

This revision was automatically updated to reflect the committed changes. Closed by commit rL369374: unittests: Use yaml2obj as a library instead of an external process (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL

[Lldb-commits] [lldb] r369374 - unittests: Use yaml2obj as a library instead of an external process

Author: labath Date: Tue Aug 20 05:28:36 2019 New Revision: 369374 URL: http://llvm.org/viewvc/llvm-project?rev=369374=rev Log: unittests: Use yaml2obj as a library instead of an external process Summary: Recently, yaml2obj has been turned into a library. This means we can use it from our unit

[Lldb-commits] [lldb] r369371 - [cmake] Remove the test for libstdc++<4.9

Author: labath Date: Tue Aug 20 05:17:42 2019 New Revision: 369371 URL: http://llvm.org/viewvc/llvm-project?rev=369371=rev Log: [cmake] Remove the test for libstdc++<4.9 It is no longer relevant now that llvm requires >=5.1. Modified: lldb/trunk/cmake/modules/LLDBConfig.cmake Modified:

[Lldb-commits] [lldb] r369353 - [lldb][NFC] Test quotes when completing

Author: teemperor Date: Tue Aug 20 02:26:58 2019 New Revision: 369353 URL: http://llvm.org/viewvc/llvm-project?rev=369353=rev Log: [lldb][NFC] Test quotes when completing Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/completion/TestCompletion.py Modified:

[Lldb-commits] [PATCH] D66392: 1/2: D66174 `RegularExpression` cleanup

jankratochvil added a comment. Thanks for the review, I hope my updates for the check-in are fine. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66392/new/ https://reviews.llvm.org/D66392 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D66392: 1/2: D66174 `RegularExpression` cleanup

This revision was automatically updated to reflect the committed changes. jankratochvil marked 2 inline comments as done. Closed by commit rL369352: [lldb] D66174 `RegularExpression` cleanup (authored by jankratochvil, committed by ). Changed prior to commit:

[Lldb-commits] [lldb] r369352 - [lldb] D66174 `RegularExpression` cleanup

Author: jankratochvil Date: Tue Aug 20 02:24:20 2019 New Revision: 369352 URL: http://llvm.org/viewvc/llvm-project?rev=369352=rev Log: [lldb] D66174 `RegularExpression` cleanup I find as a good cleanup to drop the Compile method. As I do not find TIMTOWTDI as an advantage and there is already

[Lldb-commits] [PATCH] D66357: Fix GetDIEForDeclContext so it only returns entries matching the provided context

labath added a comment. In D66357#1635851 , @clayborg wrote: > Pavel, any comments on the testing code? I am worried that this approach of using pointers into thin air instead of real objects (which admittedly, would be hard to create/mock) is going to

[Lldb-commits] [PATCH] D66392: 1/2: D66174 `RegularExpression` cleanup

jankratochvil marked 8 inline comments as done. jankratochvil added inline comments. Comment at: lldb/include/lldb/Utility/RegularExpression.h:34 + /// \param[in] string + /// A NULL terminated C string that represents the regular + /// expression to compile.

[Lldb-commits] [PATCH] D66447: Add char8_t support (C++20)

labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lang/cpp/char8_t/Makefile:4-6 +CFLAGS := -g -O0 -std=c++2a + +clean: OBJECTS+=$(wildcard main.d.*) Replace with `CFLAGS_EXTRAS+=-std=c++2a` Comment at:

[Lldb-commits] [PATCH] D66453: Make the FindTypes(std::vector, ...) API testable in lldb-test

labath added a comment. I am glad you're finding lldb-test useful. Please see my inline comment about quoting. Comment at: lldb/lit/SymbolFile/DWARF/compilercontext.ll:1 +; This simulates the debug info for a Clang module. +source_filename = "/t.c" We

[Lldb-commits] [PATCH] D66429: [CMake] Remove LLDB_TEST_USE_CUSTOM_C(XX)_COMPILER

labath added subscribers: stella.stamenova, labath. labath added a comment. I agree that the USE variables seem redundant. I remember thinking the same thing when they were introduced, but I was not objecting back then because there seemed to be a good reason for it. However, now I don't know

[Lldb-commits] [PATCH] D66451: [ClangExpressionParser] Add ClangDeclVendor

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66451/new/ https://reviews.llvm.org/D66451