Re: [Lldb-commits] [PATCH] D66566: [lldb] Replace std::once_flag with llvm::once_flag.

I've reverted the debugserver change in r369621 because it doesn't link against llvm and was therefore failing to build on the bot. On Wed, Aug 21, 2019 at 8:18 PM Davide Italiano via Phabricator via lldb-commits wrote: > > This revision was not accepted when it landed; it landed in state "Needs

[Lldb-commits] [lldb] r369621 - [debugserver] Switch back to std::once_flag

Author: jdevlieghere Date: Wed Aug 21 20:48:19 2019 New Revision: 369621 URL: http://llvm.org/viewvc/llvm-project?rev=369621&view=rev Log: [debugserver] Switch back to std::once_flag We cannot use llvm::once_flag in debugserver because doesn't link against llvm. Modified: lldb/trunk/tools/de

[Lldb-commits] [PATCH] D66566: [lldb] Replace std::once_flag with llvm::once_flag.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL369618: [lldb] Replace std::once_flag with llvm::once_flag. (authored by davide, committed by ). Herald added a project: L

[Lldb-commits] [lldb] r369617 - [FormatManage] Fix the format info order

Author: jdevlieghere Date: Wed Aug 21 20:12:25 2019 New Revision: 369617 URL: http://llvm.org/viewvc/llvm-project?rev=369617&view=rev Log: [FormatManage] Fix the format info order The format info entries need to match the order of the enum entries. This should fix the two failing data-formatter t

[Lldb-commits] [lldb] r369618 - [lldb] Replace std::once_flag with llvm::once_flag.

Author: davide Date: Wed Aug 21 20:12:49 2019 New Revision: 369618 URL: http://llvm.org/viewvc/llvm-project?rev=369618&view=rev Log: [lldb] Replace std::once_flag with llvm::once_flag. Summary: The former seems like it's not working on some platforms. All the other uses use `llvm::`, so, let's ch

[Lldb-commits] [lldb] r369614 - [FormatManager] Add static_assert to keep formats in sync.

Author: jdevlieghere Date: Wed Aug 21 19:56:00 2019 New Revision: 369614 URL: http://llvm.org/viewvc/llvm-project?rev=369614&view=rev Log: [FormatManager] Add static_assert to keep formats in sync. This adds a static assert that ensures that there's a format info entry for every format enum value

[Lldb-commits] [lldb] r369611 - The g_format_infos table needs to be updated in concert with the

Author: jmolenda Date: Wed Aug 21 19:06:03 2019 New Revision: 369611 URL: http://llvm.org/viewvc/llvm-project?rev=369611&view=rev Log: The g_format_infos table needs to be updated in concert with the enum Format entries; else we can crash in a place like FormatManager::GetFormatAsCString(). We sh

[Lldb-commits] [PATCH] D66566: [lldb] Replace std::once_flag with llvm::once_flag.

davide added a comment. I and Jason discussed this offline and he's fine with it, so, I'm going to land this now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66566/new/ https://reviews.llvm.org/D66566 _

[Lldb-commits] [PATCH] D66546: Extend FindTypes w/ CompilerContext to allow filtering by language

JDevlieghere added a comment. This LGTM, unless Pavel has comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66546/new/ https://reviews.llvm.org/D66546 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cg

[Lldb-commits] [PATCH] D66566: [lldb] Replace std::once_flag with llvm::once_flag.

davide created this revision. davide added reviewers: jasonmolenda, friss. Herald added a project: LLDB. The former seems like it's not working on some platforms. All the other uses use `llvm::`, so, let's change for consistency. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D6

[Lldb-commits] [PATCH] D66546: Extend FindTypes w/ CompilerContext to allow filtering by language

aprantl updated this revision to Diff 216518. aprantl added a comment. More feedback from Jonas. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66546/new/ https://reviews.llvm.org/D66546 Files: lldb/include/lldb/Core/PluginManager.h lldb/include/lldb/Symbol/ClangASTContext.h lldb/

[Lldb-commits] [PATCH] D66546: Extend FindTypes w/ CompilerContext to allow filtering by language

JDevlieghere added a comment. This looks like a great improvement. Thanks for working on this! Comment at: lldb/include/lldb/Core/PluginManager.h:400 - static TypeSystemEnumerateSupportedLanguages - GetTypeSystemEnumerateSupportedLanguagesCallbackAtIndex(uint32_t idx);

[Lldb-commits] [PATCH] D66546: Extend FindTypes w/ CompilerContext to allow filtering by language

aprantl updated this revision to Diff 216508. aprantl added a comment. Address review feedback. (This was quite a trip down the rabbit hole, but on the plus side I got to remove a few (now) completely useless callback APIs). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66546/new/ htt

[Lldb-commits] [lldb] r369595 - [test] Update test so it matches the Windows output

Author: jdevlieghere Date: Wed Aug 21 15:32:21 2019 New Revision: 369595 URL: http://llvm.org/viewvc/llvm-project?rev=369595&view=rev Log: [test] Update test so it matches the Windows output Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/char8_t/TestCxxChar8_t.py Modified: lld

[Lldb-commits] [PATCH] D66447: Add char8_t support (C++20)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL369582: Add char8_t support (C++20) (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added

[Lldb-commits] [lldb] r369584 - When building file without debug info, include the architecture

Author: jmolenda Date: Wed Aug 21 14:34:17 2019 New Revision: 369584 URL: http://llvm.org/viewvc/llvm-project?rev=369584&view=rev Log: When building file without debug info, include the architecture setting in the cflags on Darwin systems. Modified: lldb/trunk/packages/Python/lldbsuite/test/

[Lldb-commits] [lldb] r369582 - Add char8_t support (C++20)

Author: jdevlieghere Date: Wed Aug 21 14:30:55 2019 New Revision: 369582 URL: http://llvm.org/viewvc/llvm-project?rev=369582&view=rev Log: Add char8_t support (C++20) This patch adds support for the char8_t type introduced in C++20 char8_t. The original patch was submitted by James Blachly on th

[Lldb-commits] [PATCH] D66546: Extend FindTypes w/ CompilerContext to allow filtering by language

aprantl added a comment. I also just discovered void ClangASTContext::EnumerateSupportedLanguages() and will incorporate that into the next revision, too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66546/new/ https://reviews.llvm.org/D66546 ___

[Lldb-commits] [PATCH] D66546: Extend FindTypes w/ CompilerContext to allow filtering by language

JDevlieghere added a comment. I think the functionality is fine. I know this is a little ironic, given that we just had this discussion, but I would propose wrapping the `SmallBitVector` here. That way you can abstracting away the details about the underlying enum values, the size, and make the

[Lldb-commits] [PATCH] D66546: Extend FindTypes w/ CompilerContext to allow filtering by language

aprantl created this revision. aprantl added reviewers: labath, clayborg, jasonmolenda, JDevlieghere. This patch is also motivated by the Swift branch and is effectively NFC for the single-TypeSystem llvm.org branch. In multi-language projects it is extremely common to have, e.g., a Clang type

[Lldb-commits] [PATCH] D66507: Generalize FindTypes with CompilerContext to support fuzzy lookup

This revision was automatically updated to reflect the committed changes. Closed by commit rL369555: Generalize FindTypes with CompilerContext to support fuzzy lookup (authored by adrian, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commi

[Lldb-commits] [lldb] r369555 - Generalize FindTypes with CompilerContext to support fuzzy lookup

Author: adrian Date: Wed Aug 21 11:06:56 2019 New Revision: 369555 URL: http://llvm.org/viewvc/llvm-project?rev=369555&view=rev Log: Generalize FindTypes with CompilerContext to support fuzzy lookup This patch generalizes the FindTypes with CompilerContext interface to support looking up a type o

[Lldb-commits] [PATCH] D66447: Add char8_t support (C++20)

labath added a comment. In D66447#1639490 , @JDevlieghere wrote: > Sounds like I simply misunderstood your earlier comment. I thought you meant > putting a full UTF-8 *character* in a `char8_t. Ah yes, I can see how that request could have been interpr

[Lldb-commits] [PATCH] D66507: Generalize FindTypes with CompilerContext to support fuzzy lookup

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/include/lldb/Symbol/Type.h:42 +/// Match this context pattern (which may contain "Any" kinds) +/// against the context chain of a type. No

[Lldb-commits] [PATCH] D66507: Generalize FindTypes with CompilerContext to support fuzzy lookup

aprantl updated this revision to Diff 216425. aprantl added a comment. Address feedback from Pavel. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66507/new/ https://reviews.llvm.org/D66507 Files: lldb/include/lldb/Symbol/SymbolFile.h lldb/include/lldb/Symbol/Type.h lldb/include/l

[Lldb-commits] [PATCH] D66536: [lldb][NFC] Remove WordComplete mode, make result array indexed from 0 and remove any undocumented/redundant return values

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks for cleaning this up, Raphael! Comment at: lldb/source/API/SBCommandInterpreter.cpp:379 + + // Make the result array indexed from 1 again by adding the 'c

[Lldb-commits] [PATCH] D66447: Add char8_t support (C++20)

JDevlieghere added a comment. I changed the test to use `frame variable` again. With `target variable` the UTF-8 formatting doesn't work. Given that this patch just copies the Char16 and Char32 implementation, I think that's something for a different patch. I'll file a PR when this gets in.

[Lldb-commits] [PATCH] D66447: Add char8_t support (C++20)

shafik added a comment. In D66447#1638783 , @labath wrote: > In D66447#1638047 , @JDevlieghere > wrote: > > > In D66447#1637640 , @labath wrote: > > > > > This looks good to

[Lldb-commits] [PATCH] D66447: Add char8_t support (C++20)

JDevlieghere updated this revision to Diff 216422. JDevlieghere added a comment. - Use UTF8 string CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66447/new/ https://reviews.llvm.org/D66447 Files: lldb/include/lldb/lldb-enumerations.h lldb/packages/Python/lldbsuite/test/lang/cpp/char

[Lldb-commits] [PATCH] D66447: Add char8_t support (C++20)

JDevlieghere added a comment. In D66447#1638783 , @labath wrote: > In D66447#1638047 , @JDevlieghere > wrote: > > > In D66447#1637640 , @labath wrote: > > > > > This looks g

[Lldb-commits] [PATCH] D66536: [lldb][NFC] Remove WordComplete mode, make result array indexed from 0 and remove any undocumented/redundant return values

teemperor updated this revision to Diff 216398. teemperor added a comment. - Add comment that we emulate the old API by adding the common prefix as element 0. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66536/new/ https://reviews.llvm.org/D66536 Files: lldb/include/lldb/Core/Forma

[Lldb-commits] [PATCH] D66536: [lldb][NFC] Remove WordComplete mode, make result array indexed from 0 and remove any undocumented/redundant return values

teemperor marked an inline comment as done. teemperor added inline comments. Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:1847 - - if (request.GetParsedLine().GetArgumentCount() == 0) { -// If we got an empty string, insert nothing. Note that I

[Lldb-commits] [PATCH] D66536: [lldb][NFC] Remove WordComplete mode, make result array indexed from 0 and remove any undocumented/redundant return values

teemperor created this revision. teemperor added a reviewer: JDevlieghere. Herald added subscribers: lldb-commits, abidh, arphaman. Herald added a project: LLDB. teemperor updated this revision to Diff 216398. teemperor added a comment. - Add comment that we emulate the old API by adding the commo

[Lldb-commits] [PATCH] D65952: SymbolVendor: Have plugins return symbol files directly

labath added a comment. Greg, any thoughts on my last comment? My biggest question is that if we remove the SymbolVendor completely, then where will the code that's currently in SymbolVendorELF and SymbolVendorMacOS go to... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65952/new/ htt

Re: [Lldb-commits] [lldb] r369506 - [lldb][NFC] Add tests for invalid command invocations

Thanks, just pushed a fix where I merge that into the dedicated apropos test! > On 21. Aug 2019, at 16:16, Pavel Labath wrote: > > On 21/08/2019 11:15, Raphael Isemann via lldb-commits wrote: >> Author: teemperor >> Date: Wed Aug 21 02:15:44 2019 >> New Revision: 369506 >> URL: http://llvm.org/v

[Lldb-commits] [lldb] r369530 - [lldb][NFC] Merge multiple TestApropos.py

Author: teemperor Date: Wed Aug 21 07:22:59 2019 New Revision: 369530 URL: http://llvm.org/viewvc/llvm-project?rev=369530&view=rev Log: [lldb][NFC] Merge multiple TestApropos.py That's cleaner and makes lldb-dotest no longer fail due to conflicting names. Removed: lldb/trunk/packages/Python/

Re: [Lldb-commits] [lldb] r369506 - [lldb][NFC] Add tests for invalid command invocations

On 21/08/2019 11:15, Raphael Isemann via lldb-commits wrote: Author: teemperor Date: Wed Aug 21 02:15:44 2019 New Revision: 369506 URL: http://llvm.org/viewvc/llvm-project?rev=369506&view=rev Log: [lldb][NFC] Add tests for invalid command invocations Added: lldb/trunk/packages/Python/lldbs

[Lldb-commits] [PATCH] D66522: [lldb][NFC] Remove dead code that is supposed to handle invalid command options

teemperor updated this revision to Diff 216385. teemperor added a comment. - Remove some unreachable that are not in the command/interpreter directory (as they might be used differently and could be reached). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66522/new/ https://reviews.llvm

Re: [Lldb-commits] [lldb] r369502 - Properly EXCLUDE_FROM_ALL the testing support library

Thanks, the bot is green again! On Wed, Aug 21, 2019 at 1:20 AM Pavel Labath via lldb-commits wrote: > > Author: labath > Date: Wed Aug 21 01:21:51 2019 > New Revision: 369502 > > URL: http://llvm.org/viewvc/llvm-project?rev=369502&view=rev > Log: > Properly EXCLUDE_FROM_ALL the testing support l

[Lldb-commits] [lldb] r369524 - [lldb] Add tests for 'settings remove' and fix error message typos

Author: teemperor Date: Wed Aug 21 06:24:21 2019 New Revision: 369524 URL: http://llvm.org/viewvc/llvm-project?rev=369524&view=rev Log: [lldb] Add tests for 'settings remove' and fix error message typos Modified: lldb/trunk/packages/Python/lldbsuite/test/settings/TestSettings.py lldb/trun

[Lldb-commits] [lldb] r369523 - Recommit "Minidump/Windows: Fix module lookup""

Author: labath Date: Wed Aug 21 06:20:25 2019 New Revision: 369523 URL: http://llvm.org/viewvc/llvm-project?rev=369523&view=rev Log: Recommit "Minidump/Windows: Fix module lookup"" This recommits r368416, which was reverted in r368838 because of test failures under ASAN. These have been dealt wit

[Lldb-commits] [lldb] r369522 - Fix two compiler warnings

Author: labath Date: Wed Aug 21 06:11:30 2019 New Revision: 369522 URL: http://llvm.org/viewvc/llvm-project?rev=369522&view=rev Log: Fix two compiler warnings Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangDeclVendor.h lldb/trunk/source/Symbol/ClangASTContext.cpp Modifie

[Lldb-commits] [lldb] r369521 - [lldb] Add tests for setting completions and enable 'settings remove' completion

Author: teemperor Date: Wed Aug 21 05:57:06 2019 New Revision: 369521 URL: http://llvm.org/viewvc/llvm-project?rev=369521&view=rev Log: [lldb] Add tests for setting completions and enable 'settings remove' completion Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/complet

[Lldb-commits] [lldb] r369513 - [lldb][NFC] Add tests for register command

Author: teemperor Date: Wed Aug 21 03:40:05 2019 New Revision: 369513 URL: http://llvm.org/viewvc/llvm-project?rev=369513&view=rev Log: [lldb][NFC] Add tests for register command Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/register/register_command/TestRegisters.py M

[Lldb-commits] [PATCH] D66522: [lldb][NFC] Remove dead code that is supposed to handle invalid command options

teemperor created this revision. teemperor added a reviewer: JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We currently have a bunch of code that is supposed to handle invalid command options, but all this code is unreachable because invalid options are alre

[Lldb-commits] [lldb] r369506 - [lldb][NFC] Add tests for invalid command invocations

Author: teemperor Date: Wed Aug 21 02:15:44 2019 New Revision: 369506 URL: http://llvm.org/viewvc/llvm-project?rev=369506&view=rev Log: [lldb][NFC] Add tests for invalid command invocations Added: lldb/trunk/packages/Python/lldbsuite/test/functionalities/apropos/ lldb/trunk/packages/Pyth

[Lldb-commits] [PATCH] D66507: Generalize FindTypes with CompilerContext to support fuzzy lookup

labath added a comment. I don't have any context or opinion on the high level functionality, but can we please not use inheritance in this way? Though I have done similar things in the past, I am not really proud of them. It looks like the matching code can be just as easily be implemented as a

[Lldb-commits] [lldb] r369503 - Fix an unused variable warning in ClangASTContext.cpp

Author: labath Date: Wed Aug 21 01:22:19 2019 New Revision: 369503 URL: http://llvm.org/viewvc/llvm-project?rev=369503&view=rev Log: Fix an unused variable warning in ClangASTContext.cpp Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified: lldb/trunk/source/Symbol/ClangASTContext

[Lldb-commits] [lldb] r369502 - Properly EXCLUDE_FROM_ALL the testing support library

Author: labath Date: Wed Aug 21 01:21:51 2019 New Revision: 369502 URL: http://llvm.org/viewvc/llvm-project?rev=369502&view=rev Log: Properly EXCLUDE_FROM_ALL the testing support library The EXCLUDE_FROM_ALL variable is used by add_llvm_library, but lldb does not use that function (it uses llvm_a