[Lldb-commits] [lldb] r370152 - Update name of objc runtime SPI function we call for class names.

Author: jmolenda Date: Tue Aug 27 19:14:07 2019 New Revision: 370152 URL: http://llvm.org/viewvc/llvm-project?rev=370152=rev Log: Update name of objc runtime SPI function we call for class names. A new SPI was added to the objc runtime to get class names without any demangling;

[Lldb-commits] [PATCH] D66858: POSIX DYLD: add workaround for android L loader

compnerd created this revision. compnerd added reviewers: davide, xiaobai. Herald added subscribers: abidh, srhines. Herald added a project: LLDB. In certain cases, the loader does not report the base address of the DSO. Attempt to infer it from the loaded address of the object file. This was

[Lldb-commits] [lldb] r370138 - [lit] Fix the way we check if an environment var is set

Author: jdevlieghere Date: Tue Aug 27 17:52:08 2019 New Revision: 370138 URL: http://llvm.org/viewvc/llvm-project?rev=370138=rev Log: [lit] Fix the way we check if an environment var is set The old method would throw a KeyError. Modified: lldb/trunk/lit/Suite/lit.cfg Modified:

[Lldb-commits] [lldb] r370136 - [test] Disable TestConcurrentManySignals on Darwin.

Author: jdevlieghere Date: Tue Aug 27 17:35:37 2019 New Revision: 370136 URL: http://llvm.org/viewvc/llvm-project?rev=370136=rev Log: [test] Disable TestConcurrentManySignals on Darwin. This test is flaky on GreenDragon. Disable it until we figure out why. Modified:

[Lldb-commits] [PATCH] D66845: [lit] Don't set DYLD_LIBRARY_PATH when DYLD_INSERT_LIBRARIES is set.

This revision was automatically updated to reflect the committed changes. Closed by commit rL370135: [lit] Dont set DYLD_LIBRARY_PATH when DYLD_INSERT_LIBRARIES is set. (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[Lldb-commits] [lldb] r370135 - [lit] Don't set DYLD_LIBRARY_PATH when DYLD_INSERT_LIBRARIES is set.

Author: jdevlieghere Date: Tue Aug 27 17:32:19 2019 New Revision: 370135 URL: http://llvm.org/viewvc/llvm-project?rev=370135=rev Log: [lit] Don't set DYLD_LIBRARY_PATH when DYLD_INSERT_LIBRARIES is set. Setting DYLD_INSERT_LIBRARIES to the Asan runtime and DYLD_LIBRARY_PATH to the LLVM shared

[Lldb-commits] [PATCH] D66845: [lit] Don't set DYLD_LIBRARY_PATH when DYLD_INSERT_LIBRARIES is set.

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. It's a hack, but it's a well-documented one. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66845/new/ https://reviews.llvm.org/D66845

[Lldb-commits] [PATCH] D66634: Postfix: move more code out of the PDB plugin

amccarth added a comment. When I added my comments, Phabricator showed this patch as still open. Now it looks like it landed four hours before that. :-( Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66634/new/ https://reviews.llvm.org/D66634

[Lldb-commits] [PATCH] D66845: [lit] Don't set DYLD_LIBRARY_PATH when DYLD_INSERT_LIBRARIES is set.

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, mgorny. Herald added a subscriber: abidh. Herald added a project: LLDB. Setting `DYLD_INSERT_LIBRARIES` to the Asan runtime and `DYLD_LIBRARY_PATH ` to the LLVM shared library dir causes the test suite to crash with a

[Lldb-commits] [PATCH] D66841: Skip test_target_create_invalid_core_file on Windows

amccarth created this revision. amccarth added a reviewer: teemperor. The operation is supposed to fail, but apparently it fails on Windows for a different reason than the test anticipated. https://reviews.llvm.org/D66841 Files:

[Lldb-commits] [PATCH] D66837: [dotest] Remove -q (quiet) flag.

davide added a comment. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66837/new/ https://reviews.llvm.org/D66837 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r370126 - Revert "[lldb] Move redundant persistent variable counter to ClangPersistentVariables"

Author: adrian Date: Tue Aug 27 15:50:40 2019 New Revision: 370126 URL: http://llvm.org/viewvc/llvm-project?rev=370126=rev Log: Revert "[lldb] Move redundant persistent variable counter to ClangPersistentVariables" This reverts commit r367842 since it wasn't quite as NFC as advertised and broke

[Lldb-commits] [PATCH] D66837: [dotest] Remove -q (quiet) flag.

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added a subscriber: teemperor. Herald added a project: LLDB. I propose removing the `-q` (quiet) flag and changing the default behavior. Currently the flag serves two purposes that are somewhat contradictory, as

[Lldb-commits] [lldb] r370120 - [dotest] Remove check for LLDB_TESTSUITE_FORCE_FINISH

Author: jdevlieghere Date: Tue Aug 27 14:59:24 2019 New Revision: 370120 URL: http://llvm.org/viewvc/llvm-project?rev=370120=rev Log: [dotest] Remove check for LLDB_TESTSUITE_FORCE_FINISH Modified: lldb/trunk/packages/Python/lldbsuite/test/dotest.py Modified:

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Support encoding working directories in a VFS mapping.

JDevlieghere updated this revision to Diff 217487. JDevlieghere retitled this revision from "[VirtualFileSystem] Support encoding a current working directory in a VFS mapping." to "[VirtualFileSystem] Support encoding working directories in a VFS mapping.". JDevlieghere added a comment. Support

[Lldb-commits] [PATCH] D66811: [dotest] Remove results port

This revision was automatically updated to reflect the committed changes. Closed by commit rL370090: [dotest] Remove results port (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r370090 - [dotest] Remove results port

Author: jdevlieghere Date: Tue Aug 27 11:18:46 2019 New Revision: 370090 URL: http://llvm.org/viewvc/llvm-project?rev=370090=rev Log: [dotest] Remove results port The results port was used by dosep.py to deal with test results coming form different processes. With dosep.py gone, I don't think we

[Lldb-commits] [PATCH] D66811: [dotest] Remove results port

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66811/new/ https://reviews.llvm.org/D66811 ___

[Lldb-commits] [PATCH] D66811: [dotest] Remove results port

BlackAngel35 requested changes to this revision. BlackAngel35 added a comment. This revision now requires changes to proceed. EnDing Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66811/new/ https://reviews.llvm.org/D66811

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

shafik added inline comments. Comment at: llvm/include/llvm/Support/MathExtras.h:271 unsigned char out[sizeof(Val)]; - std::memcpy(in, , sizeof(Val)); + memcpy(in, , sizeof(Val)); for (unsigned i = 0; i < sizeof(Val); ++i) What are you building on that

[Lldb-commits] [PATCH] D66811: [dotest] Remove results port

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added a subscriber: abidh. Herald added a project: LLDB. The results port was used by `dosep` to deal with test results coming form different processes. With dosep gone, I don't think we need this any longer.

[Lldb-commits] [PATCH] D66655: [lldb] Fix x86 compilation

This revision was automatically updated to reflect the committed changes. Closed by commit rL370078: [lldb] Fix x86 compilation (authored by tkrasnukha, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r370078 - [lldb] Fix x86 compilation

Author: tkrasnukha Date: Tue Aug 27 10:22:03 2019 New Revision: 370078 URL: http://llvm.org/viewvc/llvm-project?rev=370078=rev Log: [lldb] Fix x86 compilation Differential Revision: https://reviews.llvm.org/D66655 Patch by Leonid Mashinskiy Modified:

[Lldb-commits] [PATCH] D63591: DWARFDebugLoc: Make parsing and error reporting more robust

JDevlieghere added a comment. LGTM Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63591/new/ https://reviews.llvm.org/D63591 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D66789: Remove DWARFExpression::LocationListSize

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks, Pavel! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66789/new/ https://reviews.llvm.org/D66789 ___ lldb-commits

[Lldb-commits] [PATCH] D66655: [lldb] Fix x86 compilation

leonid.mashinskiy added a comment. @tatyana-krasnukha Can you commit this please because I have no commit access Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66655/new/ https://reviews.llvm.org/D66655 ___

[Lldb-commits] [PATCH] D66655: [lldb] Fix x86 compilation

tatyana-krasnukha accepted this revision. tatyana-krasnukha added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66655/new/ https://reviews.llvm.org/D66655

[Lldb-commits] [PATCH] D59692: [ASTImporter] Fix name conflict handling with different strategies

labath added a comment. In D59692#1646990 , @martong wrote: > Jenkins is not green > http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/743/ > However, the newly failing test is `TestTargetCommand.py`, which seems to be > unrelated. That ought

[Lldb-commits] [PATCH] D59692: [ASTImporter] Fix name conflict handling with different strategies

martong added a comment. Jenkins is not green http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/743/ However, the newly failing test is `TestTargetCommand.py`, which seems to be unrelated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] r370057 - [lldb][NFC] Add missing invalid_core_file to TestTargetCommand test

Author: teemperor Date: Tue Aug 27 06:34:15 2019 New Revision: 370057 URL: http://llvm.org/viewvc/llvm-project?rev=370057=rev Log: [lldb][NFC] Add missing invalid_core_file to TestTargetCommand test Added:

[Lldb-commits] [lldb] r370054 - Stabilize TestIOHandlerCompletion

Author: labath Date: Tue Aug 27 06:09:40 2019 New Revision: 370054 URL: http://llvm.org/viewvc/llvm-project?rev=370054=rev Log: Stabilize TestIOHandlerCompletion pexpect gives as raw data going to a terminal. This means that if the completed line does not fit the emulated line, the returned data

[Lldb-commits] [PATCH] D63591: DWARFDebugLoc: Make parsing and error reporting more robust

labath updated this revision to Diff 217378. labath added a comment. Rebase the patch on top of DataExtractor Cursor changes. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63591/new/ https://reviews.llvm.org/D63591 Files:

[Lldb-commits] [PATCH] D66654: Prevent D66398 `TestDataFormatterStdList`-like regressions in the future

jankratochvil planned changes to this revision. jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: lldb/include/lldb/Core/ValueObject.h:460 + // Store error from Expected<> parameter unless some error is already stored. + template

[Lldb-commits] [PATCH] D59692: [ASTImporter] Fix name conflict handling with different strategies

This revision was automatically updated to reflect the committed changes. Closed by commit rGf035b75d8f07: [ASTImporter] Fix name conflict handling with different strategies (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] r370050 - [lldb][NFC] Add some tests for the target subcommands

Author: teemperor Date: Tue Aug 27 04:57:26 2019 New Revision: 370050 URL: http://llvm.org/viewvc/llvm-project?rev=370050=rev Log: [lldb][NFC] Add some tests for the target subcommands Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/target_command/TestTargetCommand.py

[Lldb-commits] [lldb] r370047 - [lldb][NFC] Give added test method a unique name

Author: teemperor Date: Tue Aug 27 04:43:54 2019 New Revision: 370047 URL: http://llvm.org/viewvc/llvm-project?rev=370047=rev Log: [lldb][NFC] Give added test method a unique name Otherwise dotest doesn't run the test and just lets it always pass. Also update the comment to explain that we do

[Lldb-commits] [lldb] r370043 - [lldb] Allow partial completions to fix directory completion.

Author: teemperor Date: Tue Aug 27 04:32:22 2019 New Revision: 370043 URL: http://llvm.org/viewvc/llvm-project?rev=370043=rev Log: [lldb] Allow partial completions to fix directory completion. On the command line we usually insert a space after a completion to indicate that the completion was

[Lldb-commits] [PATCH] D66655: [lldb] Fix x86 compilation

leonid.mashinskiy updated this revision to Diff 217359. leonid.mashinskiy added a reviewer: tatyana-krasnukha. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66655/new/ https://reviews.llvm.org/D66655 Files:

[Lldb-commits] [PATCH] D66744: NativeProcessLinux: Remove some register context boilerplate

jankratochvil added a comment. In D66744#1646572 , @labath wrote: > In D66744#1646514 , @jankratochvil > wrote: > > > But then there is `NativeRegisterContextLinux_x86_64::GetFPRBuffer()`. > > Which is never used

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

labath added a comment. Looks mostly fine, but you'll need to split this patch up. You'll want a separate review (and test) for the yaml2obj changes. Also, the lzma code should not live inside ObjectFileELF. I'd put it somewhere under `lldb/Host/LZMA.h`. For how to wrap lzma, I'd suggest

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 217341. kwk added a comment. - Added documentation source for mini debuginfo commands Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files:

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 217339. kwk added a comment. - Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: lldb/packages/Python/lldbsuite/test/linux/minidebuginfo/Makefile

[Lldb-commits] [PATCH] D59692: [ASTImporter] Fix name conflict handling with different strategies

martong updated this revision to Diff 217337. martong added a comment. - Apply clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59692/new/ https://reviews.llvm.org/D59692 Files: clang/include/clang/AST/ASTImporter.h

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 217334. kwk added a comment. - Improve documentation of GetGnuDebugDataObjectFile Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files:

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 217331. kwk added a comment. - Change header comment of minidebuginfo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files:

[Lldb-commits] [PATCH] D59692: [ASTImporter] Fix name conflict handling with different strategies

martong marked 4 inline comments as done. martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3452 << FoundField->getType(); - - return make_error(ImportError::NameConflict); + ConflictingDecls.push_back(FoundField); }

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk marked an inline comment as done. kwk added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/linux/minidebuginfo/TestMiniDebugInfo.py:1 +""" Testing debugging of a binary with "mixed" dwarf (with/without fission). """ +import lldb I just

[Lldb-commits] [PATCH] D59692: [ASTImporter] Fix name conflict handling with different strategies

martong updated this revision to Diff 217330. martong marked 2 inline comments as done. martong added a comment. - Revert changes in VisitFieldDecl and in VisitIndirectFieldDecl - Remove test suite ConflictingDeclsWithConservativeStrategy Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk created this revision. Herald added subscribers: llvm-commits, lldb-commits, MaskRay, hiraditya, arichardson, mgorny, emaste. Herald added a reviewer: espindola. Herald added projects: LLDB, LLVM. kwk added reviewers: labath, jankratochvil. kwk marked an inline comment as done. kwk updated

[Lldb-commits] [PATCH] D66744: NativeProcessLinux: Remove some register context boilerplate

labath marked an inline comment as done. labath added a comment. In D66744#1646514 , @jankratochvil wrote: > > {Read,Write}[GF]PR now no longer check whether the supplied buffers are > > null, because they never are > > But then there is

[Lldb-commits] [PATCH] D66654: Prevent D66398 `TestDataFormatterStdList`-like regressions in the future

labath added a comment. In D66654#1645792 , @jankratochvil wrote: > In D66654#1645658 , @clayborg wrote: > > > What about having the first one that matched being the one that is used and > > avoid errors all

[Lldb-commits] [PATCH] D66634: Postfix: move more code out of the PDB plugin

labath marked 3 inline comments as done. labath added a comment. Please find my replies inline (including my yesterday's reply to Aleksandr, which I apparently failed to submit). Comment at: lldb/trunk/source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:61

[Lldb-commits] [PATCH] D66744: NativeProcessLinux: Remove some register context boilerplate

jankratochvil added a comment. > {Read,Write}[GF]PR now no longer check whether the supplied buffers are null, > because they never are But then there is `NativeRegisterContextLinux_x86_64::GetFPRBuffer()`. Which is never used so maybe together with

[Lldb-commits] [PATCH] D66789: Remove DWARFExpression::LocationListSize

labath created this revision. labath added reviewers: JDevlieghere, clayborg. Herald added subscribers: kristof.beyls, javed.absar, aprantl. The only reason for this function's existance is so that we could pass the correct size into the DWARFExpression constructor. However, there is no harm in

[Lldb-commits] [PATCH] D66745: DWARFExpression: Simplify class interface

This revision was automatically updated to reflect the committed changes. Closed by commit rGe588b8b66456: DWARFExpression: Simplify class interface (authored by labath). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D66745?vs=217159=217317#toc Repository:

[Lldb-commits] [lldb] r370027 - DWARFExpression: Simplify class interface

Author: labath Date: Tue Aug 27 00:49:41 2019 New Revision: 370027 URL: http://llvm.org/viewvc/llvm-project?rev=370027=rev Log: DWARFExpression: Simplify class interface Summary: The DWARFExpression methods have a lot of arguments. This removes two of them by removing the ability to slice the

[Lldb-commits] [lldb] r370026 - Fix an unused variable warning in no-assert builds

Author: labath Date: Tue Aug 27 00:46:07 2019 New Revision: 370026 URL: http://llvm.org/viewvc/llvm-project?rev=370026=rev Log: Fix an unused variable warning in no-assert builds Modified: lldb/trunk/source/Host/common/MainLoop.cpp Modified: lldb/trunk/source/Host/common/MainLoop.cpp URL:

[Lldb-commits] [PATCH] D66249: [JIT][Breakpoint] Add "BreakpointInjectedSite" and FCB Trampoline

labath added a comment. Ok, it sounds we're in agreement then. I'l looking forward to the updated patches. :) Comment at: lldb/include/lldb/Target/ABI.h:165 + + virtual size_t GetJumpSize() { return 0; } + mib wrote: > labath wrote: > > The point of my

[Lldb-commits] [lldb] r370020 - Fix TestStdCXXDisassembly.py

Author: labath Date: Mon Aug 26 23:43:45 2019 New Revision: 370020 URL: http://llvm.org/viewvc/llvm-project?rev=370020=rev Log: Fix TestStdCXXDisassembly.py missing decorator import. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/stl/TestStdCXXDisassembly.py Modified:

[Lldb-commits] [lldb] r370019 - CommandObjectExpression: Fix a misleading-indentation warning

Author: labath Date: Mon Aug 26 23:42:42 2019 New Revision: 370019 URL: http://llvm.org/viewvc/llvm-project?rev=370019=rev Log: CommandObjectExpression: Fix a misleading-indentation warning Modified: lldb/trunk/source/Commands/CommandObjectExpression.cpp Modified: