[Lldb-commits] [PATCH] D68071: cmake: Link lldb libraries and tools with libclang-cpp.so when CLANG_LINK_LLVM_DYLIB=ON

tstellar created this revision. tstellar added reviewers: beanz, smeenai, clayborg, zturner. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68071 Files: lldb/cmake/modules/AddLLDB.cmake Index:

[Lldb-commits] [PATCH] D68069: Explicitly set entry point arch when it's thumb

aadsm created this revision. aadsm added reviewers: clayborg, labath, wallace. Herald added subscribers: lldb-commits, MaskRay, kristof.beyls, arichardson, emaste, srhines. Herald added a reviewer: espindola. Herald added a project: LLDB. I found a case where the main android binary

[Lldb-commits] [PATCH] D67891: remove File::SetStream(), make new files instead.

lawrence_danna updated this revision to Diff 221866. lawrence_danna added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67891/new/ https://reviews.llvm.org/D67891 Files: lldb/include/lldb/Core/Debugger.h

[Lldb-commits] [PATCH] D67996: Convert FileSystem::Open() to return Expected

lawrence_danna updated this revision to Diff 221864. lawrence_danna added a comment. got rid of StreamFile::SetFile Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67996/new/ https://reviews.llvm.org/D67996 Files:

[Lldb-commits] [PATCH] D67994: [WIP] Modify lldb-test to print out ASTs from symbol file

shafik marked an inline comment as done. shafik added inline comments. Comment at: tools/lldb-test/lldb-test.cpp:552-579 + +lldb_private::TypeList type_list; +size_t ntypes = symfile->GetTypes(nullptr, eTypeClassAny, type_list); +printf( "Type list size: %zu\n",

[Lldb-commits] [PATCH] D67996: Convert FileSystem::Open() to return Expected

lawrence_danna marked 2 inline comments as done. lawrence_danna added inline comments. Comment at: lldb/include/lldb/Core/StreamFile.h:48-53 + void SetFile(std::shared_ptr file) { +if (file) + m_file_sp = file; +else + m_file_sp = std::make_shared(); + }

[Lldb-commits] [PATCH] D67994: [WIP] Modify lldb-test to print out ASTs from symbol file

shafik marked an inline comment as done. shafik added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3077 + ParseType(sc, die, _is_new).get(); + printf( "pubname: %s is_type = %d\n", die.GetPubname(), true); + break;

[Lldb-commits] [PATCH] D67994: [WIP] Modify lldb-test to print out ASTs from symbol file

shafik added a comment. In D67994#1682051 , @labath wrote: > For dumping a specific type something like this could be right, but for > "indiscriminately dumping" everything, this seems to be a bit fragile. > > Would it be possible to make this use the

[Lldb-commits] [PATCH] D68048: [WIP][RFC] Improve fetching the process list on the android platform

xiaobai added inline comments. Comment at: lldb/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.cpp:240 + +bool parsePsHeader(const std::string , PsColumnsIndices ) { + std::stringstream line_stream(line); You could return the PsColumsnIndices

[Lldb-commits] [PATCH] D68048: [WIP][RFC] Improve fetching the process list on the android platform

xiaobai added a comment. In D68048#1683238 , @clayborg wrote: > > There are some things still left. > > > > architecture: > > I don't know if we can simply reuse an existing variable and set it for > > all processes, or if we should really find the

[Lldb-commits] [PATCH] D67776: Don't stop execution in batch mode when process stops with SIGINT or SIGSTOP

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM. Thanks for sticking with this. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67776/new/ https://reviews.llvm.org/D67776

[Lldb-commits] [PATCH] D67996: Convert FileSystem::Open() to return Expected

lawrence_danna updated this revision to Diff 221842. lawrence_danna marked an inline comment as done. lawrence_danna added a comment. Herald added a subscriber: mgorny. Fixed according to reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D67996: Convert FileSystem::Open() to return Expected

lawrence_danna marked 19 inline comments as done. lawrence_danna added a comment. wow, I didn't realize the part about actually consuming the error. I thought the asserts only checked that you checked if there was an error. Uploading fixes momentarily Comment at:

[Lldb-commits] [PATCH] D68048: [WIP][RFC] Improve fetching the process list on the android platform

clayborg added a comment. Added Pavel to the review list. Pavel, please add anyone that has Android expertise to this patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68048/new/ https://reviews.llvm.org/D68048

[Lldb-commits] [PATCH] D68048: [WIP][RFC] Improve fetching the process list on the android platform

clayborg added a comment. > There are some things still left. > > architecture: > I don't know if we can simply reuse an existing variable and set it for all > processes, or if we should really find the architecture of each process. The only time we might run into an issue is when we have

[Lldb-commits] [PATCH] D68048: [WIP][RFC] Improve fetching the process list on the android platform

wallace updated this revision to Diff 221837. wallace added a comment. remove unwanted files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68048/new/ https://reviews.llvm.org/D68048 Files:

Re: [Lldb-commits] [lldb] r372891 - [Dwarf] Make dw_tag_t a typedef for llvm::dwarf::Tag instead of uint16_t.

Thanks, fixed in r372920. On Wed, Sep 25, 2019 at 11:51 AM Rumeet Dhindsa wrote: > > Hi Jonas, > > Since dw_tag_t is an enum now, in the switch statement at following mentioned > location, default case needs to be added as well. It generates a warning that > some enumeration values are not

[Lldb-commits] [lldb] r372920 - [Dwarf] Fix switch cases that take an dw_tag_t.

Author: jdevlieghere Date: Wed Sep 25 13:59:56 2019 New Revision: 372920 URL: http://llvm.org/viewvc/llvm-project?rev=372920=rev Log: [Dwarf] Fix switch cases that take an dw_tag_t. Now that dw_tag_t is an enum, a default case is required. Modified:

[Lldb-commits] [PATCH] D68048: adbps

wallace created this revision. Herald added subscribers: lldb-commits, srhines. Herald added a project: LLDB. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68048 Files: lldb/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.cpp

[Lldb-commits] [PATCH] D68039: [lit] Do a better job at parsing unsupported tests.

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rL372914: [lit] Do a better job at parsing unsupported tests. (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a

[Lldb-commits] [lldb] r372914 - [lit] Do a better job at parsing unsupported tests.

Author: jdevlieghere Date: Wed Sep 25 12:31:54 2019 New Revision: 372914 URL: http://llvm.org/viewvc/llvm-project?rev=372914=rev Log: [lit] Do a better job at parsing unsupported tests. When all the tests run by dotest are unsupported, it still reports RESULT: PASSED which we translate to

[Lldb-commits] [PATCH] D68039: [lit] Do a better job at parsing unsupported tests.

JDevlieghere marked 3 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/lit/Suite/lldbtest.py:105 +has_unsupported_tests = 'UNSUPPORTED:' in out or 'UNSUPPORTED:' in err +has_passing_tests = 'PASS:' in out or 'PASS:' in err

[Lldb-commits] [PATCH] D68039: [lit] Do a better job at parsing unsupported tests.

aprantl added inline comments. Comment at: lldb/lit/Suite/lldbtest.py:105 +has_unsupported_tests = 'UNSUPPORTED:' in out or 'UNSUPPORTED:' in err +has_passing_tests = 'PASS:' in out or 'PASS:' in err JDevlieghere wrote: > aprantl wrote: > >

Re: [Lldb-commits] [lldb] r372891 - [Dwarf] Make dw_tag_t a typedef for llvm::dwarf::Tag instead of uint16_t.

Hi Jonas, Since dw_tag_t is an enum now, in the switch statement at following mentioned location, default case needs to be added as well. It generates a warning that some enumeration values are not handled in switch.

[Lldb-commits] [PATCH] D68039: [lit] Do a better job at parsing unsupported tests.

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/lit/Suite/lldbtest.py:105 +has_unsupported_tests = 'UNSUPPORTED:' in out or 'UNSUPPORTED:' in err +has_passing_tests = 'PASS:' in out or 'PASS:' in err

[Lldb-commits] [PATCH] D68040: [lldb] Excludes private headers from SWIG dependency.

This revision was automatically updated to reflect the committed changes. Closed by commit rL372905: [lldb] Excludes private headers from SWIG dependency. (authored by hhb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D68039: [lit] Do a better job at parsing unsupported tests.

aprantl added inline comments. Comment at: lldb/lit/Suite/lldbtest.py:105 +has_unsupported_tests = 'UNSUPPORTED:' in out or 'UNSUPPORTED:' in err +has_passing_tests = 'PASS:' in out or 'PASS:' in err `'UNSUPPORTED:' in out + err` ?

[Lldb-commits] [PATCH] D68040: [lldb] Excludes private headers from SWIG dependency.

hhb created this revision. hhb added a reviewer: xiaobai. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68040 Files: lldb/scripts/CMakeLists.txt Index: lldb/scripts/CMakeLists.txt

[Lldb-commits] [PATCH] D68039: [lit] Do a better job at parsing unsupported tests.

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68039/new/ https://reviews.llvm.org/D68039 ___

[Lldb-commits] [PATCH] D68039: [lit] Do a better job at parsing unsupported tests.

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, labath, jingham, xiaobai. Herald added a project: LLDB. When all the tests run by dotest are unsupported, it still reports `RESULT: PASSED` which we translate to success for lit. We can better report the status as

[Lldb-commits] [PATCH] D68007: [lldb] Move swig call from python code to cmake

xiaobai added inline comments. Comment at: lldb/trunk/scripts/CMakeLists.txt:5 + ${LLDB_SOURCE_DIR}/include/lldb/API/*.h + ${LLDB_SOURCE_DIR}/include/lldb/*.h ) hhb wrote: > xiaobai wrote: > > Doesn't this now include the `lldb-private` headers now? Is that

[Lldb-commits] [PATCH] D67774: [Mangle] Add flag to asm labels to disable '\01' prefixing

This revision was automatically updated to reflect the committed changes. Closed by commit rL372903: [Mangle] Add flag to asm labels to disable \01 prefixing (authored by vedantk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r372903 - [Mangle] Add flag to asm labels to disable '\01' prefixing

Author: vedantk Date: Wed Sep 25 11:00:31 2019 New Revision: 372903 URL: http://llvm.org/viewvc/llvm-project?rev=372903=rev Log: [Mangle] Add flag to asm labels to disable '\01' prefixing LLDB synthesizes decls using asm labels. These decls cannot have a mangle different than the one specified

[Lldb-commits] [PATCH] D68007: [lldb] Move swig call from python code to cmake

hhb marked an inline comment as done. hhb added inline comments. Comment at: lldb/trunk/scripts/CMakeLists.txt:5 + ${LLDB_SOURCE_DIR}/include/lldb/API/*.h + ${LLDB_SOURCE_DIR}/include/lldb/*.h ) xiaobai wrote: > Doesn't this now include the `lldb-private`

[Lldb-commits] [PATCH] D68007: [lldb] Move swig call from python code to cmake

xiaobai added inline comments. Comment at: lldb/trunk/scripts/CMakeLists.txt:5 + ${LLDB_SOURCE_DIR}/include/lldb/API/*.h + ${LLDB_SOURCE_DIR}/include/lldb/*.h ) Doesn't this now include the `lldb-private` headers now? Is that intended? Repository: rL LLVM

[Lldb-commits] [PATCH] D67774: [Mangle] Add flag to asm labels to disable '\01' prefixing

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67774/new/ https://reviews.llvm.org/D67774 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D67774: [Mangle] Add flag to asm labels to disable '\01' prefixing

vsk updated this revision to Diff 221801. vsk added a comment. - Add a comment describing where non-literal labels are used. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67774/new/ https://reviews.llvm.org/D67774 Files: clang/include/clang/Basic/Attr.td

[Lldb-commits] [lldb] r372901 - [CMake] Add the system debugserver to lldb-test-deps.

Author: jdevlieghere Date: Wed Sep 25 10:13:02 2019 New Revision: 372901 URL: http://llvm.org/viewvc/llvm-project?rev=372901=rev Log: [CMake] Add the system debugserver to lldb-test-deps. When using the system debugserver we create a target to copy it over. This target has to be added to

[Lldb-commits] [lldb] r372900 - [CMake] Run the lldb-server tests with system debugserver.

Author: jdevlieghere Date: Wed Sep 25 10:12:59 2019 New Revision: 372900 URL: http://llvm.org/viewvc/llvm-project?rev=372900=rev Log: [CMake] Run the lldb-server tests with system debugserver. Now that we no longer build debugserver when LLDB_USE_SYSTEM_DEBUGSERVER is set, we have to change the

[Lldb-commits] [PATCH] D68003: [dotest] Support specifying a version for skipIfOutOfTreeDebugserver

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: lldb/packages/Python/lldbsuite/test/decorators.py:513 +debugserver_version[0], debugserver_version[1], +actual_debugserver_version)

[Lldb-commits] [PATCH] D68010: [lldb] Fix string summary of an empty NSPathStore2

aprantl added inline comments. Comment at: lldb/include/lldb/DataFormatters/StringPrinter.h:120 + +bool GetHasSourceSize() const { return m_has_source_size; } + I don't know the LLDB rules that well: is the convention really `GetHas` instead of `Has`?

[Lldb-commits] [PATCH] D68003: [dotest] Support specifying a version for skipIfOutOfTreeDebugserver

JDevlieghere updated this revision to Diff 221791. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68003/new/ https://reviews.llvm.org/D68003 Files: lldb/packages/Python/lldbsuite/test/commands/register/register/register_command/TestRegisters.py

[Lldb-commits] [PATCH] D68003: [dotest] Support specifying a version for skipIfOutOfTreeDebugserver

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/TestConcurrentManyBreakpoints.py:18 @expectedFailureNetBSD -@skipIfOutOfTreeDebugserver +

[Lldb-commits] [PATCH] D68007: [lldb] Move swig call from python code to cmake

This revision was automatically updated to reflect the committed changes. Closed by commit rL372895: [lldb] Move swig call from python code to cmake (authored by hhb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D68003: [dotest] Support specifying a version for skipIfOutOfTreeDebugserver

aprantl added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/commands/register/register/register_command/TestRegisters.py:73 @skipIf(archs=no_match(['amd64', 'i386', 'x86_64'])) -@skipIfOutOfTreeDebugserver +@skipIfOutOfTreeDebugserver(['<',

[Lldb-commits] [PATCH] D68005: Make dw_tag_t a llvm::dwarf::Tag

shafik added a comment. Thanks for doing this! I spent a bunch of time trying to understand that relationship yesterday. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68005/new/ https://reviews.llvm.org/D68005 ___

[Lldb-commits] [PATCH] D68003: [dotest] Support specifying a version for skipIfOutOfTreeDebugserver

aprantl added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/commands/register/register/register_command/TestRegisters.py:73 @skipIf(archs=no_match(['amd64', 'i386', 'x86_64'])) -@skipIfOutOfTreeDebugserver +@skipIfOutOfTreeDebugserver(['<',

[Lldb-commits] [PATCH] D68005: Make dw_tag_t a llvm::dwarf::Tag

aprantl added inline comments. Comment at: lldb/trunk/include/lldb/Core/dwarf.h:23 typedef int32_t dw_sleb128_t; typedef uint16_t dw_attr_t; typedef uint16_t dw_form_t; so should this be `llvm::dwarf::Attribute`? Comment at:

[Lldb-commits] [lldb] r372894 - [Docs] Document forwarding arguments with lit

Author: jdevlieghere Date: Wed Sep 25 09:14:26 2019 New Revision: 372894 URL: http://llvm.org/viewvc/llvm-project?rev=372894=rev Log: [Docs] Document forwarding arguments with lit Explain how to forward arguments to dotest.py from lit. Modified: lldb/trunk/docs/resources/test.rst Modified:

[Lldb-commits] [PATCH] D68005: Make dw_tag_t a llvm::dwarf::Tag

This revision was automatically updated to reflect the committed changes. Closed by commit rL372891: [Dwarf] Make dw_tag_t a typedef for llvm::dwarf::Tag instead of uint16_t. (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[Lldb-commits] [lldb] r372891 - [Dwarf] Make dw_tag_t a typedef for llvm::dwarf::Tag instead of uint16_t.

Author: jdevlieghere Date: Wed Sep 25 09:04:38 2019 New Revision: 372891 URL: http://llvm.org/viewvc/llvm-project?rev=372891=rev Log: [Dwarf] Make dw_tag_t a typedef for llvm::dwarf::Tag instead of uint16_t. Currently dw_tag_t is a typedef for uint16_t. This patch changes makes dw_tag_t a

[Lldb-commits] [lldb] r372890 - Modernize Makefile.

Author: adrian Date: Wed Sep 25 08:48:30 2019 New Revision: 372890 URL: http://llvm.org/viewvc/llvm-project?rev=372890=rev Log: Modernize Makefile. Modified: lldb/trunk/packages/Python/lldbsuite/test/commands/expression/import-std-module/sysroot/Makefile Modified:

[Lldb-commits] [PATCH] D67776: Don't stop execution in batch mode when process stops with SIGINT or SIGSTOP

tatyana-krasnukha updated this revision to Diff 221744. tatyana-krasnukha retitled this revision from "Use UnixSignals::ShouldSuppress to filter out signals a process expects" to "Don't stop execution in batch mode when process stops with SIGINT or SIGSTOP". tatyana-krasnukha edited the summary

[Lldb-commits] [lldb] r372869 - [lldb][modern-type-lookup] Add two basic tests for modern-type-lookup

Author: teemperor Date: Wed Sep 25 06:33:50 2019 New Revision: 372869 URL: http://llvm.org/viewvc/llvm-project?rev=372869=rev Log: [lldb][modern-type-lookup] Add two basic tests for modern-type-lookup The story so far: LLDB's modern type lookup mode has no (as in, 0%) test coverage. It was

[Lldb-commits] [PATCH] D67776: Use UnixSignals::ShouldSuppress to filter out signals a process expects

tatyana-krasnukha added a comment. To Pavel: this problem is not only about the behavior of process attach, but for process launch too (and possibly something else). That's why I'm trying to move this logic out of specific commands. Now I see that there are too many different usages of SIGTRAP

[Lldb-commits] [PATCH] D67965: Have ABI plugins vend llvm MCRegisterInfo data

This revision was automatically updated to reflect the committed changes. labath marked an inline comment as done. Closed by commit rL372862: Have ABI plugins vend llvm MCRegisterInfo data (authored by labath, committed by ). Herald added subscribers: llvm-commits, jrtc27. Herald added a project:

[Lldb-commits] [lldb] r372862 - Have ABI plugins vend llvm MCRegisterInfo data

Author: labath Date: Wed Sep 25 06:03:04 2019 New Revision: 372862 URL: http://llvm.org/viewvc/llvm-project?rev=372862=rev Log: Have ABI plugins vend llvm MCRegisterInfo data Summary: I was recently surprised to learn that there is a total of 2 (two) users of the register info definitions

[Lldb-commits] [lldb] r372861 - [lldb][NFC] Remove CompletionRequest::GetCursorArgument and GetRawLineUntilCursor

Author: teemperor Date: Wed Sep 25 05:55:30 2019 New Revision: 372861 URL: http://llvm.org/viewvc/llvm-project?rev=372861=rev Log: [lldb][NFC] Remove CompletionRequest::GetCursorArgument and GetRawLineUntilCursor They both return the same result as another function (GetCursorArgumentPrefix and

[Lldb-commits] [PATCH] D67965: Have ABI plugins vend llvm MCRegisterInfo data

labath marked 3 inline comments as done. labath added inline comments. Comment at: include/lldb/Target/ABI.h:141 protected: - // Classes that inherit from ABI can see and modify these - ABI(lldb::ProcessSP process_sp) { -if (process_sp.get()) -m_process_wp =

[Lldb-commits] [lldb] r372858 - [lldb][NFC] Add CompletionRequest::AppendEmptyArgument

Author: teemperor Date: Wed Sep 25 05:40:01 2019 New Revision: 372858 URL: http://llvm.org/viewvc/llvm-project?rev=372858=rev Log: [lldb][NFC] Add CompletionRequest::AppendEmptyArgument This is the only legitimate use we currently have for modifying a CompletionRequest. Add a utility function

[Lldb-commits] [PATCH] D67793: new api class: SBFile

labath added inline comments. Comment at: lldb/source/API/SBFile.cpp:20-26 +void SBFile::SetStream(FILE *file, bool transfer_ownership) { +m_opaque_up = std::make_unique(file, transfer_ownership); +} + +void SBFile::SetDescriptor(int fd, bool transfer_owndership) { +

[Lldb-commits] [PATCH] D67891: remove File::SetStream(), make new files instead.

labath added a comment. Thanks for splitting these up. It makes it much more obvious what is going on. I see now that you're making use of this SetFile method which I wanted to remove in the previous patch. I kind of like that, because it pushes the `Set` one level up (so it now happens on the

[Lldb-commits] [PATCH] D67996: Convert FileSystem::Open() to return Expected

labath marked an inline comment as done. labath added a comment. Thanks for splitting this up. Despite the number of comments, I think this is looking pretty good. The main theme of the comments is making sure that we satisfy the contract of the Expected class, which is a bit... unexpected.

[Lldb-commits] [lldb] r372851 - [lldb][NFC] Remove useless cursor shifting in Options::HandleOptionCompletion

Author: teemperor Date: Wed Sep 25 05:04:48 2019 New Revision: 372851 URL: http://llvm.org/viewvc/llvm-project?rev=372851=rev Log: [lldb][NFC] Remove useless cursor shifting in Options::HandleOptionCompletion The cursor position is always at the end of the current argument (as the argument cut

Re: [Lldb-commits] [lldb] r372788 - Host: use the platform identifiers from LLVM (NFC)

This seems to have broken the build: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/9182 I've reverted in r372847. On Wed, Sep 25, 2019 at 12:53 AM Saleem Abdulrasool via lldb-commits wrote: > > Author: compnerd > Date: Tue Sep 24 15:55:44 2019 > New Revision: 372788 > > URL:

[Lldb-commits] [lldb] r372847 - Revert r372788 "Host: use the platform identifiers from LLVM (NFC)"

Author: hans Date: Wed Sep 25 04:55:16 2019 New Revision: 372847 URL: http://llvm.org/viewvc/llvm-project?rev=372847=rev Log: Revert r372788 "Host: use the platform identifiers from LLVM (NFC)" > Use symbolic constants for the platform identifiers rather than replicating > them > locally. This

[Lldb-commits] [PATCH] D68010: [lldb] Fix string summary of an empty NSPathStore2

teemperor updated this revision to Diff 221702. teemperor edited the summary of this revision. teemperor added a comment. - Land the NFC test additions to other string classes as separate NFC commits. - Rebase on the already landed refactoring. CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] r372840 - [lldb] [test] Add NetBSD to XFAIL list for thread_local test

Author: mgorny Date: Wed Sep 25 03:18:38 2019 New Revision: 372840 URL: http://llvm.org/viewvc/llvm-project?rev=372840=rev Log: [lldb] [test] Add NetBSD to XFAIL list for thread_local test Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/thread_local/TestThreadLocal.py

[Lldb-commits] [lldb] r372837 - [lldb] Test data formatters for empty strings

Author: teemperor Date: Wed Sep 25 03:07:23 2019 New Revision: 372837 URL: http://llvm.org/viewvc/llvm-project?rev=372837=rev Log: [lldb] Test data formatters for empty strings Modified:

[Lldb-commits] [lldb] r372836 - [lldb][NFC] Refactor and document *DumpToStreamOptions

Author: teemperor Date: Wed Sep 25 02:56:23 2019 New Revision: 372836 URL: http://llvm.org/viewvc/llvm-project?rev=372836=rev Log: [lldb][NFC] Refactor and document *DumpToStreamOptions Those two classes were mostly copy-pasted. Modified:

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

This revision was automatically updated to reflect the committed changes. Closed by commit rL372835: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [lldb] r372835 - [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

Author: mgorny Date: Wed Sep 25 02:47:35 2019 New Revision: 372835 URL: http://llvm.org/viewvc/llvm-project?rev=372835=rev Log: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib Fix installing Python modules on systems that use /usr/lib for Python while installing other

[Lldb-commits] [PATCH] D68007: [lldb] Move swig call from python code to cmake

labath accepted this revision. labath added a comment. Yay, tons of nasty python code going down the drain. This looks fine, but please take it slowly when landing these patches. Waiting a day or two before proceeding with the next patch will make it easier to fix things up if any of them

[Lldb-commits] [PATCH] D67993: [lldb] Calculate relative path for symbol links

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This looks fine. There is no xcode build. If you want to test building the framework, you just need to set LLDB_BUILD_FRAMEWORK cmake variable. I don't know if there's any other var than

[Lldb-commits] [lldb] r372834 - [lldb][NFC] Remove unused method chaining from Read[Buffer/String]AndDumpToStreamOptions

Author: teemperor Date: Wed Sep 25 02:21:00 2019 New Revision: 372834 URL: http://llvm.org/viewvc/llvm-project?rev=372834=rev Log: [lldb][NFC] Remove unused method chaining from Read[Buffer/String]AndDumpToStreamOptions All this code isn't used anywhere and method chaining isn't really useful

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

jankratochvil added inline comments. Comment at: lldb/source/Plugins/ObjectFile/ELF/ELFHeader.h:276 + st_size == rhs.st_size && st_other == rhs.st_other && + st_shndx == rhs.st_shndx && st_value == rhs.st_value; + } It could be in the same

[Lldb-commits] [PATCH] D67774: [Mangle] Add flag to asm labels to disable '\01' prefixing

teemperor resigned from this revision. teemperor added a comment. This LGTM modulo rjmccall's comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67774/new/ https://reviews.llvm.org/D67774 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D67988: [lldb] clean up lldb/scripts a little bit

labath added a subscriber: sgraenitz. labath added a comment. I don't think this is fully right. We did have a separate xcode build, but it was removed a couple of months ago. Instead the regular cmake build supports building a macos-style framework (and I believe it does that regardless of

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk updated this revision to Diff 221690. kwk added a comment. - Revert "Change test expectation to find 2 instead of 1 symbol" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67390/new/ https://reviews.llvm.org/D67390 Files:

[Lldb-commits] [PATCH] D67774: [Mangle] Add flag to asm labels to disable '\01' prefixing

rjmccall added a comment. Thanks. One last and minor request: please mention in the comment on IsLiteralLabel that non-literal labels are used by some external AST sources like LLDB. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67774/new/ https://reviews.llvm.org/D67774

[Lldb-commits] [PATCH] D68005: Make dw_tag_t a llvm::dwarf::Tag

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Makes sense to me. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68005/new/ https://reviews.llvm.org/D68005

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk updated this revision to Diff 221689. kwk added a comment. - [LLDB][ELF] Fixup for comments in D67390 - Change test expectation to find 2 instead of 1 symbol - symbol uniqueness by using elf::ELFSymbol Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [lldb] r372830 - [lldb][NFC] Use default member initializers in ReadBufferAndDumpToStreamOptions

Author: teemperor Date: Wed Sep 25 01:55:55 2019 New Revision: 372830 URL: http://llvm.org/viewvc/llvm-project?rev=372830=rev Log: [lldb][NFC] Use default member initializers in ReadBufferAndDumpToStreamOptions Modified: lldb/trunk/include/lldb/DataFormatters/StringPrinter.h Modified:

[Lldb-commits] [PATCH] D67984: Canonicalize variable usage in testsuite Makefiles

labath added a comment. Cool stuff. I wanted to do this for a while. Thanks. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67984/new/ https://reviews.llvm.org/D67984 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D68003: [dotest] Support specifying a version for skipIfOutOfTreeDebugserver

labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/TestConcurrentManyBreakpoints.py:18 @expectedFailureNetBSD -@skipIfOutOfTreeDebugserver +@skipIfOutOfTreeDebugserver(['<=', '']) def

[Lldb-commits] [PATCH] D67994: [WIP] Modify lldb-test to print out ASTs from symbol file

labath added a comment. For dumping a specific type something like this could be right, but for "indiscriminately dumping" everything, this seems to be a bit fragile. Would it be possible to make this use the `SymbolFile::DumpClangAST` method (this is what the "image dump ast" lldb command

[Lldb-commits] [lldb] r372827 - [lldb] Remove -nostdlib++ flag from import-std-module/sysroot test

Author: teemperor Date: Wed Sep 25 01:32:25 2019 New Revision: 372827 URL: http://llvm.org/viewvc/llvm-project?rev=372827=rev Log: [lldb] Remove -nostdlib++ flag from import-std-module/sysroot test That flag was introduced in Clang 6.0, so this made the test fail with Clang <= 5.0. As it only

[Lldb-commits] [PATCH] D68010: [lldb] Fix string summary of an empty NSPathStore2

teemperor created this revision. teemperor added reviewers: aprantl, JDevlieghere, shafik. Herald added subscribers: lldb-commits, abidh, christof. Herald added a project: LLDB. Printing a summary for an empty NSPathStore2 string currently prints random bytes behind the empty string pointer from

[Lldb-commits] [lldb] r372817 - [lldb] Fix undefined behavior when having fixits in undefined top level exprs

Author: teemperor Date: Wed Sep 25 00:34:56 2019 New Revision: 372817 URL: http://llvm.org/viewvc/llvm-project?rev=372817=rev Log: [lldb] Fix undefined behavior when having fixits in undefined top level exprs In top level expressions, we don't have a m_source_code and we don't need to change

[Lldb-commits] [lldb] r372815 - [lldb][NFC] Refactor TestCallBuiltinFunction

Author: teemperor Date: Wed Sep 25 00:11:37 2019 New Revision: 372815 URL: http://llvm.org/viewvc/llvm-project?rev=372815=rev Log: [lldb][NFC] Refactor TestCallBuiltinFunction Using asserts doesn't print a useful error message in case this test fails. Modified: