[Lldb-commits] [PATCH] D69873: [lldb-vscode] support the completion request

wallace created this revision. wallace added reviewers: clayborg, aadsm. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. wallace edited the summary of this revision. The DAP has a completion request that has been unimplemented. It allows showing autocompletion tokens

[Lldb-commits] [PATCH] D69871: crashlog.py: Improve regular expressions

aprantl created this revision. aprantl added reviewers: jingham, jasonmolenda. Herald added a subscriber: kristof.beyls. aprantl edited the summary of this revision. This is yet another change to the regular expressions in crashlog.py that fix a few edge cases, and attempt to improve the

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

aadsm added a comment. @hhb I just did, and get the same error as well :( `ninja: error: 'bin/LLDB.framework/LLDB', needed by 'bin/LLDB.framework/Resources/Python/lldb/_lldb.so', missing and no known rule to make it` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

hhb added a comment. In D69589#1733567 , @aadsm wrote: > @hhb fwiw, I still get the same error with this diff (after applying it on > top of D69834 ). But D69834 > by itself works great!

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

hhb updated this revision to Diff 227974. hhb added a comment. Fix some naming Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69589/new/ https://reviews.llvm.org/D69589 Files: lldb/CMakeLists.txt lldb/scripts/CMakeLists.txt Index:

[Lldb-commits] [lldb] 40f3d13 - [TestMTCSimple] Disable the test if you don't have libMTC

Author: Alex Langford Date: 2019-11-05T14:11:26-08:00 New Revision: 40f3d1307cfd66e6dc1a921eec42559a6691b393 URL: https://github.com/llvm/llvm-project/commit/40f3d1307cfd66e6dc1a921eec42559a6691b393 DIFF: https://github.com/llvm/llvm-project/commit/40f3d1307cfd66e6dc1a921eec42559a6691b393.diff

[Lldb-commits] [PATCH] D69738: Fix handling for the clang name mangling extension for block invocations

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Let's do the refactoring in a follow-up commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69738/new/ https://reviews.llvm.org/D69738

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

hhb updated this revision to Diff 227958. hhb added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69589/new/ https://reviews.llvm.org/D69589 Files: lldb/CMakeLists.txt lldb/scripts/CMakeLists.txt Index:

[Lldb-commits] [PATCH] D69834: [lldb] Add a install target for lldb python on darwin

hhb updated this revision to Diff 227956. hhb added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69834/new/ https://reviews.llvm.org/D69834 Files: lldb/CMakeLists.txt Index: lldb/CMakeLists.txt

[Lldb-commits] [PATCH] D69834: [lldb] Add a install target for lldb python on darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a79e083a0d1: [lldb] Add a install target for lldb python on darwin (authored by hhb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69834/new/

[Lldb-commits] [lldb] 6a79e08 - [lldb] Add a install target for lldb python on darwin

Author: Haibo Huang Date: 2019-11-05T13:25:38-08:00 New Revision: 6a79e083a0d131e741ac8f48badbb0481491e47f URL: https://github.com/llvm/llvm-project/commit/6a79e083a0d131e741ac8f48badbb0481491e47f DIFF: https://github.com/llvm/llvm-project/commit/6a79e083a0d131e741ac8f48badbb0481491e47f.diff

[Lldb-commits] [lldb] 3ac6863 - [ValueObject] Upstream early exit from swift-lldb. (NFC)

Author: Adrian Prantl Date: 2019-11-05T12:43:00-08:00 New Revision: 3ac6863efbbfa27175588670e3b3715b0351ff4e URL: https://github.com/llvm/llvm-project/commit/3ac6863efbbfa27175588670e3b3715b0351ff4e DIFF: https://github.com/llvm/llvm-project/commit/3ac6863efbbfa27175588670e3b3715b0351ff4e.diff

[Lldb-commits] [lldb] 2abcf44 - [Reproducer] Add test case for expression evaluation

Author: Jonas Devlieghere Date: 2019-11-05T12:33:21-08:00 New Revision: 2abcf44f4c91a326d1f4513fb5c25fec51c6ca66 URL: https://github.com/llvm/llvm-project/commit/2abcf44f4c91a326d1f4513fb5c25fec51c6ca66 DIFF:

[Lldb-commits] [lldb] 270fe47 - testsuite: skipIfNoSBHeaders should skip when running remotely

Author: Fred Riss Date: 2019-11-05T12:22:59-08:00 New Revision: 270fe47aae4ac0bf72251161ad3320de56055c3a URL: https://github.com/llvm/llvm-project/commit/270fe47aae4ac0bf72251161ad3320de56055c3a DIFF: https://github.com/llvm/llvm-project/commit/270fe47aae4ac0bf72251161ad3320de56055c3a.diff

[Lldb-commits] [lldb] 2ff545e - Modernize add-dsym test Makefile

Author: Fred Riss Date: 2019-11-05T12:22:59-08:00 New Revision: 2ff545e76d11bc4fdd7663945d6ac343575530fe URL: https://github.com/llvm/llvm-project/commit/2ff545e76d11bc4fdd7663945d6ac343575530fe DIFF: https://github.com/llvm/llvm-project/commit/2ff545e76d11bc4fdd7663945d6ac343575530fe.diff

[Lldb-commits] [PATCH] D69738: Fix handling for the clang name mangling extension for block invocations

aprantl added inline comments. Comment at: lldb/source/Core/Mangled.cpp:106 + + return Mangled::eManglingSchemeNone; +} shafik wrote: > aprantl wrote: > > You don't need to fix this all at once, but I think it would be even better > > if this function did

[Lldb-commits] [lldb] 3606b56 - ValueObject: Upstream early-exit from swift-lldb. (NFC)

Author: Adrian Prantl Date: 2019-11-05T10:53:57-08:00 New Revision: 3606b567849a935ef6bf627dec2e6100a8f25c4b URL: https://github.com/llvm/llvm-project/commit/3606b567849a935ef6bf627dec2e6100a8f25c4b DIFF: https://github.com/llvm/llvm-project/commit/3606b567849a935ef6bf627dec2e6100a8f25c4b.diff

[Lldb-commits] [lldb] a997003 - [lldb] Fix Python 3 incompatibility in API/lit.cfg.py

Author: Jonas Devlieghere Date: 2019-11-05T10:13:01-08:00 New Revision: a9970036d43b4fb8622d7179603722b539756457 URL: https://github.com/llvm/llvm-project/commit/a9970036d43b4fb8622d7179603722b539756457 DIFF:

[Lldb-commits] [PATCH] D69738: Fix handling for the clang name mangling extension for block invocations

shafik added inline comments. Comment at: lldb/source/Core/Mangled.cpp:99 + + if (s.size() >= 2 && (s[0] == '_' && s[1] == 'Z')) +return Mangled::eManglingSchemeItanium; aprantl wrote: > jingham wrote: > > StringRef has a startswith. That might be easier

[Lldb-commits] [PATCH] D69843: Expression eval lookup - prune methods without parsing

aprantl added a comment. I thought about something similar in the context of https://reviews.llvm.org/D68678 (that's for FIndTypes, but it we the same kind of problems there). Like Pavel said, it would be valuable to be able to filter after the accelerator table lookup, but before building,

[Lldb-commits] [PATCH] D69846: [lldb] [Python] Build readline override module only on Linux

serge-sans-paille added a comment. Thanks for the fix o/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69846/new/ https://reviews.llvm.org/D69846 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D69843: Expression eval lookup - prune methods without parsing

labath added reviewers: aprantl, clayborg. labath added a comment. > A resonable solution would be to change the meaning of > eFunctionNameTypeFull to only mean mangled names, and if the caller > wanted methods and basenames, they would have to call with > eFunctionNameTypeFull |

[Lldb-commits] [PATCH] D69846: [lldb] [Python] Build readline override module only on Linux

This revision was automatically updated to reflect the committed changes. Closed by commit rGdf3ae1eb296d: [lldb] [Python] Build readline override module only on Linux (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D69846: [lldb] [Python] Build readline override module only on Linux

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Makes sense to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69846/new/ https://reviews.llvm.org/D69846 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D69793: Bundle libedit-compatible readline replacement

mgorny added a comment. Made D69846 for that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69793/new/ https://reviews.llvm.org/D69793 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D69846: [lldb] [Python] Build readline override module only on Linux

mgorny created this revision. mgorny added reviewers: serge-sans-paille, labath, JDevlieghere, krytarowski. Restrict building the readline override to Linux only. It both does not build on *BSD systems, and is largely irrelevant since they default to using libedit over readline anyway. This

[Lldb-commits] [PATCH] D69793: Bundle libedit-compatible readline replacement

mgorny added a comment. Ok, this is breaking build on NetBSD: http://lab.llvm.org:8014/builders/netbsd-amd64/builds/92/steps/ninja%20build%20local/logs/stdio Header location is not the only problem, the code fails to build after fixing that. FWICS, the previous module was built only for

[Lldb-commits] [PATCH] D69793: Bundle libedit-compatible readline replacement

labath added a comment. In D69793#1733774 , @serge-sans-paille wrote: > In D69793#1733672 , @labath wrote: > > > > 1. use PyMem_RawMalloc instead of PyMem_Malloc, as expected by > > > PyOS_Readline (prevents to

[Lldb-commits] [PATCH] D69793: Bundle libedit-compatible readline replacement

serge-sans-paille added a comment. In D69793#1733672 , @labath wrote: > > 1. use PyMem_RawMalloc instead of PyMem_Malloc, as expected by > > PyOS_Readline (prevents to segfault upon exit of interactive session) > > It looks like this is failing on

[Lldb-commits] [lldb] d590498 - [lldb] Fix readline/libedit compat patch for py2

Author: serge-sans-paille Date: 2019-11-05T14:16:39+01:00 New Revision: d590498829d8c0d4f4f673569949fa3850485c9c URL: https://github.com/llvm/llvm-project/commit/d590498829d8c0d4f4f673569949fa3850485c9c DIFF:

[Lldb-commits] [lldb] 9357b5d - Revert and patch "[Python] Remove readline module"

Author: serge-sans-paille Date: 2019-11-05T11:39:19+01:00 New Revision: 9357b5d08497326a1895cab6c1d712bf12a34519 URL: https://github.com/llvm/llvm-project/commit/9357b5d08497326a1895cab6c1d712bf12a34519 DIFF:

[Lldb-commits] [lldb] f71e35d - lldb/breakpad: add suppport for the "x86_64h" architecture

Author: Pavel Labath Date: 2019-11-05T11:41:20+01:00 New Revision: f71e35dc1f3ea9b368b1d4626ee9bf7993839084 URL: https://github.com/llvm/llvm-project/commit/f71e35dc1f3ea9b368b1d4626ee9bf7993839084 DIFF: https://github.com/llvm/llvm-project/commit/f71e35dc1f3ea9b368b1d4626ee9bf7993839084.diff

[Lldb-commits] [PATCH] D69793: Bundle libedit-compatible readline replacement

labath added a comment. > 1. use PyMem_RawMalloc instead of PyMem_Malloc, as expected by PyOS_Readline > (prevents to segfault upon exit of interactive session) It looks like this is failing on python2, because it has no RawMalloc function https://docs.python.org/2.7/c-api/memory.html. I guess

[Lldb-commits] [lldb] 4ecff91 - lldb/minidump: Add support for the alternate ARM64 constant

Author: Pavel Labath Date: 2019-11-05T11:26:06+01:00 New Revision: 4ecff91ed1df05edbdb55cb2ccdf58466f1333b0 URL: https://github.com/llvm/llvm-project/commit/4ecff91ed1df05edbdb55cb2ccdf58466f1333b0 DIFF: https://github.com/llvm/llvm-project/commit/4ecff91ed1df05edbdb55cb2ccdf58466f1333b0.diff

[Lldb-commits] [PATCH] D69793: Bundle libedit-compatible readline replacement

This revision was automatically updated to reflect the committed changes. Closed by commit rG9357b5d08497: Revert and patch [Python] Remove readline module (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D69793?vs=227823=227834#toc Repository: rG LLVM

[Lldb-commits] [lldb] 28cf969 - MemoryRegion: Print "don't know" permission values as such

Author: Pavel Labath Date: 2019-11-05T11:17:27+01:00 New Revision: 28cf9698abd39221001ace885a7d1c1f488b967c URL: https://github.com/llvm/llvm-project/commit/28cf9698abd39221001ace885a7d1c1f488b967c DIFF: https://github.com/llvm/llvm-project/commit/28cf9698abd39221001ace885a7d1c1f488b967c.diff

[Lldb-commits] [lldb] db5074d - [lldb][NFC] Give some parameters in CommandInterpreter more descriptive names

Author: Raphael Isemann Date: 2019-11-05T09:21:10+01:00 New Revision: db5074dc10222a8202adcd7c1da1acd2828fbecb URL: https://github.com/llvm/llvm-project/commit/db5074dc10222a8202adcd7c1da1acd2828fbecb DIFF: