[Lldb-commits] [lldb] 6602e1f - Reordering KextImageInfo::LoadImageUsingMemoryModule

Author: Jason Molenda Date: 2019-11-07T19:34:09-08:00 New Revision: 6602e1fb0e34c1a755ef561de24e5b78a460672a URL: https://github.com/llvm/llvm-project/commit/6602e1fb0e34c1a755ef561de24e5b78a460672a DIFF: https://github.com/llvm/llvm-project/commit/6602e1fb0e34c1a755ef561de24e5b78a460672a.diff

[Lldb-commits] [PATCH] D69931: Add cmake variables to specify a python framework to ship with lldb

smeenai added a comment. I agree on not getting into the business of installing Python ourselves, but there's also the rpath issue. The Windows case is different because you just put all your DLLs in the same directory (or some other directory in your PATH) and you're done. With macOS, you have

Re: [Lldb-commits] [lldb] 0877dd1 - [Driver] Force llvm to install its handlers before lldb's

Hey JF, Pavel, We're still seeing crashes due to SIGPIPE on some lldb bots. This workaround in the lldb driver is insufficient, because liblldb.dylib may install its own a fresh set of llvm signal handlers (the `NumRegisteredSignals` global is not shared by all images loaded in a process). Here

[Lldb-commits] [PATCH] D69931: Add cmake variables to specify a python framework to ship with lldb

hhb added a comment. In D69931#1736607 , @labath wrote: > In principle, this looks pretty similar to D67942 > , and my opinion on it is the same -- I > don't think we should be in the business of trying to package the tra

[Lldb-commits] [lldb] cbdd92b - Modernize TestWeakSymbols Makefile

Author: Fred Riss Date: 2019-11-07T14:53:52-08:00 New Revision: cbdd92be8a57e204aeb346c02ec6c4f440499679 URL: https://github.com/llvm/llvm-project/commit/cbdd92be8a57e204aeb346c02ec6c4f440499679 DIFF: https://github.com/llvm/llvm-project/commit/cbdd92be8a57e204aeb346c02ec6c4f440499679.diff LOG

[Lldb-commits] [PATCH] D69425: [lldb] Fix broken -D option for breakpoint set command

This revision was automatically updated to reflect the committed changes. Closed by commit rGf1539b9db39a: BreakpointDummyOptionGroup was using g_breakpoint_modify_options rather than… (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D69425: [lldb] Fix broken -D option for breakpoint set command

jingham added a comment. In D69425#1731155 , @poya wrote: > No commit access, so would need some assistance getting this change into the > repo. I pushed this (f1539b9db39a59a5e50c065c39e491ba4f890377

[Lldb-commits] [lldb] f1539b9 - BreakpointDummyOptionGroup was using g_breakpoint_modify_options rather than g_breakpoint_dummy_options

Author: Jim Ingham Date: 2019-11-07T14:25:04-08:00 New Revision: f1539b9db39a59a5e50c065c39e491ba4f890377 URL: https://github.com/llvm/llvm-project/commit/f1539b9db39a59a5e50c065c39e491ba4f890377 DIFF: https://github.com/llvm/llvm-project/commit/f1539b9db39a59a5e50c065c39e491ba4f890377.diff LO

[Lldb-commits] [lldb] c62a9f1 - [lldb] Improve assert in GDBRemoteCommunicationReplayServer

Author: Jonas Devlieghere Date: 2019-11-07T12:43:59-08:00 New Revision: c62a9f180c26e2fed012531caa581f0d736bfed9 URL: https://github.com/llvm/llvm-project/commit/c62a9f180c26e2fed012531caa581f0d736bfed9 DIFF: https://github.com/llvm/llvm-project/commit/c62a9f180c26e2fed012531caa581f0d736bfed9.d

[Lldb-commits] [PATCH] D69871: crashlog.py: Improve regular expressions

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGff9d73288738: crashlog.py: Improve regular expressions (authored by aprantl). Herald added a project: LLDB. Changed prior

[Lldb-commits] [lldb] ff9d732 - crashlog.py: Improve regular expressions

Author: Adrian Prantl Date: 2019-11-07T10:52:06-08:00 New Revision: ff9d732887385e6f3e516769419dd64b406d81d8 URL: https://github.com/llvm/llvm-project/commit/ff9d732887385e6f3e516769419dd64b406d81d8 DIFF: https://github.com/llvm/llvm-project/commit/ff9d732887385e6f3e516769419dd64b406d81d8.diff

[Lldb-commits] [lldb] 44f4346 - [lldb] Comment typo fix

Author: Jan Kratochvil Date: 2019-11-07T17:48:25+01:00 New Revision: 44f43461c018e7fdc3b1cf3a7a41f52b1cb20a39 URL: https://github.com/llvm/llvm-project/commit/44f43461c018e7fdc3b1cf3a7a41f52b1cb20a39 DIFF: https://github.com/llvm/llvm-project/commit/44f43461c018e7fdc3b1cf3a7a41f52b1cb20a39.diff

[Lldb-commits] [PATCH] D68909: change shortcut for 'step out' from 'o' to 'f'

llunak added a comment. In D68909#1736931 , @kwk wrote: > Are there no tests for this code? https://reviews.llvm.org/D68541 adds one that also covers this. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68909/new/ http

[Lldb-commits] [PATCH] D69944: [lldb] Add -m option to 'target modules dump symtab' to disable demangling

This revision was automatically updated to reflect the committed changes. Closed by commit rG87bc320b510e: [lldb] Add -m option to 'target modules dump symtab' to disable demangling (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [lldb] 87bc320 - [lldb] Add -m option to 'target modules dump symtab' to disable demangling

Author: Raphael Isemann Date: 2019-11-07T15:47:01+01:00 New Revision: 87bc320b510e91a1a71aa8a154c585db65579628 URL: https://github.com/llvm/llvm-project/commit/87bc320b510e91a1a71aa8a154c585db65579628 DIFF: https://github.com/llvm/llvm-project/commit/87bc320b510e91a1a71aa8a154c585db65579628.dif

[Lldb-commits] [PATCH] D69944: [lldb] Add -m option to 'target modules dump symtab' to disable demangling

teemperor updated this revision to Diff 228235. teemperor added a comment. - Blatantly steal Pavel's yaml file as MachO seems very verbose. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69944/new/ https://reviews.llvm.org/D69944 Files: lldb/include/lldb/Symbol/Symbol.h lldb/include

[Lldb-commits] [PATCH] D69944: [lldb] Add -m option to 'target modules dump symtab' to disable demangling

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. BTW, is it possible to prune the yaml to remove the stuff irrelevant for the test? I'm not that familiar with how macho2yaml works, but the equivalent elf representation of this can be as shor

[Lldb-commits] [PATCH] D69944: [lldb] Add -m option to 'target modules dump symtab' to disable demangling

teemperor requested review of this revision. teemperor marked an inline comment as done. teemperor added inline comments. Comment at: lldb/source/Commands/Options.td:8 + def tm_smn : Option<"show-mangled-names", "m">, Group<1>, +Desc<"Do not demangle symbol names before show

[Lldb-commits] [PATCH] D69944: [lldb] Add -m option to 'target modules dump symtab' to disable demangling

teemperor updated this revision to Diff 228229. teemperor added a comment. - Renamed variable. - Now using yaml2obj CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69944/new/ https://reviews.llvm.org/D69944 Files: lldb/include/lldb/Symbol/Symbol.h lldb/include/lldb/Symbol/Symtab.h

[Lldb-commits] [PATCH] D68909: change shortcut for 'step out' from 'o' to 'f'

kwk added a comment. Are there no tests for this code? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68909/new/ https://reviews.llvm.org/D68909 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://list

[Lldb-commits] [PATCH] D69944: [lldb] Add -m option to 'target modules dump symtab' to disable demangling

kwk accepted this revision. kwk added a comment. This revision is now accepted and ready to land. LGTM with the exception of a local variable name. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:2008 uint32_t num_dumped = 0; +Mangled::NamePreference preferenc

[Lldb-commits] [PATCH] D69944: [lldb] Add -m option to 'target modules dump symtab' to disable demangling

kwk added inline comments. Comment at: lldb/source/Commands/Options.td:8 + def tm_smn : Option<"show-mangled-names", "m">, Group<1>, +Desc<"Do not demangle symbol names before showing them.">; } Does it make sense to tell what the default is here? Reposit

[Lldb-commits] [PATCH] D69944: [lldb] Add -m option to 'target modules dump symtab' to disable demangling

labath added a comment. You could just make a YAML file with some symbols inside. That would isolate you from any host mangling specifics (which I think is a good thing, as this test is really about the command line option, and not mangling). Repository: rLLDB LLDB CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D69944: [lldb] Add -m option to 'target modules dump symtab' to disable demangling

teemperor created this revision. teemperor added a reviewer: LLDB. Herald added subscribers: lldb-commits, JDevlieghere, abidh. Herald added a project: LLDB. teemperor added a project: Upstreaming LLDB's downstream patches. teemperor added a comment. I'll add a Windows-specific test as a follow-up

[Lldb-commits] [PATCH] D69944: [lldb] Add -m option to 'target modules dump symtab' to disable demangling

teemperor added a comment. I'll add a Windows-specific test as a follow-up (because that test will probably involve fixing the Windows bot and I don't want this reverted). Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69944/new/ https://reviews.llvm.org/D69944

[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

This revision was automatically updated to reflect the committed changes. Closed by commit rGb1b70f676126: [lldb-server] Add setting to force 'g' packet use (authored by guiandrade, committed by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [lldb] b1b70f6 - [lldb-server] Add setting to force 'g' packet use

Author: Guilherme Andrade Date: 2019-11-07T10:48:54+01:00 New Revision: b1b70f6761266c3eecaf8bd71529eaf51994207b URL: https://github.com/llvm/llvm-project/commit/b1b70f6761266c3eecaf8bd71529eaf51994207b DIFF: https://github.com/llvm/llvm-project/commit/b1b70f6761266c3eecaf8bd71529eaf51994207b.d

[Lldb-commits] [PATCH] D69904: [arm] Add core definition for armv8l and armv7l

labath added a comment. Everything except the `CoreUpdated` part LGTM. The CoreUpdated part could use another look from someone more familiar with what exactly that code was trying to achieve. And a test... I'd consider breaking that off into a separate patch. Comment at: lld

[Lldb-commits] [PATCH] D69931: Add cmake variables to specify a python framework to ship with lldb

labath added a comment. In principle, this looks pretty similar to D67942 , and my opinion on it is the same -- I don't think we should be in the business of trying to package the transitive set of lldb dependencies. I think the lldb install target should instal