[Lldb-commits] [PATCH] D70474: [Reproducer] Generate LLDB reproducer on crash

JDevlieghere created this revision. JDevlieghere added reviewers: labath, vsk, jingham, friss. Herald added a reviewer: jfb. Herald added a project: LLDB. JDevlieghere edited the summary of this revision. Herald added a subscriber: dexonsmith. This patch hooks the reproducer infrastructure with

[Lldb-commits] [PATCH] D69309: Support template instantiation in the expression evaluator

friss added a comment. Sorry that I haven't reviewed the patch, but there's something I'd like to point out before anyone invests a lot of time into plugin holes in our current template support code. It would be great to fix the way templates are represented, because currently the debug info

[Lldb-commits] [lldb] 36eea5c - [Reproducer] Namespace the reproducer dump options.

Author: Jonas Devlieghere Date: 2019-11-19T16:19:43-08:00 New Revision: 36eea5c31f13c086c951239ff876564c90546efa URL: https://github.com/llvm/llvm-project/commit/36eea5c31f13c086c951239ff876564c90546efa DIFF:

[Lldb-commits] [PATCH] D70324: [lldb][test] Prevent \n in calls to lldb's expect() test helper.

This revision was automatically updated to reflect the committed changes. Closed by commit rG327a18ca0a00: [lldb][test] Prevent \n in calls to lldbs expect() test helper. (authored by rupprecht). Changed prior to commit: https://reviews.llvm.org/D70324?vs=229593=230157#toc Repository: rG

[Lldb-commits] [lldb] 327a18c - [lldb][test] Prevent \n in calls to lldb's expect() test helper.

Author: Jordan Rupprecht Date: 2019-11-19T15:17:35-08:00 New Revision: 327a18ca0a000e4f99d02d0042ca2106db635a68 URL: https://github.com/llvm/llvm-project/commit/327a18ca0a000e4f99d02d0042ca2106db635a68 DIFF:

[Lldb-commits] [PATCH] D70458: [NFC] Refactor and improve comments in CommandObjectTarget

amccarth created this revision. amccarth added a reviewer: labath. Made small improvements while debugging through CommandObjectTarget::AddModuleSymbols. 1. Refactored error case for an early out, reducing the indentation of the rest of this long function. 2. Clarified some comments by

[Lldb-commits] [PATCH] D70417: Accept g packet responses that don't supply all registers

jasonmolenda updated this revision to Diff 230129. jasonmolenda added a reviewer: labath. jasonmolenda added a comment. Updated GDBRemoteRegisterContext::ReadRegisterBytes to only mark registers as valid if the full contents for the register are included in the g packet. Updated

[Lldb-commits] [PATCH] D70259: [Error] Add source location to cantFail

hintonda updated this revision to Diff 230131. hintonda added a comment. - Add back original llvm::cantFail signatures so they'll still be Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70259/new/ https://reviews.llvm.org/D70259 Files:

[Lldb-commits] [PATCH] D70259: [Error] Add source location to cantFail

hintonda updated this revision to Diff 230125. hintonda added a comment. Herald added subscribers: lldb-commits, cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added projects: clang, LLDB. - Replace macro magic with matching 3-parameter template functions. - Refactor cantFail move

[Lldb-commits] [PATCH] D70449: Add a "Using LLDB" section to the welcome page of the website

This revision was automatically updated to reflect the committed changes. Closed by commit rG77f8a3324b74: Add a Using LLDB section to the welcome page of the website (authored by aprantl). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] 77f8a33 - Add a "Using LLDB" section to the welcome page of the website

Author: Adrian Prantl Date: 2019-11-19T10:55:50-08:00 New Revision: 77f8a3324b741bc78c93d1076a31b77f331a0bc5 URL: https://github.com/llvm/llvm-project/commit/77f8a3324b741bc78c93d1076a31b77f331a0bc5 DIFF: https://github.com/llvm/llvm-project/commit/77f8a3324b741bc78c93d1076a31b77f331a0bc5.diff

[Lldb-commits] [PATCH] D70449: Add a "Using LLDB" section to the welcome page of the website

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM with the comment. Comment at: lldb/docs/.htaccess:3 Redirect 301 /cpp_reference/html/index.html https://lldb.llvm.org/cpp_reference/index.html +Redirect

[Lldb-commits] [PATCH] D70449: Add a "Using LLDB" section to the welcome page of the website

aprantl updated this revision to Diff 230103. aprantl added a comment. Cool, I didn't know about the redirects! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70449/new/ https://reviews.llvm.org/D70449 Files: lldb/docs/.htaccess lldb/docs/index.rst

[Lldb-commits] [PATCH] D70449: Add a "Using LLDB" section to the welcome page of the website

aprantl marked 4 inline comments as done. aprantl added inline comments. Comment at: lldb/docs/status/goals.rst:38 + +In order to achieve our goals we decided to start with a fresh architecture +that would support modern multi-threaded programs, handle debugging symbols in

[Lldb-commits] [lldb] b117ec8 - [LLDB] Fix formatting in the driver (NFC)

Author: Jonas Devlieghere Date: 2019-11-19T10:23:56-08:00 New Revision: b117ec8be0f350f6a644de28a9871cf0183a1c54 URL: https://github.com/llvm/llvm-project/commit/b117ec8be0f350f6a644de28a9871cf0183a1c54 DIFF:

[Lldb-commits] [PATCH] D70448: [LLDB] Fix wrong argument in CommandObjectThreadStepWithTypeAndScope

aganea updated this revision to Diff 230097. aganea marked an inline comment as done. aganea added a comment. Omit default arguments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70448/new/ https://reviews.llvm.org/D70448 Files: lldb/source/Commands/CommandObjectThread.cpp Index:

[Lldb-commits] [PATCH] D70448: [LLDB] Fix wrong argument in CommandObjectThreadStepWithTypeAndScope

shafik added inline comments. Comment at: lldb/source/Commands/CommandObjectThread.cpp:529 m_step_type(step_type), m_step_scope(step_scope), m_options(), -m_class_options("scripted step", 'C') { +m_class_options("scripted step", true, 'C') {

[Lldb-commits] [PATCH] D70449: Add a "Using LLDB" section to the welcome page of the website

labath added a comment. Sounds like a good idea. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70449/new/ https://reviews.llvm.org/D70449 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D70449: Add a "Using LLDB" section to the welcome page of the website

shafik added inline comments. Comment at: lldb/docs/status/goals.rst:38 + +In order to achieve our goals we decided to start with a fresh architecture +that would support modern multi-threaded programs, handle debugging symbols in Is it worth adding anything

[Lldb-commits] [PATCH] D70449: Add a "Using LLDB" section to the welcome page of the website

shafik added inline comments. Comment at: lldb/docs/index.rst:25 +:ref:`LLDB Tutorial `. For users already familiar with +other debuggers there is also a cheat sheet listing common tasks and +their LLDB equivalent in the :ref:`GDB to LLDB command map `. `other

[Lldb-commits] [PATCH] D70449: Add a "Using LLDB" section to the welcome page of the website

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. Please add a redirect in the `.htaccess` file for the architecture page. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70449/new/

[Lldb-commits] [PATCH] D70448: [LLDB] Fix wrong argument in CommandObjectThreadStepWithTypeAndScope

aganea created this revision. aganea added a reviewer: jingham. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This fixes a warning on MSVC: F:\llvm-project\lldb\source\Commands\CommandObjectThread.cpp(529): warning C4305: 'argument': truncation from 'char' to 'bool'

[Lldb-commits] [PATCH] D70449: Add a "Using LLDB" section to the welcome page of the website

aprantl created this revision. aprantl added reviewers: jingham, JDevlieghere, jasonmolenda, labath, clayborg, friss. Herald added a subscriber: arphaman. This is an attempt to feature the user-facing resources more prominently on the LLDB website by calling out the tutorial and the GDB command

[Lldb-commits] [PATCH] D70442: [LLDB] Force message formatting to English

aganea created this revision. aganea added reviewers: asmith, aleksandr.urakov. aganea added a project: LLDB. Herald added a subscriber: lldb-commits. This is a follow-up on D53092 , and fixes the test below on non-English locales (below, on a French locale):

[Lldb-commits] [PATCH] D69309: Support template instantiation in the expression evaluator

jarin updated this revision to Diff 230069. jarin added a comment. This update introduces a callback from clang for template specialization. The callback allows lldb to construct instantiations on demand, rather than having to create the instantiation eagerly. Perhaps it would still beneficial

[Lldb-commits] [PATCH] D70393: [lldb] Fix NSURL data formatter truncation issue in Swift

poya marked 3 inline comments as not done. poya added a comment. Sorry for marking comments as done, not used to the tool. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70393/new/ https://reviews.llvm.org/D70393 ___ lldb-commits mailing

[Lldb-commits] [lldb] 4a6d03a - [lldb] Add logging to IRExecutionUnit::GetStaticInitializers

Author: Raphael Isemann Date: 2019-11-19T15:52:01+01:00 New Revision: 4a6d03ad0e00c75c18d5740438d49918f99cb4f2 URL: https://github.com/llvm/llvm-project/commit/4a6d03ad0e00c75c18d5740438d49918f99cb4f2 DIFF:

[Lldb-commits] [lldb] c54d21c - [lldb][NFC] Early exit in IRExecutionUnit::GetStaticInitializers

Author: Raphael Isemann Date: 2019-11-19T15:06:30+01:00 New Revision: c54d21c848d350e85cd8f95a725fc12f6fa3ab19 URL: https://github.com/llvm/llvm-project/commit/c54d21c848d350e85cd8f95a725fc12f6fa3ab19 DIFF:

[Lldb-commits] [PATCH] D70393: [lldb] Fix NSURL data formatter truncation issue in Swift

poya marked an inline comment as done. poya added a comment. Comment at: lldb/source/Plugins/Language/ObjC/Cocoa.cpp:662 +static void NSURL_ConcatSummary(StreamString , const StreamString , +std::string prefix, std::string suffix) { teemperor wrote: >

[Lldb-commits] [PATCH] D70393: [lldb] Fix NSURL data formatter truncation issue in Swift

teemperor requested changes to this revision. teemperor added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Plugins/Language/ObjC/Cocoa.cpp:662 +static void NSURL_ConcatSummary(StreamString , const StreamString , +std::string

[Lldb-commits] [PATCH] D70393: [lldb] Fix NSURL data formatter truncation issue in Swift

poya added a comment. @davide Thanks for the review, and while I haven't been able to reproduce the test failure locally with my configuration, I reviewed the code and corrected a potential memory issue that might have been the cause for the failure. If not, do you mind sharing more info on

[Lldb-commits] [PATCH] D70393: [lldb] Fix NSURL data formatter truncation issue in Swift

poya updated this revision to Diff 230045. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70393/new/ https://reviews.llvm.org/D70393 Files: lldb/source/Plugins/Language/ObjC/Cocoa.cpp Index: lldb/source/Plugins/Language/ObjC/Cocoa.cpp

[Lldb-commits] [lldb] f6ffe6f - [lldb] Also test Get[De]mangledName of SBType in TestSBTypeClassMembers.py

Author: Raphael Isemann Date: 2019-11-19T14:04:02+01:00 New Revision: f6ffe6fc9d9b8b0e197500b5b61f3e8d55599d7a URL: https://github.com/llvm/llvm-project/commit/f6ffe6fc9d9b8b0e197500b5b61f3e8d55599d7a DIFF:

[Lldb-commits] [PATCH] D70433: [lldb] Improve error message when running static initialisers in expression fails

teemperor created this revision. teemperor added a reviewer: jingham. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. The current error message is current `error: couldn't run static initializers: couldn't run static initializer: ` which just doesn't make a

[Lldb-commits] [PATCH] D70388: [lldb] Remove ClangExpressionDeclMap::ResolveUnknownTypes

This revision was automatically updated to reflect the committed changes. Closed by commit rG96d814a5fe0a: [lldb] Remove ClangExpressionDeclMap::ResolveUnknownTypes (authored by teemperor). Changed prior to commit: https://reviews.llvm.org/D70388?vs=229800=230029#toc Repository: rG LLVM

[Lldb-commits] [lldb] 96d814a - [lldb] Remove ClangExpressionDeclMap::ResolveUnknownTypes

Author: Raphael Isemann Date: 2019-11-19T12:44:27+01:00 New Revision: 96d814a5fe0a333bc53f52e8f290d1ac009c85fe URL: https://github.com/llvm/llvm-project/commit/96d814a5fe0a333bc53f52e8f290d1ac009c85fe DIFF:

[Lldb-commits] [lldb] bb7c8e9 - Mark PR44037 tests as XFAIL on AArch64 Linux dwo

Author: Diana Picus Date: 2019-11-19T10:49:00+01:00 New Revision: bb7c8e984f87e1de7c80abd33d00025ac366efa6 URL: https://github.com/llvm/llvm-project/commit/bb7c8e984f87e1de7c80abd33d00025ac366efa6 DIFF: https://github.com/llvm/llvm-project/commit/bb7c8e984f87e1de7c80abd33d00025ac366efa6.diff

[Lldb-commits] [PATCH] D70387: [LLDB] [Windows] Allow making subprocesses use the debugger's console with LLDB_INHERIT_CONSOLE=true

mstorsjo added a comment. In D70387#1751090 , @labath wrote: > It's good that you mentioned lldb-server, because it's presence complicates > this behavior even further. If we wanted the console sharing approach to > work, then we'd have to have both

[Lldb-commits] [PATCH] D70381: Mark PR44037 tests as XFAIL on AArch64 Linux dwo

labath added a comment. In D70381#1751116 , @rovka wrote: > In D70381#1749616 , @labath wrote: > > > Looks fine to me, but I am not running aarch64 tests. You might want to > > check of @omjavaid is running them

[Lldb-commits] [PATCH] D70381: Mark PR44037 tests as XFAIL on AArch64 Linux dwo

rovka added a subscriber: labath. rovka added a comment. In D70381#1749616 , @labath wrote: > Looks fine to me, but I am not running aarch64 tests. You might want to check > of @omjavaid is running them and whether he's ok with that. Otherwise, you >

[Lldb-commits] [PATCH] D70417: Accept g packet responses that don't supply all registers

labath added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp:215 +struct RegisterInfo *reginfo = m_reg_info.GetRegisterInfoAtIndex(i); +if (reginfo->byte_offset < buffer_sp->GetByteSize()) { +

[Lldb-commits] [PATCH] D70387: [LLDB] [Windows] Allow making subprocesses use the debugger's console with LLDB_INHERIT_CONSOLE=true

labath added a comment. In D70387#1750578 , @mstorsjo wrote: > Thanks for the excellent explanations of the situation so far. I'll have a > look at how it behaves with input and other aspects of console sharing. You > might be right that it can cause