[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

paolosev added a comment. > Hi @paolosev, the lldb sanitized bot is flagging a container-overflow error > here. I know that this /can/ have FPs when sanitized and unsanitized code is > mixed, but we should be in purely sanitized code here, and this looks like a > valid report. PTAL. I think I

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

paolosev added a comment. In D72751#1892514 , @vsk wrote: > Hi @paolosev, the lldb sanitized bot is flagging a container-overflow error > here. I know that this /can/ have FPs when sanitized and unsanitized code is > mixed, but we should be in purely

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

vsk added a comment. Hi @paolosev, the lldb sanitized bot is flagging a container-overflow error here. I know that this /can/ have FPs when sanitized and unsanitized code is mixed, but we should be in purely sanitized code here, and this looks like a valid report. PTAL.

[Lldb-commits] [lldb] 4b2b8b9 - Re-land Unwind past an interrupt handler correctly on arm or at pc==0

Author: Jason Molenda Date: 2020-02-25T14:58:20-08:00 New Revision: 4b2b8b96db2837a95e8c3ceca3f31ac5641ca001 URL: https://github.com/llvm/llvm-project/commit/4b2b8b96db2837a95e8c3ceca3f31ac5641ca001 DIFF: https://github.com/llvm/llvm-project/commit/4b2b8b96db2837a95e8c3ceca3f31ac5641ca001.diff

[Lldb-commits] [lldb] 3cd13c4 - Fix a race between lldb's packet timeout and the profile thread's usleep.

Author: Jim Ingham Date: 2020-02-25T11:17:08-08:00 New Revision: 3cd13c4624b5900c884b691b72d0ca053433f6fe URL: https://github.com/llvm/llvm-project/commit/3cd13c4624b5900c884b691b72d0ca053433f6fe DIFF: https://github.com/llvm/llvm-project/commit/3cd13c4624b5900c884b691b72d0ca053433f6fe.diff

[Lldb-commits] [PATCH] D75004: Fix a race between lldb's packet timeout and killing the profile thread

This revision was automatically updated to reflect the committed changes. Closed by commit rG3cd13c4624b5: Fix a race between lldbs packet timeout and the profile threads usleep. (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D74598: [lldb/gdb-remote] Add support for the qOffsets packet

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Thanks for doing the changes, looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74598/new/ https://reviews.llvm.org/D74598

[Lldb-commits] [PATCH] D73961: [LLDB] Addresses can be two bytes in size

labath added a comment. Yes, standalone patches are the way to go. To help you, I've tried to annotate the various assertions, what kind of problems they could cause, and possible testing strategies. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugArangeSet.cpp:71

[Lldb-commits] [PATCH] D74255: [LLDB] Add support for AVR breakpoints

aykevl added a comment. In D74255#1871958 , @labath wrote: > However, if we look at this locally, if the AVR architecture has a trap > opcode (maybe to implement `__builtin_debugbreak()` -- I am assuming that's > what 0x98 0x95 is), then I don't see a

[Lldb-commits] [PATCH] D73961: [LLDB] Addresses can be two bytes in size

aykevl abandoned this revision. aykevl added a comment. Closing this one. Maybe there is something useful in this patch but if there is, I'll submit that in a standalone (more focused) patch. The majority of it has been merged in D73969 . Repository: rG LLVM

[Lldb-commits] [PATCH] D73969: [LLDB] Let DataExtractor deal with two-byte addresses

aykevl added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73969/new/ https://reviews.llvm.org/D73969 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D73969: [LLDB] Let DataExtractor deal with two-byte addresses

This revision was automatically updated to reflect the committed changes. Closed by commit rGec1efe71130f: [LLDB] Let DataExtractor deal with two-byte addresses (authored by aykevl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73969/new/

[Lldb-commits] [lldb] ec1efe7 - [LLDB] Let DataExtractor deal with two-byte addresses

Author: Ayke van Laethem Date: 2020-02-25T16:27:38+01:00 New Revision: ec1efe71130f5b049e53828281204b50d89d4cf6 URL: https://github.com/llvm/llvm-project/commit/ec1efe71130f5b049e53828281204b50d89d4cf6 DIFF:

[Lldb-commits] [PATCH] D73969: [LLDB] Let DataExtractor deal with two-byte addresses

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I think this is fine. There's no need to hold this up over the assert duplication issue, as this does not make the situation any worse. Thanks for the patch. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D73969: [LLDB] Let DataExtractor deal with two-byte addresses

aykevl added a comment. In D73969#1860696 , @labath wrote: > I agree only one of those two places should be enough. My idea was to make > the constructors delegate to one another (if necessary by creating a private > uber-constructor that everybody can

[Lldb-commits] [PATCH] D73969: [LLDB] Let DataExtractor deal with two-byte addresses

aykevl updated this revision to Diff 246443. aykevl added a comment. Rebase on master (after `GetPointer` was removed). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73969/new/ https://reviews.llvm.org/D73969 Files: lldb/source/Utility/DataExtractor.cpp

[Lldb-commits] [lldb] bdb24fa - [lldb][NFC] Move filling namespace map in ClangASTSource to own function

Author: Raphael Isemann Date: 2020-02-25T13:59:21+01:00 New Revision: bdb24faa2af4b989e757bc0a220224df9fe4d874 URL: https://github.com/llvm/llvm-project/commit/bdb24faa2af4b989e757bc0a220224df9fe4d874 DIFF:

[Lldb-commits] [lldb] 93b6e19 - [lldb] Initialize NameSearchContext::m_namespace_map in constructor

Author: Raphael Isemann Date: 2020-02-25T13:20:54+01:00 New Revision: 93b6e1924081874039e6c88828db8e0ab7bbba04 URL: https://github.com/llvm/llvm-project/commit/93b6e1924081874039e6c88828db8e0ab7bbba04 DIFF:

[Lldb-commits] [lldb] 2ad7b6f - [lldb][NFC] Make NameSearchContext::m_found members bools instead of bitfields

Author: Raphael Isemann Date: 2020-02-25T12:45:00+01:00 New Revision: 2ad7b6fba0e3a9e71df64bd1a51a14f9c5930eb3 URL: https://github.com/llvm/llvm-project/commit/2ad7b6fba0e3a9e71df64bd1a51a14f9c5930eb3 DIFF:

[Lldb-commits] [lldb] defd0e2 - [lldb][NFC] Move NameSearchContext to own header/source files

Author: Raphael Isemann Date: 2020-02-25T12:25:36+01:00 New Revision: defd0e24aa054aed583d5272e2cc64ae7b0fdc7d URL: https://github.com/llvm/llvm-project/commit/defd0e24aa054aed583d5272e2cc64ae7b0fdc7d DIFF:

[Lldb-commits] [lldb] fc0d11c - [lldb][NFC] Modernize logging in ClangASTSource/ExpressionDeclMap

Author: Raphael Isemann Date: 2020-02-25T12:08:09+01:00 New Revision: fc0d11c90420acfcaa5424f5df979a63f5ab4123 URL: https://github.com/llvm/llvm-project/commit/fc0d11c90420acfcaa5424f5df979a63f5ab4123 DIFF:

[Lldb-commits] [PATCH] D74598: [lldb/gdb-remote] Add support for the qOffsets packet

labath updated this revision to Diff 246401. labath added a comment. Update the unit test for the function rename (GetExecutableOffset->GetQOffsets) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74598/new/ https://reviews.llvm.org/D74598 Files:

[Lldb-commits] [PATCH] D74598: [lldb/gdb-remote] Add support for the qOffsets packet

labath marked an inline comment as done. labath added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h:429 + /// Use qOffsets to query the offset used when relocating the target + /// executable. Currently, we only support

[Lldb-commits] [PATCH] D74598: [lldb/gdb-remote] Add support for the qOffsets packet

labath updated this revision to Diff 246397. labath added a comment. Fully parse the qOffsets response Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74598/new/ https://reviews.llvm.org/D74598 Files:

[Lldb-commits] [lldb] 05d174d - [lldb][NFC] Move namespace lookup in ClangASTSource to own function.

Author: Raphael Isemann Date: 2020-02-25T10:27:47+01:00 New Revision: 05d174d30159579ae19e90899736d98e2544c0e3 URL: https://github.com/llvm/llvm-project/commit/05d174d30159579ae19e90899736d98e2544c0e3 DIFF:

Re: [Lldb-commits] [lldb] de8793b - [lldb/DWARF] Add support for type units in dwp files

Yes, the order of these is unfortunately nondeterministic. I've changed the test expectation in eefbff00. On 25/02/2020 01:22, Jonas Devlieghere wrote: > I don't think it's this particular change that caused it, but every so > often this test fails for me locally.  > > Command Output (stderr): >

[Lldb-commits] [lldb] eefbff0 - [lldb] s/CHECK-NEXT/CHECK-DAG in dwp-debug-types.s

Author: Pavel Labath Date: 2020-02-25T10:04:09+01:00 New Revision: eefbff0082c5228e01611f7e6987695d0b1c6d32 URL: https://github.com/llvm/llvm-project/commit/eefbff0082c5228e01611f7e6987695d0b1c6d32 DIFF: https://github.com/llvm/llvm-project/commit/eefbff0082c5228e01611f7e6987695d0b1c6d32.diff

[Lldb-commits] [lldb] ea6b95d - [lldb][NFC] Make ArrayRef initialization more obvious in lldb-test.cpp

Author: Raphael Isemann Date: 2020-02-25T09:48:17+01:00 New Revision: ea6b95dc2f68e7f3f06abc47fae44c91ceebef93 URL: https://github.com/llvm/llvm-project/commit/ea6b95dc2f68e7f3f06abc47fae44c91ceebef93 DIFF: