[Lldb-commits] [lldb] eecef3a - [lldb][test] Enable fix-its for the test case that expects them enabled

Author: Tatyana Krasnukha Date: 2020-03-05T10:31:07+03:00 New Revision: eecef3af2ca8b27f4070be41c73bff989a096f9b URL: https://github.com/llvm/llvm-project/commit/eecef3af2ca8b27f4070be41c73bff989a096f9b DIFF: https://github.com/llvm/llvm-project/commit/eecef3af2ca8b27f4070be41c73bff989a096f9b.d

[Lldb-commits] [PATCH] D74903: [lldb][testsuite] Create a SBDebugger instance for each test

This revision was automatically updated to reflect the committed changes. Closed by commit rGa31130f6fcf2: [lldb][testsuite] Create a SBDebugger instance for each test (authored by tatyana-krasnukha). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D749

[Lldb-commits] [lldb] a31130f - [lldb][testsuite] Create a SBDebugger instance for each test

Author: Tatyana Krasnukha Date: 2020-03-05T10:12:54+03:00 New Revision: a31130f6fcf27518b31a8ac1f5971a42fc24837e URL: https://github.com/llvm/llvm-project/commit/a31130f6fcf27518b31a8ac1f5971a42fc24837e DIFF: https://github.com/llvm/llvm-project/commit/a31130f6fcf27518b31a8ac1f5971a42fc24837e.d

Re: [Lldb-commits] [lldb] e98ef0a - [lldb] Fix several LLDB_LOGs with wrong indices in ClangASTSource.cpp

We should really have a low-frequency bot that just runs the whole testsuite with all the logs turned on and make sure that doesn't crash... Jim > On Mar 4, 2020, at 10:56 AM, Raphael “Teemperor” Isemann via lldb-commits > wrote: > > Yeah this whole thing is a disaster and it’s puzzling that

[Lldb-commits] [lldb] 70b8f95 - [lldb][NFC] Use C++11 for loop in ClangASTSource::FindExternalLexicalDecls

Author: Raphael Isemann Date: 2020-03-04T12:57:05-08:00 New Revision: 70b8f95813106491166fc9f18fa90a0866024ffc URL: https://github.com/llvm/llvm-project/commit/70b8f95813106491166fc9f18fa90a0866024ffc DIFF: https://github.com/llvm/llvm-project/commit/70b8f95813106491166fc9f18fa90a0866024ffc.dif

[Lldb-commits] [PATCH] D75488: Preserve the owning module information from DWARF in the synthesized AST

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/module-ownership.mm:25 +// CHECK-DAG: CXXRecordDecl {{.*}} imported in A struct Nested +// CHECK-DAG: -FieldDecl {{.*}} in A fromb 'StructB' + No

[Lldb-commits] [lldb] 4ab2ea9 - [lldb] Fix typo in ClangASTSource logging statement

Author: Raphael Isemann Date: 2020-03-04T11:05:48-08:00 New Revision: 4ab2ea9fc09d93ef136a690f3f94d3c791540fcf URL: https://github.com/llvm/llvm-project/commit/4ab2ea9fc09d93ef136a690f3f94d3c791540fcf DIFF: https://github.com/llvm/llvm-project/commit/4ab2ea9fc09d93ef136a690f3f94d3c791540fcf.dif

Re: [Lldb-commits] [lldb] e98ef0a - [lldb] Fix several LLDB_LOGs with wrong indices in ClangASTSource.cpp

Yeah this whole thing is a disaster and it’s puzzling that we don’t test the whole logging but instead just crash on the end user machine. I’m currently writing a test that gives all this code at least coverage and then I guess we have to fix all of these bugs. > On Mar 4, 2020, at 10:53 AM, Sh

Re: [Lldb-commits] [lldb] e98ef0a - [lldb] Fix several LLDB_LOGs with wrong indices in ClangASTSource.cpp

This is a lot of errors, did it the index use to start at one before? There is a type below, noted inline > On Mar 4, 2020, at 10:33 AM, Raphael Isemann via lldb-commits > wrote: > > > Author: Raphael Isemann > Date: 2020-03-04T10:32:50-08:00 > New Revision: e98ef0af2c725f12dc60556a039e947dd

[Lldb-commits] [PATCH] D75488: Preserve the owning module information from DWARF in the synthesized AST

aprantl updated this revision to Diff 248244. aprantl marked an inline comment as done. aprantl added a comment. Hardcode triple in test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75488/new/ https://reviews.llvm.org/D75488 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser

[Lldb-commits] [PATCH] D75488: Preserve the owning module information from DWARF in the synthesized AST

aprantl updated this revision to Diff 248241. aprantl marked 3 inline comments as done. aprantl added a comment. Address feedback from Pavel. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75488/new/ https://reviews.llvm.org/D75488 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTP

[Lldb-commits] [PATCH] D75626: Add support for owning module information to TypeSystemClang.

aprantl created this revision. aprantl added reviewers: labath, jingham, teemperor, shafik. aprantl added a child revision: D75488: Preserve the owning module information from DWARF in the synthesized AST. This was split out from https://reviews.llvm.org/D75488. https://reviews.llvm.org/D75626

[Lldb-commits] [PATCH] D74903: [lldb][testsuite] Create a SBDebugger instance for each test

jingham accepted this revision. jingham added a comment. Seems great to me. Getting the host platform is a generally useful thing to be able to do, and I can't think of anything you would want to add to this, so that is fine to. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74903/new/

[Lldb-commits] [lldb] e98ef0a - [lldb] Fix several LLDB_LOGs with wrong indices in ClangASTSource.cpp

Author: Raphael Isemann Date: 2020-03-04T10:32:50-08:00 New Revision: e98ef0af2c725f12dc60556a039e947ddeeb9f42 URL: https://github.com/llvm/llvm-project/commit/e98ef0af2c725f12dc60556a039e947ddeeb9f42 DIFF: https://github.com/llvm/llvm-project/commit/e98ef0af2c725f12dc60556a039e947ddeeb9f42.dif

[Lldb-commits] [PATCH] D75537: Clear all settings during a test's setUp

tatyana-krasnukha updated this revision to Diff 248213. tatyana-krasnukha added a comment. Added `--all` property to `settings clear` + added a test Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75537/new/ https://reviews.llvm.org/D75537 Files: lldb/packages

[Lldb-commits] [lldb] 0ab109d - [lldb][NFC] Modernize logging UserExpression

Author: Raphael Isemann Date: 2020-03-04T09:04:54-08:00 New Revision: 0ab109d43d9d8389fe686ee8df4a82634f246b55 URL: https://github.com/llvm/llvm-project/commit/0ab109d43d9d8389fe686ee8df4a82634f246b55 DIFF: https://github.com/llvm/llvm-project/commit/0ab109d43d9d8389fe686ee8df4a82634f246b55.dif

[Lldb-commits] [PATCH] D70764: build: reduce CMake handling for zlib

hans added a comment. There were some concerns raised on this patch, and also in PR44780. I think at this point it's safer to revert these changes and start over. I've pushed the revert in 916be8fd6a0a0feea4cefcbeb0c22c65848d7a2e

[Lldb-commits] [PATCH] D75607: [lldb] Use llvm::MC for register numbers in AArch64 ABIs

labath marked an inline comment as done. labath added inline comments. Comment at: lldb/source/Plugins/ABI/AArch64/ABIAArch64.cpp:29-32 + if (name == "pc") +return {LLDB_INVALID_REGNUM, arm64_dwarf::pc}; + if (name == "cpsr") +return {LLDB_INVALID_REGNUM, arm64_dwarf::c

[Lldb-commits] [PATCH] D74557: [lldb] Make BreakpointResolver hold weak_ptr instead of raw pointer to breakpoint

This revision was automatically updated to reflect the committed changes. Closed by commit rG6c17cc531f9f: [lldb] Make BreakpointResolver hold weak_ptr instead of raw pointer to… (authored by tatyana-krasnukha). Changed prior to commit: https://reviews.llvm.org/D74557?vs=244727&id=248166#toc R

[Lldb-commits] [PATCH] D75607: [lldb] Use llvm::MC for register numbers in AArch64 ABIs

labath created this revision. labath added reviewers: JDevlieghere, jasonmolenda. Herald added subscribers: kristof.beyls, aprantl. Herald added a project: LLDB. labath marked an inline comment as done. labath added inline comments. Comment at: lldb/source/Plugins/ABI/AArch64/ABI

[Lldb-commits] [lldb] 6c17cc5 - [lldb] Make BreakpointResolver hold weak_ptr instead of raw pointer to breakpoint

Author: Tatyana Krasnukha Date: 2020-03-04T16:56:50+03:00 New Revision: 6c17cc531f9f4ee94f2298200fc4813c02999d78 URL: https://github.com/llvm/llvm-project/commit/6c17cc531f9f4ee94f2298200fc4813c02999d78 DIFF: https://github.com/llvm/llvm-project/commit/6c17cc531f9f4ee94f2298200fc4813c02999d78.d

[Lldb-commits] [lldb] b1324e7 - [lldb][NFC] Move local variables near to their usage

Author: Tatyana Krasnukha Date: 2020-03-04T16:56:51+03:00 New Revision: b1324e74da2661e799b9fad037948e70d002b771 URL: https://github.com/llvm/llvm-project/commit/b1324e74da2661e799b9fad037948e70d002b771 DIFF: https://github.com/llvm/llvm-project/commit/b1324e74da2661e799b9fad037948e70d002b771.d

[Lldb-commits] [lldb] 3245dd5 - [lldb] Reduce duplication in CommandObjectDisassemble

Author: Pavel Labath Date: 2020-03-04T13:47:35+01:00 New Revision: 3245dd59b124cbfce8cdce1f2c90e843d57d8722 URL: https://github.com/llvm/llvm-project/commit/3245dd59b124cbfce8cdce1f2c90e843d57d8722 DIFF: https://github.com/llvm/llvm-project/commit/3245dd59b124cbfce8cdce1f2c90e843d57d8722.diff

[Lldb-commits] [PATCH] D74903: [lldb][testsuite] Create a SBDebugger instance for each test

labath accepted this revision. labath added a reviewer: jingham. labath added a comment. This revision is now accepted and ready to land. This is a great cleanup. I don't believe the addition of the new SBPlatform interface is an issue, but I've added @jingham just in case he has any thoughts on

[Lldb-commits] [PATCH] D75537: Clear all settings during a test's setUp

labath added a reviewer: jingham. labath added a subscriber: jingham. labath added a comment. Clearing all settings is a reasonable operation, so I don't have any problem with it per se. I'm just wondering, given that this is not something that one would want to do very often (and it can have ca

[Lldb-commits] [PATCH] D73016: [lldb/CMake] Make it possible to disable plugins at configuration time

labath added a comment. Looking this over again, I do see two open questions. The first is that there is a disconnect between the place which *declares* something to be a plugin (the PLUGIN argument to add_lldb_library), and the place which *disables* something as a plugin (the macro invocation

[Lldb-commits] [PATCH] D75488: Preserve the owning module information from DWARF in the synthesized AST

labath added a comment. This sounds like it could be useful though I can't say I really no much about modules. I appreciate the effort in splitting this patch up, but I am wondering if we couldn't do this is one more step. Would it be possible to split the TypeSystem changes into a patch of it