[Lldb-commits] [lldb] 2a227b3 - Revert "Add terminateCommands to lldb-vscode protocol"

Author: Pavel Labath Date: 2020-05-20T10:48:29+02:00 New Revision: 2a227b36b010e559bb9495a6deaca086952a8d64 URL: https://github.com/llvm/llvm-project/commit/2a227b36b010e559bb9495a6deaca086952a8d64 DIFF: https://github.com/llvm/llvm-project/commit/2a227b36b010e559bb9495a6deaca086952a8d64.diff

[Lldb-commits] [PATCH] D80150: [lldb/DataFormatter] Check for overflow when finding NSDate epoch

labath added a comment. In D80150#2045364 , @vsk wrote: > @labath Agreed on all points, I've addressed the feedback in 82dbf4aca84 > by > moving "DataFormatters/Mock.h" to "Plugins/Lan

[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

labath added a comment. Unfortunately I've had to revert this because it was making a number of vscode tests hang nondeterministically: http://lab.llvm.org:8011/builders/lldb-x86_64-debian/builds/10557, http://lab.llvm.org:8011/builders/lldb-x86_64-debian/builds/10545, http://lab.llvm.org:8011

[Lldb-commits] [PATCH] D79308: [lldb-server] Reset stop reason of all threads when resuming

labath added a comment. Sure. Btw, at this point, I think one of you guys should get commit-after-aproval access to the repository, so you can handle these things yourselves. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79

[Lldb-commits] [lldb] 56de738 - [lldb-server] Reset stop reason of all threads when resuming

Author: Jaroslav Sevcik Date: 2020-05-20T11:08:34+02:00 New Revision: 56de738d18e11c86169f0248b97b2854c37e35ce URL: https://github.com/llvm/llvm-project/commit/56de738d18e11c86169f0248b97b2854c37e35ce DIFF: https://github.com/llvm/llvm-project/commit/56de738d18e11c86169f0248b97b2854c37e35ce.dif

[Lldb-commits] [lldb] a9d7b45 - Use IPv4 for Android connections

Author: Emre Kultursay Date: 2020-05-20T11:32:03+02:00 New Revision: a9d7b458c094d62a8c11ada11e39bf0d4da596c8 URL: https://github.com/llvm/llvm-project/commit/a9d7b458c094d62a8c11ada11e39bf0d4da596c8 DIFF: https://github.com/llvm/llvm-project/commit/a9d7b458c094d62a8c11ada11e39bf0d4da596c8.diff

[Lldb-commits] [PATCH] D80254: Prevent GetNumChildren from transitively walking pointer chains

teemperor accepted this revision. teemperor added subscribers: labath, clayborg. teemperor added a comment. This revision is now accepted and ready to land. I think this looks good beside some minor nit-picks. Maybe @labath should take a second look too. Comment at: lldb/sourc

[Lldb-commits] [PATCH] D79757: Use IPv4 for Android connections

This revision was automatically updated to reflect the committed changes. Closed by commit rGa9d7b458c094: Use IPv4 for Android connections (authored by emrekultursay, committed by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79757/new/ ht

[Lldb-commits] [PATCH] D79308: [lldb-server] Reset stop reason of all threads when resuming

This revision was automatically updated to reflect the committed changes. Closed by commit rG56de738d18e1: [lldb-server] Reset stop reason of all threads when resuming (authored by jarin, committed by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D80150: [lldb/DataFormatter] Check for overflow when finding NSDate epoch

MForster added a subscriber: echristo. MForster added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/Cocoa.cpp:797 + + if (date_value > std::numeric_limits::max() || + date_value < std::numeric_limits::min()) This is the line where the "Ille

[Lldb-commits] [PATCH] D80150: [lldb/DataFormatter] Check for overflow when finding NSDate epoch

MForster added subscribers: gribozavr2, MForster. MForster added a comment. In D80150#2045632 , @omjavaid wrote: > This patch breaks lldb unit tests on lldb-arm-ubuntu buildbot. > > http://lab.llvm.org:8014/builders/lldb-arm-ubuntu/builds/1697 It also br

[Lldb-commits] [PATCH] D80254: Prevent GetNumChildren from transitively walking pointer chains

labath added a comment. Looks fine to me too. The way this test is phrased, it would probably make more sense under `test/API/python_api/value`, than here. (I mean, it's not technically wrong because everything is a "functionality", but i'd like to avoid putting stuff here precisely because the

[Lldb-commits] [lldb] 4bee2af - [lldb][NFC] Modernize TestCPPStaticMethods

Author: Raphael Isemann Date: 2020-05-20T12:27:44+02:00 New Revision: 4bee2afcd7ea10c9f58f6172924f822849fed8f9 URL: https://github.com/llvm/llvm-project/commit/4bee2afcd7ea10c9f58f6172924f822849fed8f9 DIFF: https://github.com/llvm/llvm-project/commit/4bee2afcd7ea10c9f58f6172924f822849fed8f9.dif

[Lldb-commits] [lldb] 0f1195a - Revert "[lldb/test] Relax NSDate mock test for non-Apple platforms"

Author: Dmitri Gribenko Date: 2020-05-20T12:44:19+02:00 New Revision: 0f1195a58648998d21bcfa1575a78a4706eaa52c URL: https://github.com/llvm/llvm-project/commit/0f1195a58648998d21bcfa1575a78a4706eaa52c DIFF: https://github.com/llvm/llvm-project/commit/0f1195a58648998d21bcfa1575a78a4706eaa52c.dif

[Lldb-commits] [lldb] f67f9e8 - Revert "[lldb/test] Disable NSDate format check under _WIN32"

Author: Dmitri Gribenko Date: 2020-05-20T12:44:19+02:00 New Revision: f67f9e86e86e68d4cbc05ef8d6ffd0cb33246d45 URL: https://github.com/llvm/llvm-project/commit/f67f9e86e86e68d4cbc05ef8d6ffd0cb33246d45 DIFF: https://github.com/llvm/llvm-project/commit/f67f9e86e86e68d4cbc05ef8d6ffd0cb33246d45.dif

[Lldb-commits] [lldb] 8214eff - Revert "[lldb/DataFormatter] Check for overflow when finding NSDate epoch"

Author: Dmitri Gribenko Date: 2020-05-20T12:44:19+02:00 New Revision: 8214eff467f583309e9fbb971862d3c1cdcc65e4 URL: https://github.com/llvm/llvm-project/commit/8214eff467f583309e9fbb971862d3c1cdcc65e4 DIFF: https://github.com/llvm/llvm-project/commit/8214eff467f583309e9fbb971862d3c1cdcc65e4.dif

[Lldb-commits] [lldb] 23f29b2 - Revert "Silence warnings around int/float conversions."

Author: Dmitri Gribenko Date: 2020-05-20T12:44:19+02:00 New Revision: 23f29b2fcc5668c51f15809067a1c3503b422c64 URL: https://github.com/llvm/llvm-project/commit/23f29b2fcc5668c51f15809067a1c3503b422c64 DIFF: https://github.com/llvm/llvm-project/commit/23f29b2fcc5668c51f15809067a1c3503b422c64.dif

[Lldb-commits] [lldb] 79fcd35 - Revert "[lldb/test] Move "DataFormatters/Mock.h" to "Plugins/Language/ObjC/Utilities.h""

Author: Dmitri Gribenko Date: 2020-05-20T12:44:18+02:00 New Revision: 79fcd35c688b94becadd162a6c37e9b95df5c084 URL: https://github.com/llvm/llvm-project/commit/79fcd35c688b94becadd162a6c37e9b95df5c084 DIFF: https://github.com/llvm/llvm-project/commit/79fcd35c688b94becadd162a6c37e9b95df5c084.dif

[Lldb-commits] [PATCH] D80150: [lldb/DataFormatter] Check for overflow when finding NSDate epoch

MForster added a comment. Reverts of a few follow-up changes were necessary as well: - 79fcd35c688b94becadd162a6c37e9b95df5c084 - 23f29b2fcc5668c51f15809067a1c3503b422c64

[Lldb-commits] [lldb] 587f81f - Revert "[lldb-server] Reset stop reason of all threads when resuming"

Author: Raphael Isemann Date: 2020-05-20T13:29:04+02:00 New Revision: 587f81f54a3abab88fe9be5f113c74fc12655ee0 URL: https://github.com/llvm/llvm-project/commit/587f81f54a3abab88fe9be5f113c74fc12655ee0 DIFF: https://github.com/llvm/llvm-project/commit/587f81f54a3abab88fe9be5f113c74fc12655ee0.dif

[Lldb-commits] [lldb] aa04ce7 - [lldb][NFC] Minor NamespaceMap refactor

Author: Raphael Isemann Date: 2020-05-20T15:29:20+02:00 New Revision: aa04ce761793bfff6de398091125823476a6e924 URL: https://github.com/llvm/llvm-project/commit/aa04ce761793bfff6de398091125823476a6e924 DIFF: https://github.com/llvm/llvm-project/commit/aa04ce761793bfff6de398091125823476a6e924.dif

[Lldb-commits] [PATCH] D80254: Prevent GetNumChildren from transitively walking pointer chains

jarin added a comment. In D80254#2046275 , @labath wrote: > Looks fine to me too. The way this test is phrased, it would probably make > more sense under `test/API/python_api/value`, than here. (I mean, it's not > technically wrong because everything is

[Lldb-commits] [PATCH] D80254: Prevent GetNumChildren from transitively walking pointer chains

jarin updated this revision to Diff 265237. jarin marked 3 inline comments as done. jarin added a comment. Merged the ObjC pointer case with the reference case, simplified the test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80254/new/ https://reviews.llvm.org/D80254 Files: lldb/s

[Lldb-commits] [PATCH] D80254: Prevent GetNumChildren from transitively walking pointer chains

shafik added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:5215 +uint32_t num_pointee_children = 0; +if (pointee_clang_type.IsAggregateType()) + num_pointee_children = jarin wrote: > shafik wrote: > > I am curi

[Lldb-commits] [lldb] 667be33 - [lldb/Reproducers] Update macosx remote tests for passive replay

Author: Jonas Devlieghere Date: 2020-05-20T09:03:16-07:00 New Revision: 667be3319d9eff4fbcf1cb1714a1205e84c9b848 URL: https://github.com/llvm/llvm-project/commit/667be3319d9eff4fbcf1cb1714a1205e84c9b848 DIFF: https://github.com/llvm/llvm-project/commit/667be3319d9eff4fbcf1cb1714a1205e84c9b848.d

[Lldb-commits] [PATCH] D80257: [lldb] Allows customizing libxml2 for darwin

JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80257/new/ https://reviews.llvm.org/D80257 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [lldb] d57b80e - [lldb/Reproducers] Support reproducers for PlatformRemoteGDBServer

Author: Jonas Devlieghere Date: 2020-05-20T09:18:57-07:00 New Revision: d57b80e13ebd140f0b9acefa02423e1bc4a835d4 URL: https://github.com/llvm/llvm-project/commit/d57b80e13ebd140f0b9acefa02423e1bc4a835d4 DIFF: https://github.com/llvm/llvm-project/commit/d57b80e13ebd140f0b9acefa02423e1bc4a835d4.d

Re: [Lldb-commits] [PATCH] D80150: [lldb/DataFormatter] Check for overflow when finding NSDate epoch

Agreed. Something is off here. My change was only to silence a few warnings, but they're definitely highlighting a conversion issue. What's up with NSDate conversions here. Does the API have a way to convert from time_t? On Wed, May 20, 2020, 2:07 AM Pavel Labath via Phabricator via lldb-commits

[Lldb-commits] [PATCH] D80130: [mlir][SystemZ] Fix incompatible datalayout in SystemZ

imaihal updated this revision to Diff 264770. imaihal added a comment. - [NFC] Replace MaybeAlign with Align in TargetTransformInfo. - [mlir][SystemZ] Fix incompatible datalayout in SystemZ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80130/new/ h

[Lldb-commits] [PATCH] D80130: [mlir][SystemZ] Fix incompatible datalayout in SystemZ

mehdi_amini accepted this revision. mehdi_amini added inline comments. Comment at: mlir/lib/ExecutionEngine/ExecutionEngine.cpp:123 } - std::unique_ptr machine( - target->createTargetMachine(targetTriple, "generic", "", {}, {})); + std::string cpu = std::string(llvm::sy

[Lldb-commits] [PATCH] D80130: [mlir][SystemZ] Fix incompatible datalayout in SystemZ

imaihal added a comment. My wrong operation(submission) may add LLDB tag on this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80130/new/ https://reviews.llvm.org/D80130 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D80130: [mlir][SystemZ] Fix incompatible datalayout in SystemZ

imaihal marked an inline comment as done. imaihal added a comment. Thanks for the review! I changed the variable name to `camelBack` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80130/new/ https://reviews.llvm.org/D80130 ___

[Lldb-commits] [PATCH] D80130: [mlir][SystemZ] Fix incompatible datalayout in SystemZ

imaihal updated this revision to Diff 264769. imaihal added a comment. Herald added subscribers: lldb-commits, kbarton, hiraditya, nemanjai. Herald added a project: LLDB. [mlir][SystemZ] Fix incompatible datalayout in SystemZ MLIR tests in "mlir/test/mlir-cpu-runner" fails in SystemZ (z14) becaus

[Lldb-commits] [lldb] 5b5b81b - [lldb/Driver] Error out when encountering unknown arguments

Author: Jonas Devlieghere Date: 2020-05-20T09:40:40-07:00 New Revision: 5b5b81bcdccb43164e86cfc6a0ac966afc3a143c URL: https://github.com/llvm/llvm-project/commit/5b5b81bcdccb43164e86cfc6a0ac966afc3a143c DIFF: https://github.com/llvm/llvm-project/commit/5b5b81bcdccb43164e86cfc6a0ac966afc3a143c.d

[Lldb-commits] [PATCH] D80226: [lldb/Driver] Error out when encountering unknown arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rG5b5b81bcdccb: [lldb/Driver] Error out when encountering unknown arguments (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[Lldb-commits] [PATCH] D80224: [lldb/Reproducers] Support reproducers for PlatformRemoteGDBServer

This revision was automatically updated to reflect the committed changes. Closed by commit rGd57b80e13ebd: [lldb/Reproducers] Support reproducers for PlatformRemoteGDBServer (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 4b17702 - [lldb/Reproducers] Skip another test that uses lldb::FileSP under the hood

Author: Jonas Devlieghere Date: 2020-05-20T09:49:29-07:00 New Revision: 4b17702434af9631e5e5a16449a93c9734be0c7e URL: https://github.com/llvm/llvm-project/commit/4b17702434af9631e5e5a16449a93c9734be0c7e DIFF: https://github.com/llvm/llvm-project/commit/4b17702434af9631e5e5a16449a93c9734be0c7e.d

[Lldb-commits] [lldb] bfb2783 - [lldb/Reproducers] Make SBStream::Print an API instead of a SWIG extension

Author: Jonas Devlieghere Date: 2020-05-20T10:37:18-07:00 New Revision: bfb278372633c50ae595f0b89241a143090c967e URL: https://github.com/llvm/llvm-project/commit/bfb278372633c50ae595f0b89241a143090c967e DIFF: https://github.com/llvm/llvm-project/commit/bfb278372633c50ae595f0b89241a143090c967e.d

[Lldb-commits] [PATCH] D80312: [lldb/Reproducers] Make SBStream::Print a first-class API instead of a SWIG extension

JDevlieghere created this revision. JDevlieghere added reviewers: labath, teemperor. teemperor accepted this revision. This revision is now accepted and ready to land. This makes it possible to instrument the call for the reproducers. This fixes TestStructuredDataAPI.py with reproducer replay.

[Lldb-commits] [PATCH] D80165: [lldb/Driver] Fix handling on positional arguments

jingham added a comment. In D80165#2045882 , @labath wrote: > In D80165#2044509 , @jingham wrote: > > > We should make sure if we do exit that we don't output any other text that > > would obscure the error message

[Lldb-commits] [PATCH] D80312: [lldb/Reproducers] Make SBStream::Print a first-class API instead of a SWIG extension

This revision was automatically updated to reflect the committed changes. Closed by commit rGbfb278372633: [lldb/Reproducers] Make SBStream::Print an API instead of a SWIG extension (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] 780d7d7 - [lldb] Allows customizing libxml2 for darwin

Author: Haibo Huang Date: 2020-05-20T12:27:08-07:00 New Revision: 780d7d77327c3537cc2c2aa9314aa2ad92cfe070 URL: https://github.com/llvm/llvm-project/commit/780d7d77327c3537cc2c2aa9314aa2ad92cfe070 DIFF: https://github.com/llvm/llvm-project/commit/780d7d77327c3537cc2c2aa9314aa2ad92cfe070.diff L

[Lldb-commits] [lldb] 04daba9 - [lldb] Cleans up system_libs

Author: Haibo Huang Date: 2020-05-20T12:30:08-07:00 New Revision: 04daba967031b7e3a72935613f23cb0051b56fc8 URL: https://github.com/llvm/llvm-project/commit/04daba967031b7e3a72935613f23cb0051b56fc8 DIFF: https://github.com/llvm/llvm-project/commit/04daba967031b7e3a72935613f23cb0051b56fc8.diff L

[Lldb-commits] [lldb] ce19664 - [lldb/Driver] Print snippet before exiting with unknown argument.

Author: Jonas Devlieghere Date: 2020-05-20T12:35:02-07:00 New Revision: ce19664d94b7dacc7291e947b19f5ccab0bba981 URL: https://github.com/llvm/llvm-project/commit/ce19664d94b7dacc7291e947b19f5ccab0bba981 DIFF: https://github.com/llvm/llvm-project/commit/ce19664d94b7dacc7291e947b19f5ccab0bba981.d

[Lldb-commits] [PATCH] D80253: [lldb] Cleans up system_libs

This revision was automatically updated to reflect the committed changes. Closed by commit rG04daba967031: [lldb] Cleans up system_libs (authored by hhb). Changed prior to commit: https://reviews.llvm.org/D80253?vs=265065&id=265327#toc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[Lldb-commits] [PATCH] D80257: [lldb] Allows customizing libxml2 for darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rG780d7d77327c: [lldb] Allows customizing libxml2 for darwin (authored by hhb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80257/new/ https://reviews.llvm.

[Lldb-commits] [lldb] 690993a - [lldb/Reproducers] Add instrumentation to SBEnvironment

Author: Jonas Devlieghere Date: 2020-05-20T13:02:20-07:00 New Revision: 690993a09a0df0d54a5cec7f06fffb6e2210ab8b URL: https://github.com/llvm/llvm-project/commit/690993a09a0df0d54a5cec7f06fffb6e2210ab8b DIFF: https://github.com/llvm/llvm-project/commit/690993a09a0df0d54a5cec7f06fffb6e2210ab8b.d

[Lldb-commits] [lldb] bc1c365 - Give microsoftDemangle() an outparam for how many input bytes were consumed.

Author: Nico Weber Date: 2020-05-20T16:17:31-04:00 New Revision: bc1c3655bfd67a0b4ccece465729c39d769e9707 URL: https://github.com/llvm/llvm-project/commit/bc1c3655bfd67a0b4ccece465729c39d769e9707 DIFF: https://github.com/llvm/llvm-project/commit/bc1c3655bfd67a0b4ccece465729c39d769e9707.diff LO

[Lldb-commits] [PATCH] D80173: Give microsoftDemangle() an outparam for how many input bytes were consumed.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbc1c3655bfd6: Give microsoftDemangle() an outparam for how many input bytes were consumed. (authored by thakis). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to com

[Lldb-commits] [lldb] 8723f84 - [lldb/Test] Support arbitrary file extensions in TestPositionalArgs.test

Author: Jonas Devlieghere Date: 2020-05-20T14:09:19-07:00 New Revision: 8723f841aad8815c6d4ab199ad591f6eafdaad83 URL: https://github.com/llvm/llvm-project/commit/8723f841aad8815c6d4ab199ad591f6eafdaad83 DIFF: https://github.com/llvm/llvm-project/commit/8723f841aad8815c6d4ab199ad591f6eafdaad83.d

[Lldb-commits] [PATCH] D80254: Prevent GetNumChildren from transitively walking pointer chains

clayborg added a comment. This looks good, thanks for subscribing me. We need to have GetNumChildren and GetChildAtIndex agreeing on things and we definitely shouldn't be walking more than on pointer recursively. My only question is do we need helper functions added to TypeSystemClang to avoid

[Lldb-commits] [PATCH] D80345: [DwarfExpression] Support entry values for indirect parameters

vsk created this revision. vsk added reviewers: djtodoro, aprantl, dstenb. Herald added subscribers: lldb-commits, hiraditya. Herald added projects: LLDB, LLVM. A struct argument can be passed-by-value to a callee via a pointer to a temporary stack copy. Add support for emitting an entry value DBG

[Lldb-commits] [PATCH] D80350: Handle the case where a thread exits while we were running a function on it

jingham created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. It is possible that the thread we are running a function on could exit while we are waiting for the function call to return. We sort of handled that case before, but it really only worked by acc

[Lldb-commits] [lldb] 7606a54 - [lldb/Reproducers] Fix/skip passive replay failures in python_api subdir

Author: Jonas Devlieghere Date: 2020-05-20T23:23:53-07:00 New Revision: 7606a54363d3d90802977c9f5fb9046d4d780835 URL: https://github.com/llvm/llvm-project/commit/7606a54363d3d90802977c9f5fb9046d4d780835 DIFF: https://github.com/llvm/llvm-project/commit/7606a54363d3d90802977c9f5fb9046d4d780835.d

[Lldb-commits] [PATCH] D80165: [lldb/Driver] Fix handling on positional arguments

labath added a comment. In D80165#2047241 , @jingham wrote: > In D80165#2045882 , @labath wrote: > > > In D80165#2044509 , @jingham wrote: > > > > > We should make sure if we