[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

jankratochvil added a comment. The filename should not be checked from `SymbolContext::function` but rather from `SymbolContext::line_entry`. As that is cheaper. And when one asks for breakpoint at `1a.h:1` then it is enough to check `.debug_line` (which needs to be checked anyway) and why to

[Lldb-commits] [PATCH] D82723: Add lldbAPI library to be able to invoke SB API from CommandObjects

shivammittal99 created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. Signed-off-by: Shivam Mittal Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82723 Files: lldb/source/API/CMakeLists.txt lldb/source/Commands/CMakeLists.txt

[Lldb-commits] [PATCH] D82723: Add lldbAPI library to be able to invoke SB API from CommandObjects

shivammittal99 updated this revision to Diff 273977. shivammittal99 added a comment. Rebase on master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82723/new/ https://reviews.llvm.org/D82723 Files: lldb/source/API/CMakeLists.txt lldb/source/Co

[Lldb-commits] [PATCH] D82732: WIP: Use SB APIs in CommandObjects

shivammittal99 created this revision. shivammittal99 added reviewers: jingham, teemperor. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Signed-off-by: Shivam Mittal Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82732 Files: lldb/include/lldb/API/SB

[Lldb-commits] [PATCH] D82378: [lldb/Unwind] Use eh_frame plan directly when it doesn't need to be augmented

labath marked an inline comment as done. labath added inline comments. Comment at: lldb/test/Shell/Unwind/eh-frame-augment-noop.test:18 +target modules show-unwind -n foo +# CHECK: Asynchronous (not restricted to call-sites) UnwindPlan is 'eh_frame CFI' +# CHECK: eh_frame augmen

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

labath added a comment. In D74136#2118983 , @jankratochvil wrote: > The filename should not be checked from `SymbolContext::function` but rather > from `SymbolContext::line_entry`. As that is cheaper. And when one asks for > breakpoint at `1a.h:1` the

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

labath added a comment. At this point I'm getting very lost in this patch, but here's some of my thoughs (the ones I could actually formulate in a coherent manner)... Comment at: lldb/source/Core/SearchFilter.cpp:713 + if (!type) +return SearchFilterByModuleList::Function

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

labath added a comment. I'm worried about the confusing relationship between `RegisterInfos_arm64_sve.h` and `RegisterInfos_arm64.h` and the overlap in the register numbers it enforces. when we discussed this last time, my understanding was that the sve registers could be inserted _before_ the

[Lldb-commits] [PATCH] D82064: [ARM64] Add QEMU testing environment setup guide for SVE testing

omjavaid added a comment. In D82064#2113851 , @rovka wrote: > Hi Omair, > > If this is intended to be more generally useful, I wonder if we should rename > it to something else (e.g. lldb-qemu-howto.txt) and only use AArch64 SVE as a > case study. > > In

[Lldb-commits] [PATCH] D82759: [lldb/Test] Introduce "assertSuccess"

labath created this revision. labath added reviewers: teemperor, JDevlieghere. Herald added a subscriber: arphaman. Herald added a project: LLDB. A lot of our tests do 'self.assertTrue(error.Success()'. The problem with that is that when this fails, it produces a completely useless error message (

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

jankratochvil added a comment. In D74136#2119549 , @labath wrote: > At this point I'm getting very lost in this patch, Me too, as you stated: In D74136#2020245 , @labath wrote: > In D74136#1983467

[Lldb-commits] [lldb] 48ca155 - [lldb] Deduplicate Scalar integral getters

Author: Pavel Labath Date: 2020-06-29T15:24:39+02:00 New Revision: 48ca15592f16fb6d8e2cef112f14345738e29cf4 URL: https://github.com/llvm/llvm-project/commit/48ca15592f16fb6d8e2cef112f14345738e29cf4 DIFF: https://github.com/llvm/llvm-project/commit/48ca15592f16fb6d8e2cef112f14345738e29cf4.diff

[Lldb-commits] [lldb] 6292702 - [lldb/Test] Skip TestVSCode_disconnect on Darwin

Author: Jonas Devlieghere Date: 2020-06-29T07:48:09-07:00 New Revision: 6292702d1231378f86a0560a68603fd006911f2f URL: https://github.com/llvm/llvm-project/commit/6292702d1231378f86a0560a68603fd006911f2f DIFF: https://github.com/llvm/llvm-project/commit/6292702d1231378f86a0560a68603fd006911f2f.d

[Lldb-commits] [PATCH] D82772: [lldb] Fix type conversion in the Scalar getters

labath created this revision. labath added reviewers: teemperor, JDevlieghere. Herald added a project: LLDB. The Scalar class claims to follow the C type conversion rules. This is true for the Promote function, but it is not true for the implicit conversions done in the getter methods. These func

[Lldb-commits] [lldb] 3936b75 - [LLDB] skip TestCreateDuringInstructionStep on aarch64/linux

Author: Muhammad Omair Javaid Date: 2020-06-29T21:32:48+05:00 New Revision: 3936b753bacc17aae4bb421bd8a27f428a9a4173 URL: https://github.com/llvm/llvm-project/commit/3936b753bacc17aae4bb421bd8a27f428a9a4173 DIFF: https://github.com/llvm/llvm-project/commit/3936b753bacc17aae4bb421bd8a27f428a9a41

[Lldb-commits] [PATCH] D82759: [lldb/Test] Introduce "assertSuccess"

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Looks like a great improvement! At some point we should document our custom methods in https://lldb.llvm.org/resources/test.html to make them more discoverable, but that's orthogo

[Lldb-commits] [PATCH] D82772: [lldb] Fix type conversion in the Scalar getters

JDevlieghere added a comment. + Ismail as he looked at this recently. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82772/new/ https://reviews.llvm.org/D82772 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [lldb] 300bbbc - [ProcessGDBRemote] Get rid of an unused function.

Author: Davide Italiano Date: 2020-06-29T12:39:09-07:00 New Revision: 300bbbcb707ad08200543735326982664136d3bc URL: https://github.com/llvm/llvm-project/commit/300bbbcb707ad08200543735326982664136d3bc DIFF: https://github.com/llvm/llvm-project/commit/300bbbcb707ad08200543735326982664136d3bc.dif

[Lldb-commits] [lldb] c48ccb6 - Simplify conditionals in DNBArchMachARM64::EnableHardwareSingleStep

Author: Jason Molenda Date: 2020-06-29T14:04:44-07:00 New Revision: c48ccb6b4e513e467b22fab1de57a25c23af4361 URL: https://github.com/llvm/llvm-project/commit/c48ccb6b4e513e467b22fab1de57a25c23af4361 DIFF: https://github.com/llvm/llvm-project/commit/c48ccb6b4e513e467b22fab1de57a25c23af4361.diff

[Lldb-commits] [PATCH] D82804: Do not set LLDB_DEBUGSERVER_PATH if --out-of-tree-debugserver is passed.

davide created this revision. davide added reviewers: vsk, aprantl, jasonmolenda. Now that there are two implementations of debugserver, one for native and the other for Rosetta [on Apple Silicon], this is needed. https://reviews.llvm.org/D82804 Files: lldb/packages/Python/lldbsuite/test/dot

[Lldb-commits] [PATCH] D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files

aprantl added inline comments. Comment at: lldb/include/lldb/Host/Host.h:231 + /// Check whether a process is translated (Rosetta). + /// \arg process_info The info structure for the process queried. Is this supposed to be a generic function call that, e.g, s

[Lldb-commits] [PATCH] D82804: Do not set LLDB_DEBUGSERVER_PATH if --out-of-tree-debugserver is passed.

aprantl added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:366 -if args.server: +if args.server and not args.out_of_tree_debugserver: os.environ['LLDB_DEBUGSERVER_PATH'] = args.server davide wrote: > aprantl wrote:

[Lldb-commits] [PATCH] D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files

JDevlieghere added inline comments. Comment at: lldb/source/Host/macosx/objcxx/Host.mm:1471 + size_t bufsize = sizeof(processInfo); + if (sysctl(mib, (unsigned)(sizeof(mib)/sizeof(int)), &processInfo, + &bufsize, NULL, 0) == 0 && bufsize <= 0) nit:

[Lldb-commits] [PATCH] D82804: Do not set LLDB_DEBUGSERVER_PATH if --out-of-tree-debugserver is passed.

aprantl added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:366 -if args.server: +if args.server and not args.out_of_tree_debugserver: os.environ['LLDB_DEBUGSERVER_PATH'] = args.server Does this have any surprising

[Lldb-commits] [PATCH] D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files

davide updated this revision to Diff 274253. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82813/new/ https://reviews.llvm.org/D82813 Files: lldb/include/lldb/Host/Host.h lldb/source/Host/common/Host.cpp lldb/source/Host/macosx/objcxx/Host.mm lldb/source/Plugins/Process/gdb-remot

[Lldb-commits] [PATCH] D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files

davide marked an inline comment as done. davide added inline comments. Comment at: lldb/include/lldb/Host/Host.h:231 + /// Run a shell command. + /// \arg process_info The info structure for the process queried. Stale comment, I'll update CHANGES SINCE LAST

[Lldb-commits] [PATCH] D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files

davide created this revision. davide added reviewers: aprantl, jasonmolenda. Nothing crazy here, just an organizational cleanup. https://reviews.llvm.org/D82813 Files: lldb/include/lldb/Host/Host.h lldb/source/Host/common/Host.cpp lldb/source/Host/macosx/objcxx/Host.mm lldb/source/Plugi

[Lldb-commits] [PATCH] D82491: [Apple Silicon] Initial support for Rosetta

davide marked an inline comment as done. davide added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:3444 +size_t bufsize = sizeof(processInfo); +if (sysctl(mib, (unsigned)(sizeof(mib)/sizeof(int)), &processInfo, + &

[Lldb-commits] [PATCH] D82804: Do not set LLDB_DEBUGSERVER_PATH if --out-of-tree-debugserver is passed.

vsk added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:366 -if args.server: +if args.server and not args.out_of_tree_debugserver: os.environ['LLDB_DEBUGSERVER_PATH'] = args.server aprantl wrote: > davide wrote: > >

[Lldb-commits] [PATCH] D82804: Do not set LLDB_DEBUGSERVER_PATH if --out-of-tree-debugserver is passed.

davide marked an inline comment as done. davide added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:366 -if args.server: +if args.server and not args.out_of_tree_debugserver: os.environ['LLDB_DEBUGSERVER_PATH'] = args.server ---

[Lldb-commits] [PATCH] D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files

davide marked an inline comment as done. davide added inline comments. Comment at: lldb/include/lldb/Host/Host.h:231 + /// Check whether a process is translated (Rosetta). + /// \arg process_info The info structure for the process queried. aprantl wrote: > Is

[Lldb-commits] [PATCH] D82835: [lldb] Fix missing characters when autocompleting LLDB commands in REPL

poya created this revision. poya added a reviewer: teemperor. Herald added a project: LLDB. poya added a comment. Tests for the Swift REPL in https://github.com/apple/llvm-project/pull/1388 When tabbing to complete LLDB commands in REPL, characters would at best be missing but at worst cause th

[Lldb-commits] [PATCH] D82835: [lldb] Fix missing characters when autocompleting LLDB commands in REPL

poya added a comment. Tests for the Swift REPL in https://github.com/apple/llvm-project/pull/1388 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82835/new/ https://reviews.llvm.org/D82835 ___ lldb-commi

[Lldb-commits] [PATCH] D82616: Improve the detection of iOS/tvOS/watchOS simulator binaries in debugserver and lldb

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Sorry for the delay, this looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82616/new/ https://reviews.llvm.org/D82616 ___