[Lldb-commits] [PATCH] D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files

2020-06-30 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: lldb/include/lldb/Host/Host.h:231 + /// Check whether a process is translated (Rosetta). + /// \arg process_info The info structure for the process queried. aprantl wrote: > davide wrote: > > aprantl wrote: > > > Is t

[Lldb-commits] [PATCH] D82835: [lldb] Fix missing characters when autocompleting LLDB commands in REPL

2020-06-30 Thread Martin Svensson via Phabricator via lldb-commits
poya marked an inline comment as done. poya added inline comments. Comment at: lldb/source/Expression/REPL.cpp:460 sub_result.GetMatches(matches); +// Prepend command prefix that was excluded in the completion request +if (request.GetCursorIndex() == 0) { ---

[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

2020-06-30 Thread Yifan Shen via Phabricator via lldb-commits
aelitashen updated this revision to Diff 274634. aelitashen added a comment. Make LLDB take care of the directory delimiter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82477/new/ https://reviews.llvm.org/D82477 Files: clang/tools/clang-format/

[Lldb-commits] [PATCH] D82879: [lldb/api] Improve error reporting in SBBreakpoint::AddName (NFCI)

2020-06-30 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib updated this revision to Diff 274633. mib added a comment. - Use new `assertSuccess` method in test. - Rename the method to `AddNameWithErrorHandling` for consistency. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82879/new/ https://reviews.l

[Lldb-commits] [PATCH] D82732: WIP: Use SB APIs in CommandObjects

2020-06-30 Thread Shivam Mittal via Phabricator via lldb-commits
shivammittal99 updated this revision to Diff 274625. shivammittal99 added a comment. - Extend SBTarget to enable/disable/ignore watchpoints Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82732/new/ https://reviews.llvm.org/D82732 Files: lldb/bind

[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

2020-06-30 Thread Yifan Shen via Phabricator via lldb-commits
aelitashen marked 3 inline comments as done. aelitashen added inline comments. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:337-340 +std::string(module.GetFileSpec().GetFilename())); + std::string module_path = std::string(module.GetFileSpec().GetDirectory()) + +

[Lldb-commits] [PATCH] D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files

2020-06-30 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added inline comments. Comment at: lldb/include/lldb/Host/Host.h:231 + /// Check whether a process is translated (Rosetta). + /// \arg process_info The info structure for the process queried. davide wrote: > aprantl wrote: > > Is this supposed to be a

[Lldb-commits] [lldb] 983a4b5 - Skip arm-(fp|gp)-read.test on Darwin.

2020-06-30 Thread Davide Italiano via lldb-commits
Author: Davide Italiano Date: 2020-06-30T12:53:20-07:00 New Revision: 983a4b520ea384ac978cbfc40bb956fbb98cd735 URL: https://github.com/llvm/llvm-project/commit/983a4b520ea384ac978cbfc40bb956fbb98cd735 DIFF: https://github.com/llvm/llvm-project/commit/983a4b520ea384ac978cbfc40bb956fbb98cd735.dif

[Lldb-commits] [lldb] 4f1f253 - [TestReturnValue] Skip based on architecutre, not platform.

2020-06-30 Thread Davide Italiano via lldb-commits
Author: Davide Italiano Date: 2020-06-30T12:48:23-07:00 New Revision: 4f1f253ce509ebc20e1f7a2d8bb6885366b155f2 URL: https://github.com/llvm/llvm-project/commit/4f1f253ce509ebc20e1f7a2d8bb6885366b155f2 DIFF: https://github.com/llvm/llvm-project/commit/4f1f253ce509ebc20e1f7a2d8bb6885366b155f2.dif

Re: [Lldb-commits] [lldb] 2501e86 - [lldb/Scalar] Fix undefined behavior

2020-06-30 Thread Jonas Devlieghere via lldb-commits
+ Pavel for post-commit review. I've reinstated the original behavior to fix the UBSan error on the bot. Please let me know if you prefer a different approach. On Tue, Jun 30, 2020 at 12:41 PM Jonas Devlieghere via lldb-commits < lldb-commits@lists.llvm.org> wrote: > > Author: Jonas Devlieghere

[Lldb-commits] [lldb] 2501e86 - [lldb/Scalar] Fix undefined behavior

2020-06-30 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-06-30T12:41:41-07:00 New Revision: 2501e86acda2905e50012f7e9fc1942517c1237d URL: https://github.com/llvm/llvm-project/commit/2501e86acda2905e50012f7e9fc1942517c1237d DIFF: https://github.com/llvm/llvm-project/commit/2501e86acda2905e50012f7e9fc1942517c1237d.d

[Lldb-commits] [PATCH] D82879: [lldb/api] Improve error reporting in SBBreakpoint::AddName (NFCI)

2020-06-30 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added inline comments. Comment at: lldb/bindings/interface/SBBreakpoint.i:210 +SBError +AddNameWithError (const char *new_name); + In `SBDebugger` we have `InitializeWithErrorHandling`, maybe use the same suffix here for consistency?

[Lldb-commits] [PATCH] D82879: [lldb/api] Improve error reporting in SBBreakpoint::AddName (NFCI)

2020-06-30 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib updated this revision to Diff 274561. mib edited the summary of this revision. mib added a comment. Introduced `SBBreakpoint::AddNameWithError` to avoid API stability breakage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82879/new/ https://re

[Lldb-commits] [lldb] 66d9c0d - [lldb/Test] Skip TestIOHandlerResizeNoEditline with reproducers

2020-06-30 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-06-30T11:40:17-07:00 New Revision: 66d9c0d4fc7ea19be08c6a3604571254186851a7 URL: https://github.com/llvm/llvm-project/commit/66d9c0d4fc7ea19be08c6a3604571254186851a7 DIFF: https://github.com/llvm/llvm-project/commit/66d9c0d4fc7ea19be08c6a3604571254186851a7.d

[Lldb-commits] [PATCH] D82616: Improve the detection of iOS/tvOS/watchOS simulator binaries in debugserver and lldb

2020-06-30 Thread Adrian Prantl via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0da0437b2afb: Improve the detection of iOS/tvOS/watchOS simulator binaries in debugserver and… (authored by aprantl). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D826

[Lldb-commits] [lldb] 0da0437 - Improve the detection of iOS/tvOS/watchOS simulator binaries in

2020-06-30 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2020-06-30T11:22:03-07:00 New Revision: 0da0437b2afbd8ebef6b11f114cca33b118e7639 URL: https://github.com/llvm/llvm-project/commit/0da0437b2afbd8ebef6b11f114cca33b118e7639 DIFF: https://github.com/llvm/llvm-project/commit/0da0437b2afbd8ebef6b11f114cca33b118e7639.diff

[Lldb-commits] [PATCH] D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files

2020-06-30 Thread Davide Italiano via Phabricator via lldb-commits
davide marked an inline comment as done. davide added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:3424 +if (Host::IsProcessTranslated(process_info)) { + FileSpec rosetta_debugserver("/Library/Apple/usr/libexec/oah/debugserver

[Lldb-commits] [PATCH] D82616: Improve the detection of iOS/tvOS/watchOS simulator binaries in debugserver and lldb

2020-06-30 Thread Davide Italiano via Phabricator via lldb-commits
davide accepted this revision. davide added a comment. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82616/new/ https://reviews.llvm.org/D82616 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[Lldb-commits] [PATCH] D82378: [lldb/Unwind] Use eh_frame plan directly when it doesn't need to be augmented

2020-06-30 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D82378#2113865 , @labath wrote: > You're right that the instruction emulation not handling multiple epilogues > is a bug. It's probably not about _all_ epilogues, only some special ones -- > for example, the function where we r

[Lldb-commits] [PATCH] D82772: [lldb] Fix type conversion in the Scalar getters

2020-06-30 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM with Raphael's and clang-format's comments addressed :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82772/new/ https://reviews.llvm.org/D82772 ___

[Lldb-commits] [PATCH] D82879: [lldb/api] Improve error reporting in SBBreakpoint::AddName (NFCI)

2020-06-30 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. We can't break the SB API, it's unfortunate but this should be an overload instead... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82879/new/ https://reviews.llvm.org/D82879 ___

[Lldb-commits] [PATCH] D82622: [DWARFYAML][debug_info] Replace 'InitialLength' with 'Format' and 'Length'.

2020-06-30 Thread Ulrich Weigand via Phabricator via lldb-commits
uweigand added a comment. In D82622#2122708 , @Higuoxing wrote: > In D82622#2122562 , @uweigand wrote: > > > This commit causes test case failures on s390x (unfortunately hidden as the > > build bot was already red

[Lldb-commits] [lldb] 69b2d9f - [lldb/Test] Skip recognizer tests when Python is disabled

2020-06-30 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-06-30T08:59:44-07:00 New Revision: 69b2d9f42f6adbd0c06264dc42b4be5760689eac URL: https://github.com/llvm/llvm-project/commit/69b2d9f42f6adbd0c06264dc42b4be5760689eac DIFF: https://github.com/llvm/llvm-project/commit/69b2d9f42f6adbd0c06264dc42b4be5760689eac.d

[Lldb-commits] [PATCH] D82864: [lldb] Replace host-typed Scalar accessors with [SZ]ExtOrTruncInt

2020-06-30 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib added a comment. Looks good to me apart from one small detail. I'll leave it open for others to comment on this, since there are lots of changes. Comment at: lldb/source/Core/ValueObject.cpp:467 bool ret; - ret = scalar_value.ULongLong(1) != 0; + ret = scalar_value !

[Lldb-commits] [PATCH] D82879: [lldb/api] Improve error reporting in SBBreakpoint::AddName (NFCI)

2020-06-30 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib created this revision. mib added a reviewer: teemperor. mib added a project: LLDB. Herald added a subscriber: lldb-commits. This patch improves the error reporting for SBBreakpoint::AddName by changing its return type form a boolean to a SBError. This way, if the breakpoint naming failed in t

[Lldb-commits] [lldb] e55a097 - [lldb/Scripts]

2020-06-30 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2020-06-30T17:06:14+02:00 New Revision: e55a09793d689f42c17f55be861773b6a65751b2 URL: https://github.com/llvm/llvm-project/commit/e55a09793d689f42c17f55be861773b6a65751b2 DIFF: https://github.com/llvm/llvm-project/commit/e55a09793d689f42c17f55be861773b6a65751b2.diff

Re: [Lldb-commits] [PATCH] D82155: [WIP][lldb/interpreter] Add ability to save lldb session to a file

2020-06-30 Thread Pavel Labath via lldb-commits
+ Shivam (Up until today I thought this was just theoretical musing but now I realized that there is actually some work going towards this.) On 25/06/2020 20:45, Jim Ingham wrote: > > One of the things that is core functionality in the debugger is “when X > happens, do Y”.  When I stop, do someth

[Lldb-commits] [PATCH] D82759: [lldb/Test] Introduce "assertSuccess"

2020-06-30 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. labath marked an inline comment as done. Closed by commit rG35674976f09e: [lldb/Test] Introduce "assertSuccess" (authored by labath). Changed prior to commit: https://reviews.llvm.org/D82759?vs=274070&id=274459#toc Repos

[Lldb-commits] [PATCH] D82622: [DWARFYAML][debug_info] Replace 'InitialLength' with 'Format' and 'Length'.

2020-06-30 Thread Xing GUO via Phabricator via lldb-commits
Higuoxing added a comment. In D82622#2122562 , @uweigand wrote: > This commit causes test case failures on s390x (unfortunately hidden as the > build bot was already red due to an unrelated issue): > http://lab.llvm.org:8011/builders/clang-s390x-linux/bu

[Lldb-commits] [lldb] 3567497 - [lldb/Test] Introduce "assertSuccess"

2020-06-30 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2020-06-30T15:41:03+02:00 New Revision: 35674976f09ec99e74d0d28b4a64b6bce360c128 URL: https://github.com/llvm/llvm-project/commit/35674976f09ec99e74d0d28b4a64b6bce360c128 DIFF: https://github.com/llvm/llvm-project/commit/35674976f09ec99e74d0d28b4a64b6bce360c128.diff

[Lldb-commits] [PATCH] D82622: [DWARFYAML][debug_info] Replace 'InitialLength' with 'Format' and 'Length'.

2020-06-30 Thread Xing GUO via Phabricator via lldb-commits
Higuoxing added a comment. In D82622#2122562 , @uweigand wrote: > This commit causes test case failures on s390x (unfortunately hidden as the > build bot was already red due to an unrelated issue): > http://lab.llvm.org:8011/builders/clang-s390x-linux/bu

[Lldb-commits] [PATCH] D82622: [DWARFYAML][debug_info] Replace 'InitialLength' with 'Format' and 'Length'.

2020-06-30 Thread Ulrich Weigand via Phabricator via lldb-commits
uweigand added a comment. This commit causes test case failures on s390x (unfortunately hidden as the build bot was already red due to an unrelated issue): http://lab.llvm.org:8011/builders/clang-s390x-linux/builds/33624 http://lab.llvm.org:8011/builders/clang-s390x-linux/builds/33624/steps/ninj

[Lldb-commits] [PATCH] D82772: [lldb] Fix type conversion in the Scalar getters

2020-06-30 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Beside some minor things this LGTM. Comment at: lldb/source/Utility/Scalar.cpp:864 case e_uint512: -return static_cast( -llvm::APIntOps::RoundAPIntToDoub

[Lldb-commits] [lldb] bc163f6 - [lldb] Fix TestModuleGetXcodeSDK test after DWARFYAML change

2020-06-30 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2020-06-30T14:05:20+02:00 New Revision: bc163f63245e88f18de44f8a13a5c94e78cb18bd URL: https://github.com/llvm/llvm-project/commit/bc163f63245e88f18de44f8a13a5c94e78cb18bd DIFF: https://github.com/llvm/llvm-project/commit/bc163f63245e88f18de44f8a13a5c94e78cb18bd.dif

[Lldb-commits] [PATCH] D82772: [lldb] Fix type conversion in the Scalar getters

2020-06-30 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Thanks for looking at this. Could you also tell me what you think of D82864 ? That's sort of a more safe/NFC-ish alternative to this patch, as it doesn't change behavior -- it just makes the current behavior more obvious. (It's technical

[Lldb-commits] [PATCH] D82759: [lldb/Test] Introduce "assertSuccess"

2020-06-30 Thread Pavel Labath via Phabricator via lldb-commits
labath marked 3 inline comments as done. labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:2537 +def assertSuccess(self, obj, msg=None): +if not obj.Success(): +error = obj.GetCString() teemperor wro

[Lldb-commits] [PATCH] D82865: [LLDB] Add GetByteOffset to SBValue interface for reading register offset

2020-06-30 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
omjavaid created this revision. omjavaid added a reviewer: labath. Herald added a subscriber: kristof.beyls. Herald added a reviewer: rengolin. omjavaid added a child revision: D82866: [LLDB] Test SVE dynamic resize with multiple threads. This patch adds GetByteOffset to SBValue interface for ac

[Lldb-commits] [PATCH] D82864: [lldb] Replace host-typed Scalar accessors with [SZ]ExtOrTruncInt

2020-06-30 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added reviewers: JDevlieghere, mib, teemperor. Herald added a subscriber: emaste. Herald added a reviewer: shafik. Herald added a project: LLDB. The Scalar class gives off the impression that it follows the C type conversion rules, but this is not true for its

[Lldb-commits] [PATCH] D82866: [LLDB] Test SVE dynamic resize with multiple threads

2020-06-30 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
omjavaid created this revision. omjavaid added a reviewer: labath. Herald added subscribers: kristof.beyls, tschuett. Herald added a reviewer: rengolin. omjavaid added a parent revision: D82863: [LLDB] Add support to resize SVE registers at run-time. omjavaid added a parent revision: D82865: [LLDB

[Lldb-commits] [PATCH] D81241: [lldb] Tab completion for `frame recognizer delete`

2020-06-30 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc37d25f0d1e0: [lldb] Tab completion for `frame recognizer delete` (authored by MrHate, committed by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINC

[Lldb-commits] [lldb] c37d25f - [lldb] Tab completion for `frame recognizer delete`

2020-06-30 Thread Raphael Isemann via lldb-commits
Author: Gongyu Deng Date: 2020-06-30T13:50:14+02:00 New Revision: c37d25f0d1e059b39fbbc1ccc9f52ddba42be6b9 URL: https://github.com/llvm/llvm-project/commit/c37d25f0d1e059b39fbbc1ccc9f52ddba42be6b9 DIFF: https://github.com/llvm/llvm-project/commit/c37d25f0d1e059b39fbbc1ccc9f52ddba42be6b9.diff L

[Lldb-commits] [PATCH] D81177: [lldb] Tab completion for `frame select`

2020-06-30 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG80eb42281feb: [lldb] Tab completion for `frame select` (authored by MrHate, committed by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D81749: [lldb][NFC] Remove ImportInProgress lock in ClangASTSource

2020-06-30 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG502773d74341: [lldb][NFC] Remove ImportInProgress lock in ClangASTSource (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monore

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

2020-06-30 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
omjavaid created this revision. omjavaid added a reviewer: labath. Herald added a subscriber: tschuett. Herald added a reviewer: rengolin. omjavaid added parent revisions: D82853: [LLDB] Support custom expedited register set in gdb-remote, D82855: [LLDB] Send SVE vg register in custom expedited r

[Lldb-commits] [PATCH] D82759: [lldb/Test] Introduce "assertSuccess"

2020-06-30 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor accepted this revision. teemperor added a comment. LGTM, thanks! Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:2537 +def assertSuccess(self, obj, msg=None): +if not obj.Success(): +error = obj.GetCString() JDevlie

[Lldb-commits] [lldb] 80eb422 - [lldb] Tab completion for `frame select`

2020-06-30 Thread Raphael Isemann via lldb-commits
Author: Gongyu Deng Date: 2020-06-30T13:13:38+02:00 New Revision: 80eb42281feb7834054be5f933f63d8c64af229d URL: https://github.com/llvm/llvm-project/commit/80eb42281feb7834054be5f933f63d8c64af229d DIFF: https://github.com/llvm/llvm-project/commit/80eb42281feb7834054be5f933f63d8c64af229d.diff L

[Lldb-commits] [lldb] 502773d - [lldb][NFC] Remove ImportInProgress lock in ClangASTSource

2020-06-30 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2020-06-30T12:46:28+02:00 New Revision: 502773d743417a7896e184b4000bcf20fddb7ad9 URL: https://github.com/llvm/llvm-project/commit/502773d743417a7896e184b4000bcf20fddb7ad9 DIFF: https://github.com/llvm/llvm-project/commit/502773d743417a7896e184b4000bcf20fddb7ad9.dif

[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

2020-06-30 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
omjavaid created this revision. omjavaid added a reviewer: labath. Herald added a subscriber: kristof.beyls. Herald added a reviewer: rengolin. In gdb-remote process we have register infos defind GDBRemoteDynamicRegisterInfo reference. In past register infos have remained constant througout the

[Lldb-commits] [PATCH] D82855: [LLDB] Send SVE vg register in custom expedited registerset

2020-06-30 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
omjavaid created this revision. omjavaid added a reviewer: labath. Herald added subscribers: kristof.beyls, tschuett. Herald added a reviewer: rengolin. omjavaid added parent revisions: D79699: Add ptrace register access for AArch64 SVE registers, D77047: AArch64 SVE register infos and core file s

[Lldb-commits] [PATCH] D82853: [LLDB] Support custom expedited register set in gdb-remote

2020-06-30 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
omjavaid created this revision. omjavaid added a reviewer: labath. Herald added a subscriber: kristof.beyls. Herald added a reviewer: rengolin. omjavaid added parent revisions: D79699: Add ptrace register access for AArch64 SVE registers, D77047: AArch64 SVE register infos and core file support.

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

2020-06-30 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
omjavaid updated this revision to Diff 274390. omjavaid added a comment. In this updated I have removed overlapping parts of RegisterInfos_arm64.h and RegisterInfos_arm64_sve.h which in turn removes any possibility of duplicate definitions. Both register infos define separate static register in

[Lldb-commits] [PATCH] D80105: [LLDB] Combine multiple defs of arm64 register sets

2020-06-30 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
omjavaid updated this revision to Diff 274382. omjavaid added a comment. In this updated I have segregated RegisterInfoInterface and RegisterInfoAndSetInterface as two mutually exclusive interfaces. RegisterInfoPosix_arm64 is currently the only class making use of set interface but I am going t

[Lldb-commits] [PATCH] D82835: [lldb] Fix missing characters when autocompleting LLDB commands in REPL

2020-06-30 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: lldb/source/Expression/REPL.cpp:460 sub_result.GetMatches(matches); +// Prepend command prefix that was excluded in the completion re

[Lldb-commits] [PATCH] D82772: [lldb] Fix type conversion in the Scalar getters

2020-06-30 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib added a comment. Hey Pavel! Thanks for taking care of this. I started looking at it no long ago but I got sidetracked working on other stuff. I don't see anything wrong with the patch, looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [lldb] 621f845 - [lldb] Modernize TestOperatorOverload.py asserts

2020-06-30 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2020-06-30T11:38:42+02:00 New Revision: 621f84567920bf5a8d79789f01a622115ec8252d URL: https://github.com/llvm/llvm-project/commit/621f84567920bf5a8d79789f01a622115ec8252d DIFF: https://github.com/llvm/llvm-project/commit/621f84567920bf5a8d79789f01a622115ec8252d.dif

[Lldb-commits] [PATCH] D82622: [DWARFYAML][debug_info] Replace 'InitialLength' with 'Format' and 'Length'.

2020-06-30 Thread Xing GUO via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGfe08ab542bd6: [DWARFYAML][debug_info] Replace 'InitialLength' with 'Format' and 'Length'. (authored by Higuoxing). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [lldb] fe08ab5 - [DWARFYAML][debug_info] Replace 'InitialLength' with 'Format' and 'Length'.

2020-06-30 Thread Xing GUO via lldb-commits
Author: Xing GUO Date: 2020-06-30T16:28:39+08:00 New Revision: fe08ab542bd6328a7906e38ae473cf655eb6a228 URL: https://github.com/llvm/llvm-project/commit/fe08ab542bd6328a7906e38ae473cf655eb6a228 DIFF: https://github.com/llvm/llvm-project/commit/fe08ab542bd6328a7906e38ae473cf655eb6a228.diff LOG:

[Lldb-commits] [PATCH] D82772: [lldb] Fix type conversion in the Scalar getters

2020-06-30 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Another possibility would be to rename `[US]LongLong` to something like `Get[SZ]ExtInteger` (similar to `APInt::get[SZ]ExtValue`) to make it clear what it does, and ditch the other getter functions. I've mean meaning to move this class away from using host types at some

[Lldb-commits] [PATCH] D82723: Add lldbAPI library to be able to invoke SB API from CommandObjects

2020-06-30 Thread Pavel Labath via Phabricator via lldb-commits
labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. I think this needs a lot more discussion. Before accepting any change like this, I'd like to get consensus on the end goal of this project and the rough steps to get there. As it st

[Lldb-commits] [PATCH] D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files

2020-06-30 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:3424 +if (Host::IsProcessTranslated(process_info)) { + FileSpec rosetta_debugserver("/Library/Apple/usr/libexec/oah/debugserver"); + debugserver_launch_info.SetExe