[Lldb-commits] [PATCH] D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue()

shafik added a comment. We found a way to hand modify the assembly and it looks good, I just need to convert it to a test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85376/new/ https://reviews.llvm.org/D85376 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages.

vsk added a comment. In D85705#2211607 , @clayborg wrote: > In D85705#2211073 , @vsk wrote: > >> This looks very cool, thanks @clayborg! I think using JSON to describe the >> trace data (what kind of trace is

[Lldb-commits] [PATCH] D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue()

shafik added a comment. In D85376#2209638 , @labath wrote: > This manifested itself for variables in registers because those end up being > described as `eValueTypeScalar`, is that so? > > If that's the case, then I think this would also manifest for

[Lldb-commits] [PATCH] D85770: Build a flat LLDB.framework for embedded Darwin targets

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks! Comment at: lldb/cmake/modules/LLDBFramework.cmake:6-37 +if(NOT APPLE_EMBEDDED) + set_target_properties(liblldb PROPERTIES +FRAMEWORK ON +

[Lldb-commits] [PATCH] D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages.

clayborg added a comment. In D85705#2211073 , @vsk wrote: > This looks very cool, thanks @clayborg! I think using JSON to describe the > trace data (what kind of trace is this, what's in it, etc.) sounds reasonable. > >> For "trace load", I get the

[Lldb-commits] [PATCH] D85770: Build a flat LLDB.framework for embedded Darwin targets

vsk added inline comments. Comment at: lldb/cmake/modules/LLDBFramework.cmake:6-37 +if(NOT APPLE_EMBEDDED) + set_target_properties(liblldb PROPERTIES +FRAMEWORK ON +FRAMEWORK_VERSION ${LLDB_FRAMEWORK_VERSION} - OUTPUT_NAME LLDB - VERSION ${LLDB_VERSION} -

[Lldb-commits] [lldb] 479f5bf - [LLDB] Improve PDB discovery

Author: Adrian McCarthy Date: 2020-08-11T13:44:14-07:00 New Revision: 479f5bfdb02b191f03b3de1a7c3d5a5098b3fcaf URL: https://github.com/llvm/llvm-project/commit/479f5bfdb02b191f03b3de1a7c3d5a5098b3fcaf DIFF:

[Lldb-commits] [lldb] 254e0ab - [lldb] Fix the last remaining tests not inheriting TCC permissions

Author: Jonas Devlieghere Date: 2020-08-11T12:50:36-07:00 New Revision: 254e0abf5be2e98cb7f1fa52617b71f4b94b11a4 URL: https://github.com/llvm/llvm-project/commit/254e0abf5be2e98cb7f1fa52617b71f4b94b11a4 DIFF:

[Lldb-commits] [PATCH] D85770: Build a flat LLDB.framework for embedded Darwin targets

JDevlieghere added inline comments. Comment at: lldb/cmake/modules/LLDBFramework.cmake:6-37 +if(NOT APPLE_EMBEDDED) + set_target_properties(liblldb PROPERTIES +FRAMEWORK ON +FRAMEWORK_VERSION ${LLDB_FRAMEWORK_VERSION} - OUTPUT_NAME LLDB - VERSION ${LLDB_VERSION} -

[Lldb-commits] [PATCH] D85770: Build a flat LLDB.framework for embedded Darwin targets

vsk created this revision. vsk added reviewers: JDevlieghere, davide, friss. Herald added a subscriber: mgorny. Herald added a project: LLDB. vsk requested review of this revision. This patch configures LLDB.framework to build as a flat unversioned framework on non-macOS Darwin targets, which

[Lldb-commits] [PATCH] D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages.

vsk added a comment. This looks very cool, thanks @clayborg! I think using JSON to describe the trace data (what kind of trace is this, what's in it, etc.) sounds reasonable. > For "trace load", I get the plugin for the JSON file by matching it up with > the "name" field in the JSON, but I

[Lldb-commits] [lldb] 61afdf0 - [lldb] Enable inheriting TCC permissions in lldb-test

Author: Jonas Devlieghere Date: 2020-08-11T11:37:14-07:00 New Revision: 61afdf0ab43f1aec93d3d482cd3d1d95c537aefe URL: https://github.com/llvm/llvm-project/commit/61afdf0ab43f1aec93d3d482cd3d1d95c537aefe DIFF:

[Lldb-commits] [PATCH] D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages.

clayborg added a comment. The idea for the JSON file is that it must have a "name" (or maybe "plug-in"?) to identify which trace plug-in and a "trace-file" at the very least: { "name": "intel-pt", "trace-file": "/tmp/trace-info" } The "name" field would match the name of the

[Lldb-commits] [PATCH] D85758: [lldb] Make several attempts to read the PID in TestAppleSimulatorOSType

JDevlieghere closed this revision. JDevlieghere added a comment. Forgot the link in the commit message. Landed in 7adf5bd18147b8acdab6e2720b4073e8c35bdf9a Repository: rLLDB LLDB CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 7adf5bd - [lldb] Look beyond the first line to find the PID in TestAppleSimulatorOSType

Author: Jonas Devlieghere Date: 2020-08-11T11:07:04-07:00 New Revision: 7adf5bd18147b8acdab6e2720b4073e8c35bdf9a URL: https://github.com/llvm/llvm-project/commit/7adf5bd18147b8acdab6e2720b4073e8c35bdf9a DIFF:

[Lldb-commits] [PATCH] D85758: [lldb] Make several attempts to read the PID in TestAppleSimulatorOSType

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: lldb/test/API/tools/lldb-server/TestAppleSimulatorOSType.py:66 +for _ in range(0, self.PID_RETRIES): stderr =

[Lldb-commits] [PATCH] D85758: [lldb] Make several attempts to read the PID in TestAppleSimulatorOSType

JDevlieghere created this revision. JDevlieghere added a reviewer: aprantl. JDevlieghere requested review of this revision. The current code fails when the the first attempt to read the PID from stderr doesn't match the given regex. This patch changes the code to make up to 10 attempts.

[Lldb-commits] [PATCH] D85708: [lldb/CMake] Separate CMake code for Lua and Python (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rGc135744b1df3: [lldb/CMake] Separate CMake code for Lua and Python (NFC) (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] c135744 - [lldb/CMake] Separate CMake code for Lua and Python (NFC)

Author: Jonas Devlieghere Date: 2020-08-11T09:04:18-07:00 New Revision: c135744b1df394f51b6a08bc562f99a1236e772c URL: https://github.com/llvm/llvm-project/commit/c135744b1df394f51b6a08bc562f99a1236e772c DIFF:

[Lldb-commits] [PATCH] D82537: [lldb] Deduplicate copy-pasted TypeSystemMap::GetTypeSystemForLanguage

teemperor added reviewers: JDevlieghere, davide. teemperor added a comment. Ping Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82537/new/ https://reviews.llvm.org/D82537 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D84748: [cmake] Make gtest macro definitions a part the library interface

labath added a comment. In D84748#2178809 , @ldionne wrote: > Can you confirm that all the targets that need to "link" (in the CMake sense) > against gtest use the gtest CMake target? I wouldn't use the word "confirm" but I did check that I am able to

[Lldb-commits] [PATCH] D84748: [cmake] Make gtest macro definitions a part the library interface

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbb91c9fe7b62: [cmake] Make gtest macro definitions a part the library interface (authored by labath). Herald added a subscriber: JDevlieghere.

[Lldb-commits] [lldb] bb91c9f - [cmake] Make gtest macro definitions a part the library interface

Author: Pavel Labath Date: 2020-08-11T15:22:44+02:00 New Revision: bb91c9fe7b62939fdb11ae42a31a5d5a61575ae7 URL: https://github.com/llvm/llvm-project/commit/bb91c9fe7b62939fdb11ae42a31a5d5a61575ae7 DIFF: https://github.com/llvm/llvm-project/commit/bb91c9fe7b62939fdb11ae42a31a5d5a61575ae7.diff

[Lldb-commits] [PATCH] D85132: [lldb] Add SubstTemplateTypeParm to RemoveWrappingTypes

This revision was automatically updated to reflect the committed changes. Closed by commit rG950f1bf976b3: [lldb] Add SubstTemplateTypeParm to RemoveWrappingTypes (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to commit:

[Lldb-commits] [lldb] 950f1bf - [lldb] Add SubstTemplateTypeParm to RemoveWrappingTypes

Author: Raphael Isemann Date: 2020-08-11T14:31:47+02:00 New Revision: 950f1bf976b332eca60267b25bf759e2ad564e0c URL: https://github.com/llvm/llvm-project/commit/950f1bf976b332eca60267b25bf759e2ad564e0c DIFF:

[Lldb-commits] [lldb] 4f3559d - [lldb] watchpoint ID common completion for commands `watchpoint delete/enable/disable/modify/ignore`

Author: Gongyu Deng Date: 2020-08-11T14:25:09+02:00 New Revision: 4f3559db1f313eed8bd84377de0fb2300a58125b URL: https://github.com/llvm/llvm-project/commit/4f3559db1f313eed8bd84377de0fb2300a58125b DIFF: https://github.com/llvm/llvm-project/commit/4f3559db1f313eed8bd84377de0fb2300a58125b.diff

[Lldb-commits] [PATCH] D84104: [lldb] watchpoint ID common completion for commands `watchpoint delete/enable/disable/modify/ignore`

This revision was automatically updated to reflect the committed changes. Closed by commit rG4f3559db1f31: [lldb] watchpoint ID common completion for commands `watchpoint… (authored by MrHate, committed by teemperor). Herald added a subscriber: lldb-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D85708: [lldb/CMake] Separate CMake code for Lua and Python (NFC)

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. sounds like a good idea CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85708/new/ https://reviews.llvm.org/D85708 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue()

labath added a comment. This manifested itself for variables in registers because those end up being described as `eValueTypeScalar`, is that so? If that's the case, then I think this would also manifest for variables described via `DW_OP_constu 0xdead, DW_OP_stack_value`. And if *that* is

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

labath added a comment. Slightly late to the party, but I want to point out that there _is_ an escape code for clearing a line: CSI n K -- Erase in Line --Erases part of the line. If n is 0 (or missing), clear from cursor to the end of the line. If n is 1, clear from

[Lldb-commits] [PATCH] D84088: [lldb] thread index common completion for commands like `thread select/step-over`

This revision was automatically updated to reflect the committed changes. Closed by commit rGa952fe236f99: [lldb] thread index common completion for commands like `thread select/step… (authored by MrHate, committed by teemperor). Herald added a subscriber: lldb-commits. Changed prior to commit:

[Lldb-commits] [lldb] a952fe2 - [lldb] thread index common completion for commands like `thread select/step-over`

Author: Gongyu Deng Date: 2020-08-11T13:27:13+02:00 New Revision: a952fe236f993b531eceb89e0a18d25bba048185 URL: https://github.com/llvm/llvm-project/commit/a952fe236f993b531eceb89e0a18d25bba048185 DIFF: https://github.com/llvm/llvm-project/commit/a952fe236f993b531eceb89e0a18d25bba048185.diff

[Lldb-commits] [lldb] b2b7dbb - [lldb] stop-hook ID common completion for commands `target stop-hook enable/disable/delete'

Author: Gongyu Deng Date: 2020-08-11T13:14:27+02:00 New Revision: b2b7dbb47aa9aff1252d4440bb9986df5a7e67cb URL: https://github.com/llvm/llvm-project/commit/b2b7dbb47aa9aff1252d4440bb9986df5a7e67cb DIFF: https://github.com/llvm/llvm-project/commit/b2b7dbb47aa9aff1252d4440bb9986df5a7e67cb.diff

[Lldb-commits] [PATCH] D84123: [lldb] stop-hook ID common completion for commands `target stop-hook enable/disable/delete'

This revision was automatically updated to reflect the committed changes. Closed by commit rGb2b7dbb47aa9: [lldb] stop-hook ID common completion for commands `target stop-hook… (authored by MrHate, committed by teemperor). Herald added a subscriber: lldb-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D85641: [LLDB] Convert SVE macros into c++ constants and inlines

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I originally thought we would keep the original macro capitalization (similar to how `llvm/BinaryFormat/elf.h` maintains the elf.h capitalizations even though it does not define these symbols

[Lldb-commits] [lldb] 33d0031 - [lldb] Fix unhandled switch case for GOFF in GDBRemoteCommunicationClient

Author: Raphael Isemann Date: 2020-08-11T12:57:18+02:00 New Revision: 33d0031edba2483579b875fc20171cafef2f6a64 URL: https://github.com/llvm/llvm-project/commit/33d0031edba2483579b875fc20171cafef2f6a64 DIFF:

[Lldb-commits] [PATCH] D84815: [LLDB] Improve PDB discovery

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D84815#2203802 , @amccarth wrote: > I tried but failed to make a negative test. LLDB sends the errors message to > stderr when the `target modules

[Lldb-commits] [PATCH] D85719: Initialize static const fields in the AST for expression evaluation

teemperor added a comment. There is actually https://reviews.llvm.org/D81471 that makes this fully work, but it's still waiting on someone to review it :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85719/new/ https://reviews.llvm.org/D85719

[Lldb-commits] [lldb] 419f1be - [lldb] tab completion for `target modules load -u`

Author: Gongyu Deng Date: 2020-08-11T12:35:36+02:00 New Revision: 419f1be7b54ef2c285050c24e4b4c333cb108cfc URL: https://github.com/llvm/llvm-project/commit/419f1be7b54ef2c285050c24e4b4c333cb108cfc DIFF: https://github.com/llvm/llvm-project/commit/419f1be7b54ef2c285050c24e4b4c333cb108cfc.diff

[Lldb-commits] [PATCH] D85289: [DWARFYAML][debug_info] Rename some mapping keys. NFC.

labath added a comment. Sorry about the delay, I was OOO. I think that making these consistent with the DWARF spec is a good idea. It's true that this makes `DebugAbbrevOffset` a bit longish. I could also live with just `AbbrevOffset`, but I think the longer version is also fine for two

[Lldb-commits] [PATCH] D85719: Initialize static const fields in the AST for expression evaluation

jarin created this revision. jarin added a reviewer: teemperor. jarin added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a reviewer: shafik. jarin requested review of this revision. This patch is for discussion. Currently, the evaluator does not know about

[Lldb-commits] [lldb] 66fa73f - [lldb] move the frame index completion into a common completion and apply it to `thread backtrace -s`

Author: Gongyu Deng Date: 2020-08-11T12:25:39+02:00 New Revision: 66fa73fa27991c2c12a4cc83143ed1f81874ded5 URL: https://github.com/llvm/llvm-project/commit/66fa73fa27991c2c12a4cc83143ed1f81874ded5 DIFF: https://github.com/llvm/llvm-project/commit/66fa73fa27991c2c12a4cc83143ed1f81874ded5.diff

[Lldb-commits] [PATCH] D83309: [lldb] tab completion for `target modules search-paths insert​`

This revision was automatically updated to reflect the committed changes. Closed by commit rG24bc8afd4baf: [lldb] tab completion for `target modules search-paths insert​` (authored by MrHate, committed by teemperor). Herald added a subscriber: lldb-commits. Changed prior to commit:

[Lldb-commits] [lldb] 24bc8af - [lldb] tab completion for `target modules search-paths insert​`

Author: Gongyu Deng Date: 2020-08-11T11:58:14+02:00 New Revision: 24bc8afd4baf703be7f4f4d70745d7680ceb54e2 URL: https://github.com/llvm/llvm-project/commit/24bc8afd4baf703be7f4f4d70745d7680ceb54e2 DIFF: https://github.com/llvm/llvm-project/commit/24bc8afd4baf703be7f4f4d70745d7680ceb54e2.diff

[Lldb-commits] [PATCH] D85275: [RFC/WIP] Fix the assumption that m_arguments in ProcessInfo does not include arg0

labath added a comment. I agree this should be cleaned up. I don't have any strong opinions on how this should work. IIUC, this patch goes in direction of making m_args always not contain argv[0]. That is probably fine -- if nothing else, it makes the class match the lldb settings (which have

[Lldb-commits] [lldb] 3ce57e0 - [lldb] type language common completion

Author: Gongyu Deng Date: 2020-08-11T11:07:19+02:00 New Revision: 3ce57e012110519c1d3a49fc98959a64634d5d8f URL: https://github.com/llvm/llvm-project/commit/3ce57e012110519c1d3a49fc98959a64634d5d8f DIFF: https://github.com/llvm/llvm-project/commit/3ce57e012110519c1d3a49fc98959a64634d5d8f.diff

Re: [Lldb-commits] [lldb] a06c28d - Temporarily revert "[test] Exit with an error if no tests are run."

On 04/08/2020 17:34, Jordan Rupprecht via lldb-commits wrote: > Thanks, that explains it! Namely this part: > > if sys.platform.startswith('win32'): >     # llvm.org/pr22274 : need a pexpect > replacement for windows >     class PExpectTest(object): >         pass > else:

[Lldb-commits] [PATCH] D81128: [lldb] tab completion for 'command delete/unalias'

This revision was automatically updated to reflect the committed changes. Closed by commit rG31fd64ac57a2: [lldb] tab completion for command delete/unalias (authored by MrHate, committed by teemperor). Herald added a subscriber: lldb-commits. Changed prior to commit:

[Lldb-commits] [lldb] 31fd64a - [lldb] tab completion for 'command delete/unalias'

Author: Gongyu Deng Date: 2020-08-11T10:27:04+02:00 New Revision: 31fd64ac57a2005c0691b8870e28b4421cf67047 URL: https://github.com/llvm/llvm-project/commit/31fd64ac57a2005c0691b8870e28b4421cf67047 DIFF: https://github.com/llvm/llvm-project/commit/31fd64ac57a2005c0691b8870e28b4421cf67047.diff

[Lldb-commits] [lldb] df91606 - [lldb][NFC] Fix warning in Thread::AutoCompleteThreadPlans

Author: Raphael Isemann Date: 2020-08-11T10:26:01+02:00 New Revision: df916062c885f9b010f8348c87e9effae06a10c4 URL: https://github.com/llvm/llvm-project/commit/df916062c885f9b010f8348c87e9effae06a10c4 DIFF:

[Lldb-commits] [lldb] f99a18b - [lldb] tab completion for `thread plan discard`

Author: Gongyu Deng Date: 2020-08-11T10:08:16+02:00 New Revision: f99a18bbaa02037b8f2e9fc066d50e2373b5017e URL: https://github.com/llvm/llvm-project/commit/f99a18bbaa02037b8f2e9fc066d50e2373b5017e DIFF: https://github.com/llvm/llvm-project/commit/f99a18bbaa02037b8f2e9fc066d50e2373b5017e.diff

[Lldb-commits] [PATCH] D83234: [lldb] tab completion for `thread plan discard`

This revision was automatically updated to reflect the committed changes. Closed by commit rGf99a18bbaa02: [lldb] tab completion for `thread plan discard` (authored by MrHate, committed by teemperor). Herald added a subscriber: lldb-commits. Changed prior to commit:

[Lldb-commits] [lldb] 51117e3 - [lldb][NFC] Remove unused custom reimplementation of realpath for Windows

Author: Raphael Isemann Date: 2020-08-11T10:04:42+02:00 New Revision: 51117e3c51754f3732ee34758310a0abc6fd3b75 URL: https://github.com/llvm/llvm-project/commit/51117e3c51754f3732ee34758310a0abc6fd3b75 DIFF:

[Lldb-commits] [PATCH] D85633: [lldb][NFC] Remove unused custom reimplementation of realpath for Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG51117e3c5175: [lldb][NFC] Remove unused custom reimplementation of realpath for Windows (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG

[Lldb-commits] [lldb] 8a5e296 - [lldb] tab completion for `disassemble -F`

Author: Gongyu Deng Date: 2020-08-11T10:01:45+02:00 New Revision: 8a5e296975b3da5d5d849ae8185ef3d98ca77795 URL: https://github.com/llvm/llvm-project/commit/8a5e296975b3da5d5d849ae8185ef3d98ca77795 DIFF: https://github.com/llvm/llvm-project/commit/8a5e296975b3da5d5d849ae8185ef3d98ca77795.diff

[Lldb-commits] [PATCH] D84177: [lldb] tab completion for `watchpoint set variable`

This revision was automatically updated to reflect the committed changes. Closed by commit rG2e653327e364: [lldb] tab completion for `watchpoint set variable` (authored by MrHate, committed by teemperor). Herald added a subscriber: lldb-commits. Changed prior to commit:

[Lldb-commits] [lldb] 2e65332 - [lldb] tab completion for `watchpoint set variable`

Author: Gongyu Deng Date: 2020-08-11T09:51:55+02:00 New Revision: 2e653327e364aae564209af99d3b6a4625e25b68 URL: https://github.com/llvm/llvm-project/commit/2e653327e364aae564209af99d3b6a4625e25b68 DIFF: https://github.com/llvm/llvm-project/commit/2e653327e364aae564209af99d3b6a4625e25b68.diff

[Lldb-commits] [PATCH] D85708: [lldb/CMake] Separate CMake code for Lua and Python (NFC)

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added a subscriber: mgorny. JDevlieghere requested review of this revision. Separate the CMake logic for Lua and Python to clearly distinguish between code specific to either scripting language and the code shared by