[Lldb-commits] [PATCH] D83116: [DWARFYAML] Add support for referencing different abbrev tables.

Higuoxing added a comment. Comment at: llvm/include/llvm/ObjectYAML/DWARFEmitter.h:34 +private: + Data + std::map AbbrevID2Index; labath wrote: > jhenderson wrote: > > Would it make any sense to merge the `DWARFYAML::Data` class and > >

[Lldb-commits] [PATCH] D86216: [lldb] Forcefully complete a type when adding typedefs

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86216/new/ https://reviews.llvm.org/D86216

[Lldb-commits] [PATCH] D86261: Add hashing of the .text section to ProcessMinidump.

clayborg created this revision. clayborg added reviewers: labath, jhenderson, aadsm, wallace. Herald added a project: LLDB. clayborg requested review of this revision. Herald added a subscriber: JDevlieghere. Breakpad will always have a UUID for binaries when it creates minidump files. If an ELF

[Lldb-commits] [lldb] a6eb70c - [lldb] Return empty string from getExtraMakeArgs when not implemented

Author: Jonas Devlieghere Date: 2020-08-19T17:52:50-07:00 New Revision: a6eb70c052da767aef6b041d0db20bdf3a9e06b5 URL: https://github.com/llvm/llvm-project/commit/a6eb70c052da767aef6b041d0db20bdf3a9e06b5 DIFF:

[Lldb-commits] [lldb] 09ca3f4 - [lldb] Update TestSimulatorPlatform.py to set ARCH_CFLAGS instead of TRIPLE

Author: Jonas Devlieghere Date: 2020-08-19T15:42:44-07:00 New Revision: 09ca3f41bbc5c2c4480accd6404f61bd9e5172a5 URL: https://github.com/llvm/llvm-project/commit/09ca3f41bbc5c2c4480accd6404f61bd9e5172a5 DIFF:

[Lldb-commits] [PATCH] D86244: [lldb] Update TestSimulatorPlatform.py now that the Makefile no longer decomposes the TRIPLE

This revision was automatically updated to reflect the committed changes. Closed by commit rG09ca3f41bbc5: [lldb] Update TestSimulatorPlatform.py to set ARCH_CFLAGS instead of TRIPLE (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D86242: [lldb/interpreter] Add REPL-specific init file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG868b45b5b31d: [lldb/interpreter] Add REPL-specific init file (authored by mib). Changed prior to commit:

[Lldb-commits] [lldb] 868b45b - [lldb/interpreter] Add REPL-specific init file

Author: Med Ismail Bennani Date: 2020-08-20T00:36:32+02:00 New Revision: 868b45b5b31d1203cab09ae0306f4c47e6070f68 URL: https://github.com/llvm/llvm-project/commit/868b45b5b31d1203cab09ae0306f4c47e6070f68 DIFF:

[Lldb-commits] [PATCH] D86242: [lldb/interpreter] Add REPL-specific init file

JDevlieghere accepted this revision. JDevlieghere added inline comments. This revision is now accepted and ready to land. Comment at: lldb/docs/man/lldb.rst:314 +If launched with a `REPL`_ option, it will first look for a REPL configuration +file, specific to the REPL language.

[Lldb-commits] [PATCH] D86242: [lldb/interpreter] Add REPL-specific init file

mib updated this revision to Diff 286674. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86242/new/ https://reviews.llvm.org/D86242 Files: lldb/docs/man/lldb.rst lldb/include/lldb/API/SBCommandInterpreter.h

[Lldb-commits] [PATCH] D86242: [lldb/interpreter] Add REPL-specific init file

mib updated this revision to Diff 286673. mib added a comment. Update man page to reflect current implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86242/new/ https://reviews.llvm.org/D86242 Files: lldb/docs/man/lldb.rst

[Lldb-commits] [PATCH] D85539: [lldb] Extend builder to pass the TRIPLE spec to Make

jankratochvil added a comment. It broke the Debian buildbot: http://lab.llvm.org:8011/builders/lldb-x86_64-debian/builds/16095 And also Fedora (although there the commit looks as a different one): http://lab.llvm.org:8014/builders/lldb-x86_64-fedora?numbuilds=1 Repository: rG LLVM

[Lldb-commits] [PATCH] D86242: [lldb/interpreter] Add REPL-specific init file

mib added inline comments. Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2183 /// whose name is "~/.lldbinit" followed by a "-" and the name of the program. -/// If this file doesn't exist, we fall back to just the "~/.lldbinit" file. -void

[Lldb-commits] [PATCH] D86242: [lldb/interpreter] Add REPL-specific init file

JDevlieghere added inline comments. Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2183 /// whose name is "~/.lldbinit" followed by a "-" and the name of the program. -/// If this file doesn't exist, we fall back to just the "~/.lldbinit" file. -void

[Lldb-commits] [PATCH] D86244: [lldb] Update TestSimulatorPlatform.py now that the Makefile no longer decomposes the TRIPLE

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. I just learned that we no longer compute SDKROOT in Makefile.rules, so this seems resonable. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86244/new/

[Lldb-commits] [PATCH] D86242: [lldb/interpreter] Add REPL-specific init file

mib updated this revision to Diff 286660. mib marked an inline comment as done. mib retitled this revision from "[lldb/interpreter] Add REPL-specific init file." to "[lldb/interpreter] Add REPL-specific init file". mib edited the summary of this revision. mib added a comment. Addressed

[Lldb-commits] [PATCH] D86235: Fix swig scripts install target name

JDevlieghere added a comment. In D86235#2227052 , @aadsm wrote: > @JDevlieghere thanks for the quick review, but on the name I mean the actual > `finish_swig_python_scripts`, this sounds like a step name and not a > component distributed by llvm like

[Lldb-commits] [PATCH] D86242: [lldb/interpreter] Add REPL-specific init file.

mib added inline comments. Comment at: lldb/docs/man/lldb.rst:312 First, it will read the application specific init file whose name is ~/.lldbinit followed by a "-" and the name of the current program. This would JDevlieghere wrote: > I wonder if we should

[Lldb-commits] [PATCH] D86235: Fix swig scripts install target name

aadsm added a comment. @JDevlieghere thanks for the quick review, but on the name I mean the actual `finish_swig_python_scripts`, this sounds like a step name and not a component distributed by llvm like `liblldb` ot `lldb-server`. That was the reason at the time I named it

[Lldb-commits] [PATCH] D86244: [lldb] Update TestSimulatorPlatform.py now that the Makefile no longer decomposes the TRIPLE

JDevlieghere created this revision. JDevlieghere added a reviewer: aprantl. JDevlieghere requested review of this revision. We move the triple (de)composition logic into the builder in e5d08fcbac72 but this test is relying on

[Lldb-commits] [lldb] a3fc61c - [lldb] Move Xcode SDK helper functions into lldbutil

Author: Jonas Devlieghere Date: 2020-08-19T13:30:27-07:00 New Revision: a3fc61c80f89ea709a1128caa2de2723fe307c81 URL: https://github.com/llvm/llvm-project/commit/a3fc61c80f89ea709a1128caa2de2723fe307c81 DIFF:

[Lldb-commits] [PATCH] D86242: [lldb/interpreter] Add REPL-specific init file.

JDevlieghere added inline comments. Comment at: lldb/docs/man/lldb.rst:312 First, it will read the application specific init file whose name is ~/.lldbinit followed by a "-" and the name of the current program. This would I wonder if we should have the

[Lldb-commits] [PATCH] D86242: [lldb/interpreter] Add REPL-specific init file.

mib updated this revision to Diff 286648. mib added a comment. Fixed typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86242/new/ https://reviews.llvm.org/D86242 Files: lldb/docs/man/lldb.rst lldb/include/lldb/API/SBCommandInterpreter.h

[Lldb-commits] [PATCH] D86242: [lldb/interpreter] Add REPL-specific init file.

mib created this revision. mib added reviewers: JDevlieghere, jingham. mib added a project: LLDB. Herald added a subscriber: lldb-commits. mib requested review of this revision. This patch adds the infrostructure to add language specific REPL init files. It's the foundation work to a following

[Lldb-commits] [PATCH] D85988: Fix the ability to list iOS simulator processes.

clayborg added a comment. In D85988#2226911 , @JDevlieghere wrote: > In D85988#2226889 , @clayborg wrote: > >> In D85988#2226496 , @aprantl wrote: >> >>> In D85988#616

[Lldb-commits] [PATCH] D85988: Fix the ability to list iOS simulator processes.

JDevlieghere added a comment. In D85988#2226889 , @clayborg wrote: > In D85988#2226496 , @aprantl wrote: > >> In D85988#616 , @clayborg wrote: >> >>> Adrian: is there

[Lldb-commits] [lldb] 9f5210a - [lldb] Print the load command that wasn't found in TestSimulatorPlatform

Author: Jonas Devlieghere Date: 2020-08-19T12:42:59-07:00 New Revision: 9f5210aacfec8602beb60f309389e2261b4d3c75 URL: https://github.com/llvm/llvm-project/commit/9f5210aacfec8602beb60f309389e2261b4d3c75 DIFF:

[Lldb-commits] [PATCH] D85988: Fix the ability to list iOS simulator processes.

clayborg added a comment. In D85988#2226496 , @aprantl wrote: > In D85988#616 , @clayborg wrote: > >> Adrian: is there something I need to do to enable simulator tests? I added a >> test to

[Lldb-commits] [lldb] b40a381 - [lldb] Code sign binaries with entitlements

Author: Jonas Devlieghere Date: 2020-08-19T11:55:36-07:00 New Revision: b40a3814b6fd0c784b52622eddac56d7c321d7cc URL: https://github.com/llvm/llvm-project/commit/b40a3814b6fd0c784b52622eddac56d7c321d7cc DIFF:

[Lldb-commits] [PATCH] D86237: [lldb] Code sign binaries with entitlements

This revision was automatically updated to reflect the committed changes. Closed by commit rGb40a3814b6fd: [lldb] Code sign binaries with entitlements (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D86237: [lldb] Code sign binaries with entitlements

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86237/new/ https://reviews.llvm.org/D86237 ___

[Lldb-commits] [PATCH] D86237: [lldb] Code sign binaries with entitlements

JDevlieghere created this revision. JDevlieghere added a reviewer: jasonmolenda. JDevlieghere requested review of this revision. Binaries need to be code signed to run on device. Repository: rLLDB LLDB https://reviews.llvm.org/D86237 Files:

[Lldb-commits] [lldb] e5d08fc - [lldb] Extend Darwin builder to pass the ARCH_CFLAGS spec to Make.

Author: Jonas Devlieghere Date: 2020-08-19T11:47:29-07:00 New Revision: e5d08fcbac722d487973d9c96838c0589f1953c3 URL: https://github.com/llvm/llvm-project/commit/e5d08fcbac722d487973d9c96838c0589f1953c3 DIFF:

[Lldb-commits] [PATCH] D85539: [lldb] Extend builder to pass the TRIPLE spec to Make

This revision was automatically updated to reflect the committed changes. Closed by commit rGe5d08fcbac72: [lldb] Extend Darwin builder to pass the ARCH_CFLAGS spec to Make. (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D84974: Enable Launching the Debugee in VSCode Terminal

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. All of the code looks good now and we need to add a test. This means we will need to modify vscode.py in the test suite to be able to received the reverse request and just

[Lldb-commits] [PATCH] D86235: Fix swig scripts install target name

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. No reason other than consistency by always appending to the given target. I didn't think of the requirement for the `install-`prefix. LGTM! Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D84974: Enable Launching the Debugee in VSCode Terminal

aelitashen added a comment. I tried rebase onto the commit that Walter created just for formatting but I am not sure why it didn't remove those formatting noise.. Comment at: lldb/tools/lldb-vscode/VSCode.cpp:410 + +VSCode::PacketStatus

[Lldb-commits] [PATCH] D84974: Enable Launching the Debugee in VSCode Terminal

aelitashen updated this revision to Diff 286620. aelitashen added a comment. Refactor code and optimize logic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84974/new/ https://reviews.llvm.org/D84974 Files: lldb/tools/lldb-vscode/VSCode.cpp

[Lldb-commits] [PATCH] D86235: Fix swig scripts install target name

aadsm created this revision. aadsm added reviewers: JDevlieghere, wallace, clayborg. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. aadsm requested review of this revision. LLVM install component targets needs to be in the form of: install-{target}[-stripped] I

[Lldb-commits] [PATCH] D86110: [WIP][DebugInfo] Lazily parse debug_loclist offsets

dblaikie added a comment. In D86110#2225970 , @labath wrote: > In D86110#2224163 , @dblaikie wrote: > >> In D86110#2223905 , @labath wrote: >> >>> This sounds perfectly

[Lldb-commits] [PATCH] D85988: Fix the ability to list iOS simulator processes.

aprantl added a comment. In D85988#616 , @clayborg wrote: > Adrian: is there something I need to do to enable simulator tests? I added a > test to TestSimulatorPlatform.py but if I run: > > $ ../debug/bin/llvm-lit -sv lldb/test/API/macosx/simulator

[Lldb-commits] [lldb] 074c591 - [lldb] Add getExtraMakeArgs to Builder (NFC)

Author: Jonas Devlieghere Date: 2020-08-19T09:47:25-07:00 New Revision: 074c591a7e9b366582dfc8dc127dd8df2ab1ac99 URL: https://github.com/llvm/llvm-project/commit/074c591a7e9b366582dfc8dc127dd8df2ab1ac99 DIFF:

[Lldb-commits] [lldb] 804691a - [lldb] Fix buildDsym signature in Builder base class

Author: Jonas Devlieghere Date: 2020-08-19T09:47:25-07:00 New Revision: 804691adc9c93eb2ac68baf531e1a6f8b6fdb0c1 URL: https://github.com/llvm/llvm-project/commit/804691adc9c93eb2ac68baf531e1a6f8b6fdb0c1 DIFF:

[Lldb-commits] [PATCH] D86220: [lldb/Utility] Simplify Scalar handling of float types

JDevlieghere accepted this revision. JDevlieghere added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Utility/Scalar.cpp:68 +Scalar::PromotionKey Scalar::GetFloatPromoKey(const llvm::fltSemantics ) { + static const llvm::fltSemantics

[Lldb-commits] [lldb] b623f3c - [lldb] Move builders under lldbsuite.test as they import lldbtest (NFC)

Author: Jonas Devlieghere Date: 2020-08-19T09:07:51-07:00 New Revision: b623f3c0b41aee2984e54bf7a4909532faacc426 URL: https://github.com/llvm/llvm-project/commit/b623f3c0b41aee2984e54bf7a4909532faacc426 DIFF:

[Lldb-commits] [lldb] 1922bf1 - [lldb] Convert builders to use inheritance (NFC)

Author: Jonas Devlieghere Date: 2020-08-19T08:44:29-07:00 New Revision: 1922bf12e1f3f228c0f57b27c796ebea4a50c358 URL: https://github.com/llvm/llvm-project/commit/1922bf12e1f3f228c0f57b27c796ebea4a50c358 DIFF:

[Lldb-commits] [PATCH] D86174: [lldb] Convert builders to classes so we can use inheritance to override platform specific methods (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG1922bf12e1f3: [lldb] Convert builders to use inheritance (NFC) (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D86174?vs=286454=286571#toc

[Lldb-commits] [PATCH] D86220: [lldb/Utility] Simplify Scalar handling of float types

labath created this revision. labath added reviewers: JDevlieghere, teemperor. Herald added a project: LLDB. labath requested review of this revision. Similarly to D85836 , collapse all Scalar float types to a single enum value, and use APFloat semantics to

[Lldb-commits] [PATCH] D86216: [lldb] Forcefully complete a type when adding typedefs

labath created this revision. labath added reviewers: teemperor, shafik. Herald added a project: LLDB. labath requested review of this revision. Herald added a subscriber: JDevlieghere. This is very similar to D85968 , only more elusive to since we were not

[Lldb-commits] [lldb] 9cc2f13 - [lldb] Clean up DW_AT_declaration-with-children.s test

Author: Pavel Labath Date: 2020-08-19T14:58:50+02:00 New Revision: 9cc2f13deeb30de3a2ce1854c36f6c0a8de86d6c URL: https://github.com/llvm/llvm-project/commit/9cc2f13deeb30de3a2ce1854c36f6c0a8de86d6c DIFF: https://github.com/llvm/llvm-project/commit/9cc2f13deeb30de3a2ce1854c36f6c0a8de86d6c.diff

[Lldb-commits] [PATCH] D86140: [lldb] Add typedefs to the DeclContext they are created in

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd7363397c669: [lldb] Add typedefs to the DeclContext they are created in (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [lldb] d736339 - [lldb] Add typedefs to the DeclContext they are created in

Author: Pavel Labath Date: 2020-08-19T14:57:43+02:00 New Revision: d7363397c669f611e379988ea12fb428847fce61 URL: https://github.com/llvm/llvm-project/commit/d7363397c669f611e379988ea12fb428847fce61 DIFF: https://github.com/llvm/llvm-project/commit/d7363397c669f611e379988ea12fb428847fce61.diff

[Lldb-commits] [PATCH] D85968: [lldb] Forcefully complete a type when adding nested classes

labath added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/DW_AT_declaration-with-children.s:7 -# RUN: llvm-mc --triple x86_64-pc-linux %s --filetype=obj > %t -# RUN: %lldb %t -o "expr a" -o exit 2>&1 | FileCheck %s --check-prefix=EXPR -# RUN: %lldb %t -o

[Lldb-commits] [PATCH] D82853: [LLDB] Support custom expedited register set in gdb-remote

labath added a comment. Looking at the dependent patch, I see that you need to conjure up a fake register set to make this work. That works, but doesn't seem entirely optimal. This expedition function doesn't really care about register sets, it just needs a way to get a list of registers. What

[Lldb-commits] [PATCH] D82865: [LLDB] Add GetByteOffset to SBValue interface for reading register offset

labath added a comment. The new API looks fairly confusing. This doesn't sound like something that the SB users should generally know or care about. What would the GetByteOffset function return in the generic case? I don't find the explanation in the summary convincing. Presumably, you should

[Lldb-commits] [PATCH] D85539: [lldb] Extend builder to pass the TRIPLE spec to Make

labath accepted this revision. labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/builders/builder.py:201-202 self.getCCSpec(compiler), self.getDsymutilSpec(), +self.getCodesignSpec(),

[Lldb-commits] [PATCH] D86110: [WIP][DebugInfo] Lazily parse debug_loclist offsets

labath added a comment. In D86110#2224163 , @dblaikie wrote: > In D86110#2223905 , @labath wrote: > >> This sounds perfectly reasonable to me. The offsets are present in memory >> already so there's no point in

[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

srj added inline comments. Comment at: llvm/include/llvm/Config/config.h.cmake:212 /* Define if the setupterm() function is supported this platform. */ -#cmakedefine HAVE_TERMINFO ${HAVE_TERMINFO} +#cmakedefine LLVM_ENABLE_TERMINFO ${LLVM_ENABLE_TERMINFO} srj

[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

gribozavr2 added a comment. @haampie It looks like this change caused a build problem with OCaml enabled. Before: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/34606 After: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/34607 Could you take a look?

[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

haampie added inline comments. Comment at: llvm/include/llvm/Config/config.h.cmake:212 /* Define if the setupterm() function is supported this platform. */ -#cmakedefine HAVE_TERMINFO ${HAVE_TERMINFO} +#cmakedefine LLVM_ENABLE_TERMINFO ${LLVM_ENABLE_TERMINFO}

[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

srj added inline comments. Comment at: llvm/include/llvm/Config/config.h.cmake:212 /* Define if the setupterm() function is supported this platform. */ -#cmakedefine HAVE_TERMINFO ${HAVE_TERMINFO} +#cmakedefine LLVM_ENABLE_TERMINFO ${LLVM_ENABLE_TERMINFO} In

[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

srj added a comment. This seems to have injected a link-time dependency on `setupterm` etc. even if you configure CMake with LLVM_ENABLE_TERMINFO=OFF (which was not the case before) -- this is breaking some builds of Halide as a result. (Should the `#idef LLVM_ENABLE_TERMINFO` actually if

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

haampie added inline comments. Comment at: llvm/lib/Support/CMakeLists.txt:217 + endif() + if(CMAKE_SHARED_LIBRARY_PREFIX AND CMAKE_SHARED_LIBRARY_SUFFIX AND + zlib_library MATCHES "^${CMAKE_SHARED_LIBRARY_PREFIX}.*${CMAKE_SHARED_LIBRARY_SUFFIX}$") This

[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

yehenrytian added a comment. It looks like this change is causing a "regression" for MLIR tests: https://mlir.llvm.org/getting_started/ git clone https://github.com/llvm/llvm-project.git mkdir llvm-project/build cd llvm-project/build cmake -G Ninja ../llvm \

[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

haampie added a comment. @gribozavr2: can you try https://reviews.llvm.org/D86134? It should fix your issue, as well as the same issue w.r.t. the ZLIB changes of https://reviews.llvm.org/D79219 on macOS. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

haampie added a comment. @srj could you please try / review https://reviews.llvm.org/D86173 for a fix for your problem? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85820/new/ https://reviews.llvm.org/D85820

[Lldb-commits] [lldb] c1b1868 - [lldb] Make error messages in TestQueues more helpfull

Author: Raphael Isemann Date: 2020-08-19T13:30:31+02:00 New Revision: c1b1868f35bbb4d6e63515c00eb74d5aeac1aecc URL: https://github.com/llvm/llvm-project/commit/c1b1868f35bbb4d6e63515c00eb74d5aeac1aecc DIFF:

[Lldb-commits] [PATCH] D86174: [lldb] Convert builders to classes so we can use inheritance to override platform specific methods (NFC)

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/packages/Python/lldbsuite/builders/freebsd.py:5-11 +def buildDsym(self, + sender=None, + architecture=None, +

[Lldb-commits] [lldb] bd791e9 - [LLDB] Minor fix in TestSVERegisters.py for AArch64/Linux buildbot

Author: Muhammad Omair Javaid Date: 2020-08-19T15:47:59+05:00 New Revision: bd791e97f8bb0e4bb507bf51850183515ecc6743 URL: https://github.com/llvm/llvm-project/commit/bd791e97f8bb0e4bb507bf51850183515ecc6743 DIFF:

[Lldb-commits] [PATCH] D82855: [LLDB] Send SVE vg register in custom expedited registerset

omjavaid added a comment. @labath ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82855/new/ https://reviews.llvm.org/D82855 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D82855: [LLDB] Send SVE vg register in custom expedited registerset

omjavaid updated this revision to Diff 286525. omjavaid added a comment. This revision updated after rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82855/new/ https://reviews.llvm.org/D82855 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp

[Lldb-commits] [PATCH] D82853: [LLDB] Support custom expedited register set in gdb-remote

omjavaid added a comment. @labath ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82853/new/ https://reviews.llvm.org/D82853 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

omjavaid added a comment. @labath ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82857/new/ https://reviews.llvm.org/D82857 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid added a comment. @labath ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82863/new/ https://reviews.llvm.org/D82863 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D82865: [LLDB] Add GetByteOffset to SBValue interface for reading register offset

omjavaid added a comment. @labath ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82865/new/ https://reviews.llvm.org/D82865 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

This revision was automatically updated to reflect the committed changes. Closed by commit rG567ba6c468b9: [LLDB] Add ptrace register access for AArch64 SVE registers (authored by omjavaid). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] 567ba6c - [LLDB] Add ptrace register access for AArch64 SVE registers

Author: Muhammad Omair Javaid Date: 2020-08-19T15:11:01+05:00 New Revision: 567ba6c468b93accefed944e5a44b1052d3597de URL: https://github.com/llvm/llvm-project/commit/567ba6c468b93accefed944e5a44b1052d3597de DIFF:

[Lldb-commits] [PATCH] D86194: [DWARFYAML] Add support for emitting multiple abbrev tables.

jhenderson accepted this revision. jhenderson added a comment. This revision is now accepted and ready to land. LGTM, except for the new test change - I think that should be in a different patch. Comment at: llvm/test/ObjectYAML/MachO/DWARF-debug_abbrev.yaml:1 +## Test that

[Lldb-commits] [PATCH] D86194: [DWARFYAML] Add support for emitting multiple abbrev tables.

Higuoxing added inline comments. Comment at: llvm/tools/obj2yaml/dwarf2yaml.cpp:26-43 + DWARFYAML::AbbrevTable AbbrevTable; for (auto AbbrvDecl : AbbrvDeclSet.second) { DWARFYAML::Abbrev Abbrv; Abbrv.Code = AbbrvDecl.getCode(); Abbrv.Tag =

[Lldb-commits] [PATCH] D86194: [DWARFYAML] Add support for emitting multiple abbrev tables.

jhenderson added inline comments. Comment at: llvm/lib/ObjectYAML/DWARFEmitter.cpp:100 + for (const DWARFYAML::AbbrevTable : DI.DebugAbbrev) { +for (auto AbbrevDecl : AbbrevTable.Table) { + AbbrevCode = Don't use `auto` here. It's not obvious what the

[Lldb-commits] [PATCH] D85539: [lldb] Extend builder to pass the TRIPLE spec to Make

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. This looks good to me, getting any logic out of the Makefile templates that we can, that's a good improvement for maintainability. CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] af4f40c - [LLDB] NativeThreadLinux invalidate register cache on stop

Author: Muhammad Omair Javaid Date: 2020-08-19T12:30:38+05:00 New Revision: af4f40c376f5f05ec1b7cc72840518e917eaf091 URL: https://github.com/llvm/llvm-project/commit/af4f40c376f5f05ec1b7cc72840518e917eaf091 DIFF:

[Lldb-commits] [PATCH] D84501: NativeThreadLinux invalidate register cache on stop

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf4f40c376f5: [LLDB] NativeThreadLinux invalidate register cache on stop (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 090306f - Convert SVE macros into c++ constants and inlines

Author: Muhammad Omair Javaid Date: 2020-08-19T12:28:16+05:00 New Revision: 090306fc80dbf3e524d0ce4a7c39e0852f0ba144 URL: https://github.com/llvm/llvm-project/commit/090306fc80dbf3e524d0ce4a7c39e0852f0ba144 DIFF:

[Lldb-commits] [PATCH] D85641: [LLDB] Convert SVE macros into c++ constants and inlines

This revision was automatically updated to reflect the committed changes. Closed by commit rG090306fc80db: Convert SVE macros into c++ constants and inlines (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D86194: [DWARFYAML] Add support for emitting multiple abbrev tables.

Higuoxing added inline comments. Comment at: llvm/lib/ObjectYAML/DWARFEmitter.cpp:259-265 + if (AbbrevTable.empty()) +return createStringError( +errc::invalid_argument, +"non-empty compilation unit should have an associated abbrev table"); + + ArrayRef

[Lldb-commits] [PATCH] D86194: [DWARFYAML] Add support for emitting multiple abbrev tables.

Higuoxing added a comment. Modified tests: test/tools/yaml2obj/ELF/debug-abbrev.yaml: Add one more abbrev table in test case (a). test/tools/yaml2obj/ELF/debug-info.yaml: Add test case (n). Test that yaml2obj emits an error message when a compilation unit has values but there is no associated