[Lldb-commits] [PATCH] D88266: Check that the "StructuredData Plugin weak pointer" is good before trying to turn it into a shared pointer

jingham updated this revision to Diff 294844. jingham added a comment. Herald added a reviewer: JDevlieghere. Check safely for an unset plugin, then try to get the plugin and if either of those fails, use the underlying ObjectSP's Dump method to dump the data. Also added a test to make sure we

[Lldb-commits] [PATCH] D88387: Create "skinny corefiles" for Mach-O with process save-core / reading

jasonmolenda added a comment. In D88387#2299413 , @clayborg wrote: > The other thing to think about is using minidump files instead of mach-o core > files. We have them in very good shape and they already have a built in > notion of "all image infos".

[Lldb-commits] [PATCH] D88387: Create "skinny corefiles" for Mach-O with process save-core / reading

clayborg added a comment. The other thing to think about is using minidump files instead of mach-o core files. We have them in very good shape and they already have a built in notion of "all image infos". Many more things in there too. Let me know if you want to know more, but I'm not holding

[Lldb-commits] [PATCH] D88453: [lldb] Fix FreeBSD Arm Process Plugin build.

brooks created this revision. brooks added reviewers: emaste, omjavaid. Herald added subscribers: lldb-commits, kristof.beyls. Herald added a project: LLDB. brooks requested review of this revision. Herald added a subscriber: JDevlieghere. Add a missing include and some definitions in

[Lldb-commits] [PATCH] D88387: Create "skinny corefiles" for Mach-O with process save-core / reading

jasonmolenda marked 2 inline comments as done. jasonmolenda added a comment. Thanks for the suggestions Greg, solid ideas. Let me rework this a bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88387/new/ https://reviews.llvm.org/D88387

[Lldb-commits] [PATCH] D88387: Create "skinny corefiles" for Mach-O with process save-core / reading

clayborg added inline comments. Comment at: lldb/include/lldb/Symbol/ObjectFile.h:692 +return MachOCorefileAllImageInfos(); + } + basically all of the code from ProcessMachCore.cpp lines 421-455 can be moved into: ``` llvm::Error

[Lldb-commits] [PATCH] D88266: Check that the "StructuredData Plugin weak pointer" is good before trying to turn it into a shared pointer

clayborg added a comment. In D88266#2299110 , @jingham wrote: > Jonas just revived the long Doc that Todd wrote about the Structured Data > printing plugins. Seems like that is a useful thing, so I'm not in favor of > getting rid of it just yet. > >

[Lldb-commits] [PATCH] D88387: Create "skinny corefiles" for Mach-O with process save-core / reading

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Many inline comments that should explain everything. Comment at: lldb/include/lldb/Symbol/ObjectFile.h:669-692 + /// A corefile may include metadata about all

[Lldb-commits] [lldb] 974551d - [lldb] Add print_function import

Author: Jonas Devlieghere Date: 2020-09-28T13:51:11-07:00 New Revision: 974551d37da8352c22fd849d19cb8fb1facff680 URL: https://github.com/llvm/llvm-project/commit/974551d37da8352c22fd849d19cb8fb1facff680 DIFF:

[Lldb-commits] [PATCH] D88266: Check that the "StructuredData Plugin weak pointer" is good before trying to turn it into a shared pointer

jingham added a comment. Jonas just revived the long Doc that Todd wrote about the Structured Data printing plugins. Seems like that is a useful thing, so I'm not in favor of getting rid of it just yet. Seems the right thing to do is if the plugin doesn't exist, call Dump straight-away.

[Lldb-commits] [lldb] 8b95bd3 - [lldb] Enable markdown support for documentation

Author: Jonas Devlieghere Date: 2020-09-28T12:51:15-07:00 New Revision: 8b95bd3310c126e76e0714bea6003a9b1aa739fb URL: https://github.com/llvm/llvm-project/commit/8b95bd3310c126e76e0714bea6003a9b1aa739fb DIFF:

[Lldb-commits] [lldb] 6e54918 - Once we've found a firmware binary and loaded it, don't search more

Author: Jason Molenda Date: 2020-09-28T12:51:23-07:00 New Revision: 6e54918db7f4dad0d5a6fbff140009ed6f151d2c URL: https://github.com/llvm/llvm-project/commit/6e54918db7f4dad0d5a6fbff140009ed6f151d2c DIFF: https://github.com/llvm/llvm-project/commit/6e54918db7f4dad0d5a6fbff140009ed6f151d2c.diff

Re: [Lldb-commits] [lldb] 74c9395 - Add a "Trace" plug-in to LLDB to add process trace support in stages.

Hey Walter, Really excited to see that this landed! I have one post-commit review comment inline -- > On Sep 21, 2020, at 5:13 PM, Walter Erquinigo via lldb-commits > wrote: > > > Author: Walter Erquinigo > Date: 2020-09-21T17:13:18-07:00 > New Revision:

[Lldb-commits] [PATCH] D88375: Fix MIPS and MIPS64 ABI to use ConstString in thier register info arrays.

teemperor added a comment. Yeah, this is just to prevent the MIPS backend from hitting the assert (well, and get the related code to actually do what it's supposed to do). This whole code on my "to refactor" list. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D88375: Fix MIPS and MIPS64 ABI to use ConstString in thier register info arrays.

JDevlieghere added a comment. Instead of copy-pasting this code can we extract a helper and call it with `g_register_infos_mips64` and `g_register_infos` respectively? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88375/new/

[Lldb-commits] [lldb] f775fe5 - Revert "Add the ability to write target stop-hooks using the ScriptInterpreter."

Author: Jonas Devlieghere Date: 2020-09-28T09:04:32-07:00 New Revision: f775fe59640a2e837ad059a8f40e26989d4f9831 URL: https://github.com/llvm/llvm-project/commit/f775fe59640a2e837ad059a8f40e26989d4f9831 DIFF:

[Lldb-commits] [PATCH] D88387: Create "skinny corefiles" for Mach-O with process save-core / reading

mib added inline comments. Comment at: lldb/include/lldb/Symbol/ObjectFile.h:700 + /// \return + /// A vector of UUIDs of binaries that were currnetly executing + /// is returned; an empty vector if this information was Little typo here.

[Lldb-commits] [lldb] 0b44bb8 - [lldb][NFC] Minor cleanup in CxxModuleHandler::tryInstantiateStdTemplate

Author: Raphael Isemann Date: 2020-09-28T13:03:45+02:00 New Revision: 0b44bb8d40af9c634203a778fe34a9a4459d288f URL: https://github.com/llvm/llvm-project/commit/0b44bb8d40af9c634203a778fe34a9a4459d288f DIFF:

[Lldb-commits] [lldb] cabee89 - [lldb] Reference STL types in import-std-module tests

Author: Raphael Isemann Date: 2020-09-28T10:37:03+02:00 New Revision: cabee89bed69ce37c9e588f9190ed9c33f6bfdee URL: https://github.com/llvm/llvm-project/commit/cabee89bed69ce37c9e588f9190ed9c33f6bfdee DIFF:

[Lldb-commits] [PATCH] D88302: [lldb] Remove nothreadallow from SWIG's __str__ wrappers to work around a Python>=3.7 crash

This revision was automatically updated to reflect the committed changes. Closed by commit rG070a1d562b30: [lldb] Remove nothreadallow from SWIGs __str__ wrappers to work around a… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG

[Lldb-commits] [lldb] 070a1d5 - [lldb] Remove nothreadallow from SWIG's __str__ wrappers to work around a Python>=3.7 crash

Author: Raphael Isemann Date: 2020-09-28T10:10:34+02:00 New Revision: 070a1d562b303e564e40d831f6dc125793e19b38 URL: https://github.com/llvm/llvm-project/commit/070a1d562b303e564e40d831f6dc125793e19b38 DIFF: