[Lldb-commits] [lldb] a4ee79c - Fix errors in 0b69756110db444282c40ea16929186b2910c3b1

Author: Walter Erquinigo Date: 2021-03-30T18:03:02-07:00 New Revision: a4ee79c8ae5ca1bbfa8d78a2782918d1f23f15b2 URL: https://github.com/llvm/llvm-project/commit/a4ee79c8ae5ca1bbfa8d78a2782918d1f23f15b2 DIFF:

[Lldb-commits] [PATCH] D91679: [trace][intel-pt] Implement trace start and trace stop

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Sounds good. Lets gets this in then and start iterating on future patches! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91679/new/

[Lldb-commits] [PATCH] D91679: [trace][intel-pt] Implement trace start and trace stop

wallace added a comment. I like that idea, but i'd rather do it in a different patch once we have a second stop event, so that I make sure the entire thing makes sense. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91679/new/

[Lldb-commits] [PATCH] D91679: [trace][intel-pt] Implement trace start and trace stop

clayborg added a comment. Looking really good. See inline comments about the need for a ProcessorTraceStopReason. Since we have the eStopReasonProcessorTrace stop reason now, we should probably deliver these stops to the Trace plug-in so that it can respond maybe? Fine if we can to do this in

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1164b4e29572: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers (authored by omjavaid). Herald added a project: LLDB. Changed prior

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd6d3d21cd1cb: [LLDB] Add support for Arm64/Linux dynamic register sets (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM

[Lldb-commits] [lldb] d6d3d21 - [LLDB] Add support for Arm64/Linux dynamic register sets

Author: Muhammad Omair Javaid Date: 2021-03-31T04:38:36+05:00 New Revision: d6d3d21cd1cb1567eaf7ff8c0867b07227a19d99 URL: https://github.com/llvm/llvm-project/commit/d6d3d21cd1cb1567eaf7ff8c0867b07227a19d99 DIFF:

[Lldb-commits] [PATCH] D96463: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ab677180091: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset (authored by omjavaid). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] 1164b4e - [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

Author: Muhammad Omair Javaid Date: 2021-03-31T04:39:00+05:00 New Revision: 1164b4e2957290e814c3dd781a68e504dd39148e URL: https://github.com/llvm/llvm-project/commit/1164b4e2957290e814c3dd781a68e504dd39148e DIFF:

[Lldb-commits] [lldb] 9ab6771 - [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset

Author: Muhammad Omair Javaid Date: 2021-03-31T04:39:14+05:00 New Revision: 9ab677180091a690cd99d4ac55d5fb9e1149b1ec URL: https://github.com/llvm/llvm-project/commit/9ab677180091a690cd99d4ac55d5fb9e1149b1ec DIFF:

[Lldb-commits] [PATCH] D98822: [lldb] [Process] Watch for fork/vfork notifications

mgorny updated this revision to Diff 334296. mgorny marked 4 inline comments as done. mgorny added a comment. Removed software breakpoint cleanup. Modified tests not to expect child's output at any specific point. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98822/new/

[Lldb-commits] [PATCH] D98886: Pass pointer authentication code mask from minidump and use to strip pac from pc.

omjavaid added inline comments. Comment at: lldb/include/lldb/Target/Process.h:79 void SetExtraStartupCommands(const Args ); + uint64_t GetPointerAuthenticationAddressMask() const; + void SetPointerAuthenticationAddressMask(const uint64_t mask); pcc wrote:

[Lldb-commits] [PATCH] D98886: Pass pointer authentication code mask from minidump and use to strip pac from pc.

pcc added inline comments. Comment at: lldb/include/lldb/Target/Process.h:79 void SetExtraStartupCommands(const Args ); + uint64_t GetPointerAuthenticationAddressMask() const; + void SetPointerAuthenticationAddressMask(const uint64_t mask); omjavaid wrote:

[Lldb-commits] [PATCH] D98886: Pass pointer authentication code mask from minidump and use to strip pac from pc.

omjavaid added inline comments. Comment at: lldb/include/lldb/Target/Process.h:79 void SetExtraStartupCommands(const Args ); + uint64_t GetPointerAuthenticationAddressMask() const; + void SetPointerAuthenticationAddressMask(const uint64_t mask); This

[Lldb-commits] [PATCH] D98761: Fix "image lookup --address" Summary results for inline functions.

clayborg updated this revision to Diff 334274. clayborg added a comment. Remove show_inline_callsite_line_info setting from SymbolContext dumping function as it isn't needed, show_inlined_frames controls this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] e3d3327 - [lldb] Remove reproducer from previous test run

Author: Jonas Devlieghere Date: 2021-03-30T10:11:20-07:00 New Revision: e3d3327edbf133da6ed50767eed4560a541a751d URL: https://github.com/llvm/llvm-project/commit/e3d3327edbf133da6ed50767eed4560a541a751d DIFF:

[Lldb-commits] [PATCH] D99571: Update ProcessMachCore::DoLoadCore to handle binary hints with and without addresses

shafik added inline comments. Comment at: lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp:214 + if (FileSystem::Instance().Exists(module_spec.GetFileSpec())) { +module_sp.reset(new Module(module_spec)); + } We can use `make_shared`

[Lldb-commits] [PATCH] D99571: Update ProcessMachCore::DoLoadCore to handle binary hints with and without addresses

shafik added inline comments. Comment at: lldb/test/API/macosx/lc-note/firmware-corefile/TestFirmwareCorefiles.py:142 +main_addr = main_sym.GetStartAddress() +self.assertGreater(main_addr.GetLoadAddress(self.target), 0x700) +

[Lldb-commits] [PATCH] D98482: [lldb] [server] Support for multiprocess extension

mgorny added a comment. In D98482#2658991 , @stella.stamenova wrote: > Looks like this broke the Windows lldb buildbot: > > https://lab.llvm.org/buildbot/#/builders/83/builds/5173 Thanks for pinging me. It seems that all Hg tests fail on Windows, so

[Lldb-commits] [lldb] c62ef12 - [lldb] [test] Mark more lldb-server tests xfail on Windows

Author: Michał Górny Date: 2021-03-30T18:49:04+02:00 New Revision: c62ef12079bcc7ce72040dddaae13408b120d995 URL: https://github.com/llvm/llvm-project/commit/c62ef12079bcc7ce72040dddaae13408b120d995 DIFF: https://github.com/llvm/llvm-project/commit/c62ef12079bcc7ce72040dddaae13408b120d995.diff

[Lldb-commits] [PATCH] D98482: [lldb] [server] Support for multiprocess extension

stella.stamenova added a comment. Looks like this broke the Windows lldb buildbot: https://lab.llvm.org/buildbot/#/builders/83/builds/5173 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98482/new/ https://reviews.llvm.org/D98482

[Lldb-commits] [PATCH] D99603: [lldb] [client] Support for multiprocess extension

mgorny added a comment. @labath, split `GetCurrentThreadIDs()` as suggested. I've also modified `GetCurrentProcessID()` to prefer explicit PID over TID when available. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99603/new/ https://reviews.llvm.org/D99603

[Lldb-commits] [PATCH] D99603: [lldb] [client] Support for multiprocess extension

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. mgorny requested review of this revision. Add a minimal support for the multiprocess extension in gdb-remote client. It accepts PIDs as part of thread-ids, and rejects PIDs that do not match the current inferior.

[Lldb-commits] [lldb] 0bbe2a3 - [lldb] More missing includes in TestGdbRemote_vContThreads

Author: Pavel Labath Date: 2021-03-30T18:05:31+02:00 New Revision: 0bbe2a3c8aae29445b73423bd54baa72e515484d URL: https://github.com/llvm/llvm-project/commit/0bbe2a3c8aae29445b73423bd54baa72e515484d DIFF: https://github.com/llvm/llvm-project/commit/0bbe2a3c8aae29445b73423bd54baa72e515484d.diff

[Lldb-commits] [lldb] 9709186 - [lldb] Add missing include in TestGdbRemote_vContThreads test

Author: Pavel Labath Date: 2021-03-30T17:38:52+02:00 New Revision: 9709186681a73489ecb76ea56cb4e1770f8da99a URL: https://github.com/llvm/llvm-project/commit/9709186681a73489ecb76ea56cb4e1770f8da99a DIFF: https://github.com/llvm/llvm-project/commit/9709186681a73489ecb76ea56cb4e1770f8da99a.diff

[Lldb-commits] [lldb] bbae066 - [lldb] Fix TestStopOnSharedlibraryEvents.py on linux

Author: Pavel Labath Date: 2021-03-30T17:38:51+02:00 New Revision: bbae06652e076a35b94acf84e67602ffbdc5c071 URL: https://github.com/llvm/llvm-project/commit/bbae06652e076a35b94acf84e67602ffbdc5c071 DIFF: https://github.com/llvm/llvm-project/commit/bbae06652e076a35b94acf84e67602ffbdc5c071.diff

[Lldb-commits] [PATCH] D98822: [lldb] [Process] Watch for fork/vfork notifications

mgorny added a comment. In D98822#2658443 , @labath wrote: > Yeah, but then we have to maintain two copies of breakpoint-unsetting code in > perpetuity. Given that we've managed to come this far with this being > completely broken, I think we can wait

[Lldb-commits] [lldb] 04b766d - [lldb/test] Deflake TestGdbRemote_vContThreads even more

Author: Pavel Labath Date: 2021-03-30T17:03:14+02:00 New Revision: 04b766dab0d9d786ab5695336348b0c01646cf99 URL: https://github.com/llvm/llvm-project/commit/04b766dab0d9d786ab5695336348b0c01646cf99 DIFF: https://github.com/llvm/llvm-project/commit/04b766dab0d9d786ab5695336348b0c01646cf99.diff

[Lldb-commits] [lldb] ce03a86 - [lldb] Remove linux/mips debugging support

Author: Pavel Labath Date: 2021-03-30T15:24:43+02:00 New Revision: ce03a862372a6f36d2fcf80dc80052aa155fcae8 URL: https://github.com/llvm/llvm-project/commit/ce03a862372a6f36d2fcf80dc80052aa155fcae8 DIFF: https://github.com/llvm/llvm-project/commit/ce03a862372a6f36d2fcf80dc80052aa155fcae8.diff

[Lldb-commits] [PATCH] D98822: [lldb] [Process] Watch for fork/vfork notifications

labath added a comment. In D98822#2658426 , @mgorny wrote: > In D98822#2658252 , @labath wrote: > >> In D98822#2646052 , @mgorny wrote: >> >>> It includes refactoring

[Lldb-commits] [PATCH] D98822: [lldb] [Process] Watch for fork/vfork notifications

mgorny added inline comments. Comment at: lldb/test/Shell/Subprocess/fork-follow-parent.test:6 +process launch +# CHECK: function run in child +# CHECK-NOT: function run in parent labath wrote: > mgorny wrote: > > The tests sometimes fail if child starts after

[Lldb-commits] [PATCH] D98822: [lldb] [Process] Watch for fork/vfork notifications

mgorny added a comment. In D98822#2658252 , @labath wrote: > In D98822#2646052 , @mgorny wrote: > >> It includes refactoring clone/fork/vfork event monitoring into a single >> function. Right now, only forks are

[Lldb-commits] [PATCH] D98482: [lldb] [server] Support for multiprocess extension

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6c1a8039de46: [lldb] [server] Support for multiprocess extension

[Lldb-commits] [lldb] 6c1a803 - [lldb] [server] Support for multiprocess extension

Author: Michał Górny Date: 2021-03-30T15:09:27+02:00 New Revision: 6c1a8039de4646f6efbb3ba404d5bee5d631be67 URL: https://github.com/llvm/llvm-project/commit/6c1a8039de4646f6efbb3ba404d5bee5d631be67 DIFF: https://github.com/llvm/llvm-project/commit/6c1a8039de4646f6efbb3ba404d5bee5d631be67.diff

[Lldb-commits] [PATCH] D98482: [lldb] [server] Support for multiprocess extension

mgorny updated this revision to Diff 334131. mgorny marked 2 inline comments as done. mgorny retitled this revision from "[lldb] Support for multiprocess extension" to "[lldb] [server] Support for multiprocess extension". mgorny added a comment. Limited to server changes. Added definitions for

[Lldb-commits] [PATCH] D98761: Fix "image lookup --address" Summary results for inline functions.

labath added a comment. I'm not that familiar with this function, but the output seems right. Given that the `show_inline_callsite_line_info` argument is no longer used, can you remove it? Comment at: lldb/source/Symbol/SymbolContext.cpp:133 + // fill it in correctly

[Lldb-commits] [PATCH] D98822: [lldb] [Process] Watch for fork/vfork notifications

labath added a comment. In D98822#2646052 , @mgorny wrote: > It includes refactoring clone/fork/vfork event monitoring into a single > function. Right now, only forks are supported — the handler creates a local > `NativeProcessLinux` instance (@labath,

[Lldb-commits] [lldb] 64bb9cf - [lldb] [Process/gdb-remote] Fix TID reading to use U64

Author: Michał Górny Date: 2021-03-30T13:59:32+02:00 New Revision: 64bb9cf7bf8df85cbe75f0848840156d3c316207 URL: https://github.com/llvm/llvm-project/commit/64bb9cf7bf8df85cbe75f0848840156d3c316207 DIFF: https://github.com/llvm/llvm-project/commit/64bb9cf7bf8df85cbe75f0848840156d3c316207.diff

[Lldb-commits] [PATCH] D98482: [lldb] Support for multiprocess extension

mgorny added a comment. Ok, I'm going to use this review to push the server part, then commit the uint64 client change separately, then create a new diff for client. If you find a few more minutes, the server-side fork/vfork patch is ready for review (and independent of this one). CHANGES

[Lldb-commits] [PATCH] D99491: [LLDB] Fix cleanup error in TestVSCode_disconnect.test_launch

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG42c3b5e5b6ff: Fix cleanup error in TestVSCode_disconnect.test_launch (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM

[Lldb-commits] [lldb] 42c3b5e - Fix cleanup error in TestVSCode_disconnect.test_launch

Author: Muhammad Omair Javaid Date: 2021-03-30T15:36:45+05:00 New Revision: 42c3b5e5b6ffd39041c3d34f01e7162573eefd6e URL: https://github.com/llvm/llvm-project/commit/42c3b5e5b6ffd39041c3d34f01e7162573eefd6e DIFF:

[Lldb-commits] [PATCH] D99571: Update ProcessMachCore::DoLoadCore to handle binary hints with and without addresses

jasonmolenda created this revision. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. jasonmolenda requested review of this revision. ProcessMachCore::DoLoadCore was implemented to handle the two LC_NOTEs "kern ver str" and "main bin spec" with only certain

[Lldb-commits] [PATCH] D96463: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset

labath accepted this revision. labath added inline comments. Comment at: lldb/test/API/commands/register/register/aarch64_dynamic_regset/TestArm64DynamicRegsets.py:59-60 + for _ in range(p_reg_size)) + '}' +self.runCmd('register write p%i' %

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good (and sorry for the delay). Just rebase to main to avoid the cast. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:77 +

[Lldb-commits] [lldb] d1486e6 - [lldb] Change CreateHostNativeRegisterContextLinux argument type

Author: Pavel Labath Date: 2021-03-30T11:45:17+02:00 New Revision: d1486e65a1645ca00c3e3109e4e4bb72df1082c3 URL: https://github.com/llvm/llvm-project/commit/d1486e65a1645ca00c3e3109e4e4bb72df1082c3 DIFF: https://github.com/llvm/llvm-project/commit/d1486e65a1645ca00c3e3109e4e4bb72df1082c3.diff

[Lldb-commits] [PATCH] D99497: [LLDB] Fix sync issue in TestVSCode_launch.test_progress_events

labath added a comment. In D99497#2656600 , @clayborg wrote: > In D99497#2656502 , @labath wrote: > >> Isn't there a better way to ensure synchronization here? Maybe, executing >> some command (setting a

[Lldb-commits] [PATCH] D98482: [lldb] Support for multiprocess extension

labath added a comment. I think it'd be better to commit this in two patches after all. The first one could include the server bits (and the multiprocess+ server thingy) -- I believe this is good to go already. The second patch/review could deal with the thread/process id business on the

[Lldb-commits] [lldb] 6919c58 - [lldb] Add a test for Obj-C properties with conflicting names

Author: Raphael Isemann Date: 2021-03-30T11:08:16+02:00 New Revision: 6919c58262b0bab682ab48903e714d70a489418b URL: https://github.com/llvm/llvm-project/commit/6919c58262b0bab682ab48903e714d70a489418b DIFF:

[Lldb-commits] [PATCH] D99513: [lldb] Add a test for Obj-C properties with conflicting names

This revision was automatically updated to reflect the committed changes. Closed by commit rG6919c58262b0: [lldb] Add a test for Obj-C properties with conflicting names (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github

[Lldb-commits] [lldb] 1a2d25f - Revert "[lldb/DWARF] Simplify DIE extraction code slightly"

Author: Pavel Labath Date: 2021-03-30T09:59:34+02:00 New Revision: 1a2d25fcdd732fc3326c1e9a9729b3b2b08b5d17 URL: https://github.com/llvm/llvm-project/commit/1a2d25fcdd732fc3326c1e9a9729b3b2b08b5d17 DIFF: https://github.com/llvm/llvm-project/commit/1a2d25fcdd732fc3326c1e9a9729b3b2b08b5d17.diff

[Lldb-commits] [lldb] ea08d4b - [lldb] Remove ScriptInterpreterLuaTest.Plugin unittest

Author: Pavel Labath Date: 2021-03-30T08:48:56+02:00 New Revision: ea08d4ba37362506ebd30957a9473467df6f00b9 URL: https://github.com/llvm/llvm-project/commit/ea08d4ba37362506ebd30957a9473467df6f00b9 DIFF: https://github.com/llvm/llvm-project/commit/ea08d4ba37362506ebd30957a9473467df6f00b9.diff

[Lldb-commits] [lldb] 5978912 - [lldb] Add a dwarf unit test for null unit dies

Author: Pavel Labath Date: 2021-03-30T08:46:36+02:00 New Revision: 5978912da00acc610e4e1379bde815b28252944c URL: https://github.com/llvm/llvm-project/commit/5978912da00acc610e4e1379bde815b28252944c DIFF: https://github.com/llvm/llvm-project/commit/5978912da00acc610e4e1379bde815b28252944c.diff

[Lldb-commits] [lldb] 1b96e13 - [lldb/DWARF] Simplify DIE extraction code slightly

Author: Pavel Labath Date: 2021-03-30T08:44:17+02:00 New Revision: 1b96e133cf5215cb9ebfe7f14630f479c1611f22 URL: https://github.com/llvm/llvm-project/commit/1b96e133cf5215cb9ebfe7f14630f479c1611f22 DIFF: https://github.com/llvm/llvm-project/commit/1b96e133cf5215cb9ebfe7f14630f479c1611f22.diff