[Lldb-commits] [lldb] eff4f65 - [lldb] Simplify check for nill value in breakpoint_function_callback.test

Author: Jonas Devlieghere Date: 2021-04-20T21:53:30-07:00 New Revision: eff4f65afb6323e19d0baa73b9ee24df6909960b URL: https://github.com/llvm/llvm-project/commit/eff4f65afb6323e19d0baa73b9ee24df6909960b DIFF:

[Lldb-commits] [PATCH] D100795: [lldb] Fix RichManglingContext::FromCxxMethodName() leak

dblaikie added inline comments. Comment at: lldb/source/Core/RichManglingContext.cpp:23 +RichManglingContext::~RichManglingContext() { + std::free(m_ipd_buf); + ResetCxxMethodParser(); JDevlieghere wrote: > shafik wrote: > > rupprecht wrote: > > > JDevlieghere

[Lldb-commits] [PATCH] D100795: [lldb] Fix RichManglingContext::FromCxxMethodName() leak

JDevlieghere added inline comments. Comment at: lldb/source/Core/RichManglingContext.cpp:23 +RichManglingContext::~RichManglingContext() { + std::free(m_ipd_buf); + ResetCxxMethodParser(); shafik wrote: > rupprecht wrote: > > JDevlieghere wrote: > > > Instead

[Lldb-commits] [PATCH] D100795: [lldb] Fix RichManglingContext::FromCxxMethodName() leak

shafik added a comment. Thank you for reforactoring into `ResetCxxMethodParser`. Comment at: lldb/source/Core/RichManglingContext.cpp:23 +RichManglingContext::~RichManglingContext() { + std::free(m_ipd_buf); + ResetCxxMethodParser(); rupprecht wrote: >

[Lldb-commits] [PATCH] D100795: [lldb] Fix RichManglingContext::FromCxxMethodName() leak

rupprecht added inline comments. Comment at: lldb/source/Core/RichManglingContext.cpp:23 +RichManglingContext::~RichManglingContext() { + std::free(m_ipd_buf); + ResetCxxMethodParser(); JDevlieghere wrote: > Instead of managing memory by hand, can we use a

[Lldb-commits] [PATCH] D98153: Some FormatEntity.cpp cleanup and unit testing

nealsid updated this revision to Diff 339059. nealsid added a comment. Small update of patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98153/new/ https://reviews.llvm.org/D98153 Files: lldb/include/lldb/Core/FormatEntity.h

[Lldb-commits] [PATCH] D100740: json

clayborg added a comment. The title should be updated on this diff as well. Set the "json" right now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100740/new/ https://reviews.llvm.org/D100740 ___

[Lldb-commits] [PATCH] D100740: json

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/include/lldb/Symbol/LineEntry.h:94-104 + /// \param[in] compare_addresses + /// If \b true, then the addresses of the LineEntry

[Lldb-commits] [PATCH] D100740: json

wallace updated this revision to Diff 339044. wallace retitled this revision from "[trace] Dedup different source lines when dumping instructions + refactor" to "json". wallace added a comment. ready for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D100795: [lldb] Fix RichManglingContext::FromCxxMethodName() leak

JDevlieghere added inline comments. Comment at: lldb/source/Core/RichManglingContext.cpp:23 +RichManglingContext::~RichManglingContext() { + std::free(m_ipd_buf); + ResetCxxMethodParser(); Instead of managing memory by hand, can we use a `unique_ptr` instead?

[Lldb-commits] [PATCH] D100795: [lldb] Fix RichManglingContext::FromCxxMethodName() leak

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks for fixing this! We don't really have a thread for keep track of what other leak sanitiser failures needs to be fixed, but I believe with this revision (+ the revisions

[Lldb-commits] [PATCH] D100898: [CMake][lldb] add_lldb_library's functions require default visibility

radford created this revision. radford added a reviewer: arphaman. Herald added a subscriber: mgorny. radford requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Compiling lldb, in a cmake sub-project that compiles with visibility hidden, will

[Lldb-commits] [PATCH] D100891: CMake fixes to enable LLVM as a sub-project

radford created this revision. Herald added a subscriber: mgorny. radford requested review of this revision. Herald added projects: clang, LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits. [CMake][llvm] Using -D in COMPILE_DEFINITIONS can create a lone -D

[Lldb-commits] [PATCH] D100795: [lldb] Fix RichManglingContext::FromCxxMethodName() leak

rupprecht updated this revision to Diff 338979. rupprecht added a comment. - Move comment about switch to the correct spot Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100795/new/ https://reviews.llvm.org/D100795 Files:

[Lldb-commits] [PATCH] D100850: Fix reading from file cache using address instead of resolved address for getting a section

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf2da1f68d815: Get Section from resolved_addr in Target::ReadMemory (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [lldb] f2da1f6 - Get Section from resolved_addr in Target::ReadMemory

Author: Jason Molenda Date: 2021-04-20T12:09:06-07:00 New Revision: f2da1f68d815f97e1211da62e7e1f102941947e3 URL: https://github.com/llvm/llvm-project/commit/f2da1f68d815f97e1211da62e7e1f102941947e3 DIFF: https://github.com/llvm/llvm-project/commit/f2da1f68d815f97e1211da62e7e1f102941947e3.diff

[Lldb-commits] [PATCH] D100850: Fix reading from file cache using address instead of resolved address for getting a section

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Ach, I should have noticed that during review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100850/new/

[Lldb-commits] [PATCH] D100806: [lldb] Fix one leak in reproducer

MaskRay marked 2 inline comments as done. MaskRay added inline comments. Comment at: lldb/tools/driver/Driver.cpp:856 if (const char *reproducer_path = SBReproducer::GetPath()) { -// Leaking the string on purpose. -std::string *finalize_cmd = new

[Lldb-commits] [PATCH] D100806: [lldb] Fix one leak in reproducer

dblaikie added inline comments. Comment at: lldb/tools/driver/Driver.cpp:856 if (const char *reproducer_path = SBReproducer::GetPath()) { -// Leaking the string on purpose. -std::string *finalize_cmd = new std::string(argv0); +static std::string

[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback

jbsolomon added a comment. In D91508#2698780 , @JDevlieghere wrote: > @kastiglione isn't this the error you fixed for Python? Should we do the same > for Lua? Correct me if I'm wrong, but I think the Python integration uses the same pragma approach

[Lldb-commits] [PATCH] D100243: [LLDB][GUI] Expand selected thread tree item by default

OmarEmaraDev marked 2 inline comments as done. OmarEmaraDev added inline comments. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:2211-2213 + if (selected_thread->GetID() == thread->GetID()) { +item[i].Expand(); + } clayborg

[Lldb-commits] [PATCH] D100850: Fix reading from file cache using address instead of resolved address for getting a section

augusto2112 created this revision. augusto2112 added a reviewer: jasonmolenda. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This fiex a small problem with https://reviews.llvm.org/D100338 where we'd grab the section from

[Lldb-commits] [PATCH] D100243: [LLDB][GUI] Expand selected thread tree item by default

OmarEmaraDev updated this revision to Diff 338846. OmarEmaraDev added a comment. - Follow LLVM coding guidelines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100243/new/ https://reviews.llvm.org/D100243 Files: