[Lldb-commits] [PATCH] D103210: [lldb] Introduce Language::MethodNameInfo

jingham added a comment. The idea seems good, but I'm not sure how you are going to extend it? "Selector" seems a pretty ObjC specific term to me. Will this be what you use to get the "method name" part of the C++ names? That would look a bit odd to me, but OTOH having a GetSelector in all

[Lldb-commits] [PATCH] D103217: Make ignore counts work as "after stop" modifiers so they play nicely with conditions

jingham created this revision. jingham added a reviewer: JDevlieghere. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Previously ignore counts were checked when we stopped to do the sync callback in Breakpoint::ShouldStop. That

[Lldb-commits] [PATCH] D103210: [lldb] Introduce Language::MethodNameInfo

bulbazord added a comment. Let me know how you feel about this abstraction/idea. I think we'll need something like this at some point to remove most of the remaining dependencies (e.g. in Module.cpp) so I'd like to get something good going here. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D103210: [lldb] Introduce Language::MethodNameInfo

bulbazord created this revision. bulbazord added a reviewer: teemperor. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. There are several instances where one may want to ask questions about the name of a method/function/whatever.

[Lldb-commits] [PATCH] D103209: [lldb] Fix gnu_libstdcpp's update methods

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0283abee5c87: [lldb] Fix gnu_libstdcpps update methods (authored by wallace). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 0283abe - [lldb] Fix gnu_libstdcpp's update methods

Author: Walter Erquinigo Date: 2021-05-26T14:52:38-07:00 New Revision: 0283abee5c87e86552b456a34d01311b66c37207 URL: https://github.com/llvm/llvm-project/commit/0283abee5c87e86552b456a34d01311b66c37207 DIFF:

[Lldb-commits] [PATCH] D103209: [lldb] Fix gnu_libstdcpp's update methods

wallace created this revision. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The variable.rst documentation says: If it returns a value, and that value is True, LLDB will be allowed to cache the children and the children

[Lldb-commits] [PATCH] D103172: [lldb][NFC] Allow range-based for loops over DWARFDIE's children

shafik added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDIE.h:117 +// (CU, (DIE)nullptr) == (nullptr, nullptr) -> true +if (!m_die.IsValid() && !it.m_die.IsValid()) + return true; I think: ``` bool operator==(const

[Lldb-commits] [PATCH] D103124: [lldb] add LLDB_SKIP_DSYM option

This revision was automatically updated to reflect the committed changes. Closed by commit rG969eefd98e0f: [lldb] add LLDB_SKIP_DSYM option (authored by rmaz, committed by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103124/new/

[Lldb-commits] [lldb] 969eefd - [lldb] add LLDB_SKIP_DSYM option

Author: Richard Howell Date: 2021-05-26T09:32:59-07:00 New Revision: 969eefd98e0f8e485148be61190cc2ef62fb1eca URL: https://github.com/llvm/llvm-project/commit/969eefd98e0f8e485148be61190cc2ef62fb1eca DIFF:

[Lldb-commits] [PATCH] D103107: [lldb] Remove cache in get_demangled_name_without_arguments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd28bc54ff44a: [lldb] Remove cache in get_demangled_name_without_arguments (authored by teemperor). Herald added a subscriber: lldb-commits.

[Lldb-commits] [lldb] d28bc54 - [lldb] Remove cache in get_demangled_name_without_arguments

Author: Raphael Isemann Date: 2021-05-26T18:27:40+02:00 New Revision: d28bc54ff44aad7b080177ef85764d7c5444f031 URL: https://github.com/llvm/llvm-project/commit/d28bc54ff44aad7b080177ef85764d7c5444f031 DIFF:

[Lldb-commits] [PATCH] D103172: [lldb][NFC] Allow range-based for loops over DWARFDIE's children

teemperor created this revision. teemperor added a reviewer: LLDB. teemperor added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a reviewer: shafik. teemperor requested review of this revision. This patch adds the ability to get a DWARFDIE's children as an LLVM range.

[Lldb-commits] [PATCH] D103124: [lldb] add LLDB_SKIP_DSYM option

rmaz added a comment. In D103124#2780955 , @smeenai wrote: > Swift's LLDB fork has a TODO for this :) CC @sgraenitz, who added that TODO. > > LGTM. Do you need this to be committed for you? If you could, thanks Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D101361: [LLDB] Support AArch64/Linux watchpoint on tagged addresses

omjavaid added a comment. @labath @mgorny any comments on this rev? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101361/new/ https://reviews.llvm.org/D101361 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D102757: [lldb] Remove non address bits when looking up memory regions

omjavaid added a comment. In D102757#2781677 , @DavidSpickett wrote: > In D102757#2781561 , @omjavaid > wrote: > >> Now that we are stripping away top byte is there any information that may be >> useful for

[Lldb-commits] [PATCH] D102757: [lldb] Remove non address bits when looking up memory regions

DavidSpickett added a comment. One thing that you might think of would be the top bits set for kernel alloations. However if we're using the masks and TBI correctly those will be left intact. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D102757: [lldb] Remove non address bits when looking up memory regions

DavidSpickett added a comment. In D102757#2781561 , @omjavaid wrote: > Now that we are stripping away top byte is there any information that may be > useful for the remote side and we are removing that on the host side. I am > thinking why we should

[Lldb-commits] [PATCH] D97285: [lldb][AArch64] Add "memory tag read" command

DavidSpickett updated this revision to Diff 347909. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97285/new/ https://reviews.llvm.org/D97285 Files: lldb/source/Commands/CMakeLists.txt

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

DavidSpickett updated this revision to Diff 347906. DavidSpickett added a comment. Rebase, fix up `SendPacketAndWaitForResponse` use. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95602/new/ https://reviews.llvm.org/D95602 Files:

[Lldb-commits] [PATCH] D102757: [lldb] Remove non address bits when looking up memory regions

omjavaid added a comment. Now that we are stripping away top byte is there any information that may be useful for the remote side and we are removing that on the host side. I am thinking why we should strip top byte on host side rather than making it the responsibility of the remote end?

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett updated this revision to Diff 347899. DavidSpickett added a comment. I was looking at the wrong file, this adds the header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95601/new/ https://reviews.llvm.org/D95601 Files:

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett updated this revision to Diff 347898. DavidSpickett added a comment. Rebase, which brings in the header pcc mentioned. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95601/new/ https://reviews.llvm.org/D95601 Files:

[Lldb-commits] [PATCH] D97282: [lldb][AArch64] Add memory-tagging qSupported feature

DavidSpickett updated this revision to Diff 347896. DavidSpickett added a subscriber: pcc. DavidSpickett added a comment. Rebase, which brings in the include @pcc mentioned. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97282/new/

[Lldb-commits] [PATCH] D97281: [lldb][AArch64] Add class for managing memory tags

DavidSpickett updated this revision to Diff 347893. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97281/new/ https://reviews.llvm.org/D97281 Files: lldb/include/lldb/Target/MemoryTagManager.h

[Lldb-commits] [PATCH] D97282: [lldb][AArch64] Add memory-tagging qSupported feature

DavidSpickett updated this revision to Diff 347895. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97282/new/ https://reviews.llvm.org/D97282 Files: lldb/include/lldb/Host/common/NativeProcessProtocol.h

[Lldb-commits] [PATCH] D99944: [LLDB] AArch64 Linux and elf-core PAC stack unwinder support

DavidSpickett resigned from this revision. DavidSpickett added a comment. Resigning to remove my requested changes, if that works. Looks good from my point of view. @labath You had earlier questions about using the register context, and a few comments that have gotten disconnected from the

[Lldb-commits] [PATCH] D99944: [LLDB] AArch64 Linux and elf-core PAC stack unwinder support

DavidSpickett added a comment. I realised my mistake, I thought this was adding a new core file but in fact it's using the one you added for the register tests. So now the outfile is there the test passes. Comment at: