[Lldb-commits] [PATCH] D103210: [lldb] Introduce Language::MethodNameInfo

teemperor added a comment. +1 to not add any language-specific terms to the Language API. Looking over the code, it seems what the code is doing its: - Going over the symbol names. - Creating a search index from the symbol names that is optionally grouped via the `FunctionNameType` cases (and t

[Lldb-commits] [PATCH] D103210: [lldb] Introduce Language::MethodNameInfo

bulbazord added a comment. In D103210#2784645 , @teemperor wrote: > +1 to not add any language-specific terms to the Language API. > > Looking over the code, it seems what the code is doing its: > > - Going over the symbol names. > - Creating a search ind

[Lldb-commits] [PATCH] D103271: [lldb/Target] Select most relevant frame only in case of signal

PatriosTheGreat created this revision. PatriosTheGreat added reviewers: mib, labath, jarin. PatriosTheGreat added a project: LLDB. Herald added a subscriber: JDevlieghere. PatriosTheGreat requested review of this revision. Herald added a subscriber: lldb-commits. In order to select most relevant f

[Lldb-commits] [PATCH] D103271: [lldb/Target] Select most relevant frame only in case of signal

mib requested changes to this revision. mib added a comment. This revision now requires changes to proceed. At first sight, this looks like a fair addition, but this feature is also used to report Swift Runtime Failure in the debugger

[Lldb-commits] [PATCH] D103271: [lldb/Target] Select most relevant frame only in case of signal

jingham requested changes to this revision. jingham added a comment. It is incorrect to say that SelectMostRelevantFrame is only relevant for asserts. The FrameRecognizer is a generic mechanism, and you have no a priori way to know what kinds of thread stops it wants to operate on. So this pat