[Lldb-commits] [PATCH] D103504: Improve performance when parsing symbol tables in mach-o files.

clayborg created this revision. clayborg added reviewers: labath, aprantl, JDevlieghere, jingham. Herald added a subscriber: kristof.beyls. clayborg requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Some larger projects were loading quite

[Lldb-commits] [PATCH] D103375: [lldb/API] Expose triple for SBProcessInfo.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG251a5d9d5239: [lldb/API] Expose triple for SBProcessInfo. (authored by brucem). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 251a5d9 - [lldb/API] Expose triple for SBProcessInfo.

Author: Bruce Mitchener Date: 2021-06-02T11:35:11+07:00 New Revision: 251a5d9d5239c0402e0ab68718aa194c2b4f04bb URL: https://github.com/llvm/llvm-project/commit/251a5d9d5239c0402e0ab68718aa194c2b4f04bb DIFF:

[Lldb-commits] [PATCH] D103500: [trace][intel-pt] Create basic SB API

wallace created this revision. wallace added a reviewer: clayborg. Herald added a subscriber: dang. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This adds a basic SB API for creating and stopping traces. Note: This doesn't add

[Lldb-commits] [lldb] 658f6ed - Make ignore counts work as "after stop" modifiers so they play nicely with conditions

Author: Jim Ingham Date: 2021-06-01T18:22:27-07:00 New Revision: 658f6ed1523b0e61ddee494ce1691f29a701c317 URL: https://github.com/llvm/llvm-project/commit/658f6ed1523b0e61ddee494ce1691f29a701c317 DIFF: https://github.com/llvm/llvm-project/commit/658f6ed1523b0e61ddee494ce1691f29a701c317.diff

[Lldb-commits] [PATCH] D103271: [lldb/Target] Select most relevant frame only in case of signal

jingham added a comment. One of the "frame recognizers" - probably the one that's causing this particular problem - is the "assert" recognizer. The idea is that when you call "assert" in user code, you pretty much always end up with a 4 or 5 frames deep stack that wanders it's way from assert

[Lldb-commits] [PATCH] D103375: [lldb/API] Expose triple for SBProcessInfo.

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103375/new/ https://reviews.llvm.org/D103375

[Lldb-commits] [PATCH] D102942: Remove or use variables which are unused but set.

This revision was automatically updated to reflect the committed changes. Closed by commit rG00d19c6704f4: [various] Remove or use variables which are unused but set. (authored by mbenfield, committed by george.burgess.iv). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 00d19c6 - [various] Remove or use variables which are unused but set.

Author: Michael Benfield Date: 2021-06-01T15:38:48-07:00 New Revision: 00d19c6704f421157ae3de3623aca5f58f6c366d URL: https://github.com/llvm/llvm-project/commit/00d19c6704f421157ae3de3623aca5f58f6c366d DIFF:

[Lldb-commits] [PATCH] D103483: [lldb] Convert the default constructor’s member initializers into default member initializers

jingham added a comment. Thanks for taking this on. The in-class initialization is so much less boiler-plate and easier to read! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103483/new/ https://reviews.llvm.org/D103483 ___ lldb-commits

[Lldb-commits] [PATCH] D103483: [lldb] Convert the default constructor’s member initializers into default member initializers

teemperor added a comment. +1. I'm anyway doing the same whenever I have to touching constructors, so we might as well pull out the big hammer. I'm also glad you volunteer to resolve all the downstream conflicts :) Comment at:

[Lldb-commits] [PATCH] D103483: [lldb] Convert the default constructor’s member initializers into default member initializers

JDevlieghere added a comment. FWIW this is more of an RFC and as always there's some manual fixing up to be done and formatting to be fixed. I wanted to put this up for review before sinking time in that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103483/new/

[Lldb-commits] [PATCH] D103349: [lldb] Don't print script output twice in HandleCommand

shafik added inline comments. Comment at: lldb/include/lldb/Interpreter/CommandReturnObject.h:169 + /// as a temporary. + bool m_hermetic; }; JDevlieghere wrote: > aprantl wrote: > > bool m_hermetic = false; > This is the second time someone has suggested to

[Lldb-commits] [PATCH] D103349: [lldb] Don't print script output twice in HandleCommand

jingham added a comment. In D103349#2791614 , @JDevlieghere wrote: > Use in-class initializers I'm all for in-class initializers, but I think it is confusing to use them piecemeal, where some ivars in a class have initializers and some are

[Lldb-commits] [PATCH] D103349: [lldb] Don't print script output twice in HandleCommand

JDevlieghere updated this revision to Diff 349033. JDevlieghere marked 3 inline comments as done. JDevlieghere added a comment. Use in-class initializers CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103349/new/ https://reviews.llvm.org/D103349 Files:

[Lldb-commits] [PATCH] D103349: [lldb] Don't print script output twice in HandleCommand

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/include/lldb/Interpreter/CommandReturnObject.h:169 + /// as a temporary. + bool m_hermetic; }; aprantl wrote: > bool m_hermetic = false; This is the second

[Lldb-commits] [PATCH] D103439: [lldb] Print the backtrace for all threads if the test breakpoint can't be hit

jingham added a comment. In D103439#2791324 , @teemperor wrote: > In D103439#2791298 , @JDevlieghere > wrote: > >> LGTM. Are there other places where we check this, either in `lldbutil` or >> maybe more

[Lldb-commits] [PATCH] D103454: [lldb][docs] Document SBType

shafik added inline comments. Comment at: lldb/bindings/interface/SBType.i:338 +* C: Returns true for anonymous struct and unions. +* C++: Same as in C. +* Objective-C: Same as in C. Worth noting that anonymous structs are a GNU extension in C++.

[Lldb-commits] [PATCH] D103158: [lldb][NFC] Use Language plugins in Mangled::GuessLanguage

shafik added a comment. I am curious how we would use this, for example `extern "C"` names won't fall under these categories, which may be fine depending on how we are using it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103158/new/

[Lldb-commits] [PATCH] D102942: Remove or use variables which are unused but set.

dblaikie added a comment. In D102942#2791204 , @mbenfield wrote: > I also heard via email from Amara Emerson that the change is fine for similar > reasons. Great, thanks for checking! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D103439: [lldb] Print the backtrace for all threads if the test breakpoint can't be hit

teemperor added a comment. In D103439#2791298 , @JDevlieghere wrote: > LGTM. Are there other places where we check this, either in `lldbutil` or > maybe more generally a pattern in the tests that could be extracted into a > helper? From what I can

[Lldb-commits] [PATCH] D103442: [lldb][NFC] Remove a redundant call to weak_ptr::expired

JDevlieghere accepted this revision as: JDevlieghere. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103442/new/ https://reviews.llvm.org/D103442

[Lldb-commits] [PATCH] D103439: [lldb] Print the backtrace for all threads if the test breakpoint can't be hit

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM. Are there other places where we check this, either in `lldbutil` or maybe more generally a pattern in the tests that could be extracted into a helper? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D103454: [lldb][docs] Document SBType

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. Left few comments regarding the phrasing but LGTM! Thanks for doing it! Comment at: lldb/bindings/interface/SBType.i:372 +%feature("docstring", +"Returns the underlying

[Lldb-commits] [PATCH] D103439: [lldb] Print the backtrace for all threads if the test breakpoint can't be hit

augusto2112 accepted this revision. augusto2112 added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103439/new/ https://reviews.llvm.org/D103439 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D102942: Remove or use variables which are unused but set.

mbenfield added a comment. I also heard via email from Amara Emerson that the change is fine for similar reasons. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102942/new/ https://reviews.llvm.org/D102942

[Lldb-commits] [lldb] ecfca42 - [lldb][NFC] Use Language plugins in Mangled::GuessLanguage

Author: Raphael Isemann Date: 2021-06-01T18:02:07+02:00 New Revision: ecfca427f9601a7789c0703582cff92e7a3277c0 URL: https://github.com/llvm/llvm-project/commit/ecfca427f9601a7789c0703582cff92e7a3277c0 DIFF:

[Lldb-commits] [PATCH] D103158: [lldb][NFC] Use Language plugins in Mangled::GuessLanguage

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGecfca427f960: [lldb][NFC] Use Language plugins in Mangled::GuessLanguage (authored by teemperor). Herald added a subscriber: lldb-commits.

[Lldb-commits] [PATCH] D103349: [lldb] Don't print script output twice in HandleCommand

aprantl added inline comments. Comment at: lldb/include/lldb/Interpreter/CommandReturnObject.h:169 + /// as a temporary. + bool m_hermetic; }; bool m_hermetic = false; Comment at: lldb/source/Interpreter/CommandReturnObject.cpp:46

[Lldb-commits] [PATCH] D103390: [lldb] Remove SBCommandReturnObject::ref

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG01fb14e17763: [lldb] Remove SBCommandReturnObject::ref (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 01fb14e - [lldb] Remove SBCommandReturnObject::ref

Author: Raphael Isemann Date: 2021-06-01T17:57:21+02:00 New Revision: 01fb14e17763269779f2c03b772db960540f47ed URL: https://github.com/llvm/llvm-project/commit/01fb14e17763269779f2c03b772db960540f47ed DIFF:

[Lldb-commits] [PATCH] D103439: [lldb] Print the backtrace for all threads if the test breakpoint can't be hit

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103439/new/ https://reviews.llvm.org/D103439 ___

[Lldb-commits] [PATCH] D102942: Remove or use variables which are unused but set.

samparker added inline comments. Comment at: llvm/lib/Target/ARM/ARMLowOverheadLoops.cpp:1250 else -return false; +return Changed; dblaikie wrote: > Also might be worth reaching out to authors to check that this change is > intended & possibly

[Lldb-commits] [PATCH] D103454: [lldb][docs] Document SBType

teemperor added a comment. The language here might shift between functions and needs to be synced up (that patch was written over a few weeks during some build/test idle time). But the patch seems good enough for a draft. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D103454: [lldb][docs] Document SBType

teemperor created this revision. teemperor added a reviewer: LLDB. teemperor added a project: LLDB. Herald added a subscriber: JDevlieghere. teemperor requested review of this revision. Herald added a subscriber: lldb-commits. This documents the behaviour of the different SBType functions with

[Lldb-commits] [PATCH] D103271: [lldb/Target] Select most relevant frame only in case of signal

PatriosTheGreat updated this revision to Diff 348919. PatriosTheGreat added a comment. Select most related frame only in threads which were stopped with reason. This diff is for further discussion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103271/new/

[Lldb-commits] [PATCH] D103442: [lldb][NFC] Remove a redundant call to weak_ptr::expired

teemperor created this revision. teemperor added a reviewer: LLDB. teemperor added a project: LLDB. Herald added a subscriber: JDevlieghere. teemperor requested review of this revision. Herald added a subscriber: lldb-commits. The `lock` call directly will check for us if the `weak_ptr` is

[Lldb-commits] [PATCH] D103439: [lldb] Print the backtrace for all threads if the test breakpoint can't be hit

teemperor created this revision. teemperor added a reviewer: JDevlieghere. teemperor added a project: LLDB. teemperor requested review of this revision. Herald added a subscriber: lldb-commits. At the moment if a test fails to hits the breakpoint we set in `run_to_source_breakpoint` the test