[Lldb-commits] [PATCH] D103210: [lldb] Introduce Language::MethodNameInfo

2021-06-03 Thread Alex Langford via Phabricator via lldb-commits
bulbazord added a comment. In D103210#2795619 , @teemperor wrote: >> We have a method called `Language::GetMethodNameVariants`, that could be >> extended/modified to be more suitable. Unless you had something else in >> mind? Maybe something more specif

[Lldb-commits] [PATCH] D103652: [lldb][NFC] Refactor name to index maps in Symtab

2021-06-03 Thread Alex Langford via Phabricator via lldb-commits
bulbazord created this revision. bulbazord added reviewers: teemperor, JDevlieghere. Herald added a subscriber: arphaman. bulbazord requested review of this revision. Herald added a project: LLDB. The various maps in Symtab lead to some repetative code. This should improve the situation somewhat.

[Lldb-commits] [PATCH] D103349: [lldb] Don't print script output twice in HandleCommand

2021-06-03 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere updated this revision to Diff 349651. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Don't try to be cute: `s/Hermetic/SuppressImmediateOutput/` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103349/new/ https://reviews.llvm.org/D103349 Files:

[Lldb-commits] [PATCH] D102092: [lldb] Enable -Wmisleading-indentation

2021-06-03 Thread Nico Weber via Phabricator via lldb-commits
thakis added a comment. In D102092#2771746 , @kastiglione wrote: > @thakis thanks for pointing that out. I had tried `-Wall` using the clang > included with the latest version of Xcode, and that does not enable > `-Wmisleading-indentation`. I see from

[Lldb-commits] [PATCH] D103609: [lldb-vscode] Synchronize calls to SendTerminatedEvent

2021-06-03 Thread walter erquinigo via Phabricator via lldb-commits
wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103609/new/ https://reviews.llvm.org/D103609 ___

[Lldb-commits] [PATCH] D103626: [lldb][AArch64] Remove non address bits from memory read arguments

2021-06-03 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added a reviewer: omjavaid. DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. The side effect here is that you do "memory read " and you see untagged addresses for the lines. It's not really that confusing but maybe something we should make a general decision

[Lldb-commits] [PATCH] D103626: [lldb][AArch64] Remove non address bits from memory read arguments

2021-06-03 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett created this revision. Herald added subscribers: danielkiss, kristof.beyls. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Addresses on AArch64 can have top byte tags, memory tags and pointer authentication sign

[Lldb-commits] [lldb] 8ef23a3 - [LLDB] Skip TestDataFormatterStdUniquePtr.py on arm/linux

2021-06-03 Thread Muhammad Omair Javaid via lldb-commits
Author: Muhammad Omair Javaid Date: 2021-06-03T14:57:00+05:00 New Revision: 8ef23a39ca022afab0bbac3daed539ebde75ef73 URL: https://github.com/llvm/llvm-project/commit/8ef23a39ca022afab0bbac3daed539ebde75ef73 DIFF: https://github.com/llvm/llvm-project/commit/8ef23a39ca022afab0bbac3daed539ebde75ef

[Lldb-commits] [lldb] f7e5911 - [LLDB] Skip TestDataFormatterStdUniquePtr.py on arm/linux

2021-06-03 Thread Muhammad Omair Javaid via lldb-commits
Author: Muhammad Omair Javaid Date: 2021-06-03T14:54:03+05:00 New Revision: f7e591161d375a20719db0de942b797c5c3318f3 URL: https://github.com/llvm/llvm-project/commit/f7e591161d375a20719db0de942b797c5c3318f3 DIFF: https://github.com/llvm/llvm-project/commit/f7e591161d375a20719db0de942b797c5c3318

[Lldb-commits] [lldb] e149c8e - [lldb][NFC] Remove unused 'using ArrayRef' in RegisterValueTest

2021-06-03 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2021-06-03T11:17:36+02:00 New Revision: e149c8e8ccce3c3f2fe23e008afdbd99ab33e558 URL: https://github.com/llvm/llvm-project/commit/e149c8e8ccce3c3f2fe23e008afdbd99ab33e558 DIFF: https://github.com/llvm/llvm-project/commit/e149c8e8ccce3c3f2fe23e008afdbd99ab33e558.dif

[Lldb-commits] [PATCH] D103210: [lldb] Introduce Language::MethodNameInfo

2021-06-03 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. Sorry for the delay! > We have a method called `Language::GetMethodNameVariants`, that could be > extended/modified to be more suitable. Unless you had something else in mind? > Maybe something more specific to Symtab mapping like > `Language::GetFunctionNameSearchVa

[Lldb-commits] [PATCH] D103454: [lldb][docs] Document SBType

2021-06-03 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. In D103454#2793219 , @werat wrote: > Is this code used for auto-generated docs? Could be have this documentation > in C++ definitions (lldb/API/SBType.h) as well? I usually just read the C++ > source code, but I can imagine ha