[Lldb-commits] [PATCH] D101285: [lldb] [llgs server] Support creating core dumps on NetBSD

krytarowski accepted this revision. krytarowski added a comment. This revision is now accepted and ready to land. Looks good CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101285/new/ https://reviews.llvm.org/D101285 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D105732: [lldb] Update logic to close inherited file descriptors.

labath added a comment. BTW, since linux-5.9, there's a close_range(2) syscall. Given that's a pretty recent kernel, it may not be very useful right now, but it sounds like a way to go for the future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [lldb] 37cbd81 - [lldb] [llgs server] Support creating core dumps on NetBSD

Author: Michał Górny Date: 2021-09-06T12:16:14+02:00 New Revision: 37cbd817d3e2b8c673862e2eb262cad6dd3dd244 URL: https://github.com/llvm/llvm-project/commit/37cbd817d3e2b8c673862e2eb262cad6dd3dd244 DIFF: https://github.com/llvm/llvm-project/commit/37cbd817d3e2b8c673862e2eb262cad6dd3dd244.diff

[Lldb-commits] [PATCH] D101285: [lldb] [llgs server] Support creating core dumps on NetBSD

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG37cbd817d3e2: [lldb] [llgs server] Support creating core dumps on NetBSD (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM G

Re: [Lldb-commits] [lldb] eee687a - [lldb] Add minidump save-core functionality to ELF object files

Thanks for flagging this! Adding the author of the change. Does it fail somewhere on the llvm builders? Is there an easy way to reproduce this locally? On Thu, 2 Sept 2021 at 01:53, Richard Smith wrote: > The new test fails under MSan: > > Uninitialized bytes in __interceptor_write at offset 2

Re: [Lldb-commits] [lldb] eee687a - [lldb] Add minidump save-core functionality to ELF object files

Not sure if there is a public builder with sanitizer enabled, but compiling LLDB with -DLLVM_USE_SANITIZER=Memory and then doing ninja check-lldb should be enough to reproduce this IIUC. Am Mo., 6. Sept. 2021 um 12:17 Uhr schrieb Andy Yankovsky via lldb-commits : > > Thanks for flagging this! Addi

[Lldb-commits] [lldb] 7fa6b9f - [lldb] Silence compiler warning after fae0dfa6421ea6c02f86ba7292fa782e1e2b69d1

Author: Benjamin Kramer Date: 2021-09-06T12:30:47+02:00 New Revision: 7fa6b9f61058ff4839eb55d7fe8ec2f1e2493d5e URL: https://github.com/llvm/llvm-project/commit/7fa6b9f61058ff4839eb55d7fe8ec2f1e2493d5e DIFF: https://github.com/llvm/llvm-project/commit/7fa6b9f61058ff4839eb55d7fe8ec2f1e2493d5e.dif

[Lldb-commits] [lldb] ac312a9 - [lldb] Silence compiler warnings from 37cbd817d3e2b8c673862e2eb262cad6dd3dd244

Author: Benjamin Kramer Date: 2021-09-06T13:04:21+02:00 New Revision: ac312a9d7c03f0be53834d3f295f1971aaf54649 URL: https://github.com/llvm/llvm-project/commit/ac312a9d7c03f0be53834d3f295f1971aaf54649 DIFF: https://github.com/llvm/llvm-project/commit/ac312a9d7c03f0be53834d3f295f1971aaf54649.dif

[Lldb-commits] [PATCH] D108944: [LLDB][GUI] Add source file searcher

OmarEmaraDev added a comment. @clayborg Did you take a look at this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108944/new/ https://reviews.llvm.org/D108944 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [PATCH] D103127: lldb: Don't check for CMAKE_SYSTEM_NAME==Android.

labath added a comment. How exactly are you building this? CMAKE_SYSTEM_NAME is set in the official android cmake toolchain file (https://android.googlesource.com/platform/ndk/+/refs/heads/ndk-release-r23/build/cmake/android.toolchain.cmake#213) Repository: rG LLVM Github Monorepo CHANGES S

[Lldb-commits] [PATCH] D104231: [lldb] Deprecate the threading functionality in SBHostOS

labath added a comment. In D104231#2817068 , @teemperor wrote: > Not sure what else we should do to properly deprecate an API. LLVM's approach > would be to put `[[deprecated("bla")]]` the C++ APIs (which would mean you > need a C++14 compiler to use th

[Lldb-commits] [PATCH] D101329: [lldb] Support SaveCore() from gdb-remote client

mgorny updated this revision to Diff 370908. mgorny added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101329/new/ https://reviews.llvm.org/D101329 Files: lldb/include/lldb/Target/Process.h lldb/source/Core/PluginManager.cpp lldb/source/Plugins/Process/gdb-re

[Lldb-commits] [PATCH] D109326: [lldb] [Process/FreeBSD] Support SaveCore() using PT_COREDUMP

mgorny created this revision. mgorny added reviewers: emaste, krytarowski, labath, JDevlieghere. mgorny requested review of this revision. https://reviews.llvm.org/D109326 Files: lldb/source/Plugins/Process/FreeBSD/NativeProcessFreeBSD.cpp lldb/source/Plugins/Process/FreeBSD/NativeProcessFree

[Lldb-commits] [PATCH] D101329: [lldb] Support SaveCore() from gdb-remote client

krytarowski accepted this revision. krytarowski added a comment. This revision is now accepted and ready to land. Looks correct. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101329/new/ https://reviews.llvm.org/D101329 ___ lldb-commits maili

[Lldb-commits] [PATCH] D106226: [lldb] Improve error message when "lldb attach" fails

apoos-maximus updated this revision to Diff 370935. apoos-maximus added a comment. added logic to report ptrace related error only if ptrace policy was the actual reason for failure. i.e. by reading the value of /proc/sys/kernel/yama/ptrace_scope file if it exists, and setting the ptrace error on

[Lldb-commits] [lldb] 25fbbc5 - [lldb] Support SaveCore() from gdb-remote client

Author: Michał Górny Date: 2021-09-06T18:33:02+02:00 New Revision: 25fbbc5936c0e05095618f4b80b303227fbb708b URL: https://github.com/llvm/llvm-project/commit/25fbbc5936c0e05095618f4b80b303227fbb708b DIFF: https://github.com/llvm/llvm-project/commit/25fbbc5936c0e05095618f4b80b303227fbb708b.diff

[Lldb-commits] [PATCH] D101329: [lldb] Support SaveCore() from gdb-remote client

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG25fbbc5936c0: [lldb] Support SaveCore() from gdb-remote client (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Mono

[Lldb-commits] [PATCH] D108739: [LLDB] AArch64 SVE restore SVE registers after expression

rankov added a comment. I have tested this patch with my setup and it fixes the issues described. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108739/new/ https://reviews.llvm.org/D108739 ___ lldb-commits mailing list lldb-commits@l

[Lldb-commits] [lldb] 4a0ba41 - [lldb] Fix pessimizing move warning

Author: Benjamin Kramer Date: 2021-09-06T21:17:29+02:00 New Revision: 4a0ba4180b3655aa39c68648c7a12ce9a1cec99a URL: https://github.com/llvm/llvm-project/commit/4a0ba4180b3655aa39c68648c7a12ce9a1cec99a DIFF: https://github.com/llvm/llvm-project/commit/4a0ba4180b3655aa39c68648c7a12ce9a1cec99a.dif

[Lldb-commits] [PATCH] D106226: [lldb] Improve error message when "lldb attach" fails

apoos-maximus updated this revision to Diff 370960. apoos-maximus added a comment. Changed the error message to be more informative, and added things, based on the previous review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106226/new/ https://r

[Lldb-commits] [PATCH] D109336: [lldb] Skip TestAppleSimulatorOSType if json parsing fails

augusto2112 created this revision. augusto2112 added reviewers: teemperor, aprantl. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. xcodebuild, which is invoked by the apple_simulator_test decorator, may may return a successful

[Lldb-commits] [PATCH] D106226: [lldb] Improve error message when "lldb attach" fails

apoos-maximus added a comment. Hi, @DavidSpickett, @teemperor, @rupprecht After our previous discussions, I have modified the patch. Now :- 1. OS is detected in Target::Attach(), and reason for failure is analyzed accordingly. 2. ptrace_scope related error message is only emitted after checkin

[Lldb-commits] [PATCH] D106226: [lldb] Improve error message when "lldb attach" fails

apoos-maximus added a comment. Hi, @DavidSpickett, @teemperor, @rupprecht After our previous discussions, I have modified the patch. Now :- 1. OS is detected in Target::Attach(), and reason for failure is analyzed accordingly. 2. ptrace_scope related error message is only emitted after checkin

[Lldb-commits] [PATCH] D109339: Fix compilation error with older libstdc++

vadimcn created this revision. vadimcn added a reviewer: jingham. vadimcn added a project: LLDB. Herald added a subscriber: JDevlieghere. vadimcn requested review of this revision. Herald added a subscriber: lldb-commits. Until GCC 6, std::unordered_map could not emplace non-copyable values, which