[Lldb-commits] [PATCH] D107809: [lldb] Add new commands and tests for getting file perms & exists

labath added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp:661-664 +if (mode != llvm::sys::fs::perms_not_known) + response.Printf("F%x", mode); +else + response.Printf("F-1,%x", (int)Status(ec).GetErr

[Lldb-commits] [PATCH] D101563: [lldb] [test] Extend aarch64-gp-read test to cover all registers

krytarowski requested changes to this revision. krytarowski added a comment. This revision now requires changes to proceed. There is an unhandled comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101563/new/ https://reviews.llvm.org/D101563

[Lldb-commits] [PATCH] D109249: [lldb] Add Getdescription function for SBInstruction.

labath added a comment. I'm not sure what's the exact use case here, but I /think/ that passing just the target part of the execution context will is not sufficient to enable all the disassembler bells and whistles. For example the regular "disassemble" command will also print a "-> " next to t

[Lldb-commits] [PATCH] D107811: [lldb] [gdb-remote] Add fallbacks for vFile:mode and vFile:exists

labath added a comment. In the code and/or in the commit message. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107811/new/ https://reviews.llvm.org/D107811 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-

[Lldb-commits] [PATCH] D107809: [lldb] Add new commands and tests for getting file perms & exists

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp:661-664 +if (mode != llvm::sys::fs::perms_not_known) + response.Printf("F%x", mode); +else + response.Printf("F-1,%x", (int)Status(ec).GetErr

[Lldb-commits] [PATCH] D107821: [lldb] [gdb-server] Add tests for more vFile packets

mgorny added a comment. In D107821#2986450 , @labath wrote: > Instead of the tempfile thingies I'd probably just use fixed files names in > the build directory -- it's specific to a single test, automatically cleaned > on each run and it's where all of

[Lldb-commits] [PATCH] D109326: [lldb] [Process/FreeBSD] Support SaveCore() using PT_COREDUMP

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb07803ee2a97: [lldb] [Process/FreeBSD] Support SaveCore() using PT_COREDUMP (authored by mgorny). Herald added a project: LLDB. Repository: rG LLV

[Lldb-commits] [lldb] 39a2449 - [lldb] [Commands] Fix reporting errors in 'platform file read/write'

Author: Michał Górny Date: 2021-09-08T10:58:12+02:00 New Revision: 39a2449ea1333886a9c9104b5afb4ff9c4932403 URL: https://github.com/llvm/llvm-project/commit/39a2449ea1333886a9c9104b5afb4ff9c4932403 DIFF: https://github.com/llvm/llvm-project/commit/39a2449ea1333886a9c9104b5afb4ff9c4932403.diff

[Lldb-commits] [lldb] b07803e - [lldb] [Process/FreeBSD] Support SaveCore() using PT_COREDUMP

Author: Michał Górny Date: 2021-09-08T10:58:12+02:00 New Revision: b07803ee2a97fdcf4ed6494d8d6593bf985a5150 URL: https://github.com/llvm/llvm-project/commit/b07803ee2a97fdcf4ed6494d8d6593bf985a5150 DIFF: https://github.com/llvm/llvm-project/commit/b07803ee2a97fdcf4ed6494d8d6593bf985a5150.diff

[Lldb-commits] [PATCH] D107665: [lldb] [Commands] Fix reporting errors in 'platform file read/write'

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG39a2449ea133: [lldb] [Commands] Fix reporting errors in 'platform file read/write' (authored by mgorny). Herald added a project: LLDB. Repository:

[Lldb-commits] [lldb] 8872c9d - [lldb] [gdb-server] Add tests for more vFile packets

Author: Michał Górny Date: 2021-09-08T10:58:12+02:00 New Revision: 8872c9d1ca2189c55fda0246890b42f67a460598 URL: https://github.com/llvm/llvm-project/commit/8872c9d1ca2189c55fda0246890b42f67a460598 DIFF: https://github.com/llvm/llvm-project/commit/8872c9d1ca2189c55fda0246890b42f67a460598.diff

[Lldb-commits] [PATCH] D107821: [lldb] [gdb-server] Add tests for more vFile packets

This revision was automatically updated to reflect the committed changes. Closed by commit rG8872c9d1ca21: [lldb] [gdb-server] Add tests for more vFile packets (authored by mgorny). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D107821?vs=365451&id=371284#toc

[Lldb-commits] [PATCH] D107931: [lldb] [gdb-remote] Implement vRun packet

mgorny added a comment. While technically this patch doesn't depend on these two, applying them out of order would cause unnecessary rebase hell. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107931/new/ https://reviews.llvm.org/D107931 ___

[Lldb-commits] [PATCH] D102428: [StopInfoMachException] Summarize arm64e BLRAx/LDRAx auth failures

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. Apologies, I forgot about this for way too long. I don't think Omair is going to object anyway so let's get this in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[Lldb-commits] [lldb] c01b76e - [lldb] Support "eflags" register name in generic reg fallback

Author: Michał Górny Date: 2021-09-08T11:33:29+02:00 New Revision: c01b76e733d6e5e2d21e4277dceaa1f319794c6a URL: https://github.com/llvm/llvm-project/commit/c01b76e733d6e5e2d21e4277dceaa1f319794c6a DIFF: https://github.com/llvm/llvm-project/commit/c01b76e733d6e5e2d21e4277dceaa1f319794c6a.diff

[Lldb-commits] [PATCH] D108548: [lldb] Support "eflags" register name in generic reg fallback

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc01b76e733d6: [lldb] Support "eflags" register name in generic reg fallback (authored by mgorny). Herald added a project: LLDB. Repository: rG LLV

[Lldb-commits] [PATCH] D109427: [lldb] Remove unused GDBRemoteCommunicationClient::SendAttach function

DavidSpickett created this revision. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D109427 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicati

[Lldb-commits] [PATCH] D109427: [lldb] Remove unused GDBRemoteCommunicationClient::SendAttach function

DavidSpickett added a reviewer: teemperor. DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. Asking for review to double check. Nothing in lldb upstream calls this and I think that's because we switched to a style where we ask to attach then have a callback that will tell u

[Lldb-commits] [PATCH] D107780: [lldb] [gdb-remote] Implement fallback to vFile:stat for GetFileSize()

mgorny updated this revision to Diff 371300. mgorny added a comment. Fix lint warnings. Add a note about not-full-replacement as requested in D107811 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107780/new/ https://reviews.llvm.org/D107780 Files:

[Lldb-commits] [PATCH] D107811: [lldb] [gdb-remote] Add fallbacks for vFile:mode and vFile:exists

mgorny updated this revision to Diff 371307. mgorny added a comment. Add fallback notes, as requested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107811/new/ https://reviews.llvm.org/D107811 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp lldb/sour

[Lldb-commits] [PATCH] D107780: [lldb] [gdb-remote] Implement fallback to vFile:stat for GetFileSize()

labath added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.h:56-70 +struct GDBRemoteFStatData { + uint32_t gdb_st_dev; + uint32_t gdb_st_ino; + uint32_t gdb_st_mode; + uint32_t gdb_st_nlink; + uint32_t gdb_st_uid; + uint32_t gdb

[Lldb-commits] [PATCH] D108768: [lldb] DynamicRegisterInfo: fix wrong regnos in Dump()

labath added a reviewer: omjavaid. labath added a comment. I'm not sure if this is correct, or if I want it to be correct. I think that a lot of the confusion comes from the fact that this structure is used both in lldb-server and lldb, and I'm not sure that the fields have the same meaning in

[Lldb-commits] [PATCH] D107664: [lldb] [Commands] Remove 'append' from 'platform file open' mode

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Sounds reasonable. > The Linux manpage for pwrite(2) suggests that Linux does not respect O_APPEND > there, I guess it would be more correct to say that it "respects" O_APPEND, when it fact

[Lldb-commits] [PATCH] D107079: [lldb] Add an option for emitting LLDB logs as JSON

labath added a comment. I think that a structured logging format could be very useful. I am not sure what to make of the trailing "," in the json format though. It seems its usefulness is fairly limited, given that additional post processing is still needed to turn it into valid json. One could

[Lldb-commits] [PATCH] D108468: [lldb] [gdb-remote] Fix displaying i387_ext & vec regs with gdbserver

labath added a comment. Is printing STi as a vector actually desired? It seems to me that printing them as floating point would be more useful. Have you looked at what it would take to make lldb-server print them as FP as well? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108468/new/

[Lldb-commits] [PATCH] D107664: [lldb] [Commands] Remove 'append' from 'platform file open' mode

mgorny added a comment. Thanks, I'll improve the commit message as suggested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107664/new/ https://reviews.llvm.org/D107664 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [lldb] 2c6d90d - [lldb] [Commands] Remove 'append' from 'platform file open' mode

Author: Michał Górny Date: 2021-09-08T15:28:03+02:00 New Revision: 2c6d90d7410b77798699ff2fff4182d83db79164 URL: https://github.com/llvm/llvm-project/commit/2c6d90d7410b77798699ff2fff4182d83db79164 DIFF: https://github.com/llvm/llvm-project/commit/2c6d90d7410b77798699ff2fff4182d83db79164.diff

[Lldb-commits] [PATCH] D107664: [lldb] [Commands] Remove 'append' from 'platform file open' mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2c6d90d7410b: [lldb] [Commands] Remove 'append' from 'platform file open' mode (authored by mgorny). Herald added a project: LLDB. Repository: rG

[Lldb-commits] [PATCH] D108468: [lldb] [gdb-remote] Fix displaying i387_ext & vec regs with gdbserver

mgorny added a comment. At a quick glance, we'd have to enhance `Scalar` to fully support x87 extended type. FWICS it's currently modeled to use convert `APFloat` from/to `float`/`double`/`long double` types. Maybe we could get away with some lossy rounding but it doesn't like a good way forwar

[Lldb-commits] [lldb] d2189b5 - [lldb] Remove unused GDBRemoteCommunicationClient::SendAttach function

Author: David Spickett Date: 2021-09-08T15:14:02Z New Revision: d2189b5c4b011201f784ed7f503287c543076f91 URL: https://github.com/llvm/llvm-project/commit/d2189b5c4b011201f784ed7f503287c543076f91 DIFF: https://github.com/llvm/llvm-project/commit/d2189b5c4b011201f784ed7f503287c543076f91.diff LOG

[Lldb-commits] [PATCH] D109427: [lldb] Remove unused GDBRemoteCommunicationClient::SendAttach function

This revision was automatically updated to reflect the committed changes. Closed by commit rGd2189b5c4b01: [lldb] Remove unused GDBRemoteCommunicationClient::SendAttach function (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [PATCH] D108148: [lldb] [gdb-remote] Use standardized GDB errno values

mgorny updated this revision to Diff 371351. mgorny added a comment. Use a .def file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108148/new/ https://reviews.llvm.org/D108148 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.h lldb/source/Plugins/Process/gdb-re

[Lldb-commits] [PATCH] D108739: [LLDB] AArch64 SVE restore SVE registers after expression

omjavaid updated this revision to Diff 371380. omjavaid added a comment. This update addresses review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108739/new/ https://reviews.llvm.org/D108739 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp l

[Lldb-commits] [PATCH] D109249: [lldb] Add Getdescription function for SBInstruction.

jingham added a comment. Would it be better to make an API that takes an SBExecutionContext? If you knew the frame that held In D109249#2988808 , @labath wrote: > I'm not sure what's the exact use case here, but I /think/ that passing just > the targe

[Lldb-commits] [PATCH] D108768: [lldb] DynamicRegisterInfo: fix wrong regnos in Dump()

omjavaid added a comment. This is complicated mainly because we are trying to merge two different register numbering scheme. On LLDB (host) side we try to construct register number from parsing register xml assigning register numbers in the increasing order. But we also have target supplied reg

[Lldb-commits] [lldb] 303b27f - [lldb] Delete IRExecutionUnit::SearchSpec

Author: Alex Langford Date: 2021-09-08T11:27:10-07:00 New Revision: 303b27f21b98a45621d39f941c88c7e30d69fbe7 URL: https://github.com/llvm/llvm-project/commit/303b27f21b98a45621d39f941c88c7e30d69fbe7 DIFF: https://github.com/llvm/llvm-project/commit/303b27f21b98a45621d39f941c88c7e30d69fbe7.diff

[Lldb-commits] [PATCH] D109384: [lldb] Delete IRExecutionUnit::SearchSpec

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG303b27f21b98: [lldb] Delete IRExecutionUnit::SearchSpec (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

rdhindsa updated this revision to Diff 371425. rdhindsa marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108061/new/ https://reviews.llvm.org/D108061 Files: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous

[Lldb-commits] [PATCH] D103127: lldb: Don't check for CMAKE_SYSTEM_NAME==Android.

pcc added a comment. In D103127#2985203 , @labath wrote: > How exactly are you building this? CMAKE_SYSTEM_NAME is set in the official > android cmake toolchain file > (https://android.googlesource.com/platform/ndk/+/refs/heads/ndk-release-r23/build/cma

[Lldb-commits] [lldb] d1d4f36 - [lldb] Make sure there's a value for the key before dereferencing.

Author: Jonas Devlieghere Date: 2021-09-08T13:46:09-07:00 New Revision: d1d4f365566ce9aae40d1f46cae517e4fe8fe6ee URL: https://github.com/llvm/llvm-project/commit/d1d4f365566ce9aae40d1f46cae517e4fe8fe6ee DIFF: https://github.com/llvm/llvm-project/commit/d1d4f365566ce9aae40d1f46cae517e4fe8fe6ee.d

[Lldb-commits] [PATCH] D109463: gn build: Add support for building LLDB on Linux.

pcc created this revision. pcc added a reviewer: thakis. Herald added a subscriber: emaste. pcc requested review of this revision. Herald added a project: LLVM. On Linux, LLDB depends on lldb-server at runtime (is it different on Mac?), so I created a top-level lldb target that will build both lld

[Lldb-commits] [PATCH] D109464: gn build: Add support for building lldb-server on Android.

pcc created this revision. pcc added a reviewer: thakis. Herald added a subscriber: danielkiss. pcc requested review of this revision. Herald added a project: LLVM. The cross-compiled lldb-server targets are added to the top-level lldb target if Android cross compilation is enabled. Repository:

[Lldb-commits] [PATCH] D109463: gn build: Add support for building LLDB on Linux.

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Very cool. LG with top-level BUILD.gn comment addressed :) Comment at: llvm/utils/gn/secondary/BUILD.gn:15 "//lld/test", +"//lldb", "//llvm/test", -

[Lldb-commits] [PATCH] D109464: gn build: Add support for building lldb-server on Android.

thakis added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109464/new/ https://reviews.llvm.org/D109464 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cg

[Lldb-commits] [PATCH] D109463: gn build: Add support for building LLDB on Linux.

pcc added inline comments. Comment at: llvm/utils/gn/secondary/BUILD.gn:15 "//lld/test", +"//lldb", "//llvm/test", thakis wrote: > Does this build fine on windows? > > Generally this only depends on the test targets which in turn depend on the > b

[Lldb-commits] [PATCH] D109463: gn build: Add support for building LLDB on Linux.

pcc updated this revision to Diff 371464. pcc added a comment. Move to data_deps Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109463/new/ https://reviews.llvm.org/D109463 Files: llvm/utils/gn/secondary/BUILD.gn llvm/utils/gn/secondary/lldb/in

[Lldb-commits] [PATCH] D109464: gn build: Add support for building lldb-server on Android.

pcc updated this revision to Diff 371465. pcc added a comment. Move to data_deps Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109464/new/ https://reviews.llvm.org/D109464 Files: llvm/utils/gn/build/libs/xml/enable.gni llvm/utils/gn/secondary/

[Lldb-commits] [PATCH] D109463: gn build: Add support for building LLDB on Linux.

thakis added inline comments. Comment at: llvm/utils/gn/secondary/BUILD.gn:15 "//lld/test", +"//lldb", "//llvm/test", pcc wrote: > thakis wrote: > > Does this build fine on windows? > > > > Generally this only depends on the test targets which in t

[Lldb-commits] [PATCH] D109463: gn build: Add support for building LLDB on Linux.

pcc added inline comments. Comment at: llvm/utils/gn/secondary/BUILD.gn:15 "//lld/test", +"//lldb", "//llvm/test", thakis wrote: > pcc wrote: > > thakis wrote: > > > Does this build fine on windows? > > > > > > Generally this only depends on the te

[Lldb-commits] [PATCH] D109463: gn build: Add support for building LLDB on Linux.

thakis added inline comments. Comment at: llvm/utils/gn/secondary/BUILD.gn:15 "//lld/test", +"//lldb", "//llvm/test", pcc wrote: > thakis wrote: > > pcc wrote: > > > thakis wrote: > > > > Does this build fine on windows? > > > > > > > > Generally t

[Lldb-commits] [PATCH] D109463: gn build: Add support for building LLDB on Linux.

thakis added a comment. (Please watch http://45.33.8.238/ when landing this :) ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109463/new/ https://reviews.llvm.org/D109463 ___ lldb-commits mailing list l

[Lldb-commits] [PATCH] D109463: gn build: Add support for building LLDB on Linux.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9449f441fc9b: gn build: Add support for building LLDB on Linux. (authored by pcc). Changed prior to commit: https://reviews.llvm.org/D109463?vs=37

[Lldb-commits] [PATCH] D109464: gn build: Add support for building lldb-server on Android.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG883e93cb280e: gn build: Add support for building lldb-server on Android. (authored by pcc). Changed prior to commit: https://reviews.llvm.org/D109