[Lldb-commits] [lldb] 89ed21a - Recognize namespaced all_image_infos symbol name from dyld

Author: Jason Molenda Date: 2021-09-10T16:56:48-07:00 New Revision: 89ed21a8f864b1c33a95ed127d073842adc2fcd0 URL: https://github.com/llvm/llvm-project/commit/89ed21a8f864b1c33a95ed127d073842adc2fcd0 DIFF: https://github.com/llvm/llvm-project/commit/89ed21a8f864b1c33a95ed127d073842adc2fcd0.diff

[Lldb-commits] [PATCH] D109633: [lldb-vscode] Fix focus thread when previous thread exits

ted created this revision. ted added a reviewer: clayborg. ted added a project: LLDB. Herald added a subscriber: JDevlieghere. ted requested review of this revision. The thread that Visual Studio Code displays on a stop is called the focus thread. When the previous focus thread exits and we stop

[Lldb-commits] [lldb] 8dae355 - [lldb] Remove unused typedefs from lldb-forward.h

Author: Alex Langford Date: 2021-09-10T14:16:47-07:00 New Revision: 8dae35527fb77a4698d05d39ed66f8c545885098 URL: https://github.com/llvm/llvm-project/commit/8dae35527fb77a4698d05d39ed66f8c545885098 DIFF: https://github.com/llvm/llvm-project/commit/8dae35527fb77a4698d05d39ed66f8c545885098.diff

[Lldb-commits] [PATCH] D109626: [lldb] Remove redundant register alt_names

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. Herald added subscribers: atanasyan, jrtc27, kbarton, kristof.beyls, nemanjai, sdardis. mgorny requested review of this revision. Remove redundant register alt_names that correspond to their respective generic

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

rdhindsa added a comment. With this patch, it looks like the test added in this patch fails for lldb-arm-ubuntu: https://lab.llvm.org/buildbot/#/builders/17/builds/10498 Everything passes on these buildbots: lldb-aarch64-ubuntu, lldb-x64-windows-ninja, lldb-x86_64-debian. The test logic

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG03df97101287: [lldb] Add support for debugging via the dynamic

[Lldb-commits] [lldb] 03df971 - [lldb] Add support for debugging via the dynamic linker.

Author: Rumeet Dhindsa Date: 2021-09-10T10:59:31-07:00 New Revision: 03df97101287e8cb647c6c0982c4efdb82585c21 URL: https://github.com/llvm/llvm-project/commit/03df97101287e8cb647c6c0982c4efdb82585c21 DIFF:

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

rdhindsa added a comment. @teemperor: I believe I have addressed your comments. If there is any other concern, I can address it post-commit. Thank you everyone for the review and help with the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D109600: [lldb] Remove PluginInterface::GetPluginVersion

bulbazord accepted this revision. bulbazord added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109600/new/ https://reviews.llvm.org/D109600 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D108554: [lldb] Support querying registers via generic names without alt_names

mgorny updated this revision to Diff 371941. mgorny added a comment. Fixed `SBFrame` stuffs. While at it, changed `ValueObjectRegister` to take `const RegisterInfo *` instead of the index, since it's almost always what it really wants. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D109600: [lldb] Remove PluginInterface::GetPluginVersion

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109600/new/ https://reviews.llvm.org/D109600

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

clayborg added a comment. Thanks Pavel for figuring out the XML issue. I will need to add that to my box of tricks when buildbots fail! I look forward to seeing this patch go in Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108061/new/

[Lldb-commits] [lldb] 4e7ac6f - [lldb] [test] Remove parent check in Subprocess/clone-follow-child-softbp.test

Author: Michał Górny Date: 2021-09-10T18:03:05+02:00 New Revision: 4e7ac6facad6d6c895c750a232d3786defedcc7b URL: https://github.com/llvm/llvm-project/commit/4e7ac6facad6d6c895c750a232d3786defedcc7b DIFF: https://github.com/llvm/llvm-project/commit/4e7ac6facad6d6c895c750a232d3786defedcc7b.diff

[Lldb-commits] [PATCH] D109345: MemoryBuffer: Migrate to Expected/llvm::Error from ErrorOr/std::error_code

dexonsmith added a comment. In D109345#2990612 , @dblaikie wrote: > Given the amount of churn this means, though - reckon it's worth it? Reckon > it needs more llvm-dev thread/buy-in/etc? I think the churn is worth since my intuition is that it has

[Lldb-commits] [PATCH] D109345: MemoryBuffer: Migrate to Expected/llvm::Error from ErrorOr/std::error_code

dexonsmith added a comment. In D109345#2992274 , @dexonsmith wrote: > 4. One or more commits: > 1. Migrate in-tree callers to MemoryBuffer. > 2. Delete MemoryBufferErrorAPI alias. > 5. Delete MemoryBufferErrorCodeAPI wrappers. (Potentially

[Lldb-commits] [PATCH] D109483: [APInt] Normalize naming on keep constructors / predicate methods.

lattner added a comment. I'll take care of the DAG.getAllOnesConstant change, but i'd appreciate it if you could look at the NOT cases. Running tests on the DAG.getAllOnesConstant patch now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D109483: [APInt] Normalize naming on keep constructors / predicate methods.

lattner added a comment. Thank you for the detailed review Craig! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109483/new/ https://reviews.llvm.org/D109483 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D109483: [APInt] Normalize naming on keep constructors / predicate methods.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109483/new/ https://reviews.llvm.org/D109483

[Lldb-commits] [PATCH] D109483: [APInt] Normalize naming on keep constructors / predicate methods.

lattner added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:3243 "Don't know how to expand this subtraction!"); -Tmp1 = DAG.getNode(ISD::XOR, dl, VT, Node->getOperand(1), -

[Lldb-commits] [lldb] d727bd6 - [lldb] [test] Skip A/vRun/QEnvironment* tests on Windows, and fix them

Author: Michał Górny Date: 2021-09-10T16:34:20+02:00 New Revision: d727bd696293a5e8ba63c01b6ec80b2b17eb373a URL: https://github.com/llvm/llvm-project/commit/d727bd696293a5e8ba63c01b6ec80b2b17eb373a DIFF: https://github.com/llvm/llvm-project/commit/d727bd696293a5e8ba63c01b6ec80b2b17eb373a.diff

[Lldb-commits] [lldb] 784281d - [lldb] [test] Attempt to fix gdb_remote_client A/vRun tests on Windows

Author: Michał Górny Date: 2021-09-10T16:27:29+02:00 New Revision: 784281d3164862cb5c7f8f20de80f3d52cc13307 URL: https://github.com/llvm/llvm-project/commit/784281d3164862cb5c7f8f20de80f3d52cc13307 DIFF: https://github.com/llvm/llvm-project/commit/784281d3164862cb5c7f8f20de80f3d52cc13307.diff

[Lldb-commits] [lldb] c362f61 - [lldb] [test] Mark new launch/QEnvironment tests as llgs category

Author: Michał Górny Date: 2021-09-10T16:23:43+02:00 New Revision: c362f610f8c08fc53bdf6aea6e990b26fe63b097 URL: https://github.com/llvm/llvm-project/commit/c362f610f8c08fc53bdf6aea6e990b26fe63b097 DIFF: https://github.com/llvm/llvm-project/commit/c362f610f8c08fc53bdf6aea6e990b26fe63b097.diff

[Lldb-commits] [lldb] 9a4379c - [lldb] [test] Skip file permission tests on Windows

Author: Michał Górny Date: 2021-09-10T16:23:42+02:00 New Revision: 9a4379c3dcab8f7d99975eb6741fe17d1788e461 URL: https://github.com/llvm/llvm-project/commit/9a4379c3dcab8f7d99975eb6741fe17d1788e461 DIFF: https://github.com/llvm/llvm-project/commit/9a4379c3dcab8f7d99975eb6741fe17d1788e461.diff

[Lldb-commits] [PATCH] D109600: [lldb] Remove PluginInterface::GetPluginVersion

labath created this revision. labath added reviewers: teemperor, JDevlieghere. Herald added subscribers: atanasyan, jrtc27, kbarton, sbc100, nemanjai, sdardis, emaste. labath requested review of this revision. Herald added subscribers: MaskRay, aheejin. Herald added a project: LLDB. In all these

[Lldb-commits] [lldb] beb768f - [lldb] Clean up Platform/CMakeLists.txt

Author: Pavel Labath Date: 2021-09-10T14:18:41+02:00 New Revision: beb768f40b47e23e05766738edc0e7723e2f98d4 URL: https://github.com/llvm/llvm-project/commit/beb768f40b47e23e05766738edc0e7723e2f98d4 DIFF: https://github.com/llvm/llvm-project/commit/beb768f40b47e23e05766738edc0e7723e2f98d4.diff

[Lldb-commits] [PATCH] D108554: [lldb] Support querying registers via generic names without alt_names

labath added a comment. These are pretty much the SB equivalents of register read, and they should keep working CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108554/new/ https://reviews.llvm.org/D108554 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D108148: [lldb] [gdb-remote] Use standardized GDB errno values

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3d3017d344f6: [lldb] [gdb-remote] Use standardized GDB errno values (authored by mgorny). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D108018: [lldb] [gdb-remote] Support QEnvironment fallback to hex-encoded

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3fade9542200: [lldb] [gdb-remote] Support QEnvironment fallback to hex-encoded (authored by mgorny). Herald added a project: LLDB. Repository: rG

[Lldb-commits] [PATCH] D107931: [lldb] [gdb-remote] Implement vRun packet

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6ba3f7237dc7: [lldb] [gdb-remote] Implement the vRun packet (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D107811: [lldb] [gdb-remote] Add fallbacks for vFile:mode and vFile:exists

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG501eaf88770d: [lldb] [gdb-remote] Add fallbacks for vFile:mode and vFile:exists (authored by mgorny). Herald added a project: LLDB. Changed prior

[Lldb-commits] [lldb] 3d3017d - [lldb] [gdb-remote] Use standardized GDB errno values

Author: Michał Górny Date: 2021-09-10T14:08:36+02:00 New Revision: 3d3017d344f6514bbb2e5ff49a335d36e31faf55 URL: https://github.com/llvm/llvm-project/commit/3d3017d344f6514bbb2e5ff49a335d36e31faf55 DIFF: https://github.com/llvm/llvm-project/commit/3d3017d344f6514bbb2e5ff49a335d36e31faf55.diff

[Lldb-commits] [PATCH] D107809: [lldb] Add new commands and tests for getting file perms & exists

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdbb0c14d2729: [lldb] Add new commands and tests for getting file perms exists (authored by mgorny). Herald added a project: LLDB. Repository: rG

[Lldb-commits] [lldb] 3fade95 - [lldb] [gdb-remote] Support QEnvironment fallback to hex-encoded

Author: Michał Górny Date: 2021-09-10T14:08:36+02:00 New Revision: 3fade9542200c96021522f91ba5afdbff02729e1 URL: https://github.com/llvm/llvm-project/commit/3fade9542200c96021522f91ba5afdbff02729e1 DIFF: https://github.com/llvm/llvm-project/commit/3fade9542200c96021522f91ba5afdbff02729e1.diff

[Lldb-commits] [lldb] 6ba3f72 - [lldb] [gdb-remote] Implement the vRun packet

Author: Michał Górny Date: 2021-09-10T14:08:36+02:00 New Revision: 6ba3f7237dc750aad2ce1d6a7a15e3b78370221a URL: https://github.com/llvm/llvm-project/commit/6ba3f7237dc750aad2ce1d6a7a15e3b78370221a DIFF: https://github.com/llvm/llvm-project/commit/6ba3f7237dc750aad2ce1d6a7a15e3b78370221a.diff

[Lldb-commits] [PATCH] D109585: [lldb] [test] Move "platform connect" logic into a common class

This revision was automatically updated to reflect the committed changes. Closed by commit rGc240d2bb06da: [lldb] [test] Move platform connect logic into a common class (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 501eaf8 - [lldb] [gdb-remote] Add fallbacks for vFile:mode and vFile:exists

Author: Michał Górny Date: 2021-09-10T14:08:36+02:00 New Revision: 501eaf88770d15de92fa0eb7435f0470a3b93b0a URL: https://github.com/llvm/llvm-project/commit/501eaf88770d15de92fa0eb7435f0470a3b93b0a DIFF: https://github.com/llvm/llvm-project/commit/501eaf88770d15de92fa0eb7435f0470a3b93b0a.diff

[Lldb-commits] [lldb] dbb0c14 - [lldb] Add new commands and tests for getting file perms & exists

Author: Michał Górny Date: 2021-09-10T14:08:36+02:00 New Revision: dbb0c14d2729d135d9d6bb2d0e858e128129da08 URL: https://github.com/llvm/llvm-project/commit/dbb0c14d2729d135d9d6bb2d0e858e128129da08 DIFF: https://github.com/llvm/llvm-project/commit/dbb0c14d2729d135d9d6bb2d0e858e128129da08.diff

[Lldb-commits] [lldb] c240d2b - [lldb] [test] Move "platform connect" logic into a common class

Author: Michał Górny Date: 2021-09-10T14:08:35+02:00 New Revision: c240d2bb06dabe8fb3a1c2da978fbdc9f642de73 URL: https://github.com/llvm/llvm-project/commit/c240d2bb06dabe8fb3a1c2da978fbdc9f642de73 DIFF: https://github.com/llvm/llvm-project/commit/c240d2bb06dabe8fb3a1c2da978fbdc9f642de73.diff

[Lldb-commits] [PATCH] D108554: [lldb] Support querying registers via generic names without alt_names

mgorny added a comment. Ok, so I've done some testing and indeed Native* part doesn't seem necessary. However, after removing the aliases from x86_64 target def, there are two test regressions. The two following snippets no longer seem to work: eip = frame.FindRegister("pc") sp_value =

[Lldb-commits] [PATCH] D107809: [lldb] Add new commands and tests for getting file perms & exists

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. cool CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107809/new/ https://reviews.llvm.org/D107809 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

labath accepted this revision. labath added a comment. Ok, let's give this one more shot. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108061/new/ https://reviews.llvm.org/D108061 ___

[Lldb-commits] [lldb] 0c8444b - [lldb] Fix Clang modules build after D101329

Author: Raphael Isemann Date: 2021-09-10T13:10:19+02:00 New Revision: 0c8444bd3462a3d05c8ac637a554e1a368dee0ac URL: https://github.com/llvm/llvm-project/commit/0c8444bd3462a3d05c8ac637a554e1a368dee0ac DIFF:

[Lldb-commits] [PATCH] D109591: [lldb] [test] Synchronize before the breakpoint in fork tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcaf508d71243: [lldb] [test] Synchronize before the breakpoint in fork tests (authored by mgorny). Herald added a project: LLDB. Repository: rG

[Lldb-commits] [lldb] caf508d - [lldb] [test] Synchronize before the breakpoint in fork tests

Author: Michał Górny Date: 2021-09-10T13:06:01+02:00 New Revision: caf508d7124353522e7604dbfea36b429469bd39 URL: https://github.com/llvm/llvm-project/commit/caf508d7124353522e7604dbfea36b429469bd39 DIFF: https://github.com/llvm/llvm-project/commit/caf508d7124353522e7604dbfea36b429469bd39.diff

[Lldb-commits] [PATCH] D109591: [lldb] [test] Synchronize before the breakpoint in fork tests

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. mgorny requested review of this revision. We set breakpoint on child_func, so synchronization inside it is too late to guarantee ordering between the parent output and child breakpoint. Split the function in two,

[Lldb-commits] [PATCH] D107809: [lldb] Add new commands and tests for getting file perms & exists

mgorny updated this revision to Diff 371858. mgorny marked 2 inline comments as done. mgorny added a comment. Add a server test for error condition. Rebase client tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107809/new/ https://reviews.llvm.org/D107809 Files:

[Lldb-commits] [lldb] e066c00 - [lldb] [gdb-server] Zero-initialize fields on WIN32

Author: Michał Górny Date: 2021-09-10T11:59:06+02:00 New Revision: e066c00be09a9257a28eaf12059e4d28f095ae65 URL: https://github.com/llvm/llvm-project/commit/e066c00be09a9257a28eaf12059e4d28f095ae65 DIFF: https://github.com/llvm/llvm-project/commit/e066c00be09a9257a28eaf12059e4d28f095ae65.diff

[Lldb-commits] [PATCH] D107840: [lldb] [gdb-server] Implement the vFile:fstat packet

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa1097d315c80: Reland [lldb] [gdb-server] Implement the vFile:fstat packet (authored by mgorny). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [lldb] a1097d3 - Reland "[lldb] [gdb-server] Implement the vFile:fstat packet"

Author: Michał Górny Date: 2021-09-10T11:57:59+02:00 New Revision: a1097d315c80a1c079dc7dda1661d0c2baa2d1e6 URL: https://github.com/llvm/llvm-project/commit/a1097d315c80a1c079dc7dda1661d0c2baa2d1e6 DIFF: https://github.com/llvm/llvm-project/commit/a1097d315c80a1c079dc7dda1661d0c2baa2d1e6.diff

[Lldb-commits] [PATCH] D109585: [lldb] [test] Move "platform connect" logic into a common class

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. cool CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109585/new/ https://reviews.llvm.org/D109585 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D107840: [lldb] [gdb-server] Implement the vFile:fstat packet

labath added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp:789 + data.gdb_st_size = file_stats.st_size; +#if !defined(_WIN32) + data.gdb_st_blksize = file_stats.st_blksize; Just make sure the fields

[Lldb-commits] [PATCH] D107840: [lldb] [gdb-server] Implement the vFile:fstat packet

mgorny updated this revision to Diff 371847. mgorny added a comment. Skip `st_blocks` and `st_blksize` on Windows. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107840/new/ https://reviews.llvm.org/D107840 Files: lldb/include/lldb/Utility/StringExtractorGDBRemote.h

[Lldb-commits] [lldb] 70558d3 - Revert "[lldb] [gdb-server] Implement the vFile:fstat packet"

Author: Michał Górny Date: 2021-09-10T11:43:24+02:00 New Revision: 70558d39f01beb87ab561bfaefeecb4d9534beed URL: https://github.com/llvm/llvm-project/commit/70558d39f01beb87ab561bfaefeecb4d9534beed DIFF: https://github.com/llvm/llvm-project/commit/70558d39f01beb87ab561bfaefeecb4d9534beed.diff

[Lldb-commits] [PATCH] D109585: [lldb] [test] Move "platform connect" logic into a common class

mgorny updated this revision to Diff 371844. mgorny added a comment. Sorry about missing that. Done now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109585/new/ https://reviews.llvm.org/D109585 Files:

[Lldb-commits] [PATCH] D108554: [lldb] Support querying registers via generic names without alt_names

mgorny added a comment. In D108554#2993993 , @labath wrote: > In D108554#2993830 , @mgorny wrote: > >> In D108554#2993766 , @labath wrote: >> >>> I'm not sure we should

[Lldb-commits] [PATCH] D109585: [lldb] [test] Move "platform connect" logic into a common class

labath added a comment. looks better. Can we also move the DisconnectRemote() thingy into the tearDown method ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109585/new/ https://reviews.llvm.org/D109585 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D108554: [lldb] Support querying registers via generic names without alt_names

labath added a comment. In D108554#2993830 , @mgorny wrote: > In D108554#2993766 , @labath wrote: > >> I'm not sure we should be preserving this behavior for the native register >> context. User-provided strings

[Lldb-commits] [PATCH] D107811: [lldb] [gdb-remote] Add fallbacks for vFile:mode and vFile:exists

mgorny updated this revision to Diff 371842. mgorny added a comment. Remove now-redundant `platform connect` from tests. Use if-declaration as requested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107811/new/ https://reviews.llvm.org/D107811 Files:

[Lldb-commits] [PATCH] D107809: [lldb] Add new commands and tests for getting file perms & exists

mgorny updated this revision to Diff 371841. mgorny marked an inline comment as done. mgorny added a comment. Remove now-redundant `platform connect` calls. TODO: server tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107809/new/ https://reviews.llvm.org/D107809 Files:

[Lldb-commits] [PATCH] D109585: [lldb] [test] Move "platform connect" logic into a common class

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. mgorny requested review of this revision. Create a common GDBPlatformClientTestBase class and move the platform select/connect logic there to reduce duplication. https://reviews.llvm.org/D109585 Files:

[Lldb-commits] [PATCH] D108148: [lldb] [gdb-remote] Use standardized GDB errno values

labath added a comment. Judging by https://docs.microsoft.com/en-us/cpp/c-runtime-library/errno-constants?view=msvc-160, this may just work, so let's cross that bridge when we get to it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108148/new/ https://reviews.llvm.org/D108148

[Lldb-commits] [PATCH] D107840: [lldb] [gdb-server] Implement the vFile:fstat packet

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9e886fbb18b5: [lldb] [gdb-server] Implement the vFile:fstat packet (authored by mgorny). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D107780: [lldb] [gdb-remote] Implement fallback to vFile:stat for GetFileSize()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG21e2d7ce43c4: [lldb] [gdb-remote] Implement fallback to vFile:stat for GetFileSize() (authored by mgorny). Herald added a project: LLDB.

[Lldb-commits] [lldb] 9e886fb - [lldb] [gdb-server] Implement the vFile:fstat packet

Author: Michał Górny Date: 2021-09-10T11:09:35+02:00 New Revision: 9e886fbb18b525c080c04f4a12bd481c9aa849c0 URL: https://github.com/llvm/llvm-project/commit/9e886fbb18b525c080c04f4a12bd481c9aa849c0 DIFF: https://github.com/llvm/llvm-project/commit/9e886fbb18b525c080c04f4a12bd481c9aa849c0.diff

[Lldb-commits] [lldb] 21e2d7c - [lldb] [gdb-remote] Implement fallback to vFile:stat for GetFileSize()

Author: Michał Górny Date: 2021-09-10T11:09:35+02:00 New Revision: 21e2d7ce43c42df5d60a2805c801b8f1eda7919c URL: https://github.com/llvm/llvm-project/commit/21e2d7ce43c42df5d60a2805c801b8f1eda7919c DIFF: https://github.com/llvm/llvm-project/commit/21e2d7ce43c42df5d60a2805c801b8f1eda7919c.diff

[Lldb-commits] [PATCH] D108554: [lldb] Support querying registers via generic names without alt_names

mgorny added a comment. In D108554#2993766 , @labath wrote: > I'm not sure we should be preserving this behavior for the native register > context. User-provided strings should not make it there, and code should > really be retrieving the registers in

[Lldb-commits] [PATCH] D108148: [lldb] [gdb-remote] Use standardized GDB errno values

mgorny marked an inline comment as done. mgorny added a comment. In D108148#2993746 , @labath wrote: > LG, modulo the comment. Keep an eye out on the bots though. I fear some > systems (windows, in particular), may not have all errno constants defined,

[Lldb-commits] [PATCH] D107840: [lldb] [gdb-server] Implement the vFile:fstat packet

mgorny marked 3 inline comments as done. mgorny added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107840/new/ https://reviews.llvm.org/D107840 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D108554: [lldb] Support querying registers via generic names without alt_names

labath added a comment. I'm not sure we should be preserving this behavior for the native register context. User-provided strings should not make it there, and code should really be retrieving the registers in some other way (like via the LLDB_REGNUM_GENERIC_*** constants). It would also be

[Lldb-commits] [PATCH] D108148: [lldb] [gdb-remote] Use standardized GDB errno values

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. LG, modulo the comment. Keep an eye out on the bots though. I fear some systems (windows, in particular), may not have all errno constants defined, and we'll need to do something smarter.

[Lldb-commits] [PATCH] D103127: lldb: Don't check for CMAKE_SYSTEM_NAME==Android.

labath added a comment. In D103127#2990249 , @pcc wrote: > In D103127#2985203 , @labath wrote: > >> How exactly are you building this? CMAKE_SYSTEM_NAME is set in the official >> android cmake toolchain file >>

[Lldb-commits] [PATCH] D107780: [lldb] [gdb-remote] Implement fallback to vFile:stat for GetFileSize()

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. cool CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107780/new/ https://reviews.llvm.org/D107780 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D107811: [lldb] [gdb-remote] Add fallbacks for vFile:mode and vFile:exists

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:3184-3185 + // Fallback to fstat. + llvm::Optional st = Stat(file_spec); + if

[Lldb-commits] [PATCH] D107840: [lldb] [gdb-server] Implement the vFile:fstat packet

labath accepted this revision. labath added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp:763 +template +void fill_clamp(T , U src, typename T::value_type fallback) { + dest = dest <= std::numeric_limits::max() ?

[Lldb-commits] [PATCH] D96766: [lldb] [Process/FreeBSD] Introduce mips64 FPU reg support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG24332f0e27e1: [lldb] [Process/FreeBSD] Introduce mips64 FPU reg support (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM

[Lldb-commits] [lldb] 24332f0 - [lldb] [Process/FreeBSD] Introduce mips64 FPU reg support

Author: Michał Górny Date: 2021-09-10T09:13:15+02:00 New Revision: 24332f0e27e17bbe3edfe3d66636c48c17d6ad5f URL: https://github.com/llvm/llvm-project/commit/24332f0e27e17bbe3edfe3d66636c48c17d6ad5f DIFF: https://github.com/llvm/llvm-project/commit/24332f0e27e17bbe3edfe3d66636c48c17d6ad5f.diff

[Lldb-commits] [PATCH] D109495: [lldb] [test] Add synchronization fix Subprocess test flakiness

This revision was automatically updated to reflect the committed changes. Closed by commit rGf659bf00b4c0: [lldb] [test] Add synchronization fix Subprocess test flakiness (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] f659bf0 - [lldb] [test] Add synchronization fix Subprocess test flakiness

Author: Michał Górny Date: 2021-09-10T09:11:08+02:00 New Revision: f659bf00b4c0f33947bbce19113ac7cd28e5da86 URL: https://github.com/llvm/llvm-project/commit/f659bf00b4c0f33947bbce19113ac7cd28e5da86 DIFF: https://github.com/llvm/llvm-project/commit/f659bf00b4c0f33947bbce19113ac7cd28e5da86.diff

[Lldb-commits] [PATCH] D109495: [lldb] [test] Add synchronization fix Subprocess test flakiness

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. cool, thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109495/new/ https://reviews.llvm.org/D109495 ___ lldb-commits mailing list