[Lldb-commits] [PATCH] D110472: [lldb] [gdb-remote] Use llvm::StringRef.split() and llvm::to_integer()

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. All the `llvm::StringRef &` iteration variables can just be `llvm::StringRef` without the reference. Also some `base` values got lost here (see inline comments). Beside that this LGTM,

[Lldb-commits] [PATCH] D110478: [lldb] Move StringConvert inside debugserver

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110478/new/ https://reviews.llvm.org/D110478 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D110478: [lldb] Move StringConvert inside debugserver

mgorny created this revision. mgorny added reviewers: labath, teemperor, krytarowski, emaste, JDevlieghere, jasonmolenda. mgorny requested review of this revision. The StringConvert API is no longer used anywhere but in debugserver. Since debugserver does not use LLVM API, we cannot replace it

[Lldb-commits] [PATCH] D110447: [lldb] Convert misc. StringConvert uses

This revision was automatically updated to reflect the committed changes. Closed by commit rG3a6ba3675177: [lldb] Convert misc. StringConvert uses (authored by mgorny). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D110447?vs=375024=375030#toc Repository:

[Lldb-commits] [lldb] 3a6ba36 - [lldb] Convert misc. StringConvert uses

Author: Michał Górny Date: 2021-09-25T14:19:19+02:00 New Revision: 3a6ba3675177cb5e47dee325f300aced4cd864ed URL: https://github.com/llvm/llvm-project/commit/3a6ba3675177cb5e47dee325f300aced4cd864ed DIFF: https://github.com/llvm/llvm-project/commit/3a6ba3675177cb5e47dee325f300aced4cd864ed.diff

[Lldb-commits] [PATCH] D110447: [lldb] Convert misc. StringConvert uses

mgorny added inline comments. Comment at: lldb/source/Symbol/SymbolContext.cpp:986 -m_end_line = StringConvert::ToSInt32(spec_string, 0, 0, _value); -if (return_value) m_type |= eLineEndSpecified; teemperor wrote: > This change and the one above

[Lldb-commits] [PATCH] D110447: [lldb] Convert misc. StringConvert uses

mgorny added a comment. In D110447#3022340 , @teemperor wrote: > If you have the time, it would be nice to drop FIXME's above the few places > where the return value of `to_integer` is not checked. Those always make > great beginner bugs. Beginner?

[Lldb-commits] [PATCH] D110447: [lldb] Convert misc. StringConvert uses

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. This patch makes me very happy. I have one comment regarding one small change in behaviour, but otherwise this LGTM. If you have the time, it would be nice to drop FIXME's above the few

[Lldb-commits] [lldb] 0b61f43 - [CMake] Consistently use the LibXml2::LibXml2 target instead of LIBXML2_LIBRARIES

Author: Markus Böck Date: 2021-09-25T13:13:11+02:00 New Revision: 0b61f43b6096a9e98652991cba34e8ad44d35101 URL: https://github.com/llvm/llvm-project/commit/0b61f43b6096a9e98652991cba34e8ad44d35101 DIFF: https://github.com/llvm/llvm-project/commit/0b61f43b6096a9e98652991cba34e8ad44d35101.diff

[Lldb-commits] [PATCH] D109975: [CMake] Consistently use the LibXml2::LibXml2 target instead of LIBXML2_LIBRARIES

This revision was automatically updated to reflect the committed changes. Closed by commit rG0b61f43b6096: [CMake] Consistently use the LibXml2::LibXml2 target instead of… (authored by zero9178). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D110447: [lldb] Convert misc. StringConvert uses

mgorny updated this revision to Diff 375024. mgorny added a comment. Reverting debugserver part, this *beep* doesn't use LLVM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110447/new/ https://reviews.llvm.org/D110447 Files: lldb/source/Interpreter/OptionValueArray.cpp

[Lldb-commits] [PATCH] D110472: [lldb] [gdb-remote] Use llvm::StringRef.split() and llvm::to_integer()

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste, JDevlieghere. mgorny requested review of this revision. Replace the uses of StringConvert combined with hand-rolled array splitting with llvm::StringRef.split() and llvm::to_integer().