[Lldb-commits] [lldb] f6e3abc - [lldb/gdb-remote] Remove last_stop_packet_mutex

Author: Pavel Labath Date: 2021-09-29T11:23:14+02:00 New Revision: f6e3abc53021dbbba4944a4fa38c5731994823e9 URL: https://github.com/llvm/llvm-project/commit/f6e3abc53021dbbba4944a4fa38c5731994823e9 DIFF: https://github.com/llvm/llvm-project/commit/f6e3abc53021dbbba4944a4fa38c5731994823e9.diff

[Lldb-commits] [PATCH] D110693: [lldb] [Host] Remove TerminalStateSwitcher

mgorny created this revision. mgorny added reviewers: labath, krytarowski, jingham, teemperor, JDevlieghere, emaste. mgorny requested review of this revision. Remove TerminalStateSwitcher class. It is not used anywhere and its API is really weird. This is the first step towards cleaning up Term

[Lldb-commits] [PATCH] D110693: [lldb] [Host] Remove TerminalStateSwitcher

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. yay CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110693/new/ https://reviews.llvm.org/D110693 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [PATCH] D110693: [lldb] [Host] Remove TerminalStateSwitcher

teemperor accepted this revision. teemperor added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110693/new/ https://reviews.llvm.org/D110693 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-

[Lldb-commits] [lldb] 52b04ef - [lldb] [Host] Remove TerminalStateSwitcher

Author: Michał Górny Date: 2021-09-29T13:45:41+02:00 New Revision: 52b04efa0197d5b1f65f4824a6528ea634bdf3db URL: https://github.com/llvm/llvm-project/commit/52b04efa0197d5b1f65f4824a6528ea634bdf3db DIFF: https://github.com/llvm/llvm-project/commit/52b04efa0197d5b1f65f4824a6528ea634bdf3db.diff

[Lldb-commits] [PATCH] D110693: [lldb] [Host] Remove TerminalStateSwitcher

This revision was automatically updated to reflect the committed changes. Closed by commit rG52b04efa0197: [lldb] [Host] Remove TerminalStateSwitcher (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11

[Lldb-commits] [PATCH] D110535: [llvm] [ADT] Update llvm::Split() per Pavel Labath's suggestions

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good to me, but I'd give @joerg a chance to respond first. In D110535#3028450 , @joerg wrote: > Why are all the changes from separator character

[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

labath added reviewers: clayborg, shafik. labath added a comment. In D110571#3027283 , @jarin wrote: > In D110571#3027173 , @labath wrote: > >> Judging by your description, I take it you parse these variables only

[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

jarin updated this revision to Diff 375865. jarin added a comment. Rewrote the recursive parser to use a plain method. Pruned and annotated the test. Added other test cases: - all parameters unused, - inlining from two different functions, - stack trace. This still uses `frame variable` rather

[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

labath added a comment. In D110571#3030192 , @jarin wrote: > This still uses `frame variable` rather than `image lookup`, mostly because > `frame variable` tests better the user experience and the cognitive overhead > for making the code runnable does n

[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

jarin updated this revision to Diff 375886. jarin added a comment. Added a C test (I have also verified that the C test fails without the SymbolFileDWARF patch). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110571/new/ https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

jarin added a comment. In D110571#3030222 , @labath wrote: > In D110571#3030192 , @jarin wrote: > >> This still uses `frame variable` rather than `image lookup`, mostly because >> `frame variable` tests better th

[Lldb-commits] [lldb] f939a32 - [lldb] Fix TestImportStdModule on some setups by testing minmax instead of abs

Author: Raphael Isemann Date: 2021-09-29T17:03:37+02:00 New Revision: f939a32e5c483686af16561211d77c06a5579011 URL: https://github.com/llvm/llvm-project/commit/f939a32e5c483686af16561211d77c06a5579011 DIFF: https://github.com/llvm/llvm-project/commit/f939a32e5c483686af16561211d77c06a5579011.dif

[Lldb-commits] [PATCH] D110721: [lldb] [Host] Merge TerminalState into Terminal

mgorny created this revision. mgorny added reviewers: labath, teemperor, emaste, krytarowski. mgorny requested review of this revision. Merge the routines from the TerminalState class into Terminal. There does not seem to be a real advantage from having the two classes split, and the TerminalStat

[Lldb-commits] [PATCH] D110721: [lldb] [Host] Merge TerminalState into Terminal

mgorny added inline comments. Comment at: lldb/source/Host/common/Terminal.cpp:124 if (save_process_group) - m_process_group = ::tcgetpgrp(0); else I think passing `0` here was a mistake. The `Restore()` method passed `fd` instead. =

[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

jarin updated this revision to Diff 375901. jarin added a comment. Changed the test to avoid running the process and use `image lookup` instead of `frame variable`. I think I would still slightly prefer `frame variable`, mostly because there seem to be differences between what `image lookup` an

[Lldb-commits] [PATCH] D110721: [lldb] [Host] Refactor TerminalState [WIP]

mgorny updated this revision to Diff 375908. mgorny retitled this revision from "[lldb] [Host] Merge TerminalState into Terminal" to "[lldb] [Host] Refactor TerminalState [WIP]". mgorny edited the summary of this revision. mgorny added a comment. Ok, let's start with smaller refactoring and see w

[Lldb-commits] [PATCH] D110721: [lldb] [Host] Refactor TerminalState [WIP]

mgorny updated this revision to Diff 375919. mgorny edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110721/new/ https://reviews.llvm.org/D110721 Files: lldb/include/lldb/Host/Terminal.h lldb/source/Host/common/Terminal.cpp lldb/source/Plugins/Scri

[Lldb-commits] [PATCH] D110721: [lldb] [Host] Refactor TerminalState [WIP]

mgorny updated this revision to Diff 375928. mgorny added a comment. Accept `Terminal` arg in place of fd. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110721/new/ https://reviews.llvm.org/D110721 Files: lldb/include/lldb/Host/Terminal.h lldb/source/Host/common/Terminal.cpp lldb

[Lldb-commits] [PATCH] D110721: [lldb] [Host] Refactor TerminalState

shafik added inline comments. Comment at: lldb/include/lldb/Host/Terminal.h:20 + struct termios; I don't think we need this forward declaration anymore. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110721/new/ https://reviews.llvm.org/D110721

[Lldb-commits] [lldb] d35702e - Fix LLDB build on old Linux kernels

Author: Walter Erquinigo Date: 2021-09-29T09:42:32-07:00 New Revision: d35702efe73010409c75b1f1b64f205cc3b2f6d3 URL: https://github.com/llvm/llvm-project/commit/d35702efe73010409c75b1f1b64f205cc3b2f6d3 DIFF: https://github.com/llvm/llvm-project/commit/d35702efe73010409c75b1f1b64f205cc3b2f6d3.di

[Lldb-commits] [PATCH] D110269: Fix LLDB build on old Linux kernels

This revision was automatically updated to reflect the committed changes. Closed by commit rGd35702efe730: Fix LLDB build on old Linux kernels (authored by Walter Erquinigo ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110269/new/

[Lldb-commits] [PATCH] D110298: Add "command multiword add" and the ability to add script commands into a user multiword hierarchy

jingham added a comment. In D110298#3026579 , @clayborg wrote: > The changes look fine from a quick read. See inline comments The command add/command delete situation is a little fractured. We currently have: command alias/command unalias - Handles al

[Lldb-commits] [PATCH] D110721: [lldb] [Host] Refactor TerminalState

mgorny updated this revision to Diff 375945. mgorny added a comment. Fix `tcgetpgrp()` call (again). Remove unneeded forward decl. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110721/new/ https://reviews.llvm.org/D110721 Files: lldb/include/lldb/Host/Terminal.h lldb/source/Host/co

[Lldb-commits] [PATCH] D110721: [lldb] [Host] Refactor TerminalState

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/include/lldb/Host/Terminal.h:20 + struct termios; shafik wrote: > I don't think we need this forward declaration anymore. You are correct, thanks! CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

clayborg added a comment. In D110571#3025527 , @jarin wrote: > Hi, could you take a look at this change? > > Some discussion points: > > - In the ParseVariablesInFunctionContext method, we are using a lambda for > the recursive parser. We could also use

[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

clayborg added a comment. This looks good to me. Pavel, are you ok with the testing strategy with the updated tests? Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3630-3631 +if (tag == DW_TAG_inlined_subroutine) { + // Walk abstract origins unti

[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

jarin added a comment. First of all, thank you, Greg and Pavel, for all the great feedback and discussion. I have followed all your suggestions (use plain method, use `image lookup`, added the additional tests). I have also packaged the C test, but as Greg notes I am not convinced it will keep

[Lldb-commits] [lldb] 385b218 - [lldb] Remove Expression's dependency on CPlusPlusLanguagePlugin

Author: Alex Langford Date: 2021-09-29T11:39:09-07:00 New Revision: 385b2189cc4446745e1ea4ac803c22b3daef73ec URL: https://github.com/llvm/llvm-project/commit/385b2189cc4446745e1ea4ac803c22b3daef73ec DIFF: https://github.com/llvm/llvm-project/commit/385b2189cc4446745e1ea4ac803c22b3daef73ec.diff

[Lldb-commits] [PATCH] D110115: [lldb] Remove Expression's dependency on CPlusPlusLanguagePlugin

bulbazord closed this revision. bulbazord added a comment. 385b2189cc44 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110115/new/ https://reviews.llvm.org/D110115 _

[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

clayborg added a comment. In D110571#3031140 , @jarin wrote: > First of all, thank you, Greg and Pavel, for all the great feedback and > discussion. I have followed all your suggestions (use plain method, use > `image lookup`, added the additional tests

[Lldb-commits] [PATCH] D110787: Make "process attach -c" work again, add a test for it.

jingham created this revision. jingham added reviewers: jasonmolenda, clayborg, JDevlieghere. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. process attach -c stopped working at some point. Since there was no test for this featur

[Lldb-commits] [PATCH] D110787: Make "process attach -c" work again, add a test for it.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. Thanks Jim! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110787/new/ https://reviews.llvm.org/D110787 __

[Lldb-commits] [PATCH] D110601: Add -relative-to-command-file to "command source"

jingham updated this revision to Diff 376083. jingham added a comment. Made -C with an absolute path an error, added at test for it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110601/new/ https://reviews.llvm.org/D110601 Files: lldb/source/Co

[Lldb-commits] [PATCH] D110601: Add -relative-to-command-file to "command source"

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110601/new/ https://reviews.llvm.org/D110601 ___

[Lldb-commits] [lldb] 3bf3b96 - Add the --relative-to-command-file to "command source" so you can

Author: Jim Ingham Date: 2021-09-29T19:33:41-07:00 New Revision: 3bf3b96629e8dfc55d01ba0cb05ca01a467017fa URL: https://github.com/llvm/llvm-project/commit/3bf3b96629e8dfc55d01ba0cb05ca01a467017fa DIFF: https://github.com/llvm/llvm-project/commit/3bf3b96629e8dfc55d01ba0cb05ca01a467017fa.diff LO

[Lldb-commits] [PATCH] D110601: Add -relative-to-command-file to "command source"

This revision was automatically updated to reflect the committed changes. Closed by commit rG3bf3b96629e8: Add the --relative-to-command-file to "command source" so you can (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110601/n

[Lldb-commits] [lldb] 2303391 - Make "process attach -c" work correctly, and add a test for it.

Author: Jim Ingham Date: 2021-09-29T19:38:09-07:00 New Revision: 2303391d1f543f4e57f9ed0fc68bad2d4cf890dc URL: https://github.com/llvm/llvm-project/commit/2303391d1f543f4e57f9ed0fc68bad2d4cf890dc DIFF: https://github.com/llvm/llvm-project/commit/2303391d1f543f4e57f9ed0fc68bad2d4cf890dc.diff LO

[Lldb-commits] [PATCH] D110787: Make "process attach -c" work again, add a test for it.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2303391d1f54: Make "process attach -c" work correctly, and add a test for it. (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110787/new

[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

jarin added a comment. In D110571#3031846 , @clayborg wrote: > In D110571#3031140 , @jarin wrote: > >> For illustration: >> >> 0x100 DW_TAG_subprogram >>DW_AT_name "inlined_function" >>.

[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

dblaikie added a comment. >> - We could supply a test written in C, but it needs -O1 and is fairly >> sensitive to the meaning of -O1 (e.g., clang started inlining and omitting >> unsued inlined parameters only recently, so changes to -O1 could make a C >> test easily meaningless). Any concerns