labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Seems straight-forward enough, though I am wondering how much of this code is
actually necessary given the deprecation/repurposing of reproducers.
Repository:
rG LLVM Github Monorepo
CHANG
labath added a comment.
This looks reasonable to me. In case the url does not specify port parameters,
it might be better to set them to known sane defaults instead of leaving them
unchanged. That way lldb and lldb-server could "just connect". However, I don't
know much about serial ports so I'
mstorsjo created this revision.
mstorsjo added reviewers: labath, teemperor, JDevlieghere.
mstorsjo requested review of this revision.
Herald added a project: LLDB.
This makes the compiler generated code for accessing the thread local
variable much simpler (no need for wrapper functions and weak p
labath added a comment.
We don't really want to support adding an arbitrary subset of sub-registers, do
we? I am thinking if this could be made simpler if it was all-or-nothing. Like,
during the initial pass you could check whether the list contains _any_
subregister, and abort if it does. Then
wallace added inline comments.
Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:627-628
+ "incompatible with 'attachCommands'.\n", arg.str().c_str());
+ }
+}
+// Run any pre run LLDB commands the user specified in the launch.json
clay
wallace added inline comments.
Comment at: lldb/include/lldb/Target/Process.h:241
- void BumpStopID() {
-m_stop_id++;
+ uint32_t BumpStopID() {
+const uint32_t prev_stop_id = m_stop_id++;
add a comment saying that this returns the stop id with the val
JDevlieghere added a comment.
I have a few comments but I think this is going in a direction that will work
for both of us. Once this lands I can sign up for the work to untie the
statistics form the target.
Comment at: lldb/include/lldb/Target/Statistics.h:23
+struct Success
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
I am fine overall with this change because of goofy things that can happen when
we always create a target. We might think about returning an error if the user
specifies "launchCo
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rG58917054c298: [lldb] Skip several lldb tests that are flaky
on Windows (authored by stella.stamenova).
Repository:
rG L
Author: Stella Stamenova
Date: 2021-10-13T09:46:41-07:00
New Revision: 58917054c29878ff3462f73b32a3e5dfa64d83f9
URL:
https://github.com/llvm/llvm-project/commit/58917054c29878ff3462f73b32a3e5dfa64d83f9
DIFF:
https://github.com/llvm/llvm-project/commit/58917054c29878ff3462f73b32a3e5dfa64d83f9.di
mstorsjo added a reviewer: thakis.
mstorsjo added a subscriber: thakis.
mstorsjo added a comment.
The demangler change looks fine to me (but a test would indeed be necessary),
but I think @thakis is the one who's been most involved with the MS demangler.
Repository:
rG LLVM Github Monorepo
C
Author: Raphael Isemann
Date: 2021-10-13T17:15:02+02:00
New Revision: 4019699fa5fd153586f02fd7f6b7cfc51a688bf2
URL:
https://github.com/llvm/llvm-project/commit/4019699fa5fd153586f02fd7f6b7cfc51a688bf2
DIFF:
https://github.com/llvm/llvm-project/commit/4019699fa5fd153586f02fd7f6b7cfc51a688bf2.dif
teemperor added reviewers: mstorsjo, rnk.
teemperor requested changes to this revision.
teemperor added a comment.
This revision now requires changes to proceed.
Herald added a subscriber: JDevlieghere.
This looks in general good to me. You probably want to add a test for this
(`llvm/test/Demangl
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at:
lldb/test/API/functionalities/data-formatter/stringprinter/main.cpp:40
+//% self.expect_var_path("c.data", summary=r'"F\0O"')
//% self.runCmd
lassefolger created this revision.
lassefolger added reviewers: teemperor, werat.
Herald added a subscriber: hiraditya.
lassefolger requested review of this revision.
Herald added projects: LLDB, LLVM.
Herald added subscribers: llvm-commits, lldb-commits.
When printing names in lldb on windows the
Author: Raphael Isemann
Date: 2021-10-13T15:27:23+02:00
New Revision: 0648b3c0265e74a6920ae356885d0c29a1f6a44e
URL:
https://github.com/llvm/llvm-project/commit/0648b3c0265e74a6920ae356885d0c29a1f6a44e
DIFF:
https://github.com/llvm/llvm-project/commit/0648b3c0265e74a6920ae356885d0c29a1f6a44e.dif
Author: Raphael Isemann
Date: 2021-10-13T13:14:57+02:00
New Revision: 7103753733a83602199958fb189d24f62c7400e8
URL:
https://github.com/llvm/llvm-project/commit/7103753733a83602199958fb189d24f62c7400e8
DIFF:
https://github.com/llvm/llvm-project/commit/7103753733a83602199958fb189d24f62c7400e8.dif
17 matches
Mail list logo
