[Lldb-commits] [PATCH] D111920: Test untested variants of BreakpointCreateBySourceRegex

jingham created this revision. jingham added reviewers: aprantl, JDevlieghere. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add tests for the other variants of BreakpointCreateBySourceRegex. I added some tests for the ca

[Lldb-commits] [PATCH] D111910: Fix Xcode project for debugserver

This revision was automatically updated to reflect the committed changes. Closed by commit rG4594f8116543: Fix Xcode project for debugserver (authored by Lawrence D'\''Anna , committed by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 4594f81 - Fix Xcode project for debugserver

Author: Lawrence D'\''Anna Date: 2021-10-15T15:08:06-07:00 New Revision: 4594f81165433c681cc4f09ed50b662b1a237137 URL: https://github.com/llvm/llvm-project/commit/4594f81165433c681cc4f09ed50b662b1a237137 DIFF: https://github.com/llvm/llvm-project/commit/4594f81165433c681cc4f09ed50b662b1a237137.

[Lldb-commits] [PATCH] D111910: Fix Xcode project for debugserver

lawrence_danna created this revision. lawrence_danna added reviewers: jasonmolenda, JDevlieghere. lawrence_danna requested review of this revision. Herald added a project: LLDB. It seems StringConvert.cpp was moved, and the Xcode project file wasn't updated. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D111908: [lldb] [Utility] Remove Status::WasInterrupted() along with its only use

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste, teemperor. mgorny requested review of this revision. Remove Status::WasInterrupted() that checks whether the underlying error code matches EINTR. ProcessGDBRemote::ConnectToDebugserver() is its only call site, and

[Lldb-commits] [PATCH] D111899: LLDB tests modification for hardware breakpoints

jingham added a comment. Actually, they aren't testing the same "sort" of thing, it's exactly the same test: "was the breakpoint hit once". But those tests are also really inaccurate as they just ask whether any breakpoint has a hit count of 1. It would be really easy to edit a test, add ano

[Lldb-commits] [PATCH] D111899: LLDB tests modification for hardware breakpoints

jingham added a comment. All these tests are testing the same sort of thing. It would be better to make an lldbutil function that does this test and convert all these tests over to that. This sort of change is exactly why we don't want code that's poking at command results to find info about

[Lldb-commits] [PATCH] D108937: [lldb] [ABI/X86] Support combining xmm* and ymm*h regs into ymm*

mgorny updated this revision to Diff 380058. mgorny retitled this revision from "[lldb] [Process/gdb-remote] Support combining xmm* and ymm*h regs into ymm*" to "[lldb] [ABI/X86] Support combining xmm* and ymm*h regs into ymm*". mgorny added a comment. Rebase to use the new `ABIX86::AugmentRegis

[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback

mstorsjo added a comment. FWIW, I had debugged the issue described here and posted about it on Discord, but never got around to posting it here. I think the MSVC build error above gets fixed by this patch: diff --git a/lldb/source/Plugins/ScriptInterpreter/Lua/Lua.cpp b/lldb/source/Plugins/S

[Lldb-commits] [PATCH] D111899: LLDB tests modification for hardware breakpoints

georgiev created this revision. georgiev added a reviewer: LLDB. georgiev requested review of this revision. LLDB now shows additional string 'hardware' when a hardware breakpoint is hit. Current test fail for those kind of breakpoints, as they match exact string, which doesn't include 'hardware

[Lldb-commits] [lldb] ff4c98c - [lldb] Harden TestCompletion against new settings in 'target.process'

Author: Raphael Isemann Date: 2021-10-15T18:50:21+02:00 New Revision: ff4c98c05559e498300bd3ad55272ac2a8d10dbc URL: https://github.com/llvm/llvm-project/commit/ff4c98c05559e498300bd3ad55272ac2a8d10dbc DIFF: https://github.com/llvm/llvm-project/commit/ff4c98c05559e498300bd3ad55272ac2a8d10dbc.dif

[Lldb-commits] [lldb] 03a8e70 - [lldb] Add test for struct merging in scratch ASTContext

Author: Raphael Isemann Date: 2021-10-15T17:20:03+02:00 New Revision: 03a8e70a192f382ae700d761e46e2299a38f58db URL: https://github.com/llvm/llvm-project/commit/03a8e70a192f382ae700d761e46e2299a38f58db DIFF: https://github.com/llvm/llvm-project/commit/03a8e70a192f382ae700d761e46e2299a38f58db.dif

[Lldb-commits] [PATCH] D111890: [lldb] [Host] Make Terminal methods return llvm::Error

mgorny added inline comments. Comment at: lldb/source/Host/common/Terminal.cpp:76 + struct termios &fd_termios = data->m_termios; + bool set_corectly = false; + if (enabled) { My gut feeling is telling me that this can be simplified somehow… or we could assum

[Lldb-commits] [PATCH] D111890: [lldb] [Host] Make Terminal methods return llvm::Error [WIP]

mgorny updated this revision to Diff 380011. mgorny added a comment. Move common code and error handling to `GetData()` and `SetData()` methods. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111890/new/ https://reviews.llvm.org/D111890 Files: lldb/include/lldb/Host/Terminal.h lldb/

[Lldb-commits] [PATCH] D111890: [lldb] [Host] Make Terminal methods return llvm::Error [WIP]

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste, teemperor. mgorny requested review of this revision. Note: this is just the initial patch, I'm doing more refactoring to dedupe the code a bit. https://reviews.llvm.org/D111890 Files: lldb/include/lldb/Host/Te

[Lldb-commits] [lldb] 1583c41 - [lldb] [test] Add TestGDBServerTargetXML tests for x86 duplicate subregs

Author: Michał Górny Date: 2021-10-15T16:04:16+02:00 New Revision: 1583c41d07a45a2daa1e9d8347dcea4329794657 URL: https://github.com/llvm/llvm-project/commit/1583c41d07a45a2daa1e9d8347dcea4329794657 DIFF: https://github.com/llvm/llvm-project/commit/1583c41d07a45a2daa1e9d8347dcea4329794657.diff

[Lldb-commits] [PATCH] D111715: [WIP] [lldb] change name demangling to be consistent between windows and linx

werat added a comment. Thanks for improving this! Can you please add a few examples in the commit description like "before -> after", so it's more obvious what is changing here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111715/new/ https://rev

[Lldb-commits] [PATCH] D111877: [lldb] Return StringRef from PluginInterface::GetPluginName

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. I'm wondering if some of those should be `std::string` instead, but this is in any case a step in the right direction so LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[Lldb-commits] [lldb] e741890 - [lldb] [test] Simplify X86 TestGDBServerTargetXML logic to match AArch64

Author: Michał Górny Date: 2021-10-15T14:15:50+02:00 New Revision: e7418906f5051da329ba0094635aeabd39bf6803 URL: https://github.com/llvm/llvm-project/commit/e7418906f5051da329ba0094635aeabd39bf6803 DIFF: https://github.com/llvm/llvm-project/commit/e7418906f5051da329ba0094635aeabd39bf6803.diff

[Lldb-commits] [PATCH] D111881: [lldb] [ABI/AArch64] Do not add subregs if some of them are present

This revision was automatically updated to reflect the committed changes. Closed by commit rGf70f9620d9ab: [lldb] [ABI/AArch64] Do not add subregs if some of them are present (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[Lldb-commits] [lldb] f70f962 - [lldb] [ABI/AArch64] Do not add subregs if some of them are present

Author: Michał Górny Date: 2021-10-15T14:08:37+02:00 New Revision: f70f9620d9abff33cf1553fad6361dc4f3183a9b URL: https://github.com/llvm/llvm-project/commit/f70f9620d9abff33cf1553fad6361dc4f3183a9b DIFF: https://github.com/llvm/llvm-project/commit/f70f9620d9abff33cf1553fad6361dc4f3183a9b.diff

[Lldb-commits] [PATCH] D111881: [lldb] [ABI/AArch64] Do not add subregs if some of them are present

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste, teemperor. Herald added subscribers: pengfei, kristof.beyls. mgorny requested review of this revision. Fix a bug introduced while refactoring ABIAArch64::AugmentRegisterInfo() that caused subregisters to be added ev

[Lldb-commits] [PATCH] D108831: [lldb] [ABI/X86] Add pseudo-registers if missing

This revision was automatically updated to reflect the committed changes. Closed by commit rG2712d1814860: [lldb] [ABI/X86] Add pseudo-registers if missing (authored by mgorny). Herald added a subscriber: thopre. Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D111489: [lldb] [DynamicRegisterInfo] Support value_regs with offset

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0d1705a9d623: [lldb] [DynamicRegisterInfo] Support value_regs with offset (authored by mgorny). Herald added a project: LLDB. Changed prior to commi

[Lldb-commits] [lldb] 2712d18 - [lldb] [ABI/X86] Add pseudo-registers if missing

Author: Michał Górny Date: 2021-10-15T12:55:03+02:00 New Revision: 2712d1814860600136546945f7a003dfe56f307a URL: https://github.com/llvm/llvm-project/commit/2712d1814860600136546945f7a003dfe56f307a DIFF: https://github.com/llvm/llvm-project/commit/2712d1814860600136546945f7a003dfe56f307a.diff

[Lldb-commits] [lldb] 0d1705a - [lldb] [DynamicRegisterInfo] Support value_regs with offset

Author: Michał Górny Date: 2021-10-15T12:55:02+02:00 New Revision: 0d1705a9d62301c84977abe6a986d9af1989072f URL: https://github.com/llvm/llvm-project/commit/0d1705a9d62301c84977abe6a986d9af1989072f DIFF: https://github.com/llvm/llvm-project/commit/0d1705a9d62301c84977abe6a986d9af1989072f.diff

[Lldb-commits] [lldb] bc9b106 - [lldb] Fix an include in HostTest.cpp

Author: Pavel Labath Date: 2021-10-15T11:10:38+02:00 New Revision: bc9b106a5750cf05ddab1dfce2a77d73bcc7d44a URL: https://github.com/llvm/llvm-project/commit/bc9b106a5750cf05ddab1dfce2a77d73bcc7d44a DIFF: https://github.com/llvm/llvm-project/commit/bc9b106a5750cf05ddab1dfce2a77d73bcc7d44a.diff

[Lldb-commits] [PATCH] D108831: [lldb] [ABI/X86] Add pseudo-registers if missing

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I think we've managed to come to something that looks mostly reasonable. Comment at: lldb/source/Plugins/ABI/X86/ABIX86.cpp:51 +std::vector ®s, +llvm::ArrayRef base_r