[Lldb-commits] [PATCH] D112863: [lldb][NFC] avoid unnecessary roundtrips between different string types

dblaikie added inline comments. Comment at: lldb/source/API/SBTarget.cpp:1589 - const ConstString csFrom(from), csTo(to); - if (!csFrom) + llvm::StringRef srFrom(from), srTo(to); + if (srFrom.empty()) Aside (since the old code did this too): Generally code

[Lldb-commits] [PATCH] D112863: [lldb][NFC] avoid unnecessary roundtrips between different string types

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112863/new/ https://reviews.llvm.org/D112863

[Lldb-commits] [PATCH] D112834: [lldb-vscode] Fix coredump load source mapping for first file

wallace accepted this revision. wallace added a comment. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112834/new/ https://reviews.llvm.org/D112834 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D112863: [lldb][NFC] avoid unnecessary roundtrips between different string types

xujuntwt95329 created this revision. xujuntwt95329 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The amount of roundtrips between StringRefs, ConstStrings and std::strings is getting a bit out of hand, this patch avoid the unnecessary

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

xujuntwt95329 updated this revision to Diff 383553. xujuntwt95329 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112439/new/ https://reviews.llvm.org/D112439 Files: lldb/source/Target/PathMappingList.cpp

[Lldb-commits] [PATCH] D112785: [formatters] Add a libstdcpp formatter for multiset and unify tests across stdlibs

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. let's land https://reviews.llvm.org/D112752 first and then this one Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:915 +

[Lldb-commits] [PATCH] D112752: [formatters] Add a libstdcpp formatter for multimap and unify modify tests across stdlibs

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. pretty good, just cosmetic changes and a comment update needed Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:915 +

[Lldb-commits] [PATCH] D112856: [lldb] Only specify LLVM_ENABLE_RUNTIMES in the libcxx error message.

JDevlieghere created this revision. JDevlieghere added reviewers: teemperor, labath. Herald added a subscriber: mgorny. JDevlieghere requested review of this revision. Now that passing `libcxx` via `LLVM_ENABLE_PROJECTS` has been deprecated, update the error message and recommend using

[Lldb-commits] [PATCH] D112834: [lldb-vscode] Fix coredump load source mapping for first file

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. This is how launch does it as well, so LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112834/new/ https://reviews.llvm.org/D112834

[Lldb-commits] [PATCH] D112165: Cleanup a few more PR36048 skips

This revision was automatically updated to reflect the committed changes. Closed by commit rGe6b323379e31: Cleanup a few more PR36048 skips (authored by dblaikie). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112165/new/

[Lldb-commits] [lldb] e6b3233 - Cleanup a few more PR36048 skips

Author: David Blaikie Date: 2021-10-29T14:10:42-07:00 New Revision: e6b323379e3195ba98bacc9216fe38025bda6104 URL: https://github.com/llvm/llvm-project/commit/e6b323379e3195ba98bacc9216fe38025bda6104 DIFF: https://github.com/llvm/llvm-project/commit/e6b323379e3195ba98bacc9216fe38025bda6104.diff

[Lldb-commits] [lldb] 16a816a - [lldb] [gdb-remote] Fix processing generic regnums

Author: Michał Górny Date: 2021-10-29T21:37:46+02:00 New Revision: 16a816a19e2a8c65cf34dbf2ef9d7497b200c0b1 URL: https://github.com/llvm/llvm-project/commit/16a816a19e2a8c65cf34dbf2ef9d7497b200c0b1 DIFF: https://github.com/llvm/llvm-project/commit/16a816a19e2a8c65cf34dbf2ef9d7497b200c0b1.diff

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

aprantl added inline comments. Comment at: lldb/source/Target/PathMappingList.cpp:33 // nomalized path pairs to ensure things match up. ConstString NormalizePath(ConstString path) { // If we use "path" to construct a FileSpec, it will normalize the path for

[Lldb-commits] [PATCH] D112825: [lldb] Add MemoryTagMap class

JDevlieghere requested changes to this revision. JDevlieghere added inline comments. This revision now requires changes to proceed. Comment at: lldb/include/lldb/Utility/MemoryTagMap.h:12 + +#include "lldb/Target/MemoryTagManager.h" +#include "lldb/lldb-private.h"

[Lldb-commits] [PATCH] D112165: Cleanup a few more PR36048 skips

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112165/new/ https://reviews.llvm.org/D112165

[Lldb-commits] [PATCH] D112834: [lldb-vscode] Fix coredump load source mapping for first file

ted created this revision. ted requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. SetSourceMapFromArguments is called after the core is loaded. This means that the source file for the crashing code won't have the source map applied. Move the

[Lldb-commits] [PATCH] D107140: [lldb] Show memory tags in memory read output

DavidSpickett updated this revision to Diff 383374. DavidSpickett added a comment. Herald added a subscriber: dang. Added a command option for showing tags (off by default). Split the patch into three (see parent revisions). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D112825: [lldb] Add MemoryTagMap class

DavidSpickett created this revision. Herald added a subscriber: mgorny. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The tag map holds a sparse set of memory tags and allows you to query ranges for tags. Granules that do

[Lldb-commits] [PATCH] D112824: [lldb][AArch64] Add MakeTaggedRanges to MemoryTagManager

DavidSpickett created this revision. Herald added subscribers: mgrang, kristof.beyls. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is to be used when you want to know what subranges of a larger range have memory

[Lldb-commits] [lldb] 5015f25 - [lldb/test] Fix TestSourceManager for eee887e0

Author: Pavel Labath Date: 2021-10-29T14:56:23+02:00 New Revision: 5015f250894d3d97917d858850fae7960923a4ae URL: https://github.com/llvm/llvm-project/commit/5015f250894d3d97917d858850fae7960923a4ae DIFF: https://github.com/llvm/llvm-project/commit/5015f250894d3d97917d858850fae7960923a4ae.diff

[Lldb-commits] [lldb] 8e3de91 - [lldb/test] Fix TestFunctionStarts for eee887e0

Author: Pavel Labath Date: 2021-10-29T14:43:53+02:00 New Revision: 8e3de91c07ce1e70463e1db2f3f0d629f57239b7 URL: https://github.com/llvm/llvm-project/commit/8e3de91c07ce1e70463e1db2f3f0d629f57239b7 DIFF: https://github.com/llvm/llvm-project/commit/8e3de91c07ce1e70463e1db2f3f0d629f57239b7.diff

[Lldb-commits] [PATCH] D112802: [lldb/test] Replace shlex.join with shlex.quote

This revision was automatically updated to reflect the committed changes. Closed by commit rGb42d51ba9ad1: [lldb/test] Replace shlex.join with shlex.quote (authored by labath). Changed prior to commit: https://reviews.llvm.org/D112802?vs=383301=383302#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] b42d51b - [lldb/test] Replace shlex.join with shlex.quote

Author: Pavel Labath Date: 2021-10-29T13:42:06+02:00 New Revision: b42d51ba9ad1f85e6b6f3508e6c2c4ab5ee22ac1 URL: https://github.com/llvm/llvm-project/commit/b42d51ba9ad1f85e6b6f3508e6c2c4ab5ee22ac1 DIFF: https://github.com/llvm/llvm-project/commit/b42d51ba9ad1f85e6b6f3508e6c2c4ab5ee22ac1.diff

[Lldb-commits] [PATCH] D112802: [lldb/test] Replace shlex.join with shlex.quote

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Thanks! Comment at: lldb/packages/Python/lldbsuite/support/seven.py:54 + +def join_for_shell(split_command): +return " ".join([shlex.quote(part) for part in

[Lldb-commits] [PATCH] D112802: [lldb/test] Replace shlex.join with shlex.quote

labath created this revision. labath added a reviewer: teemperor. labath requested review of this revision. Herald added a project: LLDB. join is only available since python-3.8, but the all the interesting magic happens in shlex.quote, which has been around since 3.3. Use shlex.quote, and

[Lldb-commits] [lldb] a394231 - [lldb] Remove ConstString from SymbolVendor, Trace, TraceExporter, UnwindAssembly, MemoryHistory and InstrumentationRuntime plugin names

Author: Pavel Labath Date: 2021-10-29T12:08:57+02:00 New Revision: a3942318198937a163deeb10f2e3378f3bc69844 URL: https://github.com/llvm/llvm-project/commit/a3942318198937a163deeb10f2e3378f3bc69844 DIFF: https://github.com/llvm/llvm-project/commit/a3942318198937a163deeb10f2e3378f3bc69844.diff

[Lldb-commits] [PATCH] D111899: LLDB tests modification for hardware breakpoints

georgiev updated this revision to Diff 383284. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111899/new/ https://reviews.llvm.org/D111899 Files: lldb/packages/Python/lldbsuite/test/lldbutil.py lldb/test/API/commands/apropos/with-process/TestAproposWithProcess.py

[Lldb-commits] [PATCH] D111899: LLDB tests modification for hardware breakpoints

georgiev updated this revision to Diff 383282. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111899/new/ https://reviews.llvm.org/D111899 Files: lldb/packages/Python/lldbsuite/test/lldbutil.py lldb/test/API/commands/apropos/with-process/TestAproposWithProcess.py

[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. labath marked an inline comment as done. Closed by commit rGeee887e03551: [lldb/test] Print build commands in trace mode (authored by labath). Changed prior to

[Lldb-commits] [lldb] eee887e - [lldb/test] Print build commands in trace mode

Author: Pavel Labath Date: 2021-10-29T11:33:31+02:00 New Revision: eee887e03551685bc03657a61c2f36ff1b522919 URL: https://github.com/llvm/llvm-project/commit/eee887e03551685bc03657a61c2f36ff1b522919 DIFF: https://github.com/llvm/llvm-project/commit/eee887e03551685bc03657a61c2f36ff1b522919.diff

[Lldb-commits] [PATCH] D112586: [lldb] Remove forgotten FIXME on CPlusPlus formatters

This revision was automatically updated to reflect the committed changes. Closed by commit rGac73f567cffb: [lldb] Remove forgotten FIXME on CPlusPlus formatters (authored by ljmf00, committed by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] ac73f56 - [lldb] Remove forgotten FIXME on CPlusPlus formatters

Author: Luís Ferreira Date: 2021-10-29T11:32:40+02:00 New Revision: ac73f567cffb663712e937051b0e81a82488698b URL: https://github.com/llvm/llvm-project/commit/ac73f567cffb663712e937051b0e81a82488698b DIFF: https://github.com/llvm/llvm-project/commit/ac73f567cffb663712e937051b0e81a82488698b.diff

[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

labath marked 2 inline comments as done. labath added inline comments. Comment at: lldb/test/API/test_utils/TestBaseTest.py:1 +""" +Test TestBase test functions. teemperor wrote: > Could we move this file into `test_utils/build` or some other subdir? Then I >

[Lldb-commits] [PATCH] D112658: [lldb] Refactor C/C++ string and char summary providers

labath added a comment. In D112658#3095656 , @labath wrote: > Do you have commit access, or should I check this in for you (I can also fix > up the formatting in that case)? Raphael tells me you don't, so I've committed this as rG5e31601

[Lldb-commits] [PATCH] D112658: [lldb] Refactor C/C++ string and char summary providers

This revision was automatically updated to reflect the committed changes. Closed by commit rG5e316012d0ac: [lldb] Refactor C/C++ string and char summary providers (authored by ljmf00, committed by labath). Changed prior to commit: https://reviews.llvm.org/D112658?vs=383121=383267#toc

[Lldb-commits] [lldb] 5e31601 - [lldb] Refactor C/C++ string and char summary providers

Author: Luís Ferreira Date: 2021-10-29T11:22:02+02:00 New Revision: 5e316012d0ac2f621b906ef7170696ec83f02409 URL: https://github.com/llvm/llvm-project/commit/5e316012d0ac2f621b906ef7170696ec83f02409 DIFF: https://github.com/llvm/llvm-project/commit/5e316012d0ac2f621b906ef7170696ec83f02409.diff

[Lldb-commits] [PATCH] D112708: [lldb] Make TypeSystemClang::GetFullyUnqualifiedType work for constant arrays

This revision was automatically updated to reflect the committed changes. labath marked an inline comment as done. Closed by commit rG3abd063fc793: [lldb] Make TypeSystemClang::GetFullyUnqualifiedType work for constant arrays (authored by labath). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [lldb] 3abd063 - [lldb] Make TypeSystemClang::GetFullyUnqualifiedType work for constant arrays

Author: Pavel Labath Date: 2021-10-29T11:13:59+02:00 New Revision: 3abd063fc793d2d56fc78287c61b73b2d7843bc5 URL: https://github.com/llvm/llvm-project/commit/3abd063fc793d2d56fc78287c61b73b2d7843bc5 DIFF: https://github.com/llvm/llvm-project/commit/3abd063fc793d2d56fc78287c61b73b2d7843bc5.diff

[Lldb-commits] [PATCH] D112785: Summary:

danilashtefan created this revision. danilashtefan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D112785 Files:

[Lldb-commits] [PATCH] D112709: [lldb] Fix matchers for char array formatters

labath added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/stringprinter/main.cpp:21 +MAKE_VARS(); +MAKE_VARS(const); + shafik wrote: > It feels like writing out the decls by hand would have been quicker but > perhaps less

[Lldb-commits] [lldb] 15b7df4 - [lldb] [Host/Terminal] Remove stale Config.h include from the header

Author: Michał Górny Date: 2021-10-29T10:02:11+02:00 New Revision: 15b7df49ca1cf4712fd0407b21c490dae357d607 URL: https://github.com/llvm/llvm-project/commit/15b7df49ca1cf4712fd0407b21c490dae357d607 DIFF: https://github.com/llvm/llvm-project/commit/15b7df49ca1cf4712fd0407b21c490dae357d607.diff

[Lldb-commits] [lldb] e9dcd8b - [lldb] [Host/Terminal] Fix warnings with termios disabled

Author: Michał Górny Date: 2021-10-29T09:58:09+02:00 New Revision: e9dcd8b37b73236f9c1db71c6afa057c181bb0c8 URL: https://github.com/llvm/llvm-project/commit/e9dcd8b37b73236f9c1db71c6afa057c181bb0c8 DIFF: https://github.com/llvm/llvm-project/commit/e9dcd8b37b73236f9c1db71c6afa057c181bb0c8.diff

[Lldb-commits] [PATCH] D112632: [lldb] [Host/Terminal] Fix warnings with termios disabled

This revision was automatically updated to reflect the committed changes. mgorny marked an inline comment as done. Closed by commit rGe9dcd8b37b73: [lldb] [Host/Terminal] Fix warnings with termios disabled (authored by mgorny). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D112632: [lldb] [Host/Terminal] Fix warnings with termios disabled

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/source/Host/common/Terminal.cpp:39 + llvm::Expected Terminal::GetData() { if (!FileDescriptorIsValid()) thakis wrote: > nit: should GetData() even exist if

[Lldb-commits] [PATCH] D112658: [lldb] Refactor C/C++ string and char summary providers

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good. Do you have commit access, or should I check this in for you (I can also fix up the formatting in that case)? Comment at: