[Lldb-commits] [lldb] 9f0b5f9 - [lldb/test] Added lldbutil function to test a breakpoint

Author: SYNOPSYS\georgiev Date: 2021-11-17T08:37:30Z New Revision: 9f0b5f9a39ea6e70c98c69a720d7e4f5d3800bf6 URL: https://github.com/llvm/llvm-project/commit/9f0b5f9a39ea6e70c98c69a720d7e4f5d3800bf6 DIFF: https://github.com/llvm/llvm-project/commit/9f0b5f9a39ea6e70c98c69a720d7e4f5d3800bf6.diff

[Lldb-commits] [PATCH] D111899: LLDB tests modification for hardware breakpoints

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f0b5f9a39ea: [lldb/test] Added lldbutil function to test a breakpoint (authored by SYNOPSYS\georgiev ). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D113498: [lldb] Constant-resolve operands to `getelementptr`

werat added a comment. Btw, this crash in `llvm::DataLayout::getIndexedOffsetInType` was discovered by lldb-eval fuzzer a while ago -- https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=36738 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113498

[Lldb-commits] [lldb] 9574da8 - [lldb/test] TestRegisterVariables test fix

Author: SYNOPSYS\georgiev Date: 2021-11-17T10:58:48Z New Revision: 9574da8f51c82aa437c3b968251225932cc970a5 URL: https://github.com/llvm/llvm-project/commit/9574da8f51c82aa437c3b968251225932cc970a5 DIFF: https://github.com/llvm/llvm-project/commit/9574da8f51c82aa437c3b968251225932cc970a5.diff

[Lldb-commits] [PATCH] D113498: [lldb] Constant-resolve operands to `getelementptr`

teemperor added a comment. In D113498#3131336 , @werat wrote: > In D113498#3124525 , @teemperor > wrote: > >> I really like the solution, but I think by fixing the `CanInterpret` you >> also made the test case n

[Lldb-commits] [PATCH] D113498: [lldb] Constant-resolve operands to `getelementptr`

werat updated this revision to Diff 387911. werat added a comment. Make the check more strict, only verify that the indexes are ConstantInt. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113498/new/ https://reviews.llvm.org/D113498 Files: lldb/s

[Lldb-commits] [PATCH] D113498: [lldb] Constant-resolve operands to `getelementptr`

werat marked 2 inline comments as done. werat added a comment. In D113498#3137196 , @teemperor wrote: > Not sure how flexible your fuzzer setup is regarding downstream patches, but > did you try putting some kind of `assert("coverage" && false);` in that

[Lldb-commits] [PATCH] D113760: [formatters] Add a libstdcpp formatter for for unordered_map, unordered_set, unordered_multimap, unordered_multiset

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. just some minor changes. Could you unify these tests with libcxx? Comment at: lldb/examples/synthetic/gnu_libstdcpp.py:10 # before relying on these formatters to

[Lldb-commits] [PATCH] D114008: Draft PR for the deque, stack, queue lldb data formatters

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. discussed offline how to traverse each individual subarray. This might make it impossible to reuse it for queue and stack Comment at: lldb/examples/synthetic/gnu

[Lldb-commits] [lldb] f07ddbc - [lldb] build failure for LLDB_PYTHON_EXE_RELATIVE_PATH on greendragon

Author: Lawrence D'Anna Date: 2021-11-17T09:26:24-08:00 New Revision: f07ddbc620a0466ebbb41ccbc78f20a8591bed5a URL: https://github.com/llvm/llvm-project/commit/f07ddbc620a0466ebbb41ccbc78f20a8591bed5a DIFF: https://github.com/llvm/llvm-project/commit/f07ddbc620a0466ebbb41ccbc78f20a8591bed5a.dif

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

lawrence_danna added a comment. In D113650#3136407 , @aprantl wrote: > This seems to have broken the green dragon incremental bot: > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/38387/ looks like its fixed now. Repository: rG LLVM Githu

[Lldb-commits] [PATCH] D113604: [lldb] Format lldb/include/lldb/Symbol/Type.h

ljmf00 added a comment. Friendly ping, maybe you forgot this, can you check it now @teemperor ? :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113604/new/ https://reviews.llvm.org/D113604 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [PATCH] D113604: [lldb] Format lldb/include/lldb/Symbol/Type.h

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM modulo the inline comment. Comment at: lldb/include/lldb/Symbol/Type.h:204 // the remaining type scope (namespaces/classes). - static bool GetTypeScopeAndBasename(const llvm::StringRef& name, + static

[Lldb-commits] [PATCH] D114106: [lldb] remove usage of distutils, fix python path on debian/ubuntu

lawrence_danna created this revision. lawrence_danna added reviewers: labath, jingham, JDevlieghere. Herald added a subscriber: mgorny. lawrence_danna requested review of this revision. Herald added a project: LLDB. distutils is deprecated and will be removed, so we shouldn't be using it. We were

[Lldb-commits] [PATCH] D114106: [lldb] remove usage of distutils, fix python path on debian/ubuntu

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I guess the correct path might depend on the precise value of "us". The ubuntu packagers might still want to put the files at that location, but they can just use the cmake variable to do that

[Lldb-commits] [PATCH] D114111: Remove a useless temporary of a base class type.

alexfh created this revision. alexfh added a reviewer: clayborg. alexfh requested review of this revision. Herald added a project: LLDB. This was found by clang-tidy bugprone-undelegated-constructor check. Was there since the very first commit back in 2016. Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] 1b468f1 - [lldb] Port PlatformWindows, PlatformOpenBSD and PlatformRemoteGDBServer to GetSupportedArchitectures

Author: Pavel Labath Date: 2021-11-17T20:09:31+01:00 New Revision: 1b468f1c1b46734f64f15c22cfbd403bada9fed8 URL: https://github.com/llvm/llvm-project/commit/1b468f1c1b46734f64f15c22cfbd403bada9fed8 DIFF: https://github.com/llvm/llvm-project/commit/1b468f1c1b46734f64f15c22cfbd403bada9fed8.diff

[Lldb-commits] [PATCH] D114111: Remove a useless temporary of a base class type.

JDevlieghere added a comment. @labath Do you know what the status is of removing RenderScript altogether? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114111/new/ https://reviews.llvm.org/D114111 ___ ll

[Lldb-commits] [PATCH] D113760: [formatters] Add a libstdcpp formatter for for unordered_map, unordered_set, unordered_multimap, unordered_multiset

danilashtefan updated this revision to Diff 388012. danilashtefan marked 9 inline comments as done. danilashtefan added a comment. All the above-mentioned is changed. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113760/new/ https://revi

[Lldb-commits] [PATCH] D113760: [formatters] Add a libstdcpp formatter for for unordered_map, unordered_set, unordered_multimap, unordered_multiset

wallace requested changes to this revision. wallace added inline comments. This revision now requires changes to proceed. Comment at: lldb/examples/synthetic/gnu_libstdcpp.py:22-27 +def get_object_kind(self, valobj): +type_name = valobj.GetTypeName() +for kind

[Lldb-commits] [PATCH] D113760: [formatters] Add a libstdcpp formatter for for unordered_map, unordered_set, unordered_multimap, unordered_multiset

danilashtefan updated this revision to Diff 388016. danilashtefan added a comment. Done! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113760/new/ https://reviews.llvm.org/D113760 Files: lldb/examples/synthetic/gnu_libstdcpp.py lldb/source/Plu

[Lldb-commits] [PATCH] D113760: [formatters] Add a libstdcpp formatter for for unordered_map, unordered_set, unordered_multimap, unordered_multiset

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. good job! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113760/new/ https://reviews.llvm.org/D113760

[Lldb-commits] [lldb] 6327071 - [lldb] remove usage of distutils, fix python path on debian/ubuntu

Author: Lawrence D'Anna Date: 2021-11-17T13:14:30-08:00 New Revision: 63270710f13af10808aac980795128db127153f5 URL: https://github.com/llvm/llvm-project/commit/63270710f13af10808aac980795128db127153f5 DIFF: https://github.com/llvm/llvm-project/commit/63270710f13af10808aac980795128db127153f5.dif

[Lldb-commits] [PATCH] D114106: [lldb] remove usage of distutils, fix python path on debian/ubuntu

This revision was automatically updated to reflect the committed changes. Closed by commit rG63270710f13a: [lldb] remove usage of distutils, fix python path on debian/ubuntu (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D114123: [NFC][lldb] Inclusive language: remove instances of master from comments in lldb

quinnp created this revision. quinnp requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. [NFC] As part of using inclusive language within the llvm project, this patch removes master in these comments. Repository: rG LLVM Github Monorepo ht

[Lldb-commits] [PATCH] D113498: [lldb] Constant-resolve operands to `getelementptr`

clayborg added a comment. FYI: I am not familiar enough with the expression parser and IR interpreter logic to be able to be able to give the ok here. I hope other expression parser experts will continue to give good feedback on this patch! Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D114123: [NFC][lldb] Inclusive language: remove instances of master from comments in lldb

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Suggested different replacement strings for the comments. Comment at: lldb/source/Core/Debugger.cpp:491 if (g_debugger_list_ptr && g_debugger_list_mutex_ptr)

[Lldb-commits] [PATCH] D113965: [NFC] Refactor symbol table parsing.

This revision was automatically updated to reflect the committed changes. Closed by commit rG951b107eedab: [NFC] Refactor symbol table parsing. (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113965/new/ https://reviews.llvm.or

[Lldb-commits] [lldb] 951b107 - [NFC] Refactor symbol table parsing.

Author: Greg Clayton Date: 2021-11-17T15:14:01-08:00 New Revision: 951b107eedab1829f18049443f03339dbb0db165 URL: https://github.com/llvm/llvm-project/commit/951b107eedab1829f18049443f03339dbb0db165 DIFF: https://github.com/llvm/llvm-project/commit/951b107eedab1829f18049443f03339dbb0db165.diff

[Lldb-commits] [PATCH] D113498: [lldb] Constant-resolve operands to `getelementptr`

jingham resigned from this revision. jingham added a comment. I have also never looked at the IR Interpreter code, and am not particularly familiar with llvm IR, sorry. Maybe Shafik Yaghmour? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113498/ne

[Lldb-commits] [lldb] 92eaad2 - Revert "Revert "Make it possible for lldb to launch a remote binary with no local file.""

Author: Jim Ingham Date: 2021-11-17T17:59:47-08:00 New Revision: 92eaad2dd7adb5ee92f397cef85ab11f2612294e URL: https://github.com/llvm/llvm-project/commit/92eaad2dd7adb5ee92f397cef85ab11f2612294e DIFF: https://github.com/llvm/llvm-project/commit/92eaad2dd7adb5ee92f397cef85ab11f2612294e.diff LO

[Lldb-commits] [lldb] a68ccda - Revert "[NFC] Refactor symbol table parsing."

Author: Greg Clayton Date: 2021-11-17T18:07:28-08:00 New Revision: a68ccda203aad2cc4fd386d5e893237f09fa1ffb URL: https://github.com/llvm/llvm-project/commit/a68ccda203aad2cc4fd386d5e893237f09fa1ffb DIFF: https://github.com/llvm/llvm-project/commit/a68ccda203aad2cc4fd386d5e893237f09fa1ffb.diff

[Lldb-commits] [PATCH] D113498: [lldb] Constant-resolve operands to `getelementptr`

shafik added a comment. So `(int*)100` can't be a constant expression b/c it is basically a `reinterpret_cast` and that is forbidden in a constant expression e.g.: constexpr const int* ip2 = (int*)100; is ill-formed. On the other hand this is a well-formed constant expression: static cons

[Lldb-commits] [PATCH] D113498: [lldb] Constant-resolve operands to `getelementptr`

shafik added a comment. I am OOO for a bit but this makes sense and LGTM, let me think about it a bit more. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113498/new/ https://reviews.llvm.org/D113498 ___

[Lldb-commits] [PATCH] D114123: [NFC][lldb] Inclusive language: remove instances of master from comments in lldb

quinnp updated this revision to Diff 388084. quinnp marked 2 inline comments as done. quinnp added a comment. Addressing review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114123/new/ https://reviews.llvm.org/D114123 Files: lldb/sour

[Lldb-commits] [PATCH] D114123: [NFC][lldb] Inclusive language: remove instances of master from comments in lldb

quinnp added a comment. Thanks @clayborg! I've updated the patch based on your suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114123/new/ https://reviews.llvm.org/D114123 ___ lldb-commits mai

[Lldb-commits] [PATCH] D113965: [NFC] Refactor symbol table parsing.

clayborg added a comment. I had to revert this. There is a deadlock in: void Module::PreloadSymbols() { std::lock_guard guard(m_mutex); SymbolFile *sym_file = GetSymbolFile(); if (!sym_file) return; // Prime the symbol file first, since it adds symbols to the symbol tab

[Lldb-commits] [PATCH] D114111: Remove a useless temporary of a base class type.

labath accepted this revision. labath added subscribers: danalbert, srhines. labath added a comment. This revision is now accepted and ready to land. In D114111#3138390 , @JDevlieghere wrote: > @labath Do you know what the status is of removing RenderScr