[Lldb-commits] [PATCH] D115137: [formatters] Add a pointer and reference tests for a list and forward_list formatters for libstdcpp and libcxx

danilashtefan created this revision. danilashtefan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D115137 Files: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cp

[Lldb-commits] [PATCH] D114861: Don't consider frames with different PCs as a loop

labath added a comment. It would be better if Jason reviewed this, but my first thoughts after seeing this are: If we're going to be using both the PC and the CFA for frame comparison, do we really need to also skip a frame when doing the comparing? It seems like it should be sufficient to com

[Lldb-commits] [PATCH] D114862: Replace StackID's operator "<" with a function returning FrameComparison

labath added a reviewer: jingham. labath added a comment. I don't really know what to make of this, but adding Jim for the thread plan changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114862/new/ https://reviews.llvm.org/D114862 ___

[Lldb-commits] [PATCH] D114819: [lldb] Split TestCxxChar8_t

labath added a comment. Looks good. Thanks for fixing this up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114819/new/ https://reviews.llvm.org/D114819 ___ lldb-commits mailing list lldb-commits@lists.

[Lldb-commits] [PATCH] D115062: [LLDB][Clang] add AccessSpecDecl for methods and fields in RecordType

labath added a comment. I like this feature, but I gotta say that a map feels a bit wasteful as well, given that the last access specifier is only needed for the short duration of time while the class definition is being parsed. Maybe if you remove the relevant entry when `CompleteTagDeclaratio

[Lldb-commits] [PATCH] D114911: [lldb] Introduce a FreeBSDKernel plugin for vmcores

mgorny updated this revision to Diff 392003. mgorny added a comment. Force `DynamicLoaderStatic`. This fixes determining load address for symbols. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114911/new/ https://reviews.llvm.org/D114911 Files: lldb/source/Plugins/Process/CMakeLists.

[Lldb-commits] [PATCH] D114675: [lldb] [Target] Support fallback to file address in ReadMemory()

mgorny abandoned this revision. mgorny added a comment. Closing in favor of D114911 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114675/new/ https://reviews.llvm.org/D114675 ___ lldb-commits mailing list l

[Lldb-commits] [PATCH] D115073: Modify DataEncoder to be able to encode data in an object owned buffer.

labath added a comment. It seems to me that the DataEncoder class is a lot more complicated than what is necessary for our existing use cases. All of them involve creating a new buffer (either empty, or with some pre-existing content), modifying it, and passing it on. A lot of the DataEncoder c

[Lldb-commits] [PATCH] D113930: [LLDB][NativePDB] Fix function decl creation for class methods

labath added a comment. I am somewhat confused by this deduplication logic. I've read https://reviews.llvm.org/D113930#3136404, so I understand why the duplication is happening, but I don't understand _should_ it be happening. IIUC, `SymbolFileNativePDB::ParseTypes` tries to force the completio

[Lldb-commits] [PATCH] D115126: [LLDB] Add unit tests for Editline keyboard shortcuts

labath added a comment. All of the changes seem fine, but it's not clear to me what is the value of the new test. To me, it just seems like a change-detector forcing the two versions of the keybindings to stay in sync. The need for the friend declarations and everything also enforces the feelin

[Lldb-commits] [PATCH] D114911: [lldb] Introduce a FreeBSDKernel plugin for vmcores

labath added a comment. I don't have a problem with incomplete patches. I (and llvm, in general) actually strongly incremental development. I'm more interested in the testing story. Comment at: lldb/source/Plugins/Process/FreeBSDKernel/CMakeLists.txt:1 +find_library(FBSDVMCOR

[Lldb-commits] [lldb] fdc1638 - [lldb] [Process/elf-core] Disable for FreeBSD vmcores

Author: Michał Górny Date: 2021-12-06T14:40:02+01:00 New Revision: fdc1638b5cbd7f93937dce56f8ea29db52390502 URL: https://github.com/llvm/llvm-project/commit/fdc1638b5cbd7f93937dce56f8ea29db52390502 DIFF: https://github.com/llvm/llvm-project/commit/fdc1638b5cbd7f93937dce56f8ea29db52390502.diff

[Lldb-commits] [PATCH] D114967: [lldb] [Process/elf-core] Disable for FreeBSD vmcores

This revision was automatically updated to reflect the committed changes. Closed by commit rGfdc1638b5cbd: [lldb] [Process/elf-core] Disable for FreeBSD vmcores (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [lldb] a52af6d - [lldb] Remove extern "C" from lldb-swig-lua interface

Author: Pavel Labath Date: 2021-12-06T14:57:44+01:00 New Revision: a52af6d3714fa6ea749783400a98dcfad94814b0 URL: https://github.com/llvm/llvm-project/commit/a52af6d3714fa6ea749783400a98dcfad94814b0 DIFF: https://github.com/llvm/llvm-project/commit/a52af6d3714fa6ea749783400a98dcfad94814b0.diff

[Lldb-commits] [lldb] 85578db - [lldb/lua] Add a file that should have been a part of a52af6d3

Author: Pavel Labath Date: 2021-12-06T14:58:39+01:00 New Revision: 85578db68aa9e3ad3f62e9aa6830d2a4c362cd1d URL: https://github.com/llvm/llvm-project/commit/85578db68aa9e3ad3f62e9aa6830d2a4c362cd1d DIFF: https://github.com/llvm/llvm-project/commit/85578db68aa9e3ad3f62e9aa6830d2a4c362cd1d.diff

[Lldb-commits] [PATCH] D115074: [lldb/lua] Suppress warnings about C-linkage in generated wrapper

labath added a comment. I just went ahead and did that in a52af6d3714 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115074/new/ https://reviews.llvm.org/D115074 __

[Lldb-commits] [lldb] 5c4cb32 - [lldb/qemu] Add support for pty redirection

Author: Pavel Labath Date: 2021-12-06T15:03:21+01:00 New Revision: 5c4cb323e86aaf816c0dd45191dad08e5d4691cf URL: https://github.com/llvm/llvm-project/commit/5c4cb323e86aaf816c0dd45191dad08e5d4691cf DIFF: https://github.com/llvm/llvm-project/commit/5c4cb323e86aaf816c0dd45191dad08e5d4691cf.diff

[Lldb-commits] [PATCH] D114796: [lldb/qemu] Add support for pty redirection

This revision was automatically updated to reflect the committed changes. Closed by commit rG5c4cb323e86a: [lldb/qemu] Add support for pty redirection (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114796/new/ https://reviews.ll

[Lldb-commits] [PATCH] D115151: [lldb/qemu] Add emulator-args setting

labath created this revision. labath added reviewers: DavidSpickett, mgorny, JDevlieghere. labath requested review of this revision. Herald added a project: LLDB. This setting allows the user to pass additional arguments to the qemu instance. While we may want to introduce dedicated settings for t

[Lldb-commits] [PATCH] D114722: [LLDB] Fix Python GIL-not-held issues

labath added a reviewer: JDevlieghere. labath added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:101 + } else { +auto gstate = PyGILState_Ensure(); +Py_XDECREF(GetValue()); This usage of auto i

[Lldb-commits] [PATCH] D114746: [lldb] Generalize ParsedDWARFTypeAttributes

ljmf00 updated this revision to Diff 392069. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114746/new/ https://reviews.llvm.org/D114746 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.cpp lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.h lldb/source/Plugins/SymbolFil

[Lldb-commits] [PATCH] D114746: [lldb] Generalize ParsedDWARFTypeAttributes

ljmf00 accepted this revision. ljmf00 added a comment. This revision is now accepted and ready to land. In D114746#3160908 , @labath wrote: > I don't think we should be putting this into the DWARFAttribute file. It is > substantially higher-level than th

[Lldb-commits] [PATCH] D114746: [lldb] Generalize ParsedDWARFTypeAttributes

ljmf00 resigned from this revision. ljmf00 added a comment. This revision now requires review to proceed. Ops, clicked on the wrong button CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114746/new/ https://reviews.llvm.org/D114746 ___ lldb-com

[Lldb-commits] [PATCH] D114746: [lldb] Generalize ParsedDWARFTypeAttributes

ljmf00 updated this revision to Diff 392087. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114746/new/ https://reviews.llvm.org/D114746 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.cpp lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.h lldb/source/Plugins/SymbolFil

[Lldb-commits] [PATCH] D115126: [LLDB] Add unit tests for Editline keyboard shortcuts

nealsid added a comment. In D115126#3173236 , @labath wrote: > All of the changes seem fine, but it's not clear to me what is the value of > the new test. To me, it just seems like a change-detector forcing the two > versions of the keybindings to stay

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

nealsid added a comment. In D113650#3168622 , @clayborg wrote: > I can't build on macOS now. I checked out the source code and tried to do: > > cmake -G Ninja -DCMAKE_BUILD_TYPE:STRING=Debug > -DLLVM_ENABLE_ASSERTIONS:BOOL=TRUE > -DLLVM_ENABLE_PROJECT

[Lldb-commits] [PATCH] D115126: [LLDB] Add unit tests for Editline keyboard shortcuts

nealsid added a comment. Random unrelated question, and if I missed docs somewhere, I apologize. Did I forget something in creating the revision that caused Harbormaster to not do arc lint or arc test? https://reviews.llvm.org/B137600. Thanks. Repository: rG LLVM Github Monorepo CHANGES S

[Lldb-commits] [lldb] 1f257ac - Speculatively fix the LLDB build bots from 6c75ab5f66b403f7ca67e86aeed3a58abe10570b

Author: Aaron Ballman Date: 2021-12-06T13:30:15-05:00 New Revision: 1f257accd713a8e302d3fdd2cac615a303295c42 URL: https://github.com/llvm/llvm-project/commit/1f257accd713a8e302d3fdd2cac615a303295c42 DIFF: https://github.com/llvm/llvm-project/commit/1f257accd713a8e302d3fdd2cac615a303295c42.diff

[Lldb-commits] [PATCH] D115062: [LLDB][Clang] add AccessSpecDecl for methods and fields in RecordType

zequanwu updated this revision to Diff 392126. zequanwu marked an inline comment as done. zequanwu added a comment. Erase the cxx_record_decl entry from map after completing it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115062/new/ https://revi

[Lldb-commits] [PATCH] D115073: Modify DataEncoder to be able to encode data in an object owned buffer.

clayborg added a comment. In D115073#3173041 , @labath wrote: > It seems to me that the DataEncoder class is a lot more complicated than what > is necessary for our existing use cases. All of them involve creating a new > buffer (either empty, or with s

[Lldb-commits] [PATCH] D115073: Modify DataEncoder to be able to encode data in an object owned buffer.

clayborg added inline comments. Comment at: lldb/source/Expression/DWARFExpression.cpp:465 std::unique_ptr head_data_up( new DataBufferHeap(m_data.GetDataStart(), m_data.GetByteSize())); That would crash the program. The data here is coming fr

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

clayborg added a comment. In D113650#3173914 , @nealsid wrote: > In D113650#3168622 , @clayborg > wrote: > >> I can't build on macOS now. I checked out the source code and tried to do: >> >> cmake -G Ninja -DCM

[Lldb-commits] [PATCH] D113930: [LLDB][NativePDB] Fix function decl creation for class methods

zequanwu added a comment. In D113930#3173181 , @labath wrote: > While I'm not very familiar with PDBs or the process of clang ast creation, > it sounds to me like there is something wrong here, and I want to make sure > we're not using the deduplication

[Lldb-commits] [PATCH] D115073: Modify DataEncoder to be able to encode data in an object owned buffer.

labath added a comment. I don't think we actually disagree here. I'm aware of your use case (let's call it "dynamic mode") for appending to a buffer. I agree it's useful and I don't want to change that. What I want to remove is the other mode (non-dynamic). Presently, this is the only mode, but

[Lldb-commits] [PATCH] D113930: [LLDB][NativePDB] Fix function decl creation for class methods

labath added a comment. Thanks for the explanation. This makes things a lot clearer (though it doesn't convince me that this is the right approach). I still think that the piecemeal addition of member functions is a problem. While I don't think that changing the parsing order in `Module::Parse

[Lldb-commits] [PATCH] D115137: [formatters] Add a pointer and reference tests for a list and forward_list formatters for libstdcpp and libcxx

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115137/new/ https://reviews.llvm.org/D115137 ___

[Lldb-commits] [PATCH] D115073: Modify DataEncoder to be able to encode data in an object owned buffer.

clayborg added a comment. In D115073#3174376 , @labath wrote: > I don't think we actually disagree here. I'm aware of your use case (let's > call it "dynamic mode") for appending to a buffer. I agree it's useful and I > don't want to change that. What I

[Lldb-commits] [PATCH] D115178: Unify libstdcpp and libcxx formatters for `std::optional`

zrthxn created this revision. zrthxn added a reviewer: wallace. zrthxn requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D115178 Files: lldb/source/Plugins/Language/CPlusPlus/

[Lldb-commits] [PATCH] D115178: Unify libstdcpp and libcxx formatters for `std::optional`

zrthxn updated this revision to Diff 392154. zrthxn added a comment. Herald added a subscriber: mgorny. Squash many commits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115178/new/ https://reviews.llvm.org/D115178 Files: lldb/source/Plugins/Lan

Re: [Lldb-commits] [lldb] ee4b462 - [lldb] Fix a warning

I am wondering if you also need to check if token != LLDB_INVALID_ADDRESS > On Dec 4, 2021, at 6:34 PM, Kazu Hirata via lldb-commits > wrote: > > > Author: Kazu Hirata > Date: 2021-12-04T18:34:29-08:00 > New Revision: ee4b462693b1ffeccfe1b8fcf0a0c12896ac6e6a > > URL: > https://github.com/llv

[Lldb-commits] [PATCH] D115182: [lldb] Remove some trivial scoped timers

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, aprantl. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. While profiling lldb (from swift/llvm-project), these timers were noticed to be short lived

[Lldb-commits] [PATCH] D115182: [lldb] Remove some trivial scoped timers

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. These functions seem hot enough that the overhead of the timer outweighs the value it brings. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D115178: Unify libstdcpp and libcxx formatters for `std::optional`

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. back to your queue until you get things working Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115178/new/ https://reviews.llvm.org/D

[Lldb-commits] [lldb] 2ea3c8a - [formatters] Add a deque formatter for libstdcpp and fix the libcxx one

Author: Walter Erquinigo Date: 2021-12-06T13:42:03-08:00 New Revision: 2ea3c8a50add5436cf939d59c3235408ca0255c1 URL: https://github.com/llvm/llvm-project/commit/2ea3c8a50add5436cf939d59c3235408ca0255c1 DIFF: https://github.com/llvm/llvm-project/commit/2ea3c8a50add5436cf939d59c3235408ca0255c1.di

[Lldb-commits] [lldb] 6622c14 - [formatters] Add a pointer and reference tests for a list and forward_list formatters for libstdcpp and libcxx

Author: Danil Stefaniuc Date: 2021-12-06T13:42:03-08:00 New Revision: 6622c1411339488aa086704ac3fad3b040604dff URL: https://github.com/llvm/llvm-project/commit/6622c1411339488aa086704ac3fad3b040604dff DIFF: https://github.com/llvm/llvm-project/commit/6622c1411339488aa086704ac3fad3b040604dff.dif

[Lldb-commits] [PATCH] D115137: [formatters] Add a pointer and reference tests for a list and forward_list formatters for libstdcpp and libcxx

This revision was automatically updated to reflect the committed changes. Closed by commit rG6622c1411339: [formatters] Add a pointer and reference tests for a list and forward_list… (authored by danilashtefan, committed by Walter Erquinigo ). Repository: rG LLVM Github Monorep

[Lldb-commits] [PATCH] D114746: [lldb] Generalize ParsedDWARFTypeAttributes

shafik added a comment. I am happy as long as Pavel is good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114746/new/ https://reviews.llvm.org/D114746 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[Lldb-commits] [PATCH] D115073: Modify DataEncoder to be able to encode data in an object owned buffer.

clayborg updated this revision to Diff 392177. clayborg added a comment. Updated to make DataEncoder always copy any data and own the buffer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115073/new/ https://reviews.llvm.org/D115073 Files: lldb/

[Lldb-commits] [PATCH] D114923: [lldb/plugins] Add arm64(e) support to ScriptedProcess

mib updated this revision to Diff 392178. mib marked an inline comment as done. mib edited the summary of this revision. mib added a comment. Add invalid Scripted Thread test, addressing @JDevlieghere comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114923/new/ https://reviews.llv

[Lldb-commits] [PATCH] D115073: Modify DataEncoder to be able to encode data in an object owned buffer.

clayborg updated this revision to Diff 392187. clayborg added a comment. Update the headerdoc and fixed some of the comments that were out of date or left over from the inital copy from DataExtractor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D115073: Modify DataEncoder to be able to encode data in an object owned buffer.

clayborg updated this revision to Diff 392191. clayborg added a comment. More documentation fixed for DataEncoder. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115073/new/ https://reviews.llvm.org/D115073 Files: lldb/include/lldb/Utility/DataEn

[Lldb-commits] [PATCH] D115178: Unify libstdcpp and libcxx formatters for `std::optional`

zrthxn updated this revision to Diff 392197. zrthxn added a comment. Added libcxx support Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115178/new/ https://reviews.llvm.org/D115178 Files: lldb/source/Plugins/Language/CPlusPlus/CMakeLists.txt l

[Lldb-commits] [PATCH] D115178: Unify libstdcpp and libcxx formatters for `std::optional`

wallace added a comment. good job! Only some cosmetic changes are needed and you also need to delete the python code Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:775-779 + // AddCXXSummary(cpp_category_sp, + // lldb_private::formatte

[Lldb-commits] [lldb] 13278ef - [lldb] Remove some trivial scoped timers

Author: Dave Lee Date: 2021-12-06T15:22:28-08:00 New Revision: 13278efd0c95a8b589bbd7dbbf17680a03b6eb77 URL: https://github.com/llvm/llvm-project/commit/13278efd0c95a8b589bbd7dbbf17680a03b6eb77 DIFF: https://github.com/llvm/llvm-project/commit/13278efd0c95a8b589bbd7dbbf17680a03b6eb77.diff LOG:

[Lldb-commits] [PATCH] D115182: [lldb] Remove some trivial scoped timers

This revision was automatically updated to reflect the committed changes. Closed by commit rG13278efd0c95: [lldb] Remove some trivial scoped timers (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115182/new/ https://reviews.

[Lldb-commits] [PATCH] D114923: [lldb/plugins] Add arm64(e) support to ScriptedProcess

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114923/new/ https://reviews.llvm.org/D114923 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D114923: [lldb/plugins] Add arm64(e) support to ScriptedProcess

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcaea440a11e4: [lldb/plugins] Add arm64(e) support to ScriptedProcess (authored by mib). Changed prior to commit: https://reviews.llvm.org/D114923?

[Lldb-commits] [lldb] caea440 - [lldb/plugins] Add arm64(e) support to ScriptedProcess

Author: Med Ismail Bennani Date: 2021-12-06T16:11:59-08:00 New Revision: caea440a11e47bf86b0e43feb28a9287e4fbe3f8 URL: https://github.com/llvm/llvm-project/commit/caea440a11e47bf86b0e43feb28a9287e4fbe3f8 DIFF: https://github.com/llvm/llvm-project/commit/caea440a11e47bf86b0e43feb28a9287e4fbe3f8.

[Lldb-commits] [PATCH] D113930: [LLDB][NativePDB] Fix function decl creation for class methods

zequanwu added a comment. In D113930#3174406 , @labath wrote: > I still think that the piecemeal addition of member functions is a problem. > While I don't think that changing the parsing order in > `Module::ParseAllDebugSymbols` would be a problem (tha

[Lldb-commits] [PATCH] D115201: [lldb] Generalize UpdateSymbolContextScopeForType

ljmf00 created this revision. Herald added a reviewer: shafik. ljmf00 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a project: LLDB. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D115201 File

[Lldb-commits] [lldb] 9c144b3 - [lldb/test] Fix InvalidScriptedThread windows test failure

Author: Med Ismail Bennani Date: 2021-12-06T17:59:29-08:00 New Revision: 9c144b3b0d6a995c2a1eecb53db06f3896e878ff URL: https://github.com/llvm/llvm-project/commit/9c144b3b0d6a995c2a1eecb53db06f3896e878ff DIFF: https://github.com/llvm/llvm-project/commit/9c144b3b0d6a995c2a1eecb53db06f3896e878ff.

[Lldb-commits] [PATCH] D115211: [lldb] Make the LLDB version a first class citizen

JDevlieghere created this revision. JDevlieghere added reviewers: labath, bulbazord. Herald added subscribers: tstellar, mgorny. JDevlieghere requested review of this revision. Instead of trying to squeeze `GetVersion` into `lldb-private.h`, give it its own header and implementation file in its o

[Lldb-commits] [PATCH] D115211: [lldb] Make the LLDB version a first class citizen

labath added a comment. I am definitely not sad to see lldbBase go away, but I am wondering if we really need a separate library for this functionality (function). The only reason I can think of is that this function forces a dependency on clang. If we put it in say Utility, then all of lldb wo