[Lldb-commits] [lldb] 05f10ae - On Windows, the function name contains the return parameter, so

Author: Jim Ingham Date: 2022-02-16T19:10:03-08:00 New Revision: 05f10ae0d8548e65130475730a1565203da8726d URL: https://github.com/llvm/llvm-project/commit/05f10ae0d8548e65130475730a1565203da8726d DIFF: https://github.com/llvm/llvm-project/commit/05f10ae0d8548e65130475730a1565203da8726d.diff LO

[Lldb-commits] [PATCH] D119997: Add a little test for simple breaking on overloaded functions by name

jingham added a comment. Should have been Module::LookupInfo in the Description... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119997/new/ https://reviews.llvm.org/D119997 ___ lldb-commits mailing list

[Lldb-commits] [lldb] dd8490d - Add a test for breaking on overloaded functions by name.

Author: Jim Ingham Date: 2022-02-16T18:12:00-08:00 New Revision: dd8490d207d3a1612091abbea04bf660f133a89f URL: https://github.com/llvm/llvm-project/commit/dd8490d207d3a1612091abbea04bf660f133a89f DIFF: https://github.com/llvm/llvm-project/commit/dd8490d207d3a1612091abbea04bf660f133a89f.diff LO

[Lldb-commits] [PATCH] D119997: Add a little test for simple breaking on overloaded functions by name

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks Jim! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119997/new/ https://reviews.llvm.org/D119997 ___

[Lldb-commits] [PATCH] D119997: Add a little test for simple breaking on overloaded functions by name

jingham created this revision. jingham added a reviewer: JDevlieghere. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When Jonas made the change to not add demangled names to the name indexes, we were worried it might cause breaki

[Lldb-commits] [PATCH] D119918: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

phosek added a comment. Provide fallback for `TARGET_TRIPLE` and print a warning about deprecation and future removal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119918/new/ https://reviews.llvm.org/D119918

[Lldb-commits] [PATCH] D119918: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

phosek updated this revision to Diff 409394. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119918/new/ https://reviews.llvm.org/D119918 Files: bolt/test/Unit/lit.site.cfg.py.in bolt/test/lit.site.cfg.py.in clang-tools-extra/clangd/test/lit.sit

[Lldb-commits] [PATCH] D119178: Add support for generating debug-info for structured bindings of structs and arrays

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4647 +const bool UsePointerValue) { + assert(CGM.getCodeGenOpts().hasRedu

[Lldb-commits] [PATCH] D119918: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

ldionne accepted this revision. ldionne added a comment. LGTM from libc++/libc++abi's perspective. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119918/new/ https://reviews.llvm.org/D119918 ___ lldb-comm

[Lldb-commits] [PATCH] D119918: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

rovka added a comment. Is this going to break for everyone that still passes TARGET_TRIPLE to cmake? If so, we should probably have a period where we support both. In particular, this might break some of our buildbots

[Lldb-commits] [PATCH] D119918: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. Looks great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119918/new/ https://reviews.llvm.org/D1199

[Lldb-commits] [PATCH] D119918: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

phosek created this revision. phosek added reviewers: beanz, smeenai, ldionne, compnerd. Herald added subscribers: ayermolo, sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, ar

[Lldb-commits] [PATCH] D119963: [LLDB] Dump valid ranges of variables

zequanwu updated this revision to Diff 409440. zequanwu added a comment. Herald added a subscriber: dang. Add `-show-variables-ranges`/`-R` flag to enable it with `-v`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119963/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D119548: [lldb] Fix race condition between lldb-vscode and stop hooks executor

jingham added a comment. I don't think CreateProcess needs a HijackListener, does it? It doesn't generate events, it just make the connection to the server. It is always followed by Launch or DebugProcess, which are the ones that do the real work. Comment at: lldb/include/l

[Lldb-commits] [PATCH] D119963: [LLDB] Dump valid ranges of variables

jingham added a comment. In D119963#3327472 , @zequanwu wrote: > In D119963#3327139 , @jingham wrote: > >> It's really useful to be able to see these variable ranges, so the feature >> seems good to me, but I thi

[Lldb-commits] [PATCH] D119548: [lldb] Fix race condition between lldb-vscode and stop hooks executor

ilya-nozhkin updated this revision to Diff 409404. ilya-nozhkin added a comment. Herald added a subscriber: emaste. Applied requested changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119548/new/ https://reviews.llvm.org/D119548 Files: lldb/include/lldb/Target/Process.h lldb/i

[Lldb-commits] [PATCH] D119501: [lldb/crashlog] Add CrashLogScriptedProcess & remove interactive mode

mib added a comment. In D119501#3327339 , @shafik wrote: > Looks like the `scripted_crashlog_json.test` is broken on green dragon: > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/41454/testReport/junit/lldb-shell/ScriptInterpreter_Python_Cras

[Lldb-commits] [lldb] d95961f - [lldb/test] Disable scripted_crashlog_json.test on non darwin aarch64 systems

Author: Med Ismail Bennani Date: 2022-02-16T13:51:53-08:00 New Revision: d95961f214a9f2e7abc2844cee309e42eba5600c URL: https://github.com/llvm/llvm-project/commit/d95961f214a9f2e7abc2844cee309e42eba5600c DIFF: https://github.com/llvm/llvm-project/commit/d95961f214a9f2e7abc2844cee309e42eba5600c.

[Lldb-commits] [PATCH] D119963: [LLDB] Dump valid ranges of variables

zequanwu added a comment. In D119963#3327139 , @jingham wrote: > It's really useful to be able to see these variable ranges, so the feature > seems good to me, but I think the valid range output should be governed by > another flag, like --show-variable

[Lldb-commits] [PATCH] D119501: [lldb/crashlog] Add CrashLogScriptedProcess & remove interactive mode

shafik added a comment. Looks like the `scripted_crashlog_json.test` is broken on green dragon: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/41454/testReport/junit/lldb-shell/ScriptInterpreter_Python_Crashlog/scripted_crashlog_json_test/ Repository: rG LLVM Github Monorepo CHANG

[Lldb-commits] [PATCH] D119915: Replace use of double underscore in identifiers

This revision was automatically updated to reflect the committed changes. Closed by commit rG80a11e080358: [LLDB] Replace use of double underscore in identifiers (authored by shafik). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [lldb] 80a11e0 - [LLDB] Replace use of double underscore in identifiers

Author: Shafik Yaghmour Date: 2022-02-16T11:54:45-08:00 New Revision: 80a11e0803585556804274fc374b208901aa7a94 URL: https://github.com/llvm/llvm-project/commit/80a11e0803585556804274fc374b208901aa7a94 DIFF: https://github.com/llvm/llvm-project/commit/80a11e0803585556804274fc374b208901aa7a94.dif

[Lldb-commits] [PATCH] D119963: [LLDB] Dump valid ranges of variables

jingham added a comment. I think the valid range output should be governed by another flag, like --show-variable-ranges. In optimized code, there can be a whole lot of ranges for each variable, so this could get really noisy and make the whole output hard to look at. Repository: rG LLVM Gi

[Lldb-commits] [PATCH] D119504: [lldb/crashlog] Fix exception signal parsing

This revision was automatically updated to reflect the committed changes. Closed by commit rG21658b77a596: [lldb/crashlog] Fix exception signal parsing (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119504/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D119501: [lldb/crashlog] Add CrashLogScriptedProcess & remove interactive mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7c54ffdc6c2e: [lldb/crashlog] Add CrashLogScriptedProcess & remove interactive mode (authored by mib). Changed prior to commit: https://reviews.ll

[Lldb-commits] [PATCH] D119499: [lldb/API] Add a way to check if the CommandInterpreter is interactive

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f3fc2eee8ff: [lldb/API] Add a way to check if the CommandInterpreter is interactive (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119499/

[Lldb-commits] [lldb] 21658b7 - [lldb/crashlog] Fix exception signal parsing

Author: Med Ismail Bennani Date: 2022-02-16T11:44:07-08:00 New Revision: 21658b77a5965217eb67f8e1ccd4307111c775f7 URL: https://github.com/llvm/llvm-project/commit/21658b77a5965217eb67f8e1ccd4307111c775f7 DIFF: https://github.com/llvm/llvm-project/commit/21658b77a5965217eb67f8e1ccd4307111c775f7.

[Lldb-commits] [lldb] 7f3fc2e - [lldb/API] Add a way to check if the CommandInterpreter is interactive

Author: Med Ismail Bennani Date: 2022-02-16T11:44:07-08:00 New Revision: 7f3fc2eee8ff13f6922a16331870fc57cd022773 URL: https://github.com/llvm/llvm-project/commit/7f3fc2eee8ff13f6922a16331870fc57cd022773 DIFF: https://github.com/llvm/llvm-project/commit/7f3fc2eee8ff13f6922a16331870fc57cd022773.

[Lldb-commits] [PATCH] D119388: [lldb/Plugin] Add artificial stackframe loading in ScriptedThread

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG70665844915e: [lldb/Plugin] Add artificial stackframe loading in ScriptedThread (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SI

[Lldb-commits] [lldb] 7c54ffd - [lldb/crashlog] Add CrashLogScriptedProcess & remove interactive mode

Author: Med Ismail Bennani Date: 2022-02-16T11:44:07-08:00 New Revision: 7c54ffdc6c2e55565344a8d6200f63ee016891a9 URL: https://github.com/llvm/llvm-project/commit/7c54ffdc6c2e55565344a8d6200f63ee016891a9 DIFF: https://github.com/llvm/llvm-project/commit/7c54ffdc6c2e55565344a8d6200f63ee016891a9.

[Lldb-commits] [lldb] 7066584 - [lldb/Plugin] Add artificial stackframe loading in ScriptedThread

Author: Med Ismail Bennani Date: 2022-02-16T11:44:07-08:00 New Revision: 70665844915eeb66273a84f131ffc33a202539d5 URL: https://github.com/llvm/llvm-project/commit/70665844915eeb66273a84f131ffc33a202539d5 DIFF: https://github.com/llvm/llvm-project/commit/70665844915eeb66273a84f131ffc33a202539d5.

[Lldb-commits] [PATCH] D119386: [lldb/Plugins] Clean-up ScriptedProcess python script (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rGc30742ba7381: [lldb/Plugins] Clean-up ScriptedProcess python script (NFC) (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119386/new/ https

[Lldb-commits] [lldb] c30742b - [lldb/Plugins] Clean-up ScriptedProcess python script (NFC)

Author: Med Ismail Bennani Date: 2022-02-16T11:44:07-08:00 New Revision: c30742ba73816ca61926121c82b81a766ebe1a6e URL: https://github.com/llvm/llvm-project/commit/c30742ba73816ca61926121c82b81a766ebe1a6e DIFF: https://github.com/llvm/llvm-project/commit/c30742ba73816ca61926121c82b81a766ebe1a6e.

[Lldb-commits] [PATCH] D119548: [lldb] Fix race condition between lldb-vscode and stop hooks executor

jingham added a comment. In D119548#3325999 , @labath wrote: > Doing it in the common code is a great idea, and it will make the code more > robust. However, instead of "sneaking" the listener through a member > variable, it would be better to pass it t

[Lldb-commits] [PATCH] D119915: Replace use of double underscore in identifiers

shafik updated this revision to Diff 409344. shafik added a comment. Used shorter options for renaming based on feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119915/new/ https://reviews.llvm.org/D119915 Files: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp lldb/source/

[Lldb-commits] [PATCH] D119963: [LLDB] Dump valid ranges of variables

zequanwu created this revision. zequanwu added a reviewer: labath. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This allows `image lookup -a ... -v` to print variables only if the given address is covered by the valid ranges of

[Lldb-commits] [PATCH] D119501: [lldb/crashlog] Add CrashLogScriptedProcess & remove interactive mode

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119501/new/ https://reviews.llvm.org/D119501 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D119501: [lldb/crashlog] Add CrashLogScriptedProcess & remove interactive mode

mib updated this revision to Diff 409335. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119501/new/ https://reviews.llvm.org/D119501 Files: lldb/bindings/python/CMakeLists.txt lldb/examples/python/crashlog.py lldb/examples/python/scripted_process/crashlog_scripted_process.py lldb

[Lldb-commits] [PATCH] D119501: [lldb/crashlog] Add CrashLogScriptedProcess & remove interactive mode

mib updated this revision to Diff 409325. mib marked an inline comment as done. mib added a comment. Add test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119501/new/ https://reviews.llvm.org/D119501 Files: lldb/bindings/python/CMakeLists.txt lldb/examples/python/crashlog.py lld

[Lldb-commits] [lldb] 6f1ce04 - [lldb] BreakpointResolver::CreateFromStructuredData Gardening (NFC)

Author: Jonas Devlieghere Date: 2022-02-16T10:38:05-08:00 New Revision: 6f1ce046fdd02458fe2e3824b865ba4bdf129d67 URL: https://github.com/llvm/llvm-project/commit/6f1ce046fdd02458fe2e3824b865ba4bdf129d67 DIFF: https://github.com/llvm/llvm-project/commit/6f1ce046fdd02458fe2e3824b865ba4bdf129d67.d

[Lldb-commits] [lldb] 046b772 - [lldb] Default initialize DWARFDebugMacroHeader

Author: Jonas Devlieghere Date: 2022-02-16T10:38:05-08:00 New Revision: 046b772c78a8f6a9728191eda7dae9eb0c766f1b URL: https://github.com/llvm/llvm-project/commit/046b772c78a8f6a9728191eda7dae9eb0c766f1b DIFF: https://github.com/llvm/llvm-project/commit/046b772c78a8f6a9728191eda7dae9eb0c766f1b.d

[Lldb-commits] [lldb] 0c58e9f - [lldb] Fix memory leak in CommandObjectType

Author: Jonas Devlieghere Date: 2022-02-16T09:05:08-08:00 New Revision: 0c58e9f4a474c60ed863e6a66c0e1202b4bd6c78 URL: https://github.com/llvm/llvm-project/commit/0c58e9f4a474c60ed863e6a66c0e1202b4bd6c78 DIFF: https://github.com/llvm/llvm-project/commit/0c58e9f4a474c60ed863e6a66c0e1202b4bd6c78.d

[Lldb-commits] [PATCH] D119548: [lldb] Fix race condition between lldb-vscode and stop hooks executor

labath added a comment. Doing it in the common code is a great idea, and it will make the code more robust. However, instead of "sneaking" the listener through a member variable, it would be better to pass it through function arguments instead (normally in the LaunchInfo struct, and as a probab

[Lldb-commits] [PATCH] D119831: [lldb] Add support for a "global" lldbinit file

labath updated this revision to Diff 409197. labath marked 4 inline comments as done. labath edited the summary of this revision. labath added a comment. And add the extra blank line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119831/new/ https:

[Lldb-commits] [PATCH] D119831: [lldb] Add support for a "system-wide" lldbinit file

labath updated this revision to Diff 409196. labath added a comment. Use the term "global" and rename functions to make it more consistent with existing code. It's worth noting that (as a part of the consistency), I have changed the cmake variable to point to a directory instead of a file. This m

[Lldb-commits] [PATCH] D119831: [lldb] Add support for a "system-wide" lldbinit file

labath added a comment. In D119831#3324830 , @clayborg wrote: > This looks good to me. Just a few things to possibly think about: > > - Maybe we would want addition system init files for different workflows and > then we would start lldb with a new optio

[Lldb-commits] [lldb] 9bde881 - [lldb] Enable TestThreadStepOut on linux

Author: Pavel Labath Date: 2022-02-16T11:18:13+01:00 New Revision: 9bde88182317325bb95c13190a4cf303d3ce4b54 URL: https://github.com/llvm/llvm-project/commit/9bde88182317325bb95c13190a4cf303d3ce4b54 DIFF: https://github.com/llvm/llvm-project/commit/9bde88182317325bb95c13190a4cf303d3ce4b54.diff

[Lldb-commits] [PATCH] D119044: Add a case for Rust in LLDB's PDB reader

This revision was automatically updated to reflect the committed changes. Closed by commit rG1ccfef14e57e: Add a case for Rust in LLDB's PDB reader (authored by arlosi, committed by theraven). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119044/new/

[Lldb-commits] [lldb] 1ccfef1 - Add a case for Rust in LLDB's PDB reader

Author: Arlo Siemsen Date: 2022-02-16T09:58:05Z New Revision: 1ccfef14e57e3ccdf9bb796142225dad8ae08168 URL: https://github.com/llvm/llvm-project/commit/1ccfef14e57e3ccdf9bb796142225dad8ae08168 DIFF: https://github.com/llvm/llvm-project/commit/1ccfef14e57e3ccdf9bb796142225dad8ae08168.diff LOG:

[Lldb-commits] [PATCH] D119857: [lldb] Don't rely on unsigned integer wrapping in PutRawBytes and PutBytesAsRawHex8

labath added a comment. Another option would be to go full-STL and do something like ArrayRef data(ptr, len); if (reverse) for (uint8_t byte: llvm::reverse(data)) ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119857/new/ https://revi

[Lldb-commits] [PATCH] D119915: Replace use of double underscore in identifiers

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Yeah, we shouldn't be using these. Personally, I think the names are now unnecessarily long, and I'd go with something shorter. E.g. replacing the double underscore (btw, in python land they a