[Lldb-commits] [PATCH] D121511: [lldb] Report debugger diagnostics as events

JDevlieghere updated this revision to Diff 415699. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121511/new/ https://reviews.llvm.org/D121511 Files: lldb/include/lldb/Core/Debugger.h lldb/include/lldb/Core/DebuggerEvents.h lldb/source/Core/Debugger.cpp

[Lldb-commits] [PATCH] D121511: [lldb] Report debugger diagnostics as events

JDevlieghere updated this revision to Diff 415697. JDevlieghere added a comment. Migrate a few more call sites to `Debugger::Report{Error,Warning}` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121511/new/ https://reviews.llvm.org/D121511 Files: lldb/include/lldb/Core/Debugger.h

[Lldb-commits] [PATCH] D121511: [lldb] Report debugger diagnostics as events

JDevlieghere updated this revision to Diff 415695. JDevlieghere added a comment. Print diagnostics directly to the debugger's error stream if nobody is listening for them. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121511/new/ https://reviews.llvm.org/D121511 Files:

Re: [Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

> On Mar 15, 2022, at 5:03 PM, Greg Clayton via Phabricator > wrote: > > clayborg added a comment. > > In D121631#3380824 , @jingham wrote: > >> This sort of change needs to do a lot more work to help the user understand >> what they can and can't

[Lldb-commits] [lldb] 37400dd - [LLDB][NFC] Remove dead code from Section.cpp

Author: Shafik Yaghmour Date: 2022-03-15T18:11:30-07:00 New Revision: 37400dd3e817ea43ed9c32d545211dd93b5e7c59 URL: https://github.com/llvm/llvm-project/commit/37400dd3e817ea43ed9c32d545211dd93b5e7c59 DIFF:

[Lldb-commits] [lldb] 384e890 - [LLDB][NativePDB] Remove REQUIRES: system-windows for local-variables-regsiters.s

Author: Zequan Wu Date: 2022-03-15T17:49:46-07:00 New Revision: 384e890dd3a3feeaa482dd973f5cadcf465fe7ec URL: https://github.com/llvm/llvm-project/commit/384e890dd3a3feeaa482dd973f5cadcf465fe7ec DIFF: https://github.com/llvm/llvm-project/commit/384e890dd3a3feeaa482dd973f5cadcf465fe7ec.diff

[Lldb-commits] [PATCH] D121425: [VFS] Add a new getVFSFromYAMLs API

bnbarham added a comment. In D121425#3384188 , @bnbarham wrote: > There's two failing tests with this change: > > - VFSFromYAMLTest.ReturnsExternalPathVFSHit > - VFSFromYAMLTest.ReturnsInternalPathVFSHit > > Apparently we allow relative paths in

[Lldb-commits] [PATCH] D121425: [VFS] Add a new getVFSFromYAMLs API

bnbarham added a comment. There's two failing tests with this change: - VFSFromYAMLTest.ReturnsExternalPathVFSHit - VFSFromYAMLTest.ReturnsInternalPathVFSHit Apparently we allow relative paths in external-contents *without* specifying `overlay-relative: true`. In this case the relative paths

[Lldb-commits] [PATCH] D121426: [VFS] Update uses of getVFSFromYAML to use the new getVFSFromYAMLs API

bnbarham marked an inline comment as done. bnbarham added a comment. Merged into D121425 instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121426/new/ https://reviews.llvm.org/D121426

[Lldb-commits] [PATCH] D121746: Use lit_config.substitute instead of foo % lit_config.params everywhere

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a reviewer: bollu. Herald added subscribers: ayermolo, sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb,

[Lldb-commits] [PATCH] D121425: [VFS] Add a new getVFSFromYAMLs API

bnbarham updated this revision to Diff 415615. bnbarham edited the summary of this revision. bnbarham added a comment. Herald added subscribers: cfe-commits, lldb-commits, carlosgalvezp. Herald added projects: clang, LLDB, clang-tools-extra. Re-order to be before D121424

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

clayborg added a comment. I am personally not a fan of the preloading of symbols settings being on by default as there are large delays in debug session startup on linux due to the lack of any kind of viable acceleration tables. I understand that delays can occur later in the debug session as

[Lldb-commits] [PATCH] D121511: [lldb] Report debugger diagnostics as events

JDevlieghere updated this revision to Diff 415644. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121511/new/ https://reviews.llvm.org/D121511 Files: lldb/include/lldb/Core/Debugger.h lldb/include/lldb/Core/DebuggerEvents.h lldb/source/Core/Debugger.cpp

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

clayborg added a comment. In D121631#3380824 , @jingham wrote: > This sort of change needs to do a lot more work to help the user understand > what they can and can't see if they accept the speed for visibility tradeoff. > > They (and we) also need to

[Lldb-commits] [PATCH] D121511: [lldb] Report debugger diagnostics as events

JDevlieghere updated this revision to Diff 415643. JDevlieghere marked 2 inline comments as done. JDevlieghere added a comment. Herald added a subscriber: mgorny. Address code review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121511/new/ https://reviews.llvm.org/D121511

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan marked 2 inline comments as done. yinghuitan added a comment. Jim, Pavel, thanks for the comment! I am happy to start a strategy discussion for this feature. @clayborg will chrime in later to suggest the approach how we can discuss. I would like to answer some of the questions here

[Lldb-commits] [lldb] 527d2c5 - [lldb] Fix AppleObjCRuntime log channels

Author: Jonas Devlieghere Date: 2022-03-15T14:47:33-07:00 New Revision: 527d2c5867ce93bbd4e28384ea9006a5032162d4 URL: https://github.com/llvm/llvm-project/commit/527d2c5867ce93bbd4e28384ea9006a5032162d4 DIFF:

[Lldb-commits] [lldb] 583223c - [LLDB][NativePDB] Don't complete static members' types when completing a record type.

Author: Zequan Wu Date: 2022-03-15T14:06:54-07:00 New Revision: 583223cd5ec42f369702a146eaac1bf20bdfbd46 URL: https://github.com/llvm/llvm-project/commit/583223cd5ec42f369702a146eaac1bf20bdfbd46 DIFF: https://github.com/llvm/llvm-project/commit/583223cd5ec42f369702a146eaac1bf20bdfbd46.diff

[Lldb-commits] [PATCH] D121030: [LLDB][NativePDB] Don't complete static members' types when completing a record type.

This revision was automatically updated to reflect the committed changes. Closed by commit rG583223cd5ec4: [LLDB][NativePDB] Dont complete static members types when completing a record… (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D121732: Avoid using a variable-sized array for a tiny allocation.

saugustine added inline comments. Comment at: lldb/source/Expression/DWARFExpression.cpp:1309 stack.back().GetScalar() = DerefSizeExtractDataHelper( -addr_bytes, sizeof(addr_bytes), objfile->GetByteOrder(), size); +addr_bytes, size,

[Lldb-commits] [PATCH] D121732: Avoid using a variable-sized array for a tiny allocation.

JDevlieghere added inline comments. Comment at: lldb/source/Expression/DWARFExpression.cpp:1309 stack.back().GetScalar() = DerefSizeExtractDataHelper( -addr_bytes, sizeof(addr_bytes), objfile->GetByteOrder(), size); +addr_bytes, size,

[Lldb-commits] [PATCH] D121408: Fixing DWARFExpression handling of ValueType::FileAddress case for DW_OP_deref_size

saugustine added a comment. Fix for the variable-sized-array issue in rG7518e0ff63cd Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121408/new/ https://reviews.llvm.org/D121408

[Lldb-commits] [PATCH] D121732: Avoid using a variable-sized array for a tiny allocation.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG7518e0ff63cd: Avoid using a variable-sized array for a tiny allocation. (authored by saugustine). Repository: rG LLVM

[Lldb-commits] [lldb] 7518e0f - Avoid using a variable-sized array for a tiny allocation.

Author: Sterling Augustine Date: 2022-03-15T13:00:14-07:00 New Revision: 7518e0ff63cdee4b4082e918e1b5603115777d9b URL: https://github.com/llvm/llvm-project/commit/7518e0ff63cdee4b4082e918e1b5603115777d9b DIFF:

[Lldb-commits] [PATCH] D121732: Avoid using a variable-sized array for a tiny allocation.

saugustine created this revision. Herald added a project: All. saugustine requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D121732 Files:

[Lldb-commits] [lldb] 8e776bb - Re-land "[lldb] Synchronize output through the IOHandler"

Author: Jonas Devlieghere Date: 2022-03-15T12:53:46-07:00 New Revision: 8e776bb660dda6c51ce7ca6cea641db1f47aa9cf URL: https://github.com/llvm/llvm-project/commit/8e776bb660dda6c51ce7ca6cea641db1f47aa9cf DIFF:

[Lldb-commits] [PATCH] D121408: Fixing DWARFExpression handling of ValueType::FileAddress case for DW_OP_deref_size

saugustine added a comment. Herald added a subscriber: JDevlieghere. This change uses a variable-sized array, which is c99 only: third_party/llvm/llvm-project/lldb/source/Expression/DWARFExpression.cpp:1300:30: error: variable length arrays are a C99 feature [-Werror,-Wvla-extension]

[Lldb-commits] [PATCH] D121030: [LLDB][NativePDB] Don't complete static members' types when completing a record type.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. awesome Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121030/new/ https://reviews.llvm.org/D121030

[Lldb-commits] [PATCH] D121030: [LLDB][NativePDB] Don't complete static members' types when completing a record type.

zequanwu added inline comments. Comment at: lldb/test/Shell/SymbolFile/NativePDB/local-variables.cpp:8-26 +class B; +class A { +public: +static const A constA; +static A a; +static B b; +int val = 1; labath wrote: > zequanwu wrote: > > labath

[Lldb-commits] [PATCH] D121030: [LLDB][NativePDB] Don't complete static members' types when completing a record type.

zequanwu updated this revision to Diff 415501. zequanwu marked an inline comment as done. zequanwu added a comment. Remove `REQUIRES: system-windows`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121030/new/ https://reviews.llvm.org/D121030

[Lldb-commits] [lldb] 9a5f04e - Revert "[lldb] Synchronize output through the IOHandler"

Author: Jonas Devlieghere Date: 2022-03-15T09:55:30-07:00 New Revision: 9a5f04e01dadf7db89ef2d6ef24b1cc51af07337 URL: https://github.com/llvm/llvm-project/commit/9a5f04e01dadf7db89ef2d6ef24b1cc51af07337 DIFF:

[Lldb-commits] [PATCH] D121408: Fixing DWARFExpression handling of ValueType::FileAddress case for DW_OP_deref_size

This revision was automatically updated to reflect the committed changes. Closed by commit rG6583f0170721: [LLDB] Fixing DWARFExpression handling of ValueType::FileAddress case for… (authored by shafik). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] 6583f01 - [LLDB] Fixing DWARFExpression handling of ValueType::FileAddress case for DW_OP_deref_size

Author: Shafik Yaghmour Date: 2022-03-15T09:36:20-07:00 New Revision: 6583f01707211ed14d8e35f2183a8805a301b6f9 URL: https://github.com/llvm/llvm-project/commit/6583f01707211ed14d8e35f2183a8805a301b6f9 DIFF:

[Lldb-commits] [PATCH] D121500: [lldb] Protect the debugger's output and error stream

This revision was automatically updated to reflect the committed changes. Closed by commit rG242c574dc03e: [lldb] Synchronize output through the IOHandler (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D121500?vs=414775=415474#toc

[Lldb-commits] [lldb] b783e5c - [lldb] Make the PlatformMacOSX unit test Apple specific

Author: Jonas Devlieghere Date: 2022-03-15T09:32:56-07:00 New Revision: b783e5c203c1959e04fc351a2e96f0700decc32c URL: https://github.com/llvm/llvm-project/commit/b783e5c203c1959e04fc351a2e96f0700decc32c DIFF:

[Lldb-commits] [lldb] 242c574 - [lldb] Synchronize output through the IOHandler

Author: Jonas Devlieghere Date: 2022-03-15T09:32:56-07:00 New Revision: 242c574dc03e4b90e992cc8d07436efc3954727f URL: https://github.com/llvm/llvm-project/commit/242c574dc03e4b90e992cc8d07436efc3954727f DIFF:

[Lldb-commits] [PATCH] D121408: Fixing DWARFExpression handling of ValueType::FileAddress case for DW_OP_deref_size

shafik updated this revision to Diff 415473. shafik added a comment. Fixing up diff CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121408/new/ https://reviews.llvm.org/D121408 Files: lldb/source/Expression/DWARFExpression.cpp

[Lldb-commits] [PATCH] D121444: [lldb] Fix platform selection on Apple Silicon (again)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc22c7a61b6d9: [lldb] Fix platform selection on Apple Silicon (again) (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to

[Lldb-commits] [lldb] c22c7a6 - [lldb] Fix platform selection on Apple Silicon (again)

Author: Jonas Devlieghere Date: 2022-03-15T09:06:29-07:00 New Revision: c22c7a61b6d9c90d5d4292205c63cd576f4fd05b URL: https://github.com/llvm/llvm-project/commit/c22c7a61b6d9c90d5d4292205c63cd576f4fd05b DIFF:

[Lldb-commits] [PATCH] D121711: [trace][intelpt] Rename IntelPTManager and change TraceCursor::GetTimestampCounter API to general trace counter API

jj10306 created this revision. jj10306 added reviewers: wallace, davidca. Herald added a subscriber: mgorny. Herald added a project: All. jj10306 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Minor refactor and renaming: - Rename

[Lldb-commits] [PATCH] D121605: [lldb/test] Make category-skipping logic "platform"-independent

labath added a comment. Yeah, I'm pretty sure its due to this patch. Though the failures don't look near as bad as I feared. :) I've reverted the patch while I work on a fix. Do let me know if you see some other failures related to this, particularly in some more exotic

[Lldb-commits] [lldb] be09f83 - Revert "[lldb/test] Make category-skipping logic "platform"-independent"

Author: Pavel Labath Date: 2022-03-15T16:23:43+01:00 New Revision: be09f83760ebe7cf698746d5504976ad82679815 URL: https://github.com/llvm/llvm-project/commit/be09f83760ebe7cf698746d5504976ad82679815 DIFF: https://github.com/llvm/llvm-project/commit/be09f83760ebe7cf698746d5504976ad82679815.diff

[Lldb-commits] [PATCH] D121605: [lldb/test] Make category-skipping logic "platform"-independent

shafik added a comment. I think this PR broke green dragon incremental build: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/42185/ It looks like the failures are all related to platforms in some ways. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D121408: Fixing DWARFExpression handling of ValueType::FileAddress case for DW_OP_deref_size

shafik updated this revision to Diff 415440. shafik marked an inline comment as done. shafik added a comment. Removing dead code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121408/new/ https://reviews.llvm.org/D121408 Files: lldb/source/Expression/DWARFExpression.cpp

[Lldb-commits] [PATCH] D121605: [lldb/test] Make category-skipping logic "platform"-independent

This revision was automatically updated to reflect the committed changes. Closed by commit rGdddf4ce034a8: [lldb/test] Make category-skipping logic platform-independent (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121605/new/

[Lldb-commits] [lldb] dddf4ce - [lldb/test] Make category-skipping logic "platform"-independent

Author: Pavel Labath Date: 2022-03-15T13:38:13+01:00 New Revision: dddf4ce034a8e06cc1351492dceece3fa2344c14 URL: https://github.com/llvm/llvm-project/commit/dddf4ce034a8e06cc1351492dceece3fa2344c14 DIFF: https://github.com/llvm/llvm-project/commit/dddf4ce034a8e06cc1351492dceece3fa2344c14.diff

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

labath added a comment. I agree with everything Jim said. One of the interesting 'strategy' questions would be the interaction between this feature and the `target.preload-symbols` feature. I don't think the interaction between the two is obvious or intuitive, and I'm even sure that

[Lldb-commits] [PATCH] D121537: [lldb] Synchronize the output through the IOHandler

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/include/lldb/Interpreter/CommandInterpreter.h:659 + void PrintCommandOutput(IOHandler _handler, llvm::StringRef str, + bool

[Lldb-commits] [PATCH] D121444: [lldb] Fix platform selection on Apple Silicon (again)

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Cool. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121444/new/ https://reviews.llvm.org/D121444 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D121511: [lldb] Report debugger diagnostics as events

labath added a comment. Heh, I didn't realize that "debugger-less" events are implemented by iterating over all debugger instances, but since we're doing that for progress events anyway, we might as well copy the pattern. Any chance of a test case for some of this stuff? Maybe a unittest which

[Lldb-commits] [PATCH] D121030: [LLDB][NativePDB] Don't complete static members' types when completing a record type.

labath added inline comments. Comment at: lldb/test/Shell/SymbolFile/NativePDB/local-variables.cpp:8-26 +class B; +class A { +public: +static const A constA; +static A a; +static B b; +int val = 1; zequanwu wrote: > labath wrote: > > Would it be