[Lldb-commits] [PATCH] D124572: Fix the encoding and decoding of UniqueCStringMap objects when saved to cache files.

yinghuitan accepted this revision. yinghuitan added a comment. This revision is now accepted and ready to land. This is a great finding! The change looks good. Some questions though: - Do you have any theory why we only see this issue on Mac not Linux? (For anyone else reading this, I found

[Lldb-commits] [PATCH] D124579: Make partial function name matching match on context boundaries

shafik added a comment. You might want to try fun cases like `operator<` and `operator()()` from a lambda. They should work but might be worth throwing them in. Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:330 + +// size_t from = 0; +//

[Lldb-commits] [PATCH] D124579: Make partial function name matching match on context boundaries

jingham created this revision. jingham added reviewers: JDevlieghere, labath, clayborg, shafik. Herald added a subscriber: mgorny. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We don't require users

[Lldb-commits] [PATCH] D124499: Rename conflict testcase

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Don't forget to rename the class name as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124499/new/

[Lldb-commits] [PATCH] D124000: [lldb] Add FixAnyAddress to ABI plugins

JDevlieghere accepted this revision. JDevlieghere added a comment. Yes, this makes a lot of sense to me. Thanks for taking care of this. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124000/new/ https://reviews.llvm.org/D124000

[Lldb-commits] [PATCH] D124573: [trace][intelpt] Support system-wide tracing [1] - Add a method for accessing the list of logical core ids

wallace created this revision. wallace added a reviewer: jj10306. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In order to open perf events per core, we need to first get the list of core ids

[Lldb-commits] [PATCH] D123954: [lldb] Add setting for max depth of value object printing (NFC)

kastiglione added inline comments. Comment at: lldb/include/lldb/Interpreter/CommandInterpreter.h:718 + /// been told. + ChildrenOmissionWarningStatus m_truncation_warning; + /// Whether we reached the maximum child nesting depth and whether the user shafik

[Lldb-commits] [PATCH] D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.

clayborg added a comment. Herald added a project: All. The unit testing I added to this patch was unable to catch a serious issue that I have fixed and is needed if anyone wants to enable this feature. So please make sure if you use this patch to also make sure that the following patch is also

[Lldb-commits] [lldb] 5205c17 - [lldb] Fix escaping when launching in terminal with AppleScript

Author: Jonas Devlieghere Date: 2022-04-27T16:37:42-07:00 New Revision: 5205c1774950b62dd410c69474295cd0f9351c7d URL: https://github.com/llvm/llvm-project/commit/5205c1774950b62dd410c69474295cd0f9351c7d DIFF:

[Lldb-commits] [PATCH] D124568: [lldb] Fix escaping when launching in terminal with AppleScript

This revision was automatically updated to reflect the committed changes. Closed by commit rG5205c1774950: [lldb] Fix escaping when launching in terminal with AppleScript (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D124572: Fix the encoding and decoding of UniqueCStringMap objects when saved to cache files.

clayborg created this revision. clayborg added reviewers: labath, JDevlieghere, jingham, aadsm, wallace, yinghuitan. Herald added a project: All. clayborg requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. UniqueCStringMap objects are a

[Lldb-commits] [PATCH] D124568: [lldb] Fix escaping when launching in terminal with AppleScript

JDevlieghere updated this revision to Diff 425638. JDevlieghere marked 2 inline comments as done. JDevlieghere added a comment. Address Adrian's code review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124568/new/ https://reviews.llvm.org/D124568 Files:

[Lldb-commits] [PATCH] D124568: [lldb] Fix escaping when launching in terminal with AppleScript

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/source/Host/macosx/objcxx/Host.mm:267 + + printf("%s\n", applescript_source.GetString().str().c_str()); + aprantl wrote: > Is this leftover debugging code? Yup,

[Lldb-commits] [PATCH] D124568: [lldb] Fix escaping when launching in terminal with AppleScript

aprantl added a comment. I have some trivial suggestions inside, but otherwise, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124568/new/ https://reviews.llvm.org/D124568 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D124568: [lldb] Fix escaping when launching in terminal with AppleScript

aprantl added inline comments. Comment at: lldb/source/Host/macosx/objcxx/Host.mm:222 if (working_dir) -command.Printf(" --working-dir '%s'", working_dir.GetCString()); +command.Printf(" --working-dir \\\"%s\\\"", working_dir.GetCString()); else {

[Lldb-commits] [PATCH] D124568: [lldb] Fix escaping when launching in terminal with AppleScript

JDevlieghere created this revision. JDevlieghere added a reviewer: aprantl. Herald added a subscriber: kristof.beyls. Herald added a project: All. JDevlieghere requested review of this revision. Fix escaping when launching in terminal with AppleScript. The invocation we're building up is wrapped

[Lldb-commits] [PATCH] D124409: Filter non-external static members from SBType::GetFieldAtIndex.

siggi-alpheus marked an inline comment as done. siggi-alpheus added a comment. Now passes all tests - but I still need to write a test for the problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124409/new/ https://reviews.llvm.org/D124409

[Lldb-commits] [PATCH] D124409: Filter non-external static members from SBType::GetFieldAtIndex.

siggi-alpheus updated this revision to Diff 425585. siggi-alpheus added a comment. Now passes all tests, still needs a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124409/new/ https://reviews.llvm.org/D124409 Files:

[Lldb-commits] [PATCH] D124471: Disable symbol on-demand feature for Windows

yinghuitan added a comment. @labath, that's a good point. If I remember correctly, exported function symbols will be included in Windows COFF export address table (which I assume will be parsed by lldb symtab). So in theory, if we change the tests (or add new tests) to set symbolic function

[Lldb-commits] [lldb] afd6390 - [LLDB][NativePDB] Minor fix ParseInlinesite.

Author: Zequan Wu Date: 2022-04-27T10:56:03-07:00 New Revision: afd639071bb32baae4ca390b3f0f5ab700d83222 URL: https://github.com/llvm/llvm-project/commit/afd639071bb32baae4ca390b3f0f5ab700d83222 DIFF: https://github.com/llvm/llvm-project/commit/afd639071bb32baae4ca390b3f0f5ab700d83222.diff

[Lldb-commits] [PATCH] D124535: [lldb] Fix crash when launching in terminal

JDevlieghere created this revision. JDevlieghere added reviewers: mgorny, labath. Herald added a project: All. JDevlieghere requested review of this revision. This patch fixes a crash when using `process launch -t` to launch the inferior from a TTY. The issue is that on Darwin, Host.mm is

[Lldb-commits] [PATCH] D124430: [lldb] Remove Python 2 checks from the test suite

JDevlieghere closed this revision. JDevlieghere added a comment. 0e9af88b7099 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124430/new/ https://reviews.llvm.org/D124430

[Lldb-commits] [PATCH] D124429: [lldb] Remove Python 2 support from the ScriptInterpreter plugin

This revision was automatically updated to reflect the committed changes. Closed by commit rG90537673302f: Remove Python 2 support from the ScriptInterpreter plugin (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 0e9af88 - Remove Python 2 checks from the test suite

Author: Jonas Devlieghere Date: 2022-04-27T08:26:26-07:00 New Revision: 0e9af88b7099fa0588661b5b8d5024b2f25f68d8 URL: https://github.com/llvm/llvm-project/commit/0e9af88b7099fa0588661b5b8d5024b2f25f68d8 DIFF:

[Lldb-commits] [lldb] 9053767 - Remove Python 2 support from the ScriptInterpreter plugin

Author: Jonas Devlieghere Date: 2022-04-27T08:26:25-07:00 New Revision: 90537673302f13e92ffabba84901164c6b974b2d URL: https://github.com/llvm/llvm-project/commit/90537673302f13e92ffabba84901164c6b974b2d DIFF:

[Lldb-commits] [PATCH] D124430: [lldb] Remove Python 2 checks from the test suite

JDevlieghere added a comment. In D124430#3475136 , @clayborg wrote: > Are we removing Python2 support? Yep, AFAIK we were the only ones that still needed it. We dropped support downstream in the previous release and we just rebranched for the next one,

[Lldb-commits] [lldb] eeaa3b5 - [lldb] Remove sanity check from TestWithLimitDebugInfo

Author: Pavel Labath Date: 2022-04-27T16:01:54+02:00 New Revision: eeaa3b5478539ec00817ff91e1603c1039376d02 URL: https://github.com/llvm/llvm-project/commit/eeaa3b5478539ec00817ff91e1603c1039376d02 DIFF: https://github.com/llvm/llvm-project/commit/eeaa3b5478539ec00817ff91e1603c1039376d02.diff

[Lldb-commits] [PATCH] D124409: Filter non-external static members from SBType::GetFieldAtIndex.

siggi-alpheus added a comment. Thanks for taking a look. Let me see about fixing the test failures and writing that test. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2672 // Handle static members - if (attrs.is_external &&

[Lldb-commits] [lldb] 089a1d9 - [lldb] Fix TestWithLimitDebugInfo.py

Author: Pavel Labath Date: 2022-04-27T15:08:58+02:00 New Revision: 089a1d9deba5579487d77c97241b3f9e5e3d4745 URL: https://github.com/llvm/llvm-project/commit/089a1d9deba5579487d77c97241b3f9e5e3d4745 DIFF: https://github.com/llvm/llvm-project/commit/089a1d9deba5579487d77c97241b3f9e5e3d4745.diff

[Lldb-commits] [lldb] f513b5f - [lldb] Make test names unique

Author: Pavel Labath Date: 2022-04-27T15:08:58+02:00 New Revision: f513b5fc47df5c040a257ab6f4643942828fa610 URL: https://github.com/llvm/llvm-project/commit/f513b5fc47df5c040a257ab6f4643942828fa610 DIFF: https://github.com/llvm/llvm-project/commit/f513b5fc47df5c040a257ab6f4643942828fa610.diff

[Lldb-commits] [PATCH] D124409: Filter non-external static members from SBType::GetFieldAtIndex.

labath added a comment. For future reference, it's better to generate a full diff when uploading a patch manually. Here are some ways to do that. Apart from the inline comment this patch seems fine. We should

[Lldb-commits] [PATCH] D124471: Disable symbol on-demand feature for Windows

labath added a comment. FWIW, I don't think that this feature, as it is implemented right now, has any chance of working on windows. Windows does not have the equivalent of .symtab (only .dynsym), so we cannot use that as a poor man's debug info substitute -- the debug info is either there --