[Lldb-commits] [PATCH] D127500: [lldb] [llgs] Make `k` kill all processes, and fix multiple exits

mgorny added a comment. In D127500#3595605 , @labath wrote: > I've ran into the "dynamic uninitialization order fiasco" problem as well. > I'm wondering if, instead of the trick (which is pretty neat, but still a > trick) with the limbo member

[Lldb-commits] [lldb] d66cbc5 - Don't use Optional::hasValue (NFC)

Author: Kazu Hirata Date: 2022-06-20T20:26:05-07:00 New Revision: d66cbc565adbea8b7362349e527ac7aa2c75788f URL: https://github.com/llvm/llvm-project/commit/d66cbc565adbea8b7362349e527ac7aa2c75788f DIFF: https://github.com/llvm/llvm-project/commit/d66cbc565adbea8b7362349e527ac7aa2c75788f.diff

[Lldb-commits] [lldb] 064a08c - Don't use Optional::hasValue (NFC)

Author: Kazu Hirata Date: 2022-06-20T20:05:16-07:00 New Revision: 064a08cd955019da9130f1109bfa534e79b8ec7c URL: https://github.com/llvm/llvm-project/commit/064a08cd955019da9130f1109bfa534e79b8ec7c DIFF: https://github.com/llvm/llvm-project/commit/064a08cd955019da9130f1109bfa534e79b8ec7c.diff

[Lldb-commits] [PATCH] D128234: Fix build break introduced by https://reviews.llvm.org/D127702

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5109de2da2e2: Fix build break introduced by https://reviews.llvm.org/D127702 (authored by yinghuitan). Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] 5109de2 - Fix build break introduced by https://reviews.llvm.org/D127702

Author: Jeffrey Tan Date: 2022-06-20T17:31:26-07:00 New Revision: 5109de2da2e2b2321bd2bc504a3ddcedce51c0f8 URL: https://github.com/llvm/llvm-project/commit/5109de2da2e2b2321bd2bc504a3ddcedce51c0f8 DIFF: https://github.com/llvm/llvm-project/commit/5109de2da2e2b2321bd2bc504a3ddcedce51c0f8.diff

[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

yinghuitan added a comment. Fixed in https://reviews.llvm.org/D128234 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127702/new/ https://reviews.llvm.org/D127702 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D128234: Fix build break introduced by https://reviews.llvm.org/D127702

yinghuitan created this revision. yinghuitan added reviewers: clayborg, thakis, kazu. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fix build break introduced by https://reviews.llvm.org/D127702

[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

yinghuitan added a comment. Sorry, I was fooled by the buildbot which says everything is green. Working on a fix for the build break now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127702/new/ https://reviews.llvm.org/D127702

[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

thakis added a comment. Here too: https://lab.llvm.org/buildbot#builders/83/builds/20210 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127702/new/ https://reviews.llvm.org/D127702 ___ lldb-commits

[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

thakis added a comment. Looks like this might not build: http://45.33.8.238/linux/79194/step_4.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127702/new/

[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c6e138aa893: Support logpoints in lldb-vscode (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127702/new/

[Lldb-commits] [lldb] 8c6e138 - Support logpoints in lldb-vscode

Author: Jeffrey Tan Date: 2022-06-20T16:22:12-07:00 New Revision: 8c6e138aa893bb88fc3d5d449e42082741f0e2a2 URL: https://github.com/llvm/llvm-project/commit/8c6e138aa893bb88fc3d5d449e42082741f0e2a2 DIFF: https://github.com/llvm/llvm-project/commit/8c6e138aa893bb88fc3d5d449e42082741f0e2a2.diff

[Lldb-commits] [lldb] c9fc433 - [lldb] Fix building with GCC 7

Author: Martin Storsjö Date: 2022-06-21T00:19:09+03:00 New Revision: c9fc4336d4b35cd1ed8083336c997c159f286794 URL: https://github.com/llvm/llvm-project/commit/c9fc4336d4b35cd1ed8083336c997c159f286794 DIFF:

[Lldb-commits] [PATCH] D127456: [trace][intelpt] Support system-wide tracing [17] - Some improvements

wallace added inline comments. Comment at: lldb/source/Plugins/Process/Linux/IntelPTPerThreadProcessTrace.cpp:55-59 +Expected> IntelPTPerThreadProcessTrace::Start(const TraceIntelPTStartRequest , ArrayRef current_tids) { -

[Lldb-commits] [PATCH] D127456: [trace][intelpt] Support system-wide tracing [17] - Some improvements

max-kudr added inline comments. Comment at: lldb/source/Plugins/Process/Linux/IntelPTPerThreadProcessTrace.cpp:55-59 +Expected> IntelPTPerThreadProcessTrace::Start(const TraceIntelPTStartRequest , ArrayRef current_tids) { -

[Lldb-commits] [PATCH] D128226: [lldb] Remove an outdated comment. NFC.

mstorsjo created this revision. mstorsjo added reviewers: labath, DavidSpickett, omjavaid, alvinhochun. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: LLDB. This comment became outdated in 053eb35651906e693906fad6c695fce11415ade7 (but was moved

[Lldb-commits] [PATCH] D127456: [trace][intelpt] Support system-wide tracing [17] - Some improvements

wallace added inline comments. Comment at: lldb/source/Plugins/Process/Linux/IntelPTPerThreadProcessTrace.cpp:55-59 +Expected> IntelPTPerThreadProcessTrace::Start(const TraceIntelPTStartRequest , ArrayRef current_tids) { -

[Lldb-commits] [PATCH] D127456: [trace][intelpt] Support system-wide tracing [17] - Some improvements

max-kudr added inline comments. Comment at: lldb/source/Plugins/Process/Linux/IntelPTPerThreadProcessTrace.cpp:55-59 +Expected> IntelPTPerThreadProcessTrace::Start(const TraceIntelPTStartRequest , ArrayRef current_tids) { -

[Lldb-commits] [PATCH] D128221: [LLDB] Add Arm64 CodeView to LLDB regnum mapping

omjavaid created this revision. omjavaid added reviewers: labath, aleksandr.urakov. omjavaid added a project: LLDB. Herald added subscribers: JDevlieghere, kristof.beyls. Herald added a project: All. omjavaid requested review of this revision. This patch writes a mapping structure for converting

[Lldb-commits] [PATCH] D128126: Support expressions in the context of a reference

emrekultursay marked an inline comment as done. emrekultursay added a comment. Thanks. Please submit the change on my behalf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128126/new/ https://reviews.llvm.org/D128126

[Lldb-commits] [PATCH] D128126: Support expressions in the context of a reference

emrekultursay updated this revision to Diff 438454. emrekultursay added a comment. Use loop instead of code duplication in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128126/new/ https://reviews.llvm.org/D128126 Files:

[Lldb-commits] [PATCH] D128107: [trace] Add LoadTraceFromFile to SBDebugger and SBTrace

This revision was automatically updated to reflect the committed changes. Closed by commit rG50f936796072: Add LoadTraceFromFile to SBDebugger and SBTrace (authored by jj10306). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128107/new/

[Lldb-commits] [lldb] 50f9367 - Add LoadTraceFromFile to SBDebugger and SBTrace

Author: Jakob Johnson Date: 2022-06-20T11:54:47-07:00 New Revision: 50f9367960725b450a9ef779d73e32a35031ee70 URL: https://github.com/llvm/llvm-project/commit/50f9367960725b450a9ef779d73e32a35031ee70 DIFF: https://github.com/llvm/llvm-project/commit/50f9367960725b450a9ef779d73e32a35031ee70.diff

[Lldb-commits] [lldb] ad7ce1e - Don't use Optional::hasValue (NFC)

Author: Kazu Hirata Date: 2022-06-20T11:49:10-07:00 New Revision: ad7ce1e7696148d093b96a6262ebc8fd5e216187 URL: https://github.com/llvm/llvm-project/commit/ad7ce1e7696148d093b96a6262ebc8fd5e216187 DIFF: https://github.com/llvm/llvm-project/commit/ad7ce1e7696148d093b96a6262ebc8fd5e216187.diff

[Lldb-commits] [PATCH] D128107: [trace] Add LoadTraceFromFile to SBDebugger and SBTrace

wallace added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/intelpt/intelpt_testcase.py:139 +if self.USE_SB_API: +traceDescriptionFile = lldb.SBFileSpec(traceDescriptionFilePath) +loadTraceError = lldb.SBError()

[Lldb-commits] [lldb] 5413bf1 - Don't use Optional::hasValue (NFC)

Author: Kazu Hirata Date: 2022-06-20T11:33:56-07:00 New Revision: 5413bf1bac2abb9e06901686cdc959e92940143a URL: https://github.com/llvm/llvm-project/commit/5413bf1bac2abb9e06901686cdc959e92940143a DIFF: https://github.com/llvm/llvm-project/commit/5413bf1bac2abb9e06901686cdc959e92940143a.diff

[Lldb-commits] [PATCH] D128107: [trace] Add LoadTraceFromFile to SBDebugger and SBTrace

jj10306 added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/intelpt/intelpt_testcase.py:139 +if self.USE_SB_API: +traceDescriptionFile = lldb.SBFileSpec(traceDescriptionFilePath) +loadTraceError = lldb.SBError()

[Lldb-commits] [PATCH] D128107: [trace] Add LoadTraceFromFile to SBDebugger and SBTrace

jj10306 updated this revision to Diff 438449. jj10306 marked 2 inline comments as done. jj10306 added a comment. rebase and use SBFileSpec constructor with that requires an explicit `resolve` flag before landing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

yinghuitan updated this revision to Diff 438448. yinghuitan added a comment. Using a single structured LogMessagePart per suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127702/new/ https://reviews.llvm.org/D127702 Files:

[Lldb-commits] [PATCH] D128107: [trace] Add LoadTraceFromFile to SBDebugger and SBTrace

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. nice job! Comment at: lldb/packages/Python/lldbsuite/test/tools/intelpt/intelpt_testcase.py:139 +if self.USE_SB_API: +traceDescriptionFile =

[Lldb-commits] [PATCH] D128042: [lldb] [test] Fix test_platform_file_fstat to account for negative ints

This revision was automatically updated to reflect the committed changes. Closed by commit rGd3292c4ba0ce: [lldb] [test] Fix test_platform_file_fstat to account for negative ints (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D128041: [lldb] [test] Make AVX/MPX register tests more robust and fix on BSD

This revision was automatically updated to reflect the committed changes. Closed by commit rGa36b9b382a03: [lldb] [test] Make AVX/MPX register tests more robust and fix on BSD (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D128034: [lldb] [test] Disable gmodules testing on FreeBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rG94074399ab0a: [lldb] [test] Disable gmodules testing on FreeBSD (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D127497: [lldb] [llgs] Refactor SendStopReasonForState for multiprocess

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf8c6de8dbbd7: [lldb] [llgs] Refactor SendStopReasonForState for multiprocess (authored by mgorny). Herald added a project: LLDB. Repository: rG

[Lldb-commits] [PATCH] D127289: [lldb] [llgs] Refactor SendStopReplyPacketForThread for multiprocess

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf93f123b92e: [lldb] [llgs] Refactor SendStopReplyPacketForThread for multiprocess (authored by mgorny). Herald added a project: LLDB. Repository:

[Lldb-commits] [lldb] d3292c4 - [lldb] [test] Fix test_platform_file_fstat to account for negative ints

Author: Michał Górny Date: 2022-06-20T19:42:22+02:00 New Revision: d3292c4ba0ce13edb316d7fb63ccae376081a102 URL: https://github.com/llvm/llvm-project/commit/d3292c4ba0ce13edb316d7fb63ccae376081a102 DIFF: https://github.com/llvm/llvm-project/commit/d3292c4ba0ce13edb316d7fb63ccae376081a102.diff

[Lldb-commits] [lldb] 9407439 - [lldb] [test] Disable gmodules testing on FreeBSD

Author: Michał Górny Date: 2022-06-20T19:42:21+02:00 New Revision: 94074399ab0a2caefadc8fe4ecef70a938b396cc URL: https://github.com/llvm/llvm-project/commit/94074399ab0a2caefadc8fe4ecef70a938b396cc DIFF: https://github.com/llvm/llvm-project/commit/94074399ab0a2caefadc8fe4ecef70a938b396cc.diff

[Lldb-commits] [lldb] a36b9b3 - [lldb] [test] Make AVX/MPX register tests more robust and fix on BSD

Author: Michał Górny Date: 2022-06-20T19:42:21+02:00 New Revision: a36b9b382a03f70d6dfe46f0f1ca43d19ea6b6df URL: https://github.com/llvm/llvm-project/commit/a36b9b382a03f70d6dfe46f0f1ca43d19ea6b6df DIFF: https://github.com/llvm/llvm-project/commit/a36b9b382a03f70d6dfe46f0f1ca43d19ea6b6df.diff

[Lldb-commits] [lldb] af93f12 - [lldb] [llgs] Refactor SendStopReplyPacketForThread for multiprocess

Author: Michał Górny Date: 2022-06-20T19:42:21+02:00 New Revision: af93f123b92eb3591d0667c24db9cd325d670912 URL: https://github.com/llvm/llvm-project/commit/af93f123b92eb3591d0667c24db9cd325d670912 DIFF: https://github.com/llvm/llvm-project/commit/af93f123b92eb3591d0667c24db9cd325d670912.diff

[Lldb-commits] [lldb] f8c6de8 - [lldb] [llgs] Refactor SendStopReasonForState for multiprocess

Author: Michał Górny Date: 2022-06-20T19:42:21+02:00 New Revision: f8c6de8dbbd7ee0d037e07a94e3c5a370c2edaff URL: https://github.com/llvm/llvm-project/commit/f8c6de8dbbd7ee0d037e07a94e3c5a370c2edaff DIFF: https://github.com/llvm/llvm-project/commit/f8c6de8dbbd7ee0d037e07a94e3c5a370c2edaff.diff

[Lldb-commits] [PATCH] D127436: [lldb] Resolve exe location for `target create`

mstorsjo added a comment. In D127436#3574289 , @alvinhochun wrote: > Does this test look good: With a bunch of minor fixups, this testcase does work - I uploaded a working copy of it at https://martin.st/temp/command-target-create-resolve-exe.test.

[Lldb-commits] [PATCH] D128201: [lldb][windows] Fix crash on getting nested exception

alvinhochun updated this revision to Diff 438430. alvinhochun edited the summary of this revision. alvinhochun added a comment. Remove old code instead of `#if 0`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128201/new/

[Lldb-commits] [PATCH] D127234: [lldb] Add setting to override PE/COFF ABI by module name

alvinhochun added inline comments. Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFFProperties.td:13 +EnumValues<"OptionEnumValues(g_abi_enums)">, +Desc<"A mapping of ABI override to use for specific modules. The module name is matched by its file name

[Lldb-commits] [PATCH] D128201: [lldb][windows] Fix crash on getting nested exception

alvinhochun added a comment. > Any reason to `#if 0` this instead of just removing it and maybe adding a one > line comment like "nested exceptions are not supported"? So that someone can > git blame that and find this commit with the removal. I want to leave a clear note explaining what not

[Lldb-commits] [PATCH] D128156: [lldb] [llgs] Include PID in QC response in multiprocess mode

mgorny updated this revision to Diff 438417. mgorny added a comment. Update more tests. I have no clue how I missed these when testing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128156/new/ https://reviews.llvm.org/D128156 Files:

[Lldb-commits] [PATCH] D127193: [lldb] [llgs] Fix signo sent with fork/vfork/vforkdone events

mgorny updated this revision to Diff 438410. mgorny edited the summary of this revision. mgorny added a comment. Update to make `signo` an unconditional member of the struct, and set it for fork/vfork/vforkdone events explicitly. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D128107: [trace] Add LoadTraceFromFile to SBDebugger and SBTrace

jj10306 added inline comments. Comment at: lldb/include/lldb/API/SBDebugger.h:403 + /// trace session. + SBTrace LoadTraceFromFile(SBError , const char *trace_file_path); + wallace wrote: > wallace wrote: > > JDevlieghere wrote: > > > Can this take a

[Lldb-commits] [PATCH] D128107: [trace] Add LoadTraceFromFile to SBDebugger and SBTrace

jj10306 updated this revision to Diff 438400. jj10306 marked 12 inline comments as done. jj10306 added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128107/new/ https://reviews.llvm.org/D128107 Files:

[Lldb-commits] [PATCH] D128201: [lldb][windows] Fix crash on getting nested exception

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added a comment. Any reason to `#if 0` this instead of just removing it and maybe adding a one line comment like "nested exceptions are not supported"? So that someone can git blame that and find this commit with the removal. If this

[Lldb-commits] [PATCH] D127234: [lldb] Add setting to override PE/COFF ABI by module name

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added inline comments. Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFFProperties.td:13 +EnumValues<"OptionEnumValues(g_abi_enums)">, +Desc<"A mapping of ABI override to use for specific

[Lldb-commits] [PATCH] D128201: [lldb][windows] Fix crash on getting nested exception

alvinhochun created this revision. Herald added a subscriber: mstorsjo. Herald added a project: All. alvinhochun requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. LLDB tries to follow `EXCEPTION_RECORD::ExceptionRecord` to follow the nested

[Lldb-commits] [PATCH] D127999: [lldb] fix stepping through POSIX trampolines

mdaniels added inline comments. Comment at: lldb/test/API/lang/cpp/step-into-namespace/TestStepIntoNamespace.py:5 + +class StepIntoNamespace(TestBase): +mydir = TestBase.compute_mydir(__file__) labath wrote: > Am I correct in assuming that the "namespace"

[Lldb-commits] [PATCH] D127999: [lldb] fix stepping through POSIX trampolines

mdaniels updated this revision to Diff 438347. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127999/new/ https://reviews.llvm.org/D127999 Files: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp lldb/test/API/lang/cpp/step-through-trampoline/Makefile

[Lldb-commits] [PATCH] D127192: [lldb] [llgs] Include process ID in stop responses

This revision was automatically updated to reflect the committed changes. Closed by commit rGac570fbb8521: [lldb] [llgs] Include process ID in stop responses (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D127191: [lldb] [llgs] Include process id in W/X stop reasons

This revision was automatically updated to reflect the committed changes. Closed by commit rGe4d6ed58a86e: [lldb] [llgs] Include process id in W/X stop reasons (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] e4d6ed5 - [lldb] [llgs] Include process id in W/X stop reasons

Author: Michał Górny Date: 2022-06-20T13:37:23+02:00 New Revision: e4d6ed58a86edc339ae124b74668b600f2a0f6d5 URL: https://github.com/llvm/llvm-project/commit/e4d6ed58a86edc339ae124b74668b600f2a0f6d5 DIFF: https://github.com/llvm/llvm-project/commit/e4d6ed58a86edc339ae124b74668b600f2a0f6d5.diff

[Lldb-commits] [lldb] ac570fb - [lldb] [llgs] Include process ID in stop responses

Author: Michał Górny Date: 2022-06-20T13:37:23+02:00 New Revision: ac570fbb8521a31a1931cc070e1b259fcac6a30f URL: https://github.com/llvm/llvm-project/commit/ac570fbb8521a31a1931cc070e1b259fcac6a30f DIFF: https://github.com/llvm/llvm-project/commit/ac570fbb8521a31a1931cc070e1b259fcac6a30f.diff

[Lldb-commits] [lldb] 1f9f7a2 - [lldb] Relax backtrace checks in TestDyldLaunchLinux

Author: Pavel Labath Date: 2022-06-20T12:59:31+02:00 New Revision: 1f9f7a2f5d75dd7b1a361a9e22138c98fcdc532b URL: https://github.com/llvm/llvm-project/commit/1f9f7a2f5d75dd7b1a361a9e22138c98fcdc532b DIFF: https://github.com/llvm/llvm-project/commit/1f9f7a2f5d75dd7b1a361a9e22138c98fcdc532b.diff

[Lldb-commits] [PATCH] D127193: [lldb] [llgs] Fix signo sent with fork/vfork/vforkdone events

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:697 +static int GetSignalForStopReason(const struct ThreadStopInfo _stop_info) { + if (tid_stop_info.reason == eStopReasonException) labath

[Lldb-commits] [PATCH] D128156: [lldb] [llgs] Include PID in QC response in multiprocess mode

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1415-1419 + response.PutCString("QC"); + if (bool(m_extensions_supported & NativeProcessProtocol::Extension::multiprocess)) +response.Format("p{0:x-}.",

[Lldb-commits] [PATCH] D128170: [lldb] [llgs] Implement the 'T' packet

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste, jingham. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Implement the 'T' packet that is used to verify whether the specified thread belongs to the

[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

labath added a comment. For the underlying functionality, I think it'd be best to extend `lldb-test` to print section alignment (`dumpSectionList` in `lldb/tools/lldb-test/lldb-test.cpp`) and then write (or extend) some test in `test/Shell/ObjectFile/ELF` (or your favourite object format).

[Lldb-commits] [PATCH] D127500: [lldb] [llgs] Make `k` kill all processes, and fix multiple exits

labath added a comment. I've ran into the "dynamic uninitialization order fiasco" problem as well. I'm wondering if, instead of the trick (which is pretty neat, but still a trick) with the limbo member variable, we could add something like the `asyncio.loop.call_soon` function in python to our

[Lldb-commits] [PATCH] D127922: [lldb] Introduce the concept of a log handler (NFC)

labath added a comment. I think we should talk about the threadsafe flag. The reason that the non-threadsafe mode is safe now is because we're using unbuffered streams, where each stream operation will map to a single write syscall (which will then be serialized by the OS somehow). And since

[Lldb-commits] [PATCH] D126464: [lldb] Add support to load object files from thin archives

PRESIDENT810 added a comment. Hi, sorry to interrupt but I just forgot to mention that I didn't have access to commit. Anyone can please help me land this one if it looks ok? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126464/new/ https://reviews.llvm.org/D126464

[Lldb-commits] [PATCH] D128026: [lldb] Add a BufferedLogHandler

labath added a comment. I feel I should note that the llvm streams already have a buffered mode, and given the way things are implemented now (our log class writes the entire log message in one call, and the raw_ostream flushing the entire buffer whenever a message does not fit), I don't think

[Lldb-commits] [PATCH] D126240: [lldb] Tighten the scope of a couple of locks in DataFormatters.

labath added a comment. In D126240#3564913 , @jgorbe wrote: > I've been experimenting a little bit and it seems that I can avoid the > deadlocks I was seeing by applying only the modification to > `TypeCategoryMap::Add`. This would avoid the problem

[Lldb-commits] [PATCH] D127193: [lldb] [llgs] Fix signo sent with fork/vfork/vforkdone events

labath added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:697 +static int GetSignalForStopReason(const struct ThreadStopInfo _stop_info) { + if (tid_stop_info.reason == eStopReasonException) It

[Lldb-commits] [PATCH] D128156: [lldb] [llgs] Include PID in QC response in multiprocess mode

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1415-1419 + response.PutCString("QC"); + if (bool(m_extensions_supported &

[Lldb-commits] [PATCH] D128156: [lldb] [llgs] Include PID in QC response in multiprocess mode

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski, jingham. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Sponsored by: The FreeBSD Foundation https://reviews.llvm.org/D128156 Files:

[Lldb-commits] [PATCH] D127999: [lldb] fix stepping through POSIX trampolines

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/test/API/lang/cpp/step-into-namespace/TestStepIntoNamespace.py:5 + +class StepIntoNamespace(TestBase): +mydir = TestBase.compute_mydir(__file__)

[Lldb-commits] [PATCH] D128126: Support expressions in the context of a reference

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/test/API/commands/expression/context-object/TestContextObject.py:22 obj_val = frame.FindVariable("cpp_struct")