[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

llunak added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122974/new/ https://reviews.llvm.org/D122974 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] fe6db8d - Revert "[lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers"

Author: Mikhail Goncharov Date: 2022-06-27T10:18:39+02:00 New Revision: fe6db8d03ff16a65f57af24d2cb04f489e2e9b0c URL: https://github.com/llvm/llvm-project/commit/fe6db8d03ff16a65f57af24d2cb04f489e2e9b0c DIFF: https://github.com/llvm/llvm-project/commit/fe6db8d03ff16a65f57af24d2cb04f489e2e9b0c.d

[Lldb-commits] [PATCH] D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers

goncharov added a comment. FYI this caused a test breakage at lldb-aarch64-ubuntu, https://lab.llvm.org/buildbot/#/builders/96/builds/25128. I have reverted this in fe6db8d03ff16a65f57af24d2cb04f489e2e9b0c Repository: rG

[Lldb-commits] [PATCH] D128221: [LLDB] Add Arm64 CodeView to LLDB regnum mapping

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/CodeViewRegisterMapping.cpp:51 +gpr_w27_arm64, // ARM64_W27, 37) +gpr_w28_arm64, // ARM64_W28, 38) +LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, --

[Lldb-commits] [PATCH] D128638: [lldb] [llgs] Add nonstop fork/vfork tests

mgorny added a comment. BTW this test is getting a bit long as well but I don't have a good idea how to split it, except for just moving some functions into a second file and making some reusable base class. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128638/new/ https://reviews.llv

[Lldb-commits] [PATCH] D128639: [lldb] [llgs] Fix premature server exit if multiprocess+nonstop

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski, jingham. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Fix lldb-server in the non-stop + multiprocess mode to exit on vStopped only if all processes h

[Lldb-commits] [PATCH] D128638: [lldb] [llgs] Add nonstop fork/vfork tests

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski, jingham. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Sponsored by: The FreeBSD Foundation https://reviews.llvm.org/D128638 Files: lldb/test/API

[Lldb-commits] [PATCH] D128557: [lldb] Add a log dump command to dump the circular log buffer

labath accepted this revision. labath added a comment. In D128557#3609545 , @JDevlieghere wrote: > One solution would be to keep a circular buffer per category. I'll think > about it and if I come up with a good solution I'll put up another patch. This

[Lldb-commits] [PATCH] D126983: [lldb] [llgs] Support "t" vCont action

This revision was automatically updated to reflect the committed changes. Closed by commit rGb4f2d7cde54c: [lldb] [llgs] Support "t" vCont action (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126983

[Lldb-commits] [lldb] b4f2d7c - [lldb] [llgs] Support "t" vCont action

Author: Michał Górny Date: 2022-06-27T17:33:59+02:00 New Revision: b4f2d7cde54c301f591a8e2a16135bb113c5e7ed URL: https://github.com/llvm/llvm-project/commit/b4f2d7cde54c301f591a8e2a16135bb113c5e7ed DIFF: https://github.com/llvm/llvm-project/commit/b4f2d7cde54c301f591a8e2a16135bb113c5e7ed.diff

[Lldb-commits] [lldb] fe80829 - [lldb] [llgs] Skip new vCont test on Windows

Author: Michał Górny Date: 2022-06-27T18:22:38+02:00 New Revision: fe80829289bf5462bff5d6739603e7040d07a391 URL: https://github.com/llvm/llvm-project/commit/fe80829289bf5462bff5d6739603e7040d07a391 DIFF: https://github.com/llvm/llvm-project/commit/fe80829289bf5462bff5d6739603e7040d07a391.diff

[Lldb-commits] [PATCH] D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers

RamNalamothu added a comment. In D50304#3611390 , @goncharov wrote: > FYI this caused a test breakage at lldb-aarch64-ubuntu, > https://lab.llvm.org/buildbot/#/builders/96/builds/25128. I have reverted > this in fe6db8d03ff16a65f57af24d2cb04f489e2e9b0c

[Lldb-commits] [PATCH] D128557: [lldb] Add a log dump command to dump the circular log buffer

JDevlieghere updated this revision to Diff 440271. JDevlieghere added a comment. Print error message when dumping is not supported. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128557/new/ https://reviews.llvm.org/D128557 Files: lldb/include/lldb/Host/Host.h lldb/include/lldb/Util

[Lldb-commits] [PATCH] D128557: [lldb] Add a log dump command to dump the circular log buffer

clayborg added a comment. In D128557#3609545 , @JDevlieghere wrote: > Thanks for pointing that out. I blindly copied the categories logic from > `Log::Disable` which uses it when computing the flags. I've omitted it for > now because I think it would b

[Lldb-commits] [PATCH] D126359: [LLDB] Add basic floating point ops to IR interpreter

clayborg added a comment. Will the floating point emulation be perfect compared to actually JITing the code? If we are going to enable this feature I would like to see tests that actually JIT code do the same operations somehow to verify that things match up with the IR interpreted results prod

[Lldb-commits] [lldb] 9bdb7e5 - [lldb] Add a log dump command

Author: Jonas Devlieghere Date: 2022-06-27T10:02:34-07:00 New Revision: 9bdb7e573427ac3785cb10829da57ee18ef65ce3 URL: https://github.com/llvm/llvm-project/commit/9bdb7e573427ac3785cb10829da57ee18ef65ce3 DIFF: https://github.com/llvm/llvm-project/commit/9bdb7e573427ac3785cb10829da57ee18ef65ce3.d

[Lldb-commits] [PATCH] D128557: [lldb] Add a log dump command to dump the circular log buffer

This revision was automatically updated to reflect the committed changes. Closed by commit rG9bdb7e573427: [lldb] Add a log dump command (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128557/ne

[Lldb-commits] [PATCH] D128668: [LLDB] Fix PDB/pointers.test for 32bit Arm/Windows

omjavaid created this revision. omjavaid added reviewers: mstorsjo, DavidSpickett. Herald added subscribers: jsji, pengfei, kristof.beyls. Herald added a project: All. omjavaid requested review of this revision. PDB/pointers.test was orignally written for 32bit x86 keeping in mind __cdecl and _

[Lldb-commits] [PATCH] D126359: [LLDB] Add basic floating point ops to IR interpreter

clayborg added inline comments. Comment at: lldb/test/API/lang/c/fpeval/TestFPEval.py:32-33 +self.runCmd("run", RUN_SUCCEEDED) +self.expect("expr --allow-jit false -- a + b", VARIABLES_DISPLAYED_CORRECTLY, +substrs=['double', '44']) +

[Lldb-commits] [PATCH] D128668: [LLDB] Fix PDB/pointers.test for 32bit Arm/Windows

omjavaid added inline comments. Comment at: lldb/test/Shell/SymbolFile/PDB/pointers.test:36 F: Variable{{.*}}, name = "this" -F-SAME:(ST *), scope = parameter, location = {{.*}}, artificial +F-SAME:(ST *), scope = parameter,{{( location = DW_OP.*,)?}} artificial F:

[Lldb-commits] [PATCH] D128668: [LLDB] Fix PDB/pointers.test for 32bit Arm/Windows

mstorsjo added a comment. I presume this is ok - if the main intent of this test is to test handling of pointers and the size thereof in PDBs. Comment at: lldb/test/Shell/SymbolFile/PDB/pointers.test:2 REQUIRES: system-windows, msvc RUN: %build --compiler=clang-cl --mode=com

[Lldb-commits] [lldb] ef5510d - [NFC][lldb] Correct Module::FindFunctions documentation

Author: Alex Langford Date: 2022-06-27T12:33:05-07:00 New Revision: ef5510d81b64fa64a75b9c9c024d7c0f6cb8e241 URL: https://github.com/llvm/llvm-project/commit/ef5510d81b64fa64a75b9c9c024d7c0f6cb8e241 DIFF: https://github.com/llvm/llvm-project/commit/ef5510d81b64fa64a75b9c9c024d7c0f6cb8e241.diff

[Lldb-commits] [PATCH] D128668: [LLDB] Fix PDB/pointers.test for 32bit Arm/Windows

omjavaid added inline comments. Comment at: lldb/test/Shell/SymbolFile/PDB/pointers.test:2 REQUIRES: system-windows, msvc RUN: %build --compiler=clang-cl --mode=compile --arch=32 --nodefaultlib --output=%T/PointerTypeTest.cpp.obj %S/Inputs/PointerTypeTest.cpp RUN: %build --co

[Lldb-commits] [PATCH] D128678: [LLDB] Add PDB/Calling-conentions.test for Arm/Windows

omjavaid created this revision. omjavaid added reviewers: mstorsjo, DavidSpickett. omjavaid added a project: LLDB. Herald added subscribers: jsji, JDevlieghere, pengfei, kristof.beyls. Herald added a project: All. omjavaid requested review of this revision. This patch renames PDB/Calling-conention

[Lldb-commits] [PATCH] D128668: [LLDB] Fix PDB/pointers.test for 32bit Arm/Windows

mstorsjo accepted this revision. mstorsjo added inline comments. This revision is now accepted and ready to land. Comment at: lldb/test/Shell/SymbolFile/PDB/pointers.test:2 REQUIRES: system-windows, msvc RUN: %build --compiler=clang-cl --mode=compile --arch=32 --nodefaultlib -

[Lldb-commits] [PATCH] D128678: [LLDB] Add PDB/Calling-conentions.test for Arm/Windows

mstorsjo added a comment. There's consistent typos about the test name in the commit subject and description. Comment at: lldb/test/Shell/SymbolFile/PDB/calling-conventions-arm.test:1 +REQUIRES: system-windows, lld, (target-arm || target-aarch64) +RUN: %build --compiler=clang

[Lldb-commits] [lldb] c1b07d6 - Have CommandObjectParsed check for "commands that take no arguments".

Author: Jim Ingham Date: 2022-06-27T15:14:41-07:00 New Revision: c1b07d617705dfdb3aabbdda51c1a40d99f7cc1a URL: https://github.com/llvm/llvm-project/commit/c1b07d617705dfdb3aabbdda51c1a40d99f7cc1a DIFF: https://github.com/llvm/llvm-project/commit/c1b07d617705dfdb3aabbdda51c1a40d99f7cc1a.diff LO

[Lldb-commits] [PATCH] D128453: Automate checking for "command that takes no arguments" being passed arguments in CommandObjectParsed

This revision was automatically updated to reflect the committed changes. Closed by commit rGc1b07d617705: Have CommandObjectParsed check for "commands that take no arguments". (authored by jingham). Changed prior to commit: https://reviews.llvm.org/D128453?vs=439443&id=440411#toc Repository:

[Lldb-commits] [lldb] e06a88c - [lldb] Use assertState in TestIgnoredExceptions

Author: Jonas Devlieghere Date: 2022-06-27T16:30:47-07:00 New Revision: e06a88cbe9cb639b0ee11026d6888455df1de214 URL: https://github.com/llvm/llvm-project/commit/e06a88cbe9cb639b0ee11026d6888455df1de214 DIFF: https://github.com/llvm/llvm-project/commit/e06a88cbe9cb639b0ee11026d6888455df1de214.d

[Lldb-commits] [PATCH] D128694: [lldb/Dataformatters] Adapt C++ std::string dataformatter for D128285

mib created this revision. mib added reviewers: aprantl, JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch changes the C++ `std::string` dataformatter to reflect internal layout changes f

[Lldb-commits] [PATCH] D128694: [lldb/Dataformatters] Adapt C++ std::string dataformatter for D128285

aprantl added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp:637 if (location_sp->GetName() == g_size_name) - location_sp = short_sp->GetChildAtIndex(3, true); + location_sp = short_sp->GetChildAtIndex(2, true); if (using_bitmas

[Lldb-commits] [PATCH] D128694: [lldb/Dataformatters] Adapt C++ std::string dataformatter for D128285

mib added subscribers: ldionne, labath. mib added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp:637 if (location_sp->GetName() == g_size_name) - location_sp = short_sp->GetChildAtIndex(3, true); + location_sp = short_sp->GetChildAtI

[Lldb-commits] [PATCH] D126983: [lldb] [llgs] Support "t" vCont action

mib added a comment. Herald added a subscriber: JDevlieghere. Hey @mgorny, This patch is causing a test to fail on the macOS bot: https://green.lab.llvm.org/green/job/lldb-cmake/44921/consoleText Feel free to skip it or let me know if you need help reproducing the issue. FAIL: lldb-api :: to

[Lldb-commits] [PATCH] D128694: [lldb/Dataformatters] Adapt C++ std::string dataformatter for D128285

mib added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp:637 if (location_sp->GetName() == g_size_name) - location_sp = short_sp->GetChildAtIndex(3, true); + location_sp = short_sp->GetChildAtIndex(2, true); if (using_bitmasks)

[Lldb-commits] [PATCH] D128694: [lldb/Dataformatters] Adapt C++ std::string dataformatter for D128285

mib updated this revision to Diff 440452. mib edited the summary of this revision. mib added a comment. Use field identifiers instead of indices and add long-mode support. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128694/new/ https://reviews.llvm.org/D128694 Files: lldb/source/Pl

[Lldb-commits] [lldb] f1dcc6a - [lldb] [test] Mark test_vCont_supports_t llgs-only

Author: Michał Górny Date: 2022-06-28T06:06:54+02:00 New Revision: f1dcc6af30d98cef6d0aa9579148fa223dbb5d7c URL: https://github.com/llvm/llvm-project/commit/f1dcc6af30d98cef6d0aa9579148fa223dbb5d7c DIFF: https://github.com/llvm/llvm-project/commit/f1dcc6af30d98cef6d0aa9579148fa223dbb5d7c.diff

[Lldb-commits] [PATCH] D126983: [lldb] [llgs] Support "t" vCont action

mgorny added a comment. Thanks, I've pushed a skip. I'm sorry, I keep forgetting to mark these new tests llgs-only :-(. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126983/new/ https://reviews.llvm.org/D126983 ___

[Lldb-commits] [PATCH] D128698: [lldb] Add a NativeProcessProtocol::Threads() iterable

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski, jingham. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Sponsored by: The FreeBSD Foundation https://reviews.llvm.org/D128698 Files: lldb/include/