[Lldb-commits] [PATCH] D128780: [lldb] [test] Use raise(SIGSTOP) instead of trap in fork tests

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski, jingham. Herald added subscribers: kristof.beyls, arichardson. Herald added a project: All. mgorny requested review of this revision. Replace the use of "trap" with a new "stop" command in fork tests, that maps to `

[Lldb-commits] [lldb] 7fc12da - [lldb] [test] Split TestGdbRemoteFork in two

Author: Michał Górny Date: 2022-06-29T06:57:38+02:00 New Revision: 7fc12da898e05e68ec59fbe852c4402378938efa URL: https://github.com/llvm/llvm-project/commit/7fc12da898e05e68ec59fbe852c4402378938efa DIFF: https://github.com/llvm/llvm-project/commit/7fc12da898e05e68ec59fbe852c4402378938efa.diff

[Lldb-commits] [PATCH] D128775: [trace] Fix errors when handling command arguments

persona0220 added a comment. lgtm. Thanks for fixing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128775/new/ https://reviews.llvm.org/D128775 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [PATCH] D128638: [lldb] [llgs] Add base nonstop fork/vfork tests

mgorny added a comment. I am trying to but unfortunately the server seems to be down. Unfortunately, I can't reproduce this on my aarch64 test machine but maybe the test is taking too long now (we've been suspecting that might be the case). I'm going to split it and see if that helps. Reposit

[Lldb-commits] [PATCH] D128576: [trace] Make events first class items in the trace cursor and rework errors

wallace added inline comments. Comment at: lldb/include/lldb/Target/Trace.h:171 + /// information failed to load, an \a llvm::Error is returned. + virtual llvm::Expected + CreateNewCursor(Thread &thread) = 0; jj10306 wrote: > Do we want to keep the cursor

[Lldb-commits] [PATCH] D128776: Handle a stop when another thread has hit a breakpoint with a failed condition

jingham created this revision. jingham added a reviewer: JDevlieghere. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Threads which hit a breakpoint but fail the condition are considered not to be hit.

[Lldb-commits] [PATCH] D128775: [trace] Fix errors when handling command arguments

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG6564ca188a12: [trace] Fix errors when handling command arguments (authored by Walter Erquinigo ). Reposit

[Lldb-commits] [lldb] 6564ca1 - [trace] Fix errors when handling command arguments

Author: Walter Erquinigo Date: 2022-06-28T17:54:30-07:00 New Revision: 6564ca188a122c79c36ad7e4b3d362fb22fbd0b5 URL: https://github.com/llvm/llvm-project/commit/6564ca188a122c79c36ad7e4b3d362fb22fbd0b5 DIFF: https://github.com/llvm/llvm-project/commit/6564ca188a122c79c36ad7e4b3d362fb22fbd0b5.di

[Lldb-commits] [PATCH] D128775: [trace] Fix errors when handling command arguments

wallace created this revision. wallace added reviewers: jj10306, persona0220. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. https://reviews.llvm.org/D128453 recently added some safety checks for comman

[Lldb-commits] [PATCH] D128477: [trace] Add a flag to the decoder to output the instruction type

wallace added a comment. nice job!! Comment at: lldb/source/Commands/Options.td:304 + def disassemble_options_kind : Option<"kind", "k">, +Desc<"Show instruction control flow type.">; def disassemble_options_context : Option<"context", "C">, Arg<"NumLines">, ---

[Lldb-commits] [PATCH] D128477: [trace] Add a flag to the decoder to output the instruction type

wallace added inline comments. Comment at: lldb/include/lldb/Core/Disassembler.h:82-86 + lldb::InstructionControlFlowType + instruction_decode(uint8_t opcode, uint8_t modrm, uint8_t map); + + lldb::InstructionControlFlowType + GetControlFlowInstructionKind(const ExecutionCont

[Lldb-commits] [PATCH] D128543: [trace] Improve the TraceCursor iteration API

This revision was automatically updated to reflect the committed changes. Closed by commit rGf91d82816ff5: [trace] Improve the TraceCursor iteration API (authored by Walter Erquinigo ). Changed prior to commit: https://reviews.llvm.org/D128543?vs=439827&id=440810#toc Repository

[Lldb-commits] [lldb] f91d828 - [trace] Improve the TraceCursor iteration API

Author: Walter Erquinigo Date: 2022-06-28T16:50:12-07:00 New Revision: f91d82816ff5a88a59e86b54a4d63547776d4854 URL: https://github.com/llvm/llvm-project/commit/f91d82816ff5a88a59e86b54a4d63547776d4854 DIFF: https://github.com/llvm/llvm-project/commit/f91d82816ff5a88a59e86b54a4d63547776d4854.di

[Lldb-commits] [PATCH] D128543: [trace] Improve the TraceCursor iteration API

wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/TraceCursorIntelPT.cpp:38 +void TraceCursorIntelPT::Next() { + m_pos += IsForwards() ? 1 : -1; jj10306 wrote: > should only do this increment or decrement if `HasValue()` is true? ot

[Lldb-commits] [PATCH] D128477: [trace] Add a flag to the decoder to output the instruction type

persona0220 updated this revision to Diff 440808. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128477/new/ https://reviews.llvm.org/D128477 Files: lldb/include/lldb/Core/Disassembler.h lldb/include/lldb/Target/TraceCursor.h lldb/include/lldb/Target/TraceInstructionDumper.h lldb/

[Lldb-commits] [PATCH] D128477: [trace] Add a flag to the decoder to output the instruction type

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. remove unwanted files CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128477/new/ https://reviews.llvm.org/D128477 ___ lldb-comm

[Lldb-commits] [PATCH] D128477: [trace] Add a flag to the decoder to output the instruction type

persona0220 updated this revision to Diff 440806. persona0220 added a comment. Herald added subscribers: Michael137, MaskRay. This new diff attach additional metadata 'control flow kind' for instruction. Add '-k / --kind' flag for both `disassemble` and `thread trace dump` command. Thanks to @jin

[Lldb-commits] [PATCH] D128638: [lldb] [llgs] Add base nonstop fork/vfork tests

mib added a comment. Herald added a subscriber: JDevlieghere. Hi @mgorny, There are some random test failures following this patch on `lldb-debian-x86_64`: https://lab.llvm.org/buildbot/#/builders/68/builds/34883 Unresolved Tests (1): lldb-api :: tools/lldb-server/T

[Lldb-commits] [lldb] 44a114f - [lldb/Dataformatters] Adapt C++ std::string dataformatter for D128285

Author: Med Ismail Bennani Date: 2022-06-28T15:34:17-07:00 New Revision: 44a114fec715bd9c9b725c939a09de4b746108e3 URL: https://github.com/llvm/llvm-project/commit/44a114fec715bd9c9b725c939a09de4b746108e3 DIFF: https://github.com/llvm/llvm-project/commit/44a114fec715bd9c9b725c939a09de4b746108e3.

[Lldb-commits] [PATCH] D128694: [lldb/Dataformatters] Adapt C++ std::string dataformatter for D128285

This revision was automatically updated to reflect the committed changes. Closed by commit rG44a114fec715: [lldb/Dataformatters] Adapt C++ std::string dataformatter for D128285 (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128694/n

[Lldb-commits] [PATCH] D128768: [lldb/Core] Fix finite progress event reporting

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch should fix event handling for finite progress reports. Previously, the event handler wo

[Lldb-commits] [PATCH] D128694: [lldb/Dataformatters] Adapt C++ std::string dataformatter for D128285

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. I agree with Adrian that we should try to support both the old and new layout. Is there a way we can fall back? I think it's fine to land the patch as is to unblock the bots and ad

[Lldb-commits] [PATCH] D128678: [LLDB] Add PDB/calling-conventions.test for Arm/Windows

omjavaid added a comment. In D128678#3616685 , @mstorsjo wrote: > Thanks, this looks more complete and consistent to me now! > > In D128678#3615531 , @labath wrote: > >> It seems like this is not actually running

[Lldb-commits] [PATCH] D128678: [LLDB] Add PDB/calling-conventions.test for Arm/Windows

mstorsjo added a comment. Thanks, this looks more complete and consistent to me now! In D128678#3615531 , @labath wrote: > It seems like this is not actually running the code. Can we make it such that > these tests are conditional on the appropriate llv

[Lldb-commits] [PATCH] D128268: [lldb] Fix reading i686-windows executables with GNU environment

mstorsjo added a comment. In D128268#3614661 , @labath wrote: > In D128268#3611053 , @mstorsjo > wrote: > >> The odd thing about the second one is the added hardcoded >> `AddArch(ArchSpec("i686-pc-windows"));` a

[Lldb-commits] [PATCH] D128639: [lldb] [llgs] Fix premature server exit if multiprocess+nonstop

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG261d0033500e: [lldb] [llgs] Fix premature server exit if multiprocess+nonstop (authored by mgorny). Herald added a project: LLDB. Changed prior to c

[Lldb-commits] [PATCH] D128638: [lldb] [llgs] Add base nonstop fork/vfork tests

This revision was automatically updated to reflect the committed changes. Closed by commit rGb415f8e3dfb8: [lldb] [llgs] Add base nonstop fork/vfork tests (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [lldb] 261d003 - [lldb] [llgs] Fix premature server exit if multiprocess+nonstop

Author: Michał Górny Date: 2022-06-28T21:49:17+02:00 New Revision: 261d0033500eaa281b74c9d54ae240257a0ea00c URL: https://github.com/llvm/llvm-project/commit/261d0033500eaa281b74c9d54ae240257a0ea00c DIFF: https://github.com/llvm/llvm-project/commit/261d0033500eaa281b74c9d54ae240257a0ea00c.diff

[Lldb-commits] [PATCH] D128698: [lldb] Add a NativeProcessProtocol::Threads() iterable

This revision was automatically updated to reflect the committed changes. Closed by commit rGe095cddb7622: [lldb] Add a NativeProcessProtocol::Threads() iterable (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [lldb] e095cdd - [lldb] Add a NativeProcessProtocol::Threads() iterable

Author: Michał Górny Date: 2022-06-28T21:49:16+02:00 New Revision: e095cddb763fde72b577f3fab5e039cea4c3 URL: https://github.com/llvm/llvm-project/commit/e095cddb763fde72b577f3fab5e039cea4c3 DIFF: https://github.com/llvm/llvm-project/commit/e095cddb763fde72b577f3fab5e039cea4c3.diff

[Lldb-commits] [lldb] b415f8e - [lldb] [llgs] Add base nonstop fork/vfork tests

Author: Michał Górny Date: 2022-06-28T21:49:16+02:00 New Revision: b415f8e3dfb839a886b5290bbebbdd42344c07a9 URL: https://github.com/llvm/llvm-project/commit/b415f8e3dfb839a886b5290bbebbdd42344c07a9 DIFF: https://github.com/llvm/llvm-project/commit/b415f8e3dfb839a886b5290bbebbdd42344c07a9.diff

[Lldb-commits] [lldb] f7bf9d1 - TestIgnoredExceptions.py needs support from debugserver, so it

Author: Jim Ingham Date: 2022-06-28T11:49:55-07:00 New Revision: f7bf9d13d50d785889952deb18cc93de0176cb96 URL: https://github.com/llvm/llvm-project/commit/f7bf9d13d50d785889952deb18cc93de0176cb96 DIFF: https://github.com/llvm/llvm-project/commit/f7bf9d13d50d785889952deb18cc93de0176cb96.diff LO

[Lldb-commits] [PATCH] D128707: [lldb] Fix build on older Linux kernel versions

wallace added a comment. @kongyi thanks for fixing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128707/new/ https://reviews.llvm.org/D128707 ___ lldb-commits mailing list lldb-commits@lists.llvm.o

[Lldb-commits] [PATCH] D128707: [lldb] Fix build on older Linux kernel versions

wallace added a comment. Herald added a subscriber: JDevlieghere. thanks a good point, Jakob. Let's keep it in mind. Maybe we can bootcamp that Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128707/new/ https://reviews.llvm.org/D128707

[Lldb-commits] [PATCH] D128638: [lldb] [llgs] Add base nonstop fork/vfork tests

mgorny added a comment. Ok, I'll commit as-is then and will revisit if we start seeing timeouts. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128638/new/ https://reviews.llvm.org/D128638 ___ lldb-commits mailing list lldb-commits@lists.llvm.

[Lldb-commits] [PATCH] D128576: [trace] Make events first class items in the trace cursor and rework errors

jj10306 requested changes to this revision. jj10306 added a comment. This revision now requires changes to proceed. review- part 1 Comment at: lldb/include/lldb/Target/Trace.h:171 + /// information failed to load, an \a llvm::Error is returned. + virtual llvm::Expected +

[Lldb-commits] [PATCH] D127755: [lldb] [llgs] Add test for resuming via c in multiprocess scenarios

mgorny added a comment. Unfortunately, I wasn't able to get ARM to work (some triple mismatch) but I've masked the tests xfail for now, and both buildbots seem green. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127755/new/ https://reviews.llvm.o

[Lldb-commits] [lldb] 25f4608 - [lldb] [test] XFAIL llgs tests failing on arm

Author: Michał Górny Date: 2022-06-28T17:02:59+02:00 New Revision: 25f46084d8e11894edc0b71b737f45e0f9115b45 URL: https://github.com/llvm/llvm-project/commit/25f46084d8e11894edc0b71b737f45e0f9115b45 DIFF: https://github.com/llvm/llvm-project/commit/25f46084d8e11894edc0b71b737f45e0f9115b45.diff

[Lldb-commits] [PATCH] D128694: [lldb/Dataformatters] Adapt C++ std::string dataformatter for D128285

ldionne added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp:637 if (location_sp->GetName() == g_size_name) - location_sp = short_sp->GetChildAtIndex(3, true); + location_sp = short_sp->GetChildAtIndex(2, true); if (using_bitmas

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

gbenyei updated this revision to Diff 440579. gbenyei marked 7 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128612/new/ https://reviews.llvm.org/D128612 Files: clang/include/clang/Basic/Attr.td clang/lib/Basic/Targets.c

[Lldb-commits] [PATCH] D128611: [libc++] Implement `std::ranges::merge`

huixie90 updated this revision to Diff 440493. huixie90 added a comment. Herald added subscribers: cfe-commits, llvm-commits, libc-commits, openmp-commits, lldb-commits, Sanitizers, steakhal, nlopes, mtrofin, jsji, Enna1, bzcheeseman, kosarev, jsilvanus, mattd, gchakrabarti, ThomasRaoux, pmatos,

[Lldb-commits] [PATCH] D128465: Zstandard as a second compression method to LLVM

MaskRay added a comment. In D128465#3612948 , @phosek wrote: > I think this patch should be broken into at least two: > > 1. Refactor `llvm/include/llvm/Support/Compression.h` and > `llvm/lib/Support/Compression.cpp` to introduce a generic interface and

[Lldb-commits] [PATCH] D128465: Zstandard as a second compression method to LLVM

phosek added a comment. I think this patch should be broken into at least two: 1. Refactor `llvm/include/llvm/Support/Compression.h` and `llvm/lib/Support/Compression.cpp` to introduce a generic interface and use it throughout the codebase. 2. zstd support in `llvm/include/llvm/Support/Compress

[Lldb-commits] [PATCH] D128465: Zstandard as a second compression method to LLVM

ckissane updated this revision to Diff 440325. ckissane added a comment. more context CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/index/Serialization.cpp clang-t

[Lldb-commits] [PATCH] D128465: Zstandard as a second compression method to LLVM

ckissane updated this revision to Diff 440327. ckissane added a comment. format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/index/Serialization.cpp clang-tools-e

[Lldb-commits] [PATCH] D128465: Zstandard as a second compression method to LLVM

ckissane updated this revision to Diff 440298. ckissane added a comment. fix type for FindZstd cmake usage Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files: clang-tools-extra/clangd/CMakeLists.txt

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

jrtc27 added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.h:113 +if (Triple.isLittleEndian()) + resetDataLayout("e-m:e-p:32:32-i64:64-n32-S128"); +else And please avoid repeating the whole data layout, just make the e/E a variable ===

[Lldb-commits] [PATCH] D128465: Zstandard as a second compression method to LLVM

ckissane updated this revision to Diff 440288. ckissane added a comment. Fix missing cmake findZstd, remove unused crc32 from compression namespaces and simplify some code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.l

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

jhenderson added inline comments. Comment at: llvm/include/llvm/ADT/Triple.h:864 /// Tests whether the target is RISC-V (32- and 64-bit). bool isRISCV() const { Perhaps worth updating to mention big and little endian here, like `isPPC64` above? ===

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.h:111 SizeType = UnsignedInt; -resetDataLayout("e-m:e-p:32:32-i64:64-n32-S128"); } Instead of creating new classes, could we have a branch on the Arch or isLittleEndian por

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

gbenyei updated this revision to Diff 440196. gbenyei added a comment. Thanks, Craig. Updated the patch with your remarks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128612/new/ https://reviews.llvm.org/D128612 Files: clang/include/clang/Basi

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

gbenyei created this revision. gbenyei added a reviewer: asb. gbenyei added projects: clang, LLVM, lld. Herald added subscribers: Enna1, sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, ormris, jocewei, PkmX, the_o, brucehoult, Mar

[Lldb-commits] [PATCH] D128250: [LLDB][RISCV]Add initial support for lldb-server.

Emmmer updated this revision to Diff 439955. Emmmer marked an inline comment as done. Emmmer added a comment. This patch change: - add `lldb/source/Plugins/Architecture/RISCV64` - add `lldb/source/Plugins/Architecture/RISCV32` - update `lldb/source/Utility/ArchSpec.cpp` - remove `lldb/source/Plu

[Lldb-commits] [PATCH] D128250: [LLDB][RISCV]Add initial support for lldb-server.

Emmmer marked 2 inline comments as done. Emmmer added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_riscv64.h:9 + +#if defined(__riscv) || __riscv_xlen == 64 + DavidSpickett wrote: > Should this be `&&`? I'm assuming t

[Lldb-commits] [PATCH] D128250: [LLDB][RISCV]Add initial support for lldb-server.

DavidSpickett added a comment. > I tried to fix this error with gdb, but the debugging process was too slow, > so I'm sorry for not being able to provide a test patch for verification of > my commit. Oh and if you want help with this please ask on discord/discourse. This stuff is a bit tedious

[Lldb-commits] [PATCH] D128250: [LLDB][RISCV]Add initial support for lldb-server.

DavidSpickett added a comment. Overall this looks fine. Without the ability to test it I don't think we would accept it yet, so I didn't look into the details too much. > To use gdbserver by lldb requires the participation of lldb-server, so my > current plan is to allow lldb to co-op with gdbs

[Lldb-commits] [PATCH] D128465: [WIP] Zstandard as a second compression method to LLVM

ckissane created this revision. ckissane added reviewers: phosek, leonardchan. ckissane added a project: LLVM. Herald added subscribers: Enna1, abrachet, wenlei, usaxena95, kadircet, arphaman, hiraditya, arichardson, mgorny, emaste. Herald added a reviewer: alexander-shaposhnikov. Herald added a r

[Lldb-commits] [PATCH] D128250: [LLDB][RISCV]Add initial support for lldb-server.

DavidSpickett added a comment. I'll give this a more thorough read later just one comment for now. In the meantime, what's your plan for testing this config going forward? This patch would be fine as the first of a series but I'd like to see the follow ups that make it usable. Will there be a

[Lldb-commits] [PATCH] D128250: [LLDB][RISCV]Add initial support for lldb-server.

Emmmer added a comment. In D128250#3598223 , @DavidSpickett wrote: > I'll give this a more thorough read later just one comment for now. > > In the meantime, what's your plan for testing this config going forward? This > patch would be fine as the first

[Lldb-commits] [PATCH] D128250: [LLDB][RISCV]Add initial support for lldb-server.

Emmmer created this revision. Emmmer added reviewers: DavidSpickett, craig.topper. Emmmer added a project: LLDB. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, JDevlieghere, s.egerton, Jim, benna, psnobl, jocew

[Lldb-commits] [PATCH] D128166: ManagedStatic: Destroy from destructor

nhaehnle created this revision. Herald added a reviewer: deadalnix. Herald added subscribers: bzcheeseman, ayermolo, sdasgup3, wenzhicui, wrengr, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, jvesely, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, a

[Lldb-commits] [PATCH] D127741: [Disassembler] Add +all CPU feature to subtargetInfo and use it for disassembling AArch64

treapster added a comment. In D127741#3583559 , @DavidSpickett wrote: > > I agree that objdump should have some kind of "max" setting, even a default. > However there will still need to be a way to test what I referred to. As you said, ` instructio

[Lldb-commits] [PATCH] D127741: [Disassembler] Add +all CPU feature to subtargetInfo and use it for disassembling AArch64

srhines added a comment. We had some internal Google folks hit this exact issue recently. I don't think that the same "default" CPU should be used for debugging tools like `llvm-objdump`, and that is the crux of the matter here. Perhaps updating the test to specify "generic" as the CPU when pas

[Lldb-commits] [PATCH] D127741: [Disassembler] Add +all CPU feature to subtargetInfo and use it for disassembling AArch64

DavidSpickett added a comment. > Why not use objdump? If we only check that instructions get disassembled, it > will work fine. I just remember some tests using llvm-mc to disassemble and some using objdump. Istr that using llvm-mc for assemble and disassemble usually meant having two test fil

[Lldb-commits] [PATCH] D127741: [Disassembler] Add +all CPU feature to subtargetInfo and use it for disassembling AArch64

treapster added a comment. For now i'd like to hear more about possible clashing instruction encodings from @labrinea, and if it's not a concern, i think we can fix the tests if we remove `CHECK-UNKNOWN:` and only call objdump with `CHECK-INST`. What do you think? Repository: rG LLVM Github

[Lldb-commits] [PATCH] D127741: [Disassembler] Add +all CPU feature to subtargetInfo and use it for disassembling AArch64

DavidSpickett added a comment. Now I think about it, tests could do something like "-mattr=-all" to remove it, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127741/new/ https://reviews.llvm.org/D127741 _

[Lldb-commits] [PATCH] D127741: [Disassembler] Add +all CPU feature to subtargetInfo and use it for disassembling AArch64

MaskRay added a comment. I like the idea of `all` for llvm-objdump, but it should be a separate change, with `-mattr=-all` tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127741/new/ https://reviews.llvm.org/D127741 _

[Lldb-commits] [PATCH] D127741: [Disassembler] Add +all CPU feature to subtargetInfo and use it for disassembling AArch64

DavidSpickett added subscribers: labrinea, DavidSpickett. DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added a comment. Herald added a subscriber: Michael137. > conflicting instructions with the same encoding in different extensions, but > it doesn't seem possible within one arche

[Lldb-commits] [PATCH] D127684: [NFC] Use `https` instead of `http` in the `LLVM.org` URLs

sunshaoce abandoned this revision. sunshaoce added a comment. Thanks for comments! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127684/new/ https://reviews.llvm.org/D127684 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D127684: [NFC] Use `https` instead of `http` in the `LLVM.org` URLs

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. +1 on breaking this down per sub-project and creating separate patches for review. I sampled the patch and about a quarter or so of the links I tried didn't work, even b

[Lldb-commits] [PATCH] D127741: [Disassembler] Add +all CPU feature to subtargetInfo and use it for disassembling AArch64

treapster added a comment. Well, it broke a lot of tests that very explicitly checking that instructions are not disassembled without explicitly specified extensions, but i don't quite get the point of such tests. If new instructions were added by default in lldb, why can't we do the same with

[Lldb-commits] [PATCH] D127741: [Disassembler] Add +all CPU feature to subtargetInfo and use it for disassembling AArch64

treapster created this revision. treapster added a reviewer: rafaelauler. Herald added subscribers: jsji, ayermolo, pengfei, rupprecht, hiraditya, kristof.beyls. Herald added a reviewer: jhenderson. Herald added a reviewer: MaskRay. Herald added a reviewer: rafauler. Herald added a reviewer: Amir.

[Lldb-commits] [PATCH] D127684: [NFC] Use `https` instead of `http` in the urls

efriedma added a comment. A couple notes skimming the changes: 1. If you're going to update URLs, please verify the new URLs are actually valid. 2. Some of the "URLs" you're updating aren't actually URLs. For example, the `xmlns` attribute in SVG files must be the exact string written in the s

[Lldb-commits] [PATCH] D127684: [NFC] Use `https` instead of `http` in the urls

philnik added a comment. Could you do this on a per-project basis? More than 1000 files is way to much to sift through. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127684/new/ https://reviews.llvm.org/D127684 ___

[Lldb-commits] [PATCH] D127684: [NFC] Use `https` instead of `http` in the urls

sunshaoce created this revision. Herald added subscribers: libc-commits, libcxx-commits, jsji, Enna1, bzcheeseman, kosarev, jsilvanus, mattd, gchakrabarti, hsmhsm, ThomasRaoux, pmatos, asb, ayermolo, awarzynski, sdasgup3, asavonic, carlosgalvezp, jeroen.dobbelaere, abrachet, wenzhicui, wrengr, C

[Lldb-commits] [PATCH] D127224: [flang][OpenMP] Lowering support for atomic capture

NimishMishra updated this revision to Diff 435060. NimishMishra added a comment. Herald added subscribers: cfe-commits, llvm-commits, libc-commits, libcxx-commits, openmp-commits, lldb-commits, Sanitizers, jsji, Enna1, kosarev, mravishankar, jsilvanus, mattd, gchakrabarti, hsmhsm, pmatos, asb, p

[Lldb-commits] [PATCH] D125860: [clang] Only use major version in resource dir

tbaeder updated this revision to Diff 435876. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125860/new/ https://reviews.llvm.org/D125860 Files: clang/include/clang/Basic/Version.inc.in clang/lib/Driver/Driver.cpp clang/lib/Headers/CMakeLists.txt clang/lib/Tooling/CMakeLists.txt

[Lldb-commits] [PATCH] D125860: [clang] Only use major version in resource dir

tbaeder updated this revision to Diff 435850. Herald added a subscriber: Enna1. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125860/new/ https://reviews.llvm.org/D125860 Files: clang/include/clang/Basic/Version.inc.in clang/lib/Driver/Driver.cpp clang/lib/Headers/CMakeLists.txt

[Lldb-commits] [PATCH] D121876: [BOLT][DWARF] Implement monolithic DWARF5

ayermolo added a comment. In D121876#3542766 , @Amir wrote: > Hi, > The test started to fail on Ubuntu buildbot: > https://lab.llvm.org/buildbot/#/builders/215/builds/6376 > > # PRECHECK: include_directories[ 0] = .debug_line_str[0x] >

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

luismarques added a comment. In D62732#3157524 , @kasper81 wrote: > Hi Luis, are you planning on adding plugin architecture support (in > `lldb/source/Plugins/Architecture`) as part of this work? I commandeered this patch from Simon Cook, the original au

[Lldb-commits] [PATCH] D121876: [BOLT][DWARF] Implement monolithic DWARF5

Amir added a comment. Hi, The test started to fail on Ubuntu buildbot: https://lab.llvm.org/buildbot/#/builders/215/builds/6376 # PRECHECK: include_directories[ 0] = .debug_line_str[0x] ^ :8:12: note: scanning from here version: 5 ^ :30:1: note: possib

[Lldb-commits] [PATCH] D125860: [clang] Only use major version in resource dir

tbaeder created this revision. tbaeder added a reviewer: tstellar. Herald added a subscriber: mgorny. Herald added a reviewer: bollu. Herald added a project: All. tbaeder requested review of this revision. Herald added subscribers: llvm-commits, openmp-commits, lldb-commits, Sanitizers, cfe-commit

[Lldb-commits] [PATCH] D122988: [BOLT][DWARF] Add version 5 split dwarf support

maksfb accepted this revision. maksfb added a comment. This revision is now accepted and ready to land. Awesome! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122988/new/ https://reviews.llvm.org/D122988 ___

[Lldb-commits] [PATCH] D123580: [libc++] Use bit field for checking if string is in long or short mode

labath added inline comments. Comment at: libcxx/utils/gdb/libcxx/printers.py:192 class StdStringPrinter(object): """Print a std::string.""" Mordante wrote: > ldionne wrote: > > philnik wrote: > > > labath wrote: > > > > philnik wrote: > > > > > dblaikie

[Lldb-commits] [PATCH] D122988: [BOLT][DWARF] Add version 5 split dwarf support

ayermolo added inline comments. Comment at: bolt/include/bolt/Core/DebugData.h:375-377 +if (Optional DWOId = Unit.getDWOId()) + return *DWOId; +return Unit.getOffset(); dblaikie wrote: > ayermolo wrote: > > ayermolo wrote: > > > dblaikie wrote: > > >

[Lldb-commits] [PATCH] D123580: [libc++] Use bit field for checking if string is in long or short mode

Mordante added inline comments. Comment at: libcxx/utils/gdb/libcxx/printers.py:192 class StdStringPrinter(object): """Print a std::string.""" labath wrote: > Mordante wrote: > > ldionne wrote: > > > philnik wrote: > > > > labath wrote: > > > > > philnik

[Lldb-commits] [PATCH] D122988: [BOLT][DWARF] Add version 5 split dwarf support

ayermolo added inline comments. Comment at: bolt/include/bolt/Core/DebugData.h:375-377 +if (Optional DWOId = Unit.getDWOId()) + return *DWOId; +return Unit.getOffset(); ayermolo wrote: > dblaikie wrote: > > That seems like a somewhat problematic API

[Lldb-commits] [PATCH] D122988: [BOLT][DWARF] Add version 5 split dwarf support

ayermolo added inline comments. Comment at: bolt/include/bolt/Core/DebugData.h:375-377 +if (Optional DWOId = Unit.getDWOId()) + return *DWOId; +return Unit.getOffset(); dblaikie wrote: > That seems like a somewhat problematic API - returning two very

[Lldb-commits] [PATCH] D123580: [libc++] Use bit field for checking if string is in long or short mode

Mordante added inline comments. Comment at: libcxx/utils/gdb/libcxx/printers.py:192 class StdStringPrinter(object): """Print a std::string.""" ldionne wrote: > philnik wrote: > > labath wrote: > > > philnik wrote: > > > > dblaikie wrote: > > > > > philnik

Re: [Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

On Fri, Jun 17, 2022 at 14:32 Jonas Devlieghere via Phabricator wrote: > > JDevlieghere added a comment. > > In D128069#3592733 , @dmlary wrote: > > > I went through the existing tests for SBSection, and there is only one test > > case for all the getters

[Lldb-commits] [lldb] a1df636 - [lldb] [test] Skip llgs tests broken due to #56268 on aarch64

Author: Michał Górny Date: 2022-06-28T16:24:38+02:00 New Revision: a1df636a8b51a660d58708d82a5bc060ee5f57d3 URL: https://github.com/llvm/llvm-project/commit/a1df636a8b51a660d58708d82a5bc060ee5f57d3 DIFF: https://github.com/llvm/llvm-project/commit/a1df636a8b51a660d58708d82a5bc060ee5f57d3.diff

[Lldb-commits] [PATCH] D127999: [lldb] fix stepping through POSIX trampolines

mdaniels added a comment. I do not have commit access, so I would need someone to commit for me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127999/new/ https://reviews.llvm.org/D127999 ___ lldb-commits mailing list lldb-commits@lists.llvm.

[Lldb-commits] [PATCH] D127999: [lldb] fix stepping through POSIX trampolines

labath accepted this revision. labath added a comment. Cool, thanks. So do you have commit access, or you need someone to commit this for you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127999/new/ https://reviews.llvm.org/D127999 ___ lld

[Lldb-commits] [PATCH] D128264: [lldb/dyld-posix] Avoid reading the module list in inconsistent states

labath marked an inline comment as done. labath added a comment. @mgorny, ping. Do you maybe want to try this out on freebsd? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128264/new/ https://reviews.llvm.org/D128264 __

[Lldb-commits] [PATCH] D128410: [lldb] Add a testcase for nested exceptions on Windows

labath added a comment. In D128410#3609185 , @mstorsjo wrote: > In D128410#3608190 , @labath wrote: > >> In D128410#3604927 , @alvinhochun >> wrote: >> >>> It may be poss

[Lldb-commits] [PATCH] D128678: [LLDB] Add PDB/calling-conventions.test for Arm/Windows

labath added a comment. It seems like this is not actually running the code. Can we make it such that these tests are conditional on the appropriate llvm targets being enabled (instead of the host being of a specific type)? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128678/new/ htt

[Lldb-commits] [PATCH] D127755: [lldb] [llgs] Add test for resuming via c in multiprocess scenarios

mgorny added a comment. Ok, it seems that LLDB is hitting some deadloop on `brk #0xf000` in code. I've filed https://github.com/llvm/llvm-project/issues/56268 for it and I'm going to skip the tests relying on traps. I'm going to try if I manage to get 32-bit ARM container to work as well. Rep

[Lldb-commits] [PATCH] D128638: [lldb] [llgs] Add base nonstop fork/vfork tests

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D128638#3611932 , @mgorny wrote: > BTW this test is getting a bit long as well but I don't have a good idea how > to split it, except for just movi

[Lldb-commits] [PATCH] D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers

labath added a comment. The problem is most likely due to the arm64 version having slightly different line number sequences due to different instruction scheduling. You might be able to gain some insight just by comparing the debug line content, without actually running it. It might be helpful

[Lldb-commits] [PATCH] D127755: [lldb] [llgs] Add test for resuming via c in multiprocess scenarios

mgorny added a comment. Thanks for letting me know. I'll set up an AArch64 development environment in a minute and try to figure it out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127755/new/ https://reviews.llvm.org/D127755 __

  1   2   >