[Lldb-commits] [PATCH] D129703: [lldb] Refactor command option enum values (NFC)

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rG7ced9fff9547: [lldb] Refactor command option enum values (NFC) (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D129707: [lldb] Print the enum values and their description in the argument value help output

This revision was automatically updated to reflect the committed changes. Closed by commit rGbcae3cdbd029: [lldb] Print the enum values and their description in the help output (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] bcae3cd - [lldb] Print the enum values and their description in the help output

Author: Jonas Devlieghere Date: 2022-07-14T21:18:08-07:00 New Revision: bcae3cdbd029210e9ecf42f07d38cc4ed4a95230 URL: https://github.com/llvm/llvm-project/commit/bcae3cdbd029210e9ecf42f07d38cc4ed4a95230 DIFF:

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

JDevlieghere added a subscriber: teemperor. JDevlieghere added a comment. In D112374#3653702 , @mizvekov wrote: > @JDevlieghere I spent a lot of time trying to get this test running on my > machine to no avail. I think lldb build and test setup is quite

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

chapuni added inline comments. Comment at: clang/lib/Sema/TypeLocBuilder.cpp:159 - assert(Capacity - Index == TypeLoc::getFullDataSizeForType(T) && + unsigned FDSz = TypeLoc::getFullDataSizeForType(T); + assert(Capacity - Index == FDSz && It causes a

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG7c51f02effdb: [clang] Implement ElaboratedType sugaring for types written bare (authored by mizvekov). Changed prior to

[Lldb-commits] [PATCH] D129682: [lldb] Filter DIEs based on qualified name when possible

jingham added a comment. BTW, this is a side comment, but given that it's fairly common in the STL at least to have functions with a bevy of defaulted arguments that very few people specify or even really know are part of the function signature, it would be neat to do things like: (lldb)

[Lldb-commits] [PATCH] D129682: [lldb] Filter DIEs based on qualified name when possible

jingham added a comment. It always bugged me that `break set some::long::path::a_common_word` was going to realize all the debug info for functions called "a_common_word". In large projects there can be a lot of those. So I'm not 100% surprised that this gives us a good speedup (but happy!)

[Lldb-commits] [PATCH] D129521: Add the ability to run expressions that call fork() or vfork().

jingham added a comment. First off, I think making "follows-fork=child" work in expressions will be pretty tricky at present, since lldb can only control either the parent or the child. But you have to make sure the parent side of the expression completes, so you can't let go of the parent

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

glandium added a comment. In D112374#3651218 , @mizvekov wrote: > Can you confirm that this `NoPrincipalGetURI` matcher would, in clang version > without this patch here, fail to match if you had rewritten the `GetUri` > method to use a qualified name?

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. @JDevlieghere I spent a lot of time trying to get this test running on my machine to no avail. I think lldb build and test setup is quite convoluted, fragile and antiquated. It uses many deprecated CMake features, It fails to properly link to system libraries it needs

[Lldb-commits] [PATCH] D129814: Fix stepping over watchpoints in architectures that raise the exception before executing the instruction

jingham added a comment. Ack, bad memory. It was actually originally done in PerformAction, but that has the same effect. You really shouldn't run the target in PerformAction if you can manage it. That's why, for instance, I added a --auto-continue flag to the breakpoints (probably should

[Lldb-commits] [PATCH] D129814: Fix stepping over watchpoints in architectures that raise the exception before executing the instruction

jingham created this revision. jingham added reviewers: JDevlieghere, jasonmolenda, labath, clayborg. Herald added subscribers: atanasyan, kristof.beyls, arichardson, sdardis. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a

[Lldb-commits] [PATCH] D129703: [lldb] Refactor command option enum values (NFC)

clayborg accepted this revision. clayborg added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Commands/CommandObjectBreakpointCommand.cpp:25-54 -// FIXME: "script-type" needs to have its contents determined dynamically, so -// somebody

[Lldb-commits] [PATCH] D129807: [LLDB][NativePDB] Add MSInheritanceAttr when completing CXXRecordDecl

zequanwu created this revision. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D129807 Files:

[Lldb-commits] [PATCH] D129703: [lldb] Refactor command option enum values (NFC)

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/source/Commands/CommandObjectBreakpointCommand.cpp:25-54 -// FIXME: "script-type" needs to have its contents determined dynamically, so -// somebody can add a new scripting

[Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

aeubanks added a comment. Herald added a project: All. Hi, sorry to ping a very old patch but `TestVSCode_runInTerminal.py` is still failing on my linux machine (and a coworker said the same thing). Searching my email for the test name, some 12.0.0 and 13.0.0 release email threads also mention

[Lldb-commits] [PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

jasonmolenda added a comment. In D128465#3653216 , @ckissane wrote: > In D128465#3653051 , @jasonmolenda > wrote: > >> In D128465#3652525 , @ckissane >> wrote: >> >>>

[Lldb-commits] [PATCH] D129703: [lldb] Refactor command option enum values (NFC)

clayborg added inline comments. Comment at: lldb/source/Commands/CommandObjectBreakpointCommand.cpp:25-54 -// FIXME: "script-type" needs to have its contents determined dynamically, so -// somebody can add a new scripting language to lldb and have it pickable here -// without

[Lldb-commits] [PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

ckissane added a comment. In D128465#3653051 , @jasonmolenda wrote: > In D128465#3652525 , @ckissane > wrote: > >> In D128465#3651025 , @aemerson >> wrote: >> >>> I

[Lldb-commits] [PATCH] D129783: [lldb] Skip tests using int128 on ARM

jasonmolenda added a comment. A very minor point but API tests don't need `mydir = TestBase.compute_mydir(__file__)` any more thanks to https://reviews.llvm.org/D128077 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129783/new/

[Lldb-commits] [PATCH] D129682: [lldb] Filter DIEs based on qualified name when possible

bulbazord added a comment. In D129682#3651175 , @labath wrote: > Well.. first of let me say that the performance gain is impressive. I > wouldn't have expected to gain that much with a relatively simple change. Thank you! I am also very surprised, it

[Lldb-commits] [PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

cassanova updated this revision to Diff 444761. cassanova edited the summary of this revision. cassanova added a comment. Removed the cxx_proto.proto file since we include the headers that it generates from the clang side. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129377/new/

[Lldb-commits] [PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

cassanova marked an inline comment as done. cassanova added inline comments. Comment at: lldb/tools/lldb-fuzzer/lldb-expression-fuzzer/cxx_proto.proto:1 +//===-- cxx_proto.proto - Protobuf description of C++ -===// +// JDevlieghere wrote: >

[Lldb-commits] [PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

ckissane added a comment. @aemerson can you let me know if https://reviews.llvm.org/D129786 works on MacOS? I am continuing work on that revision because this one has a lot of outdated unrelated history. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D128893: [lldb] [llgs] Fix disabling non-stop mode

mgorny updated this revision to Diff 444727. mgorny added a comment. Use a single `bool` member to indicate whether we're still waiting for any process to stop. Turned out pretty easy. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128893/new/ https://reviews.llvm.org/D128893 Files:

[Lldb-commits] [lldb] c3a28e8 - Revert "[lldb] Add support for using integral const static data members in the expression evaluator"

Author: Stella Stamenova Date: 2022-07-14T10:47:01-07:00 New Revision: c3a28e8a99a6672339a38c468f2519ace5659fa2 URL: https://github.com/llvm/llvm-project/commit/c3a28e8a99a6672339a38c468f2519ace5659fa2 DIFF:

[Lldb-commits] [PATCH] D128878: [lldb] [llgs] Remove not-really-used m_inferior_prev_state

This revision was automatically updated to reflect the committed changes. Closed by commit rG06b3f27fedd5: [lldb] [llgs] Remove not-really-used m_inferior_prev_state (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 06b3f27 - [lldb] [llgs] Remove not-really-used m_inferior_prev_state

Author: Michał Górny Date: 2022-07-14T19:25:54+02:00 New Revision: 06b3f27fedd5a26ad571c093ccf47d0c11b1e913 URL: https://github.com/llvm/llvm-project/commit/06b3f27fedd5a26ad571c093ccf47d0c11b1e913 DIFF: https://github.com/llvm/llvm-project/commit/06b3f27fedd5a26ad571c093ccf47d0c11b1e913.diff

[Lldb-commits] [PATCH] D129707: [lldb] Print the enum values and their description in the argument value help output

clayborg accepted this revision. clayborg added a comment. nice! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129707/new/ https://reviews.llvm.org/D129707 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

ckissane added a comment. In D128465#3651025 , @aemerson wrote: > I just reverted this in 6e6be5f9504d > because > it seems to have broken macOS builds: > >

[Lldb-commits] [PATCH] D129724: [lldb] Remove ELF .zdebug support

This revision was automatically updated to reflect the committed changes. MaskRay marked an inline comment as done. Closed by commit rGecfaf4801cd0: [lldb] Remove ELF .zdebug support (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D129724?vs=444504=444707#toc

[Lldb-commits] [PATCH] D129724: [lldb] Remove ELF .zdebug support

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1610 static SectionType GetSectionTypeFromName(llvm::StringRef Name) { if (Name.consume_front(".debug_") ||

[Lldb-commits] [lldb] ecfaf48 - [lldb] Remove ELF .zdebug support

Author: Fangrui Song Date: 2022-07-14T10:12:48-07:00 New Revision: ecfaf4801cd0cc85fdced820110652f0281765fa URL: https://github.com/llvm/llvm-project/commit/ecfaf4801cd0cc85fdced820110652f0281765fa DIFF: https://github.com/llvm/llvm-project/commit/ecfaf4801cd0cc85fdced820110652f0281765fa.diff

[Lldb-commits] [PATCH] D128710: [lldb] [llgs] Fix multi-resume bugs with nonstop mode

mgorny updated this revision to Diff 444696. mgorny added a comment. Remove support for `t` with individual thread numbers and simplify code. Move resuming the process (and checking whether it can be resumed) into a common `ResumeProcess()` method. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D81471: [lldb] Add support for using integral const static data members in the expression evaluator

stella.stamenova added a comment. Looks like this broke the Windows lldb bot as well: https://lab.llvm.org/buildbot/#/builders/83/builds/21186 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81471/new/ https://reviews.llvm.org/D81471

[Lldb-commits] [PATCH] D129078: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

Michael137 added a comment. After playing around with this some more I found an edge case with conditional breakpoints (in fact any place where we reuse an LLVMUserExpression). Modifying `lldb/test/API/functionalities/breakpoint/two_hits_one_actual` such that the helper method is inside a

[Lldb-commits] [PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

JDevlieghere added inline comments. Comment at: lldb/tools/lldb-fuzzer/lldb-expression-fuzzer/cxx_proto.proto:1 +//===-- cxx_proto.proto - Protobuf description of C++ -===// +// Do we still need a copy of this for LLDB? CHANGES SINCE LAST

[Lldb-commits] [PATCH] D129783: [lldb] Skip tests using int128 on ARM

werat created this revision. werat added a reviewer: Michael137. Herald added a subscriber: kristof.beyls. Herald added a project: All. werat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Follow-up fix for

[Lldb-commits] [lldb] 4867872 - [lldb] Add support for using integral const static data members in the expression evaluator

Author: Andy Yankovsky Date: 2022-07-14T15:15:11Z New Revision: 486787210df5ce5eabadc90a7de353ae81101feb URL: https://github.com/llvm/llvm-project/commit/486787210df5ce5eabadc90a7de353ae81101feb DIFF: https://github.com/llvm/llvm-project/commit/486787210df5ce5eabadc90a7de353ae81101feb.diff

[Lldb-commits] [PATCH] D81471: [lldb] Add support for using integral const static data members in the expression evaluator

This revision was automatically updated to reflect the committed changes. Closed by commit rG486787210df5: [lldb] Add support for using integral const static data members in the… (authored by werat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D129652: [lldb] [llgs] Convert m_debugged_processes into a map of structs

This revision was automatically updated to reflect the committed changes. Closed by commit rG355c7916336f: [lldb] [llgs] Convert m_debugged_processes into a map of structs (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 355c791 - [lldb] [llgs] Convert m_debugged_processes into a map of structs

Author: Michał Górny Date: 2022-07-14T15:32:19+02:00 New Revision: 355c7916336fb4922946a8cfc174dbdb514dddb5 URL: https://github.com/llvm/llvm-project/commit/355c7916336fb4922946a8cfc174dbdb514dddb5 DIFF: https://github.com/llvm/llvm-project/commit/355c7916336fb4922946a8cfc174dbdb514dddb5.diff

[Lldb-commits] [PATCH] D129750: [lldb] Always use APFloat for FP dumping

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. I'm no float expert but seems fine. Also checked on AArch64 and no failures there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D128710: [lldb] [llgs] Fix multi-resume bugs with nonstop mode

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1818-1821 +// 4. vCont on a running process that requests suspending a subset +//of running threads or resuming a subset of suspended threads. +

[Lldb-commits] [PATCH] D128893: [lldb] [llgs] Fix disabling non-stop mode

mgorny added a comment. Hmm, I suppose that makes sense. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128893/new/ https://reviews.llvm.org/D128893 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D129652: [lldb] [llgs] Convert m_debugged_processes into a map of structs

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1058-1060 // Terminate the main loop only if vKill has not been used. // When running in non-stop mode, wait for the vStopped to clear // the

[Lldb-commits] [PATCH] D129489: [lldb][AArch64] Add support for memory tags in core files

DavidSpickett updated this revision to Diff 444628. DavidSpickett added a comment. Add a release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129489/new/ https://reviews.llvm.org/D129489 Files: lldb/include/lldb/Target/Process.h

[Lldb-commits] [PATCH] D128710: [lldb] [llgs] Fix multi-resume bugs with nonstop mode

labath added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1818-1821 +// 4. vCont on a running process that requests suspending a subset +//of running threads or resuming a subset of suspended threads. +

[Lldb-commits] [PATCH] D81471: [lldb] Add support for using integral const static data members in the expression evaluator

werat edited reviewers, added: Michael137; removed: jarin. werat added a comment. In D81471#3641915 , @labath wrote: > So, if noone objects to this, then I think it's fine. I guess nobody objects :) @labath, @Michael137, can you accept/LGTM the

[Lldb-commits] [PATCH] D129750: [lldb] Always use APFloat for FP dumping

Emmmer added a comment. On the riscv64 platform, LLDBCoreTests passed after applying this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129750/new/ https://reviews.llvm.org/D129750 ___

[Lldb-commits] [PATCH] D129736: [lldb] Skip a float16 NaN test for RISC-V

Emmmer abandoned this revision. Emmmer added a comment. Superseded by D129750 , which introduced a platform independent way of checking floating point test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D128893: [lldb] [llgs] Fix disabling non-stop mode

labath added a comment. Actually, on second thought (:D) do we even need a per-process flag for this? Turning off non-stop should stop _all_ processes, so instead of checking whether there are any processes with the 'stopping-due-to-qnonstop` flag around, couldn't we just check if we have any

[Lldb-commits] [PATCH] D129652: [lldb] [llgs] Convert m_debugged_processes into a map of structs

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1058-1060 // Terminate the main loop only if vKill has not been used.

[Lldb-commits] [PATCH] D129736: [lldb] Skip a float16 NaN test for RISC-V

labath added a comment. That code is horrible. Lemme see if I can remove it (=> D129750 ). If that doesn't work, then we can try skipping this... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129736/new/

[Lldb-commits] [PATCH] D129750: [lldb] Always use APFloat for FP dumping

labath created this revision. labath added reviewers: JDevlieghere, jingham, DavidSpickett, Emmmer. Herald added subscribers: jsji, pengfei. Herald added a project: All. labath requested review of this revision. Herald added a project: LLDB. The DumpDataExtractor function had two branches for

[Lldb-commits] [PATCH] D129736: [lldb] Skip a float16 NaN test for RISC-V

DavidSpickett added a comment. Seems fine to me. Do you have a tracking issue for this? You could just open one for "lldb riscv test failures" and add comments as you find more failures. So people can see the current state of the test suite. Comment at:

[Lldb-commits] [lldb] c164efb - [lldb] [gdb-remote] Remove stray GetSupportsThreadSuffix() method (NFC)

Author: Michał Górny Date: 2022-07-14T12:18:17+02:00 New Revision: c164efb0064682893fc37d6c07e1e000861d7879 URL: https://github.com/llvm/llvm-project/commit/c164efb0064682893fc37d6c07e1e000861d7879 DIFF: https://github.com/llvm/llvm-project/commit/c164efb0064682893fc37d6c07e1e000861d7879.diff

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. In D112374#3650749 , @glandium wrote: > FWIW, this change also broke this check in Firefox's clang plugin: >

[Lldb-commits] [PATCH] D129682: [lldb] Filter DIEs based on qualified name when possible

labath added a comment. Well.. first of let me say that the performance gain is impressive. I wouldn't have expected to gain that much with a relatively simple change. Now, as for the implementation, I have two main questions: - Do we really need the `GetQualifiedNameWithParams` function? My

[Lldb-commits] [PATCH] D129724: [lldb] Remove ELF .zdebug support

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1610 static SectionType GetSectionTypeFromName(llvm::StringRef Name) { if

[Lldb-commits] [PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

sebastian-ne added a comment. This breaks builds when LLVM is included with CMake’s `add_subdirectory`. I think the zstd target needs to be marked as imported. The following patch fixes the problem, although I’m not familiar enough with CMake to know if this is the right way to go: diff --git

[Lldb-commits] [lldb] ac49e90 - jGetLoadedDynamicLibrariesInfos can inspect machos not yet loaded

Author: Jason Molenda Date: 2022-07-14T00:56:14-07:00 New Revision: ac49e9021919d2a356dd10b39888f168736a43b0 URL: https://github.com/llvm/llvm-project/commit/ac49e9021919d2a356dd10b39888f168736a43b0 DIFF: https://github.com/llvm/llvm-project/commit/ac49e9021919d2a356dd10b39888f168736a43b0.diff

[Lldb-commits] [PATCH] D129736: [lldb] Skip a float16 NaN test for RISC-V

Emmmer created this revision. Emmmer added reviewers: MaskRay, liaolucy, craig.topper, DavidSpickett. Emmmer added projects: LLDB, LLDB test suite on simulator. Herald added subscribers: jsji, sunshaoce, VincentWu, luke957, StephenFan, vkmr, luismarques, sameer.abuasal, JDevlieghere, pengfei,