[Lldb-commits] [PATCH] D129814: Fix stepping over watchpoints in architectures that raise the exception before executing the instruction

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D129814#3655878 , @jingham wrote: > In D129814#3654368 , @labath wrote: > >> In D129814#3654276

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov marked an inline comment as done. mizvekov added a comment. @JDevlieghere @teemperor ping. Sorry for the urgency here, but I have a lot of work built on top of this patch. And this patch fixes a bunch of bugs that other people are unaware and duplicating effort, see github issues. Re

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

nikic added a comment. Given that LLVM 15 branches off in one week, maybe it would be better to wait for that before relanding the change, as it seems to have significant impact on plugins? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112374/new/

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. In D112374#3659597 , @nikic wrote: > Given that LLVM 15 branches off in one week, maybe it would be better to wait > for that before relanding the change, as it seems to have significant impact > on plugins? I think it would m

[Lldb-commits] [PATCH] D126615: [lldb] Add an integration test for non-stop protocol

mgorny updated this revision to Diff 445512. mgorny added a comment. Update again ;-). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126615/new/ https://reviews.llvm.org/D126615 Files: lldb/test/Shell/Process/Inputs/signal.c lldb/test/Shell/Process/TestNonStop.test Index: lldb/te

[Lldb-commits] [PATCH] D129807: [LLDB][NativePDB] Add MSInheritanceAttr when completing CXXRecordDecl

rnk added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp:492 if (pr.isPointerToMember()) { MemberPointerInfo mpi = pr.getMemberInfo(); GetOrCreateType(mpi.ContainingType); I think you want to make code c

[Lldb-commits] [PATCH] D129814: Fix stepping over watchpoints in architectures that raise the exception before executing the instruction

jingham updated this revision to Diff 445591. jingham added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129814/new/ https://reviews.llvm.org/D129814 Files: lldb/include/lldb/Breakpoint/Watchpoint.h lldb/inc

[Lldb-commits] [PATCH] D129814: Fix stepping over watchpoints in architectures that raise the exception before executing the instruction

jingham marked 3 inline comments as done. jingham added inline comments. Comment at: lldb/source/Target/StopInfo.cpp:730 +StopInfoWatchpoint *as_wp_stop_info += reinterpret_cast(m_stop_info_sp.get()); +as_wp_stop_info->SetStepOverPlanComplete(); -

[Lldb-commits] [PATCH] D129814: Fix stepping over watchpoints in architectures that raise the exception before executing the instruction

jingham marked an inline comment as done. jingham added a comment. In D129814#3658998 , @labath wrote: > In D129814#3655878 , @jingham wrote: > >> In D129814#3654368 , @la

[Lldb-commits] [PATCH] D128465: [OLD] [llvm] add zstd to `llvm::compression` namespace

MaskRay added a comment. Instead of marking a differential `[OLD] ` (which may confuse readers whether this is to be abandoned), you can mark a differential `Request Reviews`/`Request Changes`. Then it will not be in the green state. I clicked "Reopen" to make it clear the patch hasn't relanded

[Lldb-commits] [PATCH] D128465: [OLD] [llvm] add zstd to `llvm::compression` namespace

ckissane added a comment. In D128465#3660714 , @MaskRay wrote: > Instead of marking a differential `[OLD] ` (which may confuse readers whether > this is to be abandoned), you can mark a differential `Request > Reviews`/`Request Changes`. Then it will no

[Lldb-commits] [PATCH] D128465: [OLD] [llvm] add zstd to `llvm::compression` namespace

MaskRay added a comment. In D128465#3660733 , @ckissane wrote: > In D128465#3660714 , @MaskRay wrote: > >> Instead of marking a differential `[OLD] ` (which may confuse readers >> whether this is to be abandoned)

[Lldb-commits] [PATCH] D130037: [lldb] [gdb-remote] Fix process ID after following forked child

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste, jingham. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Update the process ID after handling fork/vfork to ensure that the process plugin reports the c

[Lldb-commits] [PATCH] D129682: [lldb] Filter DIEs based on qualified name when possible

bulbazord updated this revision to Diff 445629. bulbazord edited the summary of this revision. bulbazord added a comment. I have factored out part of `Module::LookupInfo::Prune` into its own method `Module::LookupInfo::NameMatchesLookupInfo` which I re-use in `ProcessFunctionDIE` instead of copy

[Lldb-commits] [lldb] 5778ada - Make hit point counts reliable for architectures that stop before evaluation.

Author: Jim Ingham Date: 2022-07-18T14:36:32-07:00 New Revision: 5778ada8e54edb2bc2869505b88a959d1915c02f URL: https://github.com/llvm/llvm-project/commit/5778ada8e54edb2bc2869505b88a959d1915c02f DIFF: https://github.com/llvm/llvm-project/commit/5778ada8e54edb2bc2869505b88a959d1915c02f.diff LO

[Lldb-commits] [PATCH] D129814: Fix stepping over watchpoints in architectures that raise the exception before executing the instruction

This revision was automatically updated to reflect the committed changes. Closed by commit rG5778ada8e54e: Make hit point counts reliable for architectures that stop before evaluation. (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [lldb] e83d47f - When the module path for `command script import` is invalid, echo the path.

Author: Jim Ingham Date: 2022-07-18T14:49:07-07:00 New Revision: e83d47f6b7bd2f8dcf419e03b3a00d5db5bd61c4 URL: https://github.com/llvm/llvm-project/commit/e83d47f6b7bd2f8dcf419e03b3a00d5db5bd61c4 DIFF: https://github.com/llvm/llvm-project/commit/e83d47f6b7bd2f8dcf419e03b3a00d5db5bd61c4.diff LO

[Lldb-commits] [PATCH] D129338: Tell the user which pathname was invalid...

This revision was automatically updated to reflect the committed changes. Closed by commit rGe83d47f6b7bd: When the module path for `command script import` is invalid, echo the path. (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D130045: Implement better path matching in FileSpecList::FindFileIndex(...).

clayborg created this revision. clayborg added reviewers: labath, JDevlieghere, jingham, aadsm, yinghuitan. Herald added a subscriber: arphaman. Herald added a project: All. clayborg requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstef

[Lldb-commits] [PATCH] D130045: Implement better path matching in FileSpecList::FindFileIndex(...).

clayborg updated this revision to Diff 445638. clayborg added a comment. Herald added a subscriber: mgorny. Didn't submit all changes at first because I had two commits. Squashed the commits to fix the diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

ckissane added a comment. In D128465#3661049 , @MaskRay wrote: > Does this address the macOS build failure? I believe so! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 445643. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp clang-tools-extra/test/clang-tid

[Lldb-commits] [PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. A few nits about naming, but otherwise this LGTM. Comment at: lldb/tools/lldb-fuzzer/lldb-expression-fuzzer/lldb-expression-fuzzer.cpp:47 +DEFINE_BINARY_PROTO_FU

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov updated this revision to Diff 445646. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112374/new/ https://reviews.llvm.org/D112374 Files: clang-tools-extra/clang-change-namespace/ChangeNamespace.cpp clang-tools-extra/clang-include-fixer/f

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 445648. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp clang-tools-extra/test/clang-tid

[Lldb-commits] [PATCH] D130045: Implement better path matching in FileSpecList::FindFileIndex(...).

clayborg updated this revision to Diff 445650. clayborg added a comment. Add absolute/relative path caching into FileSpec since we will be using it more for breakpoints if this patch gets approved. FileSpecList objects are used by the line table classes and the support file lists don't change.

[Lldb-commits] [PATCH] D130045: Implement better path matching in FileSpecList::FindFileIndex(...).

clayborg added a comment. I added relative/absolute path caching to FileSpec without increasing the size of the FileSpec objects. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130045/new/ https://reviews.llvm.org/D130045 _

[Lldb-commits] [lldb] 555ae5b - This is a followup to https://reviews.llvm.org/D129814

Author: Jim Ingham Date: 2022-07-18T16:24:31-07:00 New Revision: 555ae5b8f5aa93ab090af853a8b7a83f815b3f20 URL: https://github.com/llvm/llvm-project/commit/555ae5b8f5aa93ab090af853a8b7a83f815b3f20 DIFF: https://github.com/llvm/llvm-project/commit/555ae5b8f5aa93ab090af853a8b7a83f815b3f20.diff LO

[Lldb-commits] [PATCH] D130054: [trace][intel pt] Introduce wall clock time for each trace item

wallace created this revision. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. - Decouple TSCs from trace items - Turn TSCs into events just like CPUs - Add a GetWallTime that returns the wall time that

[Lldb-commits] [PATCH] D130054: [trace][intel pt] Introduce wall clock time for each trace item

wallace updated this revision to Diff 445664. wallace edited the summary of this revision. wallace added a comment. Herald added subscribers: jsji, pengfei. fix nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130054/new/ https://reviews.llvm.org

[Lldb-commits] [lldb] 4f5707e - Revert "This is a followup to https://reviews.llvm.org/D129814"

Author: Jim Ingham Date: 2022-07-18T17:37:13-07:00 New Revision: 4f5707e743528a0d40ac154e2e07705a03fd7ad3 URL: https://github.com/llvm/llvm-project/commit/4f5707e743528a0d40ac154e2e07705a03fd7ad3 DIFF: https://github.com/llvm/llvm-project/commit/4f5707e743528a0d40ac154e2e07705a03fd7ad3.diff LO

[Lldb-commits] [lldb] 83fab8c - Revert "Make hit point counts reliable for architectures that stop before evaluation."

Author: Jim Ingham Date: 2022-07-18T17:38:43-07:00 New Revision: 83fab8cee9d6b9fa911195c20325b4512a7a22ef URL: https://github.com/llvm/llvm-project/commit/83fab8cee9d6b9fa911195c20325b4512a7a22ef DIFF: https://github.com/llvm/llvm-project/commit/83fab8cee9d6b9fa911195c20325b4512a7a22ef.diff LO

[Lldb-commits] [PATCH] D128250: [LLDB][RISCV]Add initial support for lldb-server.

Emmmer updated this revision to Diff 445699. Emmmer added a comment. This commit updates: - Add the pc register according to the implementation of gdb - Fix register type definition m