[Lldb-commits] [PATCH] D130320: Move GetControlFlowKind's logic to DisassemblerLLVMC.cpp

persona0220 updated this revision to Diff 446680. persona0220 edited the summary of this revision. persona0220 added a comment. Not to cache the control flow kind CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130320/new/ https://reviews.llvm.org/D130320 Files:

[Lldb-commits] [PATCH] D130320: Move GetControlFlowKind's logic to DisassemblerLLVMC.cpp

persona0220 created this revision. persona0220 added reviewers: wallace, jj10306. Herald added a project: All. persona0220 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This diff move the logic of `GetControlFlowKind()` from

[Lldb-commits] [PATCH] D130312: [LLDB][Reliability] Fix accessing invalid iterator

This revision was automatically updated to reflect the committed changes. Closed by commit rG98186def3f1f: [LLDB][Reliability] Fix accessing invalid iterator (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130312/new/

[Lldb-commits] [lldb] 98186de - [LLDB][Reliability] Fix accessing invalid iterator

Author: Slava Gurevich Date: 2022-07-21T17:39:11-07:00 New Revision: 98186def3f1f6f3862e6c91ca01dfd278ad1929e URL: https://github.com/llvm/llvm-project/commit/98186def3f1f6f3862e6c91ca01dfd278ad1929e DIFF:

[Lldb-commits] [PATCH] D130309: [NFC] Improve FileSpec internal APIs and usage in preparation for adding caching of resolved/absolute.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks Greg, this is a much cleaner API. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130309/new/

[Lldb-commits] [PATCH] D130312: [LLDB][Reliability] Fix accessing invalid iterator

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130312/new/ https://reviews.llvm.org/D130312

[Lldb-commits] [PATCH] D129078: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

jingham accepted this revision. jingham added a comment. This looks good to me. I had a trivial comment about comments. You added a test for the condition in lambda as well, that's great! Comment at: lldb/include/lldb/Expression/Materializer.h:88 + /// \param[in] name

[Lldb-commits] [PATCH] D130312: [LLDB][Reliability] Fix accessing invalid iterator

fixathon created this revision. fixathon added reviewers: clayborg, aadsm, jingham. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Using invalidated vector iterator is at best a UB and could crash

[Lldb-commits] [PATCH] D130045: Implement better path matching in FileSpecList::FindFileIndex(...).

clayborg added a comment. I submitted https://reviews.llvm.org/D130309 to fix issues with FileSpec before I do a separate patch to add caching of the absolute/relative value. This patch is needed so we can control all locations where a string is modified so we can clear the cached value when

[Lldb-commits] [PATCH] D130309: [NFC] Improve FileSpec internal APIs and usage in preparation for adding caching of resolved/absolute.

clayborg created this revision. clayborg added reviewers: labath, JDevlieghere, jingham, aadsm, yinghuitan. Herald added a project: All. clayborg requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a project: LLDB.

[Lldb-commits] [PATCH] D130307: [LLDB][Reliability] Fix register value unpacking

fixathon created this revision. fixathon added reviewers: clayborg, aadsm. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fix incorrect direction for bit-shifting. Coverity warning 1355603

[Lldb-commits] [PATCH] D130285: [lldb] Handle jumping to the end in DW_OP_skip/DW_OP_bra

werat created this revision. werat added reviewers: labath, jingham, jasonmolenda. Herald added a project: All. werat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. DW_OP_skip/DW_OP_bra can move offset to the end of the data, which means

[Lldb-commits] [PATCH] D130054: [trace][intel pt] Introduce wall clock time for each trace item

wallace updated this revision to Diff 446541. wallace added a comment. fix a bug that happens when the initial trace items don't have timing information Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130054/new/ https://reviews.llvm.org/D130054

[Lldb-commits] [PATCH] D130219: [lldb][NFCI] Refactor regex filtering logic in CommandObjectTypeFormatterList

This revision was automatically updated to reflect the committed changes. Closed by commit rGfa3a2e611d84: [lldb][NFCI] Refactor regex filtering logic in CommandObjectTypeFormatterList (authored by jgorbe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] fa3a2e6 - [lldb][NFCI] Refactor regex filtering logic in CommandObjectTypeFormatterList

Author: Jorge Gorbe Moya Date: 2022-07-21T09:22:40-07:00 New Revision: fa3a2e611d84c29ddb3b48afea0ac64ef85b2de9 URL: https://github.com/llvm/llvm-project/commit/fa3a2e611d84c29ddb3b48afea0ac64ef85b2de9 DIFF:

[Lldb-commits] [PATCH] D130219: [lldb][NFCI] Refactor regex filtering logic in CommandObjectTypeFormatterList

jgorbe added inline comments. Comment at: lldb/source/Commands/CommandObjectType.cpp:1064 +// No regex means list everything. +return (regex == nullptr || (s == regex->GetText() || regex->Execute(s))); + } labath wrote: > What's up with all the

[Lldb-commits] [PATCH] D130219: [lldb][NFCI] Refactor regex filtering logic in CommandObjectTypeFormatterList

jgorbe updated this revision to Diff 446532. jgorbe added a comment. Removed unnecessary parentheses. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130219/new/ https://reviews.llvm.org/D130219 Files: lldb/source/Commands/CommandObjectType.cpp Index:

[Lldb-commits] [PATCH] D130037: [lldb] [gdb-remote] Fix process ID after following forked child

This revision was automatically updated to reflect the committed changes. Closed by commit rGb61b8efcf31b: [lldb] [gdb-remote] Fix process ID after following forked child (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] b61b8ef - [lldb] [gdb-remote] Fix process ID after following forked child

Author: Michał Górny Date: 2022-07-21T17:11:38+02:00 New Revision: b61b8efcf31b3d53377b9cf6cb3eb87742602ff6 URL: https://github.com/llvm/llvm-project/commit/b61b8efcf31b3d53377b9cf6cb3eb87742602ff6 DIFF: https://github.com/llvm/llvm-project/commit/b61b8efcf31b3d53377b9cf6cb3eb87742602ff6.diff

[Lldb-commits] [lldb] cd18e2e - [lldb/test] Fix flakyness in TestNonStop.test_stdio

Author: Pavel Labath Date: 2022-07-21T16:53:13+02:00 New Revision: cd18e2ea3f4e87f8804a7d6661d5596ef1f07b81 URL: https://github.com/llvm/llvm-project/commit/cd18e2ea3f4e87f8804a7d6661d5596ef1f07b81 DIFF: https://github.com/llvm/llvm-project/commit/cd18e2ea3f4e87f8804a7d6661d5596ef1f07b81.diff

[Lldb-commits] [PATCH] D130219: [lldb][NFCI] Refactor regex filtering logic in CommandObjectTypeFormatterList

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Commands/CommandObjectType.cpp:1064 +// No regex means list everything. +return (regex == nullptr || (s == regex->GetText() ||

[Lldb-commits] [PATCH] D130213: [LLDB][ClangExpression] Fix initialization of static enum alias members

werat added a comment. In D130213#3668450 , @aprantl wrote: > @werat did you build with assertions enabled? Oh, no, I build in `RelWithDebInfo` out of habit. I've tried with assertions and then it fails. However, when ignoring the asserts the result

[Lldb-commits] [PATCH] D130213: [LLDB][ClangExpression] Fix initialization of static enum alias members

This revision was automatically updated to reflect the committed changes. Closed by commit rG140bcd369b0f: [LLDB][ClangExpression] Fix initialization of static enum alias members (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 140bcd3 - [LLDB][ClangExpression] Fix initialization of static enum alias members

Author: Michael Buch Date: 2022-07-21T14:23:41+01:00 New Revision: 140bcd369b0fd61f19cdeabf4be2fe68d5f9804b URL: https://github.com/llvm/llvm-project/commit/140bcd369b0fd61f19cdeabf4be2fe68d5f9804b DIFF: https://github.com/llvm/llvm-project/commit/140bcd369b0fd61f19cdeabf4be2fe68d5f9804b.diff

[Lldb-commits] [PATCH] D129962: [LLDB][DataFormatter] Add support for std::__map_const_iterator

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6703812688b8: [LLDB][DataFormatter] Add support for std::__map_const_iterator (authored by Michael137). Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] 6703812 - [LLDB][DataFormatter] Add support for std::__map_const_iterator

Author: Michael Buch Date: 2022-07-21T14:21:12+01:00 New Revision: 6703812688b84100a159ec793f677952ea8e3eba URL: https://github.com/llvm/llvm-project/commit/6703812688b84100a159ec793f677952ea8e3eba DIFF: https://github.com/llvm/llvm-project/commit/6703812688b84100a159ec793f677952ea8e3eba.diff

[Lldb-commits] [PATCH] D129962: [LLDB][DataFormatter] Add support for std::__map_const_iterator

Michael137 updated this revision to Diff 446464. Michael137 added a comment. - Add newline to flush printf buffer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129962/new/ https://reviews.llvm.org/D129962 Files:

[Lldb-commits] [PATCH] D130213: [LLDB][ClangExpression] Fix initialization of static enum alias members

Michael137 added a comment. > Though I'm a little confused why the test does find > `ClassWithEnumAlias::enum_alias` despite it not being instantiated in `main` Oh nvm, probably just because clang++ on Darwin invokes dsymutil at the end. Whereas in the test suite we don't unless explicitly

[Lldb-commits] [PATCH] D130213: [LLDB][ClangExpression] Fix initialization of static enum alias members

Michael137 added a comment. In D130213#3668450 , @aprantl wrote: > @werat did you build with assertions enabled? > > This change looks fine to me, but it might be interesting to see where the > discrepancy between the platforms comes from.

[Lldb-commits] [PATCH] D129962: [LLDB][DataFormatter] Add support for std::__map_const_iterator

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/map/main.cpp:30 +intint_map::const_iterator const_it = ii.cbegin(); +

[Lldb-commits] [PATCH] D130213: [LLDB][ClangExpression] Fix initialization of static enum alias members

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. @werat did you build with assertions enabled? This change looks fine to me, but it might be interesting to see where the discrepancy between the platforms comes from.

[Lldb-commits] [PATCH] D130213: [LLDB][ClangExpression] Fix initialization of static enum alias members

Michael137 added a comment. In D130213#3668109 , @werat wrote: > I've tried reproducing the test case with `lldb` built from HEAD on my Linux > machine and it seems to work without your patch: > > ❯ cat ~/src/cpp/const.cc > enum class ScopedEnum {

[Lldb-commits] [PATCH] D130213: [LLDB][ClangExpression] Fix initialization of static enum alias members

werat added a comment. I've tried reproducing the test case with `lldb` built from HEAD on my Linux machine and it seems to work without your patch: ❯ cat ~/src/cpp/const.cc enum class ScopedEnum { scoped_enum_case1 = 1, scoped_enum_case2 = 2, }; struct A { using

[Lldb-commits] [PATCH] D129489: [lldb][AArch64] Add support for memory tags in core files

DavidSpickett added a comment. @labath (or indeed anyone else) any objections to this or the previous patch? Happy to make changes but if it's ok as is I'd like to get it landed before the branch next week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D130213: [LLDB][ClangExpression] Fix evaluation of types with constant initialized enum typedefs

Michael137 updated this revision to Diff 446418. Michael137 added a comment. - Reword commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130213/new/ https://reviews.llvm.org/D130213 Files:

[Lldb-commits] [PATCH] D129489: [lldb][AArch64] Add support for memory tags in core files

omjavaid added a comment. In D129489#3665218 , @DavidSpickett wrote: >> You mean "memory read --show-tags"? The details >> are tested on live processes already but a simple smoke test wouldn't hurt, >> I'll do that. > > I checked and to include the