[Lldb-commits] [lldb] b7c5683 - [lldb] Silence a GCC warning about missing returns after a fully covered switch. NFC.

Author: Martin Storsjö Date: 2022-08-02T10:57:33+03:00 New Revision: b7c5683fac3de2f3349d57b9e133ac53204b1148 URL: https://github.com/llvm/llvm-project/commit/b7c5683fac3de2f3349d57b9e133ac53204b1148 DIFF: https://github.com/llvm/llvm-project/commit/b7c5683fac3de2f3349d57b9e133ac53204b1148.diff

[Lldb-commits] [PATCH] D130972: [LLDB][NFC] Fix LLDB_WATCH_TYPE_IS_VALID macro

fixathon created this revision. fixathon added reviewers: clayborg, aadsm, jingham, JDevlieghere. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. LLDB_WATCH_TYPE_IS_VALID would always return true when v

[Lldb-commits] [PATCH] D130939: [LLDB][NFC] Fix potential div by 0 "count" can be zero potentially causing div by 0

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added a comment. Given that testing packet speed by sending no packets seems pointless, I wonder if this should be asserts on the packet counts instead. If this speed test is something we do as part of connection setup, you'd probably

[Lldb-commits] [PATCH] D130972: [LLDB][NFC] Fix LLDB_WATCH_TYPE_IS_VALID macro

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added a comment. Sometimes you wonder how anything works :) I looked at the places this is used and I don't see a way to reach them from the API without the type already being `LLDB_WATCH_TYPE_READ` or `LLDB_WATCH_TYPE_WRITE`. It's ch

[Lldb-commits] [PATCH] D130929: [LLDB][Reliability] Remove dead code.

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130929/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D129682: [lldb] Filter DIEs based on qualified name when possible

labath added inline comments. Comment at: lldb/source/Core/Module.cpp:740 + bool user_provided_name_is_mangled = + Mangled::GetManglingScheme(m_name.GetStringRef()) != + Mangled::eManglingSchemeNone; bulbazord wrote: > labath wrote: > > labath wrote: >

[Lldb-commits] [lldb] a1bf0c0 - [LLDB] Skip buildbot failures AArch64/Windows

Author: Muhammad Omair Javaid Date: 2022-08-02T16:59:12+05:00 New Revision: a1bf0c08947d54a38cf10fed8e2b88fed2d50e52 URL: https://github.com/llvm/llvm-project/commit/a1bf0c08947d54a38cf10fed8e2b88fed2d50e52 DIFF: https://github.com/llvm/llvm-project/commit/a1bf0c08947d54a38cf10fed8e2b88fed2d50e

[Lldb-commits] [PATCH] D130985: [lldb] Fix TestDeletedExecutable on linux

labath created this revision. labath added a reviewer: DavidSpickett. Herald added subscribers: JDevlieghere, kbarton, nemanjai. Herald added a project: All. labath requested review of this revision. Herald added a project: LLDB. Currently, lldb-server was opening the executable file to determine

[Lldb-commits] [PATCH] D130985: [lldb] Fix TestDeletedExecutable on linux

DavidSpickett added a comment. Tell me if I understand the strategy. If you're on arm64 but the process is actually arm32 and you ask for the general registers, you'll get back something with size < the size you expect for the 64 bit register set. If you're on arm32 then you always assume that

[Lldb-commits] [PATCH] D130985: [lldb] Fix TestDeletedExecutable on linux

labath marked an inline comment as done. labath added a comment. In D130985#3693453 , @DavidSpickett wrote: > Tell me if I understand the strategy. > > If you're on arm64 but the process is actually arm32 and you ask for the > general registers, you'll

[Lldb-commits] [PATCH] D130985: [lldb] Fix TestDeletedExecutable on linux

labath updated this revision to Diff 449282. labath added a comment. rename the size variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130985/new/ https://reviews.llvm.org/D130985 Files: lldb/source/Plugins/Process/Linux/NativeProcessLinux.

[Lldb-commits] [PATCH] D121290: [lldb] Create an enum to specify the kind of ArchSpec matching

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6093a77caf44: [lldb] Create an enum to specify the kind of ArchSpec matching (authored by labath). Changed prior to commit: https://reviews.llvm.o

[Lldb-commits] [lldb] 6093a77 - [lldb] Create an enum to specify the kind of ArchSpec matching

Author: Pavel Labath Date: 2022-08-02T16:20:13+02:00 New Revision: 6093a77caf44aad1bc62056295988d08e13cd421 URL: https://github.com/llvm/llvm-project/commit/6093a77caf44aad1bc62056295988d08e13cd421 DIFF: https://github.com/llvm/llvm-project/commit/6093a77caf44aad1bc62056295988d08e13cd421.diff

[Lldb-commits] [PATCH] D130985: [lldb] Fix TestDeletedExecutable on linux

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130985/new/ https://reviews.llvm.org/D130985 _

[Lldb-commits] [PATCH] D130930: [trace] Add SBTraceCursor bindings

jj10306 marked 13 inline comments as done. jj10306 added inline comments. Comment at: lldb/include/lldb/API/SBTraceCursor.h:166 + /// The specific kind of event the cursor is pointing at, or \b + /// TraceEvent::eTraceEventNone if the cursor not pointing to an event. +

[Lldb-commits] [PATCH] D130930: [trace] Add SBTraceCursor bindings

jj10306 updated this revision to Diff 449289. jj10306 marked 4 inline comments as done. jj10306 added a comment. 1. address comments 2. rebase 3. minor changes to `DecodedThread::GetInstructionLoadAddress` and `DecodedThread::GetErrorByIndex` Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D130805: [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema

jj10306 requested changes to this revision. jj10306 added a comment. Nice work! qq: Do we plan to add this kernel tracing support for live tracing as well? Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp:83 JSONTraceBundleDescription &bundle_description, Ar

[Lldb-commits] [PATCH] D130930: [trace] Add SBTraceCursor bindings

jj10306 added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.cpp:201 lldb::TraceEvent DecodedThread::GetEventByIndex(int item_index) const { + // This currently returns an undefined value when the item isn't an event. return m_item_data[item_in

[Lldb-commits] [PATCH] D130813: Add ability for lldb to load binaries in a process/corefile given only a load address & no dynamic loader

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. A few minor nits but the change looks sound to me. It's great to see the existing code getting unified and nice job on that test. LGTM. Comment at: lldb/source/C

[Lldb-commits] [PATCH] D129614: [lldb/crashlog] Surface error using SBCommandReturnObject argument

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:1012-1015 +def error(message, sb_error=lldb.SBError()): +nonlocal result +result.SetError(sb_error, "error: %s" % message) +return mib wrote: > JDevlieghe

[Lldb-commits] [lldb] d735307 - [LLDB][Reliability] Remove dead code.

Author: Slava Gurevich Date: 2022-08-02T10:09:45-07:00 New Revision: d735307aa2be0ebcc37ddd8d4268635dcd1e9d4e URL: https://github.com/llvm/llvm-project/commit/d735307aa2be0ebcc37ddd8d4268635dcd1e9d4e DIFF: https://github.com/llvm/llvm-project/commit/d735307aa2be0ebcc37ddd8d4268635dcd1e9d4e.diff

[Lldb-commits] [PATCH] D130929: [LLDB][Reliability] Remove dead code.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd735307aa2be: [LLDB][Reliability] Remove dead code. (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130929/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D129682: [lldb] Filter DIEs based on qualified name when possible

bulbazord updated this revision to Diff 449350. bulbazord edited the summary of this revision. bulbazord added a comment. Simplify `Module::LookupInfo::NameMatchesLookupInfo`. Perform an initial check to see if the name matches, and if not, do the more expensive demangling operation. CHANGES S

[Lldb-commits] [PATCH] D131005: [LLDB] Add SBInstruction::GetControlFlowKind()

jj10306 created this revision. jj10306 added reviewers: wallace, persona0220. Herald added a project: All. jj10306 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. D128477 adds the control flow kind for `I

[Lldb-commits] [PATCH] D130805: [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema

wallace added a comment. > qq: Do we plan to add this kernel tracing support for live tracing as well? I think it won't be possible without major changes or at least a big discussion because LLDB is supposed to operated on processes it's debugging, so let's better leave it out of scope for now.

[Lldb-commits] [PATCH] D130805: [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema

wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp:83 JSONTraceBundleDescription &bundle_description, ArrayRef traced_processes, -ArrayRef traced_threads) { +ArrayRef traced_threads, TraceMode trace_mode) { TraceIntelPT

[Lldb-commits] [PATCH] D130930: [trace] Add SBTraceCursor bindings

wallace added inline comments. Comment at: lldb/bindings/interface/SBTraceCursor.i:56 + + explicit operator bool() const; +}; +1 Comment at: lldb/include/lldb/API/SBTraceCursor.h:21 +public: + /// Default constructor for an invalid \a SBTrace

[Lldb-commits] [PATCH] D131005: [LLDB] Add SBInstruction::GetControlFlowKind()

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. great! Comment at: lldb/source/API/SBInstruction.cpp:176 +if (target_sp) { + lock = std::unique_lock(target_sp->GetAPIMutex()); + this might be po

[Lldb-commits] [PATCH] D131013: [LLDB][NFC] Fix incorrect return status Some functions always return 'false' for both success and fail return paths.

fixathon created this revision. fixathon added reviewers: clayborg, aadsm, jingham, JDevlieghere, DavidSpickett. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo ht

[Lldb-commits] [lldb] 0a56927 - [LLDB][NFC] Fix LLDB_WATCH_TYPE_IS_VALID macro

Author: Slava Gurevich Date: 2022-08-02T13:05:29-07:00 New Revision: 0a569274cb3b10401593ebd6eef01b74abbf4504 URL: https://github.com/llvm/llvm-project/commit/0a569274cb3b10401593ebd6eef01b74abbf4504 DIFF: https://github.com/llvm/llvm-project/commit/0a569274cb3b10401593ebd6eef01b74abbf4504.diff

[Lldb-commits] [PATCH] D130972: [LLDB][NFC] Fix LLDB_WATCH_TYPE_IS_VALID macro

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a569274cb3b: [LLDB][NFC] Fix LLDB_WATCH_TYPE_IS_VALID macro (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130972/new/ https://revie

[Lldb-commits] [PATCH] D130813: Add ability for lldb to load binaries in a process/corefile given only a load address & no dynamic loader

jasonmolenda updated this revision to Diff 449413. jasonmolenda added a comment. Update patch to address Jonas' feedback, add a better descriptive comment on what my custom corefile creator in the test case does. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[Lldb-commits] [lldb] d8879fb - Allow firmware binaries to be specified only by load address

Author: Jason Molenda Date: 2022-08-02T13:49:30-07:00 New Revision: d8879fba8825b9799166ba0ea552d4027bfb8ad1 URL: https://github.com/llvm/llvm-project/commit/d8879fba8825b9799166ba0ea552d4027bfb8ad1 DIFF: https://github.com/llvm/llvm-project/commit/d8879fba8825b9799166ba0ea552d4027bfb8ad1.diff

[Lldb-commits] [PATCH] D130813: Add ability for lldb to load binaries in a process/corefile given only a load address & no dynamic loader

This revision was automatically updated to reflect the committed changes. Closed by commit rGd8879fba8825: Allow firmware binaries to be specified only by load address (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130813/n

[Lldb-commits] [PATCH] D131020: Reland "[lldb/Fuzzer] Add fuzzer for expression evaluator"

cassanova created this revision. cassanova added reviewers: JDevlieghere, mib. cassanova added a project: LLDB. Herald added a subscriber: mgorny. Herald added a project: All. cassanova requested review of this revision. Herald added a project: clang. Herald added subscribers: lldb-commits, cfe-com

[Lldb-commits] [lldb] 803386d - Revert "Allow firmware binaries to be specified only by load address"

Author: Jason Molenda Date: 2022-08-02T13:53:34-07:00 New Revision: 803386da2ff80f0a5e75d2baee6dfa79d9d8d26f URL: https://github.com/llvm/llvm-project/commit/803386da2ff80f0a5e75d2baee6dfa79d9d8d26f DIFF: https://github.com/llvm/llvm-project/commit/803386da2ff80f0a5e75d2baee6dfa79d9d8d26f.diff

[Lldb-commits] [PATCH] D130939: [LLDB][NFC] Fix potential div by 0 "count" can be zero potentially causing div by 0

fixathon added a comment. The function has a void return type, with no way to communicate its success/failure status. Perhaps the right thing to do is to mod the function to return error Status, in addition to adding the assert (or some runtime check that works for all build flavors)? ==

[Lldb-commits] [PATCH] D131013: [LLDB][NFC] Fix incorrect return status Some functions always return 'false' for both success and fail return paths.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Neat. LGMT! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131013/new/ https://reviews.llvm.org/D131013

[Lldb-commits] [PATCH] D131020: Reland "[lldb/Fuzzer] Add fuzzer for expression evaluator"

JDevlieghere added inline comments. Comment at: lldb/tools/lldb-fuzzer/lldb-expression-fuzzer/CMakeLists.txt:51-56 +add_custom_target(fuzz-lldb-expression + COMMENT "Running the LLDB expression evaluator fuzzer..." + WORKING_DIRECTORY ${CMAKE_BINARY_DIR}/fuzzer-art

[Lldb-commits] [lldb] 96d1218 - Allow firmware binaries to be specified only by load address

Author: Jason Molenda Date: 2022-08-02T14:14:16-07:00 New Revision: 96d12187b3d28f63d29802a7af49dfe53cc306f3 URL: https://github.com/llvm/llvm-project/commit/96d12187b3d28f63d29802a7af49dfe53cc306f3 DIFF: https://github.com/llvm/llvm-project/commit/96d12187b3d28f63d29802a7af49dfe53cc306f3.diff

[Lldb-commits] [PATCH] D130803: [lldb] Allow SymbolTable regex search functions to match mangled name

augusto2112 updated this revision to Diff 449440. augusto2112 added a comment. Added test and updated functions to use Mangled::NamePreference instead of a bool Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130803/new/ https://reviews.llvm.org/D13

[Lldb-commits] [lldb] 318454a - Inline my uuid_is_null() implementation in a header file

Author: Jason Molenda Date: 2022-08-02T14:24:11-07:00 New Revision: 318454a8e5fce57a92573f42e39f148adcedc5d4 URL: https://github.com/llvm/llvm-project/commit/318454a8e5fce57a92573f42e39f148adcedc5d4 DIFF: https://github.com/llvm/llvm-project/commit/318454a8e5fce57a92573f42e39f148adcedc5d4.diff

[Lldb-commits] [PATCH] D130803: [lldb] Allow SymbolTable regex search functions to match mangled name

JDevlieghere added inline comments. Comment at: lldb/test/Shell/Symtab/Inputs/t.yaml:60 +reserved3: 0x0 +content: 01001C00010020002202983E38003800FD3E380003000C0006002400040

[Lldb-commits] [PATCH] D130805: [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema

persona0220 updated this revision to Diff 449442. persona0220 marked 15 inline comments as done. persona0220 added a comment. - Remove duplicate files under `lldb/test/API/commands/trace/intelpt-kernel-trace` and use relative path to `../intelpt-multi-core-trace/` - Update TraceIntelBundleSaver

[Lldb-commits] [PATCH] D130805: [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema

persona0220 updated this revision to Diff 449447. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130805/new/ https://reviews.llvm.org/D130805 Files: lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.h lldb/source/Plugins/Trace/intel-

[Lldb-commits] [PATCH] D130805: [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema

persona0220 marked 7 inline comments as done. persona0220 added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPTConstants.h:25 const bool kDefaultDisableCgroupFiltering = false; +const uint64_t kDefaultKernelLoadAddress = 0x8100; ---

[Lldb-commits] [PATCH] D130805: [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema

persona0220 updated this revision to Diff 449452. persona0220 marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130805/new/ https://reviews.llvm.org/D130805 Files: lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp lldb/source/Plugins/Trace/intel-pt/Tra

[Lldb-commits] [PATCH] D131025: Document why test is disabled on macos ventura

aprantl created this revision. aprantl added reviewers: JDevlieghere, jasonmolenda. Herald added a project: All. aprantl requested review of this revision. Starting with macOS 13 CoreFoundation pulls in Foundation. rdar://96224141 https://reviews.llvm.org/D131025 Files: lldb/test/API/lang/ob

[Lldb-commits] [PATCH] D131025: Document why test is disabled on macos ventura

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131025/new/ https://reviews.llvm.org/D131025 ___ lldb-commits mail

[Lldb-commits] [PATCH] D130803: [lldb] Allow SymbolTable regex search functions to match mangled name

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130803/new/ https://reviews.llvm.org/D130803 ___

[Lldb-commits] [PATCH] D130930: [trace] Add SBTraceCursor bindings

jj10306 updated this revision to Diff 449461. jj10306 marked 4 inline comments as done. jj10306 added a comment. Revert changes to DecodedThread trace item getter API's Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130930/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D130930: [trace] Add SBTraceCursor bindings

jj10306 updated this revision to Diff 449462. jj10306 added a comment. nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130930/new/ https://reviews.llvm.org/D130930 Files: lldb/bindings/interface/SBTrace.i lldb/bindings/interface/SBTraceCurso

[Lldb-commits] [lldb] 6cbc6e9 - [LLDB] Add SBInstruction::GetControlFlowKind()

Author: Jakob Johnson Date: 2022-08-02T15:42:45-07:00 New Revision: 6cbc6e9a6d5f0ef9c406f718dd0c3e6dd6dffeef URL: https://github.com/llvm/llvm-project/commit/6cbc6e9a6d5f0ef9c406f718dd0c3e6dd6dffeef DIFF: https://github.com/llvm/llvm-project/commit/6cbc6e9a6d5f0ef9c406f718dd0c3e6dd6dffeef.diff

[Lldb-commits] [PATCH] D131005: [LLDB] Add SBInstruction::GetControlFlowKind()

This revision was automatically updated to reflect the committed changes. jj10306 marked an inline comment as done. Closed by commit rG6cbc6e9a6d5f: [LLDB] Add SBInstruction::GetControlFlowKind() (authored by jj10306). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[Lldb-commits] [lldb] 4502e35 - [LLDB][NFC] Fix incorrect return status Some functions always return 'false' for both success and fail return paths.

Author: Slava Gurevich Date: 2022-08-02T15:56:23-07:00 New Revision: 4502e3531f623c47e71d3a159580a72560b90954 URL: https://github.com/llvm/llvm-project/commit/4502e3531f623c47e71d3a159580a72560b90954 DIFF: https://github.com/llvm/llvm-project/commit/4502e3531f623c47e71d3a159580a72560b90954.diff

[Lldb-commits] [PATCH] D131013: [LLDB][NFC] Fix incorrect return status Some functions always return 'false' for both success and fail return paths.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4502e3531f62: [LLDB][NFC] Fix incorrect return status Some functions always return 'false'… (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [lldb] c7bd61d - Revert "[lldb][modules] Disable Clang Modules in source/Host directory on macOS"

Author: Jonas Devlieghere Date: 2022-08-02T16:14:02-07:00 New Revision: c7bd61d4a79b88dbd97028bb0a73a73b2d6aca89 URL: https://github.com/llvm/llvm-project/commit/c7bd61d4a79b88dbd97028bb0a73a73b2d6aca89 DIFF: https://github.com/llvm/llvm-project/commit/c7bd61d4a79b88dbd97028bb0a73a73b2d6aca89.d

[Lldb-commits] [PATCH] D131029: [NFC] Remove no-op code, duplicated, with multiple confusing comments, from x86AssemblyInspectionEngine::jmp_to_reg_p

jasonmolenda created this revision. jasonmolenda added a reviewer: fixathon. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. Thanks to @fixathon for ca

[Lldb-commits] [PATCH] D131029: [NFC] Remove no-op code, duplicated, with multiple confusing comments, from x86AssemblyInspectionEngine::jmp_to_reg_p

fixathon accepted this revision. fixathon added a comment. This revision is now accepted and ready to land. LGTM Thanks for fixing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131029/new/ https://reviews.llvm.org/D131029 ___

[Lldb-commits] [PATCH] D129614: [lldb/crashlog] Surface error using SBCommandReturnObject argument

mib updated this revision to Diff 449472. mib added a comment. Address @JDevlieghere comments: - Use exception approach / Remove `error` helper function - Add test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129614/new/ https://reviews.llvm.org/D129614 Files: lldb/examples/python/

[Lldb-commits] [lldb] 63725eb - [NFC] Remove no-op code from x86AssemblyInspectionEngine::jmp_to_reg_p

Author: Jason Molenda Date: 2022-08-02T16:28:10-07:00 New Revision: 63725ebc182d7955c569be94b845b93d14374def URL: https://github.com/llvm/llvm-project/commit/63725ebc182d7955c569be94b845b93d14374def DIFF: https://github.com/llvm/llvm-project/commit/63725ebc182d7955c569be94b845b93d14374def.diff

[Lldb-commits] [PATCH] D131029: [NFC] Remove no-op code, duplicated, with multiple confusing comments, from x86AssemblyInspectionEngine::jmp_to_reg_p

This revision was automatically updated to reflect the committed changes. Closed by commit rG63725ebc182d: [NFC] Remove no-op code from x86AssemblyInspectionEngine::jmp_to_reg_p (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D131032: [lldb/crashlog] Update frame regex matcher

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch updates the regular expression matching stackframes in crashlog to allow addresses that

[Lldb-commits] [PATCH] D130805: [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. just some minor cosmetic changes :) Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleLoader.cpp:177-184 + if (bundle_description.kernel->load_ad

[Lldb-commits] [PATCH] D130930: [trace] Add SBTraceCursor bindings

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. yaay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130930/new/ https://reviews.llvm.org/D130930 _

[Lldb-commits] [PATCH] D130805: [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema

wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPTConstants.h:26 +const lldb::addr_t kDefaultKernelLoadAddress = 0x8100; +const lldb::pid_t kDefaultKernelProcessID = 1; mention that github link here CHANGES

[Lldb-commits] [PATCH] D130805: [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema

persona0220 updated this revision to Diff 449481. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130805/new/ https://reviews.llvm.org/D130805 Files: lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.h lldb/source/Plugins/Trace/intel-

[Lldb-commits] [PATCH] D131033: [lldb/crashlog] Fix parsing issue with `procPath`

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch checks that the `procPath` key exists in the crashlog data before using it. In can happe

[Lldb-commits] [PATCH] D130803: [lldb] Allow SymbolTable regex search functions to match mangled name

augusto2112 updated this revision to Diff 449483. augusto2112 added a comment. Removed __unwind_info and __eh_frame sections from test yaml file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130803/new/ https://reviews.llvm.org/D130803 Files: l

[Lldb-commits] [lldb] f9b4ea0 - [trace] Add SBTraceCursor bindings

Author: Jakob Johnson Date: 2022-08-02T16:55:33-07:00 New Revision: f9b4ea0ce9efb4132a75551c40b2efc049e5b9f7 URL: https://github.com/llvm/llvm-project/commit/f9b4ea0ce9efb4132a75551c40b2efc049e5b9f7 DIFF: https://github.com/llvm/llvm-project/commit/f9b4ea0ce9efb4132a75551c40b2efc049e5b9f7.diff

[Lldb-commits] [PATCH] D130930: [trace] Add SBTraceCursor bindings

This revision was automatically updated to reflect the committed changes. Closed by commit rGf9b4ea0ce9ef: [trace] Add SBTraceCursor bindings (authored by jj10306). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130930/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D131036: [lldb/crashlog] Add `-s|--skip-status` option to interactive mode

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch introduces a new option for the interactive crashlog mode, that will prevent it from dum

[Lldb-commits] [PATCH] D129611: [lldb/crashlog] Add '-t|--target' option to interactive mode

mib updated this revision to Diff 449495. mib added a comment. Make lit run command more readable CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129611/new/ https://reviews.llvm.org/D129611 Files: lldb/examples/python/crashlog.py lldb/examples/python/scripted_process/crashlog_script

[Lldb-commits] [PATCH] D131038: [lldb/crashlog] Skip null image dsym fetching on interactive mode

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. Sometimes, it can happen that a crash report has null images in its list of used binaries. This man

[Lldb-commits] [PATCH] D129603: [lldb/crashlog] Fix interactive crashlog test

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129603/new/ https://reviews.llvm.org/D129603 ___ lldb-commits mailing list

[Lldb-commits] [lldb] d8602bc - fix f9b4ea0ce9efb4132a75551c40b2efc049e5b9f7

Author: Walter Erquinigo Date: 2022-08-02T19:23:28-07:00 New Revision: d8602bcdfa653d1beef1070a8ce7bb8a77bb316e URL: https://github.com/llvm/llvm-project/commit/d8602bcdfa653d1beef1070a8ce7bb8a77bb316e DIFF: https://github.com/llvm/llvm-project/commit/d8602bcdfa653d1beef1070a8ce7bb8a77bb316e.di

[Lldb-commits] [PATCH] D131038: [lldb/crashlog] Skip null image dsym fetching on interactive mode

jasonmolenda added inline comments. Comment at: lldb/examples/python/scripted_process/crashlog_scripted_process.py:28 if image not in self.loaded_images: +if image.uuid == uuid.UUID(int=0): +print(f"Note: S

[Lldb-commits] [lldb] d179ea1 - [NFC][trace] format source files

Author: Walter Erquinigo Date: 2022-08-02T21:16:31-07:00 New Revision: d179ea12fd3186690cb9c630be03ab98b42c5448 URL: https://github.com/llvm/llvm-project/commit/d179ea12fd3186690cb9c630be03ab98b42c5448 DIFF: https://github.com/llvm/llvm-project/commit/d179ea12fd3186690cb9c630be03ab98b42c5448.di