[Lldb-commits] [PATCH] D131919: Move googletest to the third-party directory

probinson added a comment. In D131919#3749850 , @Meinersbur wrote: > Semi-OT: `polly\lib\External` has 3 more third-party libraries. Two of them > have been heavily modified in-tree, the third has just a custom > CMakeLists.txt. > Should these

[Lldb-commits] [lldb] 6f88388 - [lldb][test] Fix nullptr test expctation for 32-bit system

Author: Adrian Vogelsgesang Date: 2022-08-25T17:11:57-07:00 New Revision: 6f88388f61327b375112e76ff4b80741a1b349cb URL: https://github.com/llvm/llvm-project/commit/6f88388f61327b375112e76ff4b80741a1b349cb DIFF:

[Lldb-commits] [PATCH] D132148: [lldb][docs] Add documentation for LLDB fuzzers

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM modulo inline comment. Comment at: lldb/docs/resources/fuzzing.rst:15-17 + $ -DLLVM_USE_SANITIZER='Address' + $ -DLLVM_USE_SANITIZE_COVERAGE=On + $

[Lldb-commits] [PATCH] D132642: [lldb] Fix dotest argument order

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/test/API/CMakeLists.txt:166 +set(LLDB_TEST_COMMON_ARGS ${LLDB_TEST_COMMON_ARGS_VAR} CACHE INTERNAL STRING) + fdeazeve

[Lldb-commits] [lldb] e360281 - [lldb] Computer the slide when and apply it to each fileset's vm addr

Author: Jonas Devlieghere Date: 2022-08-25T16:38:01-07:00 New Revision: e360281fa710a6e637667e6d70aa9e3919214b0f URL: https://github.com/llvm/llvm-project/commit/e360281fa710a6e637667e6d70aa9e3919214b0f DIFF:

[Lldb-commits] [PATCH] D132710: [lldb] Computer and apply the slide to the fileset entry's vmaddr

This revision was automatically updated to reflect the committed changes. Closed by commit rGe360281fa710: [lldb] Computer the slide when and apply it to each filesets vm addr (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D132710: [lldb] Computer and apply the slide to the fileset entry's vmaddr

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132710/new/ https://reviews.llvm.org/D132710 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D132709: [lldb][ClangExpression] Fix LLDB_LOG incorrect format specifier

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132709/new/ https://reviews.llvm.org/D132709

[Lldb-commits] [PATCH] D132710: [lldb] Computer and apply the slide to the fileset entry's vmaddr

JDevlieghere created this revision. JDevlieghere added a reviewer: jasonmolenda. Herald added a project: All. JDevlieghere requested review of this revision. Computer and apply the slide to the fileset entry's vmaddr when reading a fileset from memory. https://reviews.llvm.org/D132710 Files:

[Lldb-commits] [PATCH] D132709: [lldb][ClangExpression] Fix LLDB_LOG incorrect format specifier

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Previously this would log: FindExternalLexicalDecls on

[Lldb-commits] [lldb] 48506fb - [lldb] Teach LLDB about Mach-O filesets

Author: Jonas Devlieghere Date: 2022-08-25T15:24:51-07:00 New Revision: 48506fbbbf2732d9fc1fa75970a132450a1c1e20 URL: https://github.com/llvm/llvm-project/commit/48506fbbbf2732d9fc1fa75970a132450a1c1e20 DIFF:

[Lldb-commits] [PATCH] D132433: [lldb] Teach LLDB about filesets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG48506fbbbf27: [lldb] Teach LLDB about Mach-O filesets (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D132433: [lldb] Teach LLDB about filesets

JDevlieghere updated this revision to Diff 455725. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. I added the ability to call `ObjectContainer::FindPlugin` which allows you to create a Mach-O fileset from memory without actually having to know it's a fileset. I

[Lldb-commits] [lldb] 613336d - Don't index the skeleton CU when we have a fission compile unit.

Author: Greg Clayton Date: 2022-08-25T14:48:04-07:00 New Revision: 613336da8ce16bd2e998e77e02eaf5866ad7e311 URL: https://github.com/llvm/llvm-project/commit/613336da8ce16bd2e998e77e02eaf5866ad7e311 DIFF: https://github.com/llvm/llvm-project/commit/613336da8ce16bd2e998e77e02eaf5866ad7e311.diff

[Lldb-commits] [PATCH] D131437: Don't index the skeleton CU when we have a fission compile unit.

This revision was automatically updated to reflect the committed changes. Closed by commit rG613336da8ce1: Dont index the skeleton CU when we have a fission compile unit. (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D132642: [lldb] Fix dotest argument order

fdeazeve added inline comments. Comment at: lldb/test/API/CMakeLists.txt:166 +set(LLDB_TEST_COMMON_ARGS ${LLDB_TEST_COMMON_ARGS_VAR} CACHE INTERNAL STRING) + JDevlieghere wrote: > Instead of having two variables, why not move this to line 40 and make >

[Lldb-commits] [PATCH] D132642: [lldb] Fix dotest argument order

JDevlieghere added inline comments. Comment at: lldb/test/API/CMakeLists.txt:166 +set(LLDB_TEST_COMMON_ARGS ${LLDB_TEST_COMMON_ARGS_VAR} CACHE INTERNAL STRING) + Instead of having two variables, why not move this to line 40 and make `LLDB_TEST_COMMON_ARGS` a

[Lldb-commits] [PATCH] D132694: [lldb] Quietly source lit-lldb-init

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132694/new/ https://reviews.llvm.org/D132694

[Lldb-commits] [PATCH] D132694: [lldb] Quietly source lit-lldb-init

kastiglione created this revision. kastiglione added a reviewer: JDevlieghere. Herald added a subscriber: mgorny. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Improve utility of `FileCheck`

[Lldb-commits] [PATCH] D131919: Move googletest to the third-party directory

Meinersbur added a comment. Semi-OT: `polly\lib\External` has 3 more third-party libraries. Two of them have been heavily modified in-tree, the third has just a custom CMakeLists.txt. Should these eventually also be moved? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D132433: [lldb] Teach LLDB about filesets

jasonmolenda accepted this revision. jasonmolenda added a comment. In D132433#3747948 , @jasonmolenda wrote: > `Process::ReadModuleFromMemory()` takes a FileSpec and header address in > memory (and a size to read, default 512 bytes). It calls through

[Lldb-commits] [PATCH] D131919: Move googletest to the third-party directory

probinson added inline comments. Comment at: clang/CMakeLists.txt:106 AND EXISTS ${UNITTEST_DIR}/CMakeLists.txt) add_subdirectory(${UNITTEST_DIR} utils/unittest) endif() Should this be `third-party/unittest` ? Looking at how the lldb

Re: [Lldb-commits] [PATCH] D132624: [LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`

> On Aug 25, 2022, at 8:11 AM, Pavel Labath via Phabricator via lldb-commits > wrote: > > labath added a comment. > > In D132624#3748434 , @avogelsgesang > wrote: > >>> The only concern is that if it would be not so easy to read if there are >>>

[Lldb-commits] [PATCH] D132624: [LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`

avogelsgesang added a comment. > leads me to believe that the data formatter is creating the synthetic > children as non pointer objects (e.g. by automatically dereferencing any > nested pointers), even though the structures clearly contain some pointers > inside Yes, that is correct. The

[Lldb-commits] [PATCH] D132624: [LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`

labath added a comment. In D132624#3748434 , @avogelsgesang wrote: >> The only concern is that if it would be not so easy to read if there are too >> many levels? (Consider the 30levels example in D132451 >> ). If it

[Lldb-commits] [PATCH] D132642: [lldb] Fix dotest argument order

fdeazeve updated this revision to Diff 455588. fdeazeve edited the summary of this revision. fdeazeve added a comment. Updated review message with the latest edits to the commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132642/new/

[Lldb-commits] [PATCH] D132642: [lldb] Fix dotest argument order

fdeazeve updated this revision to Diff 455585. fdeazeve added a comment. Added missing files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132642/new/ https://reviews.llvm.org/D132642 Files: lldb/test/API/CMakeLists.txt

[Lldb-commits] [PATCH] D132642: [lldb] Fix dotest argument order

fdeazeve updated this revision to Diff 455531. fdeazeve added a comment. Herald added a subscriber: JDevlieghere. Fix commit message typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132642/new/ https://reviews.llvm.org/D132642 Files:

[Lldb-commits] [PATCH] D132642: [lldb] Fix dotest argument order

fdeazeve created this revision. Herald added a subscriber: mgorny. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When running LLDB API tests, a user can override test arguments with the

[Lldb-commits] [PATCH] D132598: [lldb] Add more dylib paths for exception breakpoints

This revision was automatically updated to reflect the committed changes. Closed by commit rGbaeb17cdfa4b: [lldb] Add more dylib paths for exception breakpoints (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132598/new/

[Lldb-commits] [lldb] baeb17c - [lldb] Add more dylib paths for exception breakpoints

Author: Felipe de Azevedo Piovezan Date: 2022-08-25T06:46:04-04:00 New Revision: baeb17cdfa4bba8985ebb9809edf7eb82c636bc4 URL: https://github.com/llvm/llvm-project/commit/baeb17cdfa4bba8985ebb9809edf7eb82c636bc4 DIFF:

[Lldb-commits] [PATCH] D132598: [lldb] Add more dylib paths for exception breakpoints

fdeazeve added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp:457 +filter_modules.EmplaceBack("libc++abi.1.0.dylib"); +filter_modules.EmplaceBack("libc++abi.1.dylib"); } aprantl

[Lldb-commits] [lldb] 14d5ae2 - [lldb][nfc] Remove unused makefile test variables

Author: Felipe de Azevedo Piovezan Date: 2022-08-25T06:39:01-04:00 New Revision: 14d5ae2038b58830f0565980e20fe0bfd683fb54 URL: https://github.com/llvm/llvm-project/commit/14d5ae2038b58830f0565980e20fe0bfd683fb54 DIFF:

[Lldb-commits] [PATCH] D132596: [lldb][nfc] Remove unused makefile test variables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG14d5ae2038b5: [lldb][nfc] Remove unused makefile test variables (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D132596: [lldb][nfc] Remove unused makefile test variables

fdeazeve updated this revision to Diff 455523. fdeazeve added a comment. Fixed typo in commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132596/new/ https://reviews.llvm.org/D132596 Files:

[Lldb-commits] [PATCH] D132624: [LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`

ChuanqiXu added a comment. In D132624#3748434 , @avogelsgesang wrote: >> The only concern is that if it would be not so easy to read if there are too >> many levels? (Consider the 30levels example in D132451 >> ). If

[Lldb-commits] [PATCH] D132624: [LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`

avogelsgesang added a comment. > The only concern is that if it would be not so easy to read if there are too > many levels? (Consider the 30levels example in D132451 > ). If it would be better to print ... at > certain level? Or this is already handled by

[Lldb-commits] [lldb] 9427487 - [lldb][Test] Prevent generating DW_AT_location for unused argument

Author: Michael Buch Date: 2022-08-25T08:49:13+01:00 New Revision: 9427487fdbb24df148caba7f9b2f87146e5b40ec URL: https://github.com/llvm/llvm-project/commit/9427487fdbb24df148caba7f9b2f87146e5b40ec DIFF: https://github.com/llvm/llvm-project/commit/9427487fdbb24df148caba7f9b2f87146e5b40ec.diff

[Lldb-commits] [PATCH] D132635: [lldb][Test] Prevent generating DW_AT_location for unused argument

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9427487fdbb2: [lldb][Test] Prevent generating DW_AT_location for

[Lldb-commits] [PATCH] D132635: [lldb][Test] Prevent generating DW_AT_location for unused argument

Michael137 updated this revision to Diff 455491. Michael137 added a comment. Herald added a subscriber: JDevlieghere. - clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132635/new/ https://reviews.llvm.org/D132635 Files:

[Lldb-commits] [PATCH] D132635: [lldb][Test] Prevent generating DW_AT_location for unused argument

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This test simply checks whether we can print an optimized function argument.