[Lldb-commits] [PATCH] D138060: Improve error logging when xcrun fails to execute successfully

aprantl updated this revision to Diff 478762. aprantl added a comment. Herald added a subscriber: fedor.sergeev. Don't introduce a Host->Core dependency. Cache the errors and remove Progress reports (since they also depend on Core). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138060/n

[Lldb-commits] [PATCH] D138960: [lldb] Enable use of dummy target from dwim-print

kastiglione created this revision. kastiglione added reviewers: jingham, labath. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Allow `dwim-print` to evaluate expressions using the dummy target if n

[Lldb-commits] [PATCH] D138724: [lldb][Target] Flush the scratch TypeSystem when process gets deleted

aprantl added inline comments. Comment at: lldb/source/Target/Target.cpp:207 +// E.g., this could happen on rebuild & relaunch +// of the debugee. +m_scratch_type_system_map.Clear(); Not opposed to this, but this is leaking an implementation detail of

[Lldb-commits] [PATCH] D138558: [lldb][DataFormatter] Add std::ranges::ref_view formatter

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Small nitpicks, otherwise good! Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxxRangesRefView.cpp:41 +private: + lldb::ValueObjectSP m_range_sp = nullptr; ///< Po

[Lldb-commits] [PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

cjdb added a comment. > though I find myself wondering if the "FormatDiagnostic" call should stay the > same, and choose the legacy-reason only when a sarif reason doesn't exist? Or > for some level of command line control? Hmm... isn't this the point of the diagnostic consumers? Repository:

[Lldb-commits] [PATCH] D137900: Make only one function that needs to be implemented when searching for types.

aprantl added a comment. I think the ` void FindTypes(const TypeQuery &query, TypeResults &results);` API looks like a reasonable compromise. I have a bunch of smaller questions inside, but otherwise I think this can work. Comment at: lldb/include/lldb/Core/Module.h:435 + //

[Lldb-commits] [PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

cjdb added a comment. > The clang-side interface to this seems a touch clunky, and I fear it'll make > continuing its use/generalizing its use less likely. Is this w.r.t. the `FormatDiagnostic` being split up, or is it something else? If it's the former: I'll be changing that to `FormatLegacyDi

[Lldb-commits] [PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

cjdb added a comment. I don't understand why `test_demangle.pass.cpp` was considered too big to upload. Here's the diff: diff --git a/libcxxabi/test/test_demangle.pass.cpp b/libcxxabi/test/test_demangle.pass.cpp index dce8e6c3..9da6fb7d2ad9 100644 --- a/libcxxabi/test/test_demangle.pa

[Lldb-commits] [PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

erichkeane added a comment. Herald added subscribers: Michael137, JDevlieghere. A few comments. I don't mind the approach, though I find myself wondering if the "FormatDiagnostic" call should stay the same, and choose the legacy-reason only when a sarif reason doesn't exist? Or for some level

[Lldb-commits] [PATCH] D138315: [lldb] Introduce dwim-print command

This revision was automatically updated to reflect the committed changes. Closed by commit rG185d4964a158: [lldb] Introduce dwim-print command (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138315/new/ https://reviews.llvm.

[Lldb-commits] [lldb] 185d496 - [lldb] Introduce dwim-print command

Author: Dave Lee Date: 2022-11-29T12:46:20-08:00 New Revision: 185d4964a1584cedc3385adb4d6ed863c71f6515 URL: https://github.com/llvm/llvm-project/commit/185d4964a1584cedc3385adb4d6ed863c71f6515 DIFF: https://github.com/llvm/llvm-project/commit/185d4964a1584cedc3385adb4d6ed863c71f6515.diff LOG:

[Lldb-commits] [PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

cjdb created this revision. cjdb added reviewers: aaron.ballman, erichkeane, shafik. Herald added subscribers: carlosgalvezp, kadircet, arphaman. Herald added a reviewer: njames93. Herald added projects: Flang, All. cjdb requested review of this revision. Herald added subscribers: cfe-commits, libc

[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

arphaman added a comment. Herald added a reviewer: njames93. Hi @mizvekov. This change has caused a failure in Clang's stage 2 CI on the green dragon Darwin CI: https://green.lab.llvm.org/green/job/clang-stage2-Rthinlto/6390/console. Assertion failed: (lvaluePath->getType() == elemTy && "Une

[Lldb-commits] [PATCH] D138724: [lldb][Target] Flush the scratch TypeSystem when process gets deleted

kastiglione added inline comments. Comment at: lldb/source/Target/Target.cpp:208 +// of the debugee. +m_scratch_type_system_map.Clear(); m_process_sp.reset(); Do we have some place in the life-cycle where we can perform this only if the target has c

[Lldb-commits] [PATCH] D138879: [lldb] Make SWIG an autodetected depenency

This revision was automatically updated to reflect the committed changes. Closed by commit rGb3c978e850d3: [lldb] Make SWIG an auto-detected dependency (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [lldb] b3c978e - [lldb] Make SWIG an auto-detected dependency

Author: Jonas Devlieghere Date: 2022-11-29T09:07:11-08:00 New Revision: b3c978e850d374438697f8b79b5e28ab51310068 URL: https://github.com/llvm/llvm-project/commit/b3c978e850d374438697f8b79b5e28ab51310068 DIFF: https://github.com/llvm/llvm-project/commit/b3c978e850d374438697f8b79b5e28ab51310068.d

[Lldb-commits] [PATCH] D129898: [test] Allow libc++ namespaces besides `__1`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7d26f9e1329f: [test] Allow libc++ namespaces besides `__1` (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 7d26f9e - [test] Allow libc++ namespaces besides `__1`

Author: Jordan Rupprecht Date: 2022-11-29T04:34:40-08:00 New Revision: 7d26f9e1329f981ed43eb31f66891702de2f6470 URL: https://github.com/llvm/llvm-project/commit/7d26f9e1329f981ed43eb31f66891702de2f6470 DIFF: https://github.com/llvm/llvm-project/commit/7d26f9e1329f981ed43eb31f66891702de2f6470.di

[Lldb-commits] [PATCH] D138850: [test] Implement layout for unstable std::string garbage formatter tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c10e9c77332: [test] Implement layout for unstable std::string garbage formatter tests. (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [lldb] 3c10e9c - [test] Implement layout for unstable std::string garbage formatter tests.

Author: Jordan Rupprecht Date: 2022-11-29T04:22:30-08:00 New Revision: 3c10e9c77332ad0472d8641a62b8faf76deef0bf URL: https://github.com/llvm/llvm-project/commit/3c10e9c77332ad0472d8641a62b8faf76deef0bf DIFF: https://github.com/llvm/llvm-project/commit/3c10e9c77332ad0472d8641a62b8faf76deef0bf.di

[Lldb-commits] [lldb] cd02e78 - [NFC] Make headers self-contained.

Author: Jordan Rupprecht Date: 2022-11-29T04:14:55-08:00 New Revision: cd02e78cd5cdfa079f2a82f34fea25bee1ae02da URL: https://github.com/llvm/llvm-project/commit/cd02e78cd5cdfa079f2a82f34fea25bee1ae02da DIFF: https://github.com/llvm/llvm-project/commit/cd02e78cd5cdfa079f2a82f34fea25bee1ae02da.di

[Lldb-commits] [PATCH] D138310: [NFC] Make headers self-contained.

This revision was automatically updated to reflect the committed changes. rupprecht marked an inline comment as done. Closed by commit rGcd02e78cd5cd: [NFC] Make headers self-contained. (authored by rupprecht). Changed prior to commit: https://reviews.llvm.org/D138310?vs=476502&id=478515#toc R

[Lldb-commits] [PATCH] D138310: [NFC] Make headers self-contained.

rupprecht marked an inline comment as done. rupprecht added inline comments. Comment at: lldb/source/Plugins/Instruction/RISCV/RISCVInstructions.h:15 -#include "EmulateInstructionRISCV.h" #include "llvm/ADT/Optional.h" MaskRay wrote: > I assume that this is co

[Lldb-commits] [PATCH] D138892: [DataFormatter] Fix variant npos with `_LIBCPP_ABI_VARIANT_INDEX_TYPE_OPTIMIZATION` enabled.

rupprecht updated this revision to Diff 478507. rupprecht added a comment. - Add comment about choice of 300 types - Use fixed-width types Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138892/new/ https://reviews.llvm.org/D138892 Files: lldb/sou

[Lldb-commits] [lldb] 6335deb - [lldb/test] Use SBPlatform info for lldbplatformutil.getPlatform()

Author: Pavel Labath Date: 2022-11-29T11:29:58+01:00 New Revision: 6335deb68b1dd417da4dff4f36fc344d8656e81a URL: https://github.com/llvm/llvm-project/commit/6335deb68b1dd417da4dff4f36fc344d8656e81a DIFF: https://github.com/llvm/llvm-project/commit/6335deb68b1dd417da4dff4f36fc344d8656e81a.diff

[Lldb-commits] [PATCH] D138430: [lldb/test] Use SBPlatform info for lldbplatformutil.getPlatform()

This revision was automatically updated to reflect the committed changes. Closed by commit rG6335deb68b1d: [lldb/test] Use SBPlatform info for lldbplatformutil.getPlatform() (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138430/n

[Lldb-commits] [PATCH] D138892: [DataFormatter] Fix variant npos with `_LIBCPP_ABI_VARIANT_INDEX_TYPE_OPTIMIZATION` enabled.

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxxVariant.cpp:74 + case 1: +return static_cast(-1); + case 2: I'd probably use fixed with ty