[Lldb-commits] [PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

ldionne accepted this revision as: libc++, libc++abi, ldionne. ldionne added a comment. I'm happy with this from the libc++/libc++abi side of things. You can ignore the failing CI job, it's been addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

sebastian-ne added inline comments. Comment at: clang/CMakeLists.txt:100 set(LLVM_RUNTIME_OUTPUT_INTDIR ${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin) - set(LLVM_LIBRARY_OUTPUT_INTDIR ${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/lib${LLVM_LIBDIR_SUFFIX}) +

[Lldb-commits] [PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 added inline comments. Comment at: clang/include/clang/Config/config.h.cmake:57 +/* Multilib basename for libdir. */ +#define CLANG_INSTALL_LIBDIR_BASENAME "${CLANG_INSTALL_LIBDIR_BASENAME}" compnerd wrote: > Does this not potentially break

[Lldb-commits] [PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 updated this revision to Diff 448053. Ericson2314 marked an inline comment as done. Ericson2314 added a comment. Fix review comments. Thanks again! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130586/new/

[Lldb-commits] [PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

compnerd added inline comments. Comment at: clang/include/clang/Config/config.h.cmake:57 +/* Multilib basename for libdir. */ +#define CLANG_INSTALL_LIBDIR_BASENAME "${CLANG_INSTALL_LIBDIR_BASENAME}" Does this not potentially break downstreams? Repository:

[Lldb-commits] [PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 updated this revision to Diff 448058. Ericson2314 added a comment. Add deprecation notice Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130586/new/ https://reviews.llvm.org/D130586 Files: bolt/runtime/CMakeLists.txt

[Lldb-commits] [PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 marked 6 inline comments as done. Ericson2314 added inline comments. Comment at: compiler-rt/cmake/Modules/CompilerRTAIXUtils.cmake:65 set(output_dir "${LLVM_LIBRARY_OUTPUT_INTDIR}") - set(install_dir "${CMAKE_INSTALL_PREFIX}/lib${LLVM_LIBDIR_SUFFIX}") +

[Lldb-commits] [PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 added a comment. Thanks so much @sebastian-ne for the thorough review! Unlike the other patches rather than being cleaned up code that needs more testing, this is closer to the original patch we've been using for a while (tested but not cleaned up); sorry there were so many things

[Lldb-commits] [PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 updated this revision to Diff 447757. Ericson2314 added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: Michael137, sstefan1, JDevlieghere, ormris. Forgot to define `CLANG_INSTALL_LIBDIR_BASENAME` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

sebastian-ne added inline comments. Comment at: clang/CMakeLists.txt:100 set(LLVM_RUNTIME_OUTPUT_INTDIR ${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin) - set(LLVM_LIBRARY_OUTPUT_INTDIR ${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/lib${LLVM_LIBDIR_SUFFIX}) +

[Lldb-commits] [PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 created this revision. Ericson2314 added reviewers: sebastian-ne, beanz, compnerd, phosek. Herald added subscribers: libc-commits, libcxx-commits, Enna1, bzcheeseman, ayermolo, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1,

[Lldb-commits] [PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

MaskRay added inline comments. Comment at: llvm/include/llvm/Support/Compression.h:48 + +constexpr int NoCompression = -5; +constexpr int BestSpeedCompression = 1; I missed the values here. Why is -5 picked for NoCompression? What does it mean? zstd.h says

[Lldb-commits] [PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

abrachet added a comment. In D128465#3672515 , @MaskRay wrote: > I am still seeing the > > zstdConfig.cmake > zstd-config.cmake > > warning. @ckissane @phosek will you fix it? :) I've quieted the warnings in

[Lldb-commits] [PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

ckissane updated this revision to Diff 445615. ckissane added a comment. - move try_find_dependency into it's own file - add newline to end of TryFindDependencyMacro.cmake - clarify comment in TryFindDependencyMacro.cmake Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

MaskRay added a comment. I am still seeing the zstdConfig.cmake zstd-config.cmake warning. @ckissane @phosek will you fix it? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465

[Lldb-commits] [PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

phosek added inline comments. Comment at: llvm/cmake/config-ix.cmake:149 + elseif(NOT LLVM_USE_SANITIZER MATCHES "Memory.*") +find_package(zstd) + endif() Since there's no `Findzstd.cmake` module shipped with CMake, and we don't provide in LLVM, we should

[Lldb-commits] [PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe939bf67e340: [llvm] add zstd to `llvm::compression` namespace (authored by ckissane). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

barannikov88 added a comment. @ckissane I took fresh sources of LLVM and when I run cmake I get the following warning: -- Looking for compress2 -- Looking for compress2 - found CMake Warning at cmake/config-ix.cmake:149 (find_package): By not providing "Findzstd.cmake" in

[Lldb-commits] [PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

leonardchan accepted this revision. leonardchan added a comment. LGTM tested on mac on my end Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 ___ lldb-commits

[Lldb-commits] [PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Does this address the macOS build failure? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465

[Lldb-commits] [PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

ckissane updated this revision to Diff 445623. ckissane added a comment. - remove extra cmake info Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files: llvm/CMakeLists.txt

[Lldb-commits] [PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

aemerson added a comment. I just reverted this in 6e6be5f9504d because it seems to have broken macOS builds: llvm/lib/Support/Compression.cpp:24:10: fatal error: 'zstd.h' file not found #include ^~~~

[Lldb-commits] [PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

jasonmolenda added a comment. In D128465#3652525 , @ckissane wrote: > In D128465#3651025 , @aemerson > wrote: > >> I just reverted this in 6e6be5f9504d >>

[Lldb-commits] [lldb] 4857b6f - Revert "Store OptTable::Info::Name as a StringRef"

Author: Douglas Yung Date: 2022-12-06T19:37:05-08:00 New Revision: 4857b6f8fff614c89ed35031c298df81394459af URL: https://github.com/llvm/llvm-project/commit/4857b6f8fff614c89ed35031c298df81394459af DIFF: https://github.com/llvm/llvm-project/commit/4857b6f8fff614c89ed35031c298df81394459af.diff

[Lldb-commits] [PATCH] D139158: [LLDB][LoongArch] Make software single stepping work

lh03061238 added inline comments. Comment at: lldb/source/Plugins/Instruction/LoongArch/EmulateInstructionLoongArch.h:58 + uint32_t reg_num) override; + lldb::addr_t ReadPC(bool *success); + bool WritePC(lldb::addr_t pc);

[Lldb-commits] [PATCH] D139158: [LLDB][LoongArch] Make software single stepping work

lh03061238 added a comment. In D139158#3974801 , @DavidSpickett wrote: > Looks mechanically fine. These classes are all a bit of a copy paste job > right now, so if you were going to take inspiration riscv is your best bet. > > On the subject of coding

[Lldb-commits] [PATCH] D139158: [LLDB][LoongArch] Make software single stepping work

SixWeining accepted this revision. SixWeining added a comment. This revision is now accepted and ready to land. In D139158#3974801 , @DavidSpickett wrote: > Looks mechanically fine. These classes are all a bit of a copy paste job > right now, so if you

[Lldb-commits] [PATCH] D139484: [lldb/test] Fix data racing issue in TestStackCoreScriptedProcess

bulbazord requested changes to this revision. bulbazord added a comment. This revision now requires changes to proceed. I think that the idea you've laid out in the summary makes sense but the implementation seems off. My understanding of `std::condition_variable` is that combined with

[Lldb-commits] [PATCH] D139484: [lldb/test] Fix data racing issue in TestStackCoreScriptedProcess

mib updated this revision to Diff 480674. mib added a comment. Run `clang-format` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139484/new/ https://reviews.llvm.org/D139484 Files: lldb/test/API/functionalities/scripted_process/Makefile

[Lldb-commits] [PATCH] D139484: [lldb/test] Fix data racing issue in TestStackCoreScriptedProcess

mib created this revision. mib added reviewers: JDevlieghere, bulbazord. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch should fix an undeterministic error in TestStackCoreScriptedProcess. In

[Lldb-commits] [PATCH] D139252: [lldb/Plugins] Introduce Scripted Platform Plugin

bulbazord added a comment. There's some overlap in implementation between `ScriptedPlatform::GetProcessInfo` and `ScriptedPlatform::FindProcesses`. If you don't anticipate these diverging dramatically, it might make sense to extract out common functionality into something like

[Lldb-commits] [PATCH] D139251: [lldb/Interpreter] Introduce ScriptedPlatform{, Python}Interface

bulbazord added inline comments. Comment at: lldb/include/lldb/Interpreter/ScriptedPlatformInterface.h:14 +#include "lldb/Interpreter/ScriptedInterface.h" +#include "lldb/Target/MemoryRegionInfo.h" + What is `MemoryRegionInfo.h` for? Comment

[Lldb-commits] [PATCH] D139463: Fix breakpoint-command.test when no script interpreter is compiled in.

hctim created this revision. hctim added reviewers: JDevlieghere, labath. Herald added a project: All. hctim requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. My local build is with -DLLVM_ENABLE_PROJECTS=lldb, but I don't compile with

[Lldb-commits] [PATCH] D139379: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo updated this revision to Diff 480619. ayermolo added a comment. fixed test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139379/new/ https://reviews.llvm.org/D139379 Files: bolt/lib/Core/DebugData.cpp

[Lldb-commits] [PATCH] D139250: [lldb] Add ScriptedPlatform python implementation

mib added inline comments. Comment at: lldb/examples/python/scripted_process/scripted_platform.py:43-46 +Dict: The processes represented as a dictionary, with at least the +process ID, name, architecture. Optionally, the user can also +

[Lldb-commits] [PATCH] D139461: Fix dwarf5-lazy-dwo.c for the default c target not being c99.

hctim created this revision. hctim added reviewers: Eric, jankratochvil, herhut. Herald added a project: All. hctim requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. My host compiler is clang version 15.0.0, which uses -std=c11 by default.

[Lldb-commits] [PATCH] D139250: [lldb] Add ScriptedPlatform python implementation

bulbazord added inline comments. Comment at: lldb/bindings/python/python-wrapper.swig:353-354 + } else { +error_string.assign("wrong number of arguments in __init__, should be 2 " +"(not including self)"); + } I think the error

[Lldb-commits] [PATCH] D139249: [lldb] Add Debugger & ScriptedMetadata reference to Platform::CreateInstance

bulbazord added a comment. The idea of the patch seems fine to me. One thing that I thought about is creating a `PlatformSpec` struct that can contain all the needed configuration for `CreateInstance`/`GetOrCreate`. What do you think of this? Comment at:

[Lldb-commits] [lldb] 5951b0b - Store OptTable::Info::Name as a StringRef

Author: serge-sans-paille Date: 2022-12-06T22:51:28+01:00 New Revision: 5951b0bb23f3265bea16f28c2af9d278b9d829c6 URL: https://github.com/llvm/llvm-project/commit/5951b0bb23f3265bea16f28c2af9d278b9d829c6 DIFF:

[Lldb-commits] [PATCH] D139453: Switch to a different library-loaded notification function breakpoint in Darwin dyld

jasonmolenda added a comment. oops, slight misstatement from not reading the patch when I wrote the description. The function we currently use has an array of uint64_t's, the one I am switching to is given an array of dyld_image_info objects, the first element has the ptrsize address of the

[Lldb-commits] [PATCH] D139453: Switch to a different library-loaded notification function breakpoint in Darwin dyld

jasonmolenda created this revision. jasonmolenda added reviewers: jingham, JDevlieghere. jasonmolenda added a project: LLDB. Herald added a subscriber: kristof.beyls. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. Darwin's

[Lldb-commits] [PATCH] D139054: Delay calling ObjC class list read utility functions very early in process startup

jasonmolenda added inline comments. Comment at: lldb/tools/debugserver/source/RNBRemote.h:111-139 +prefix_reg_packets_with_tid,// 'QPrefixRegisterPacketsWithThreadID +set_logging_mode, // 'QSetLogging:' +set_ignored_exceptions, //

[Lldb-commits] [PATCH] D139054: Delay calling ObjC class list read utility functions very early in process startup

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/tools/debugserver/source/RNBRemote.h:111-139 +prefix_reg_packets_with_tid,// 'QPrefixRegisterPacketsWithThreadID +

[Lldb-commits] [PATCH] D138834: [lldb] Fix simple template names interaction with debug info declarations

aeubanks added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:765 +m_ast.CreateClassTemplateSpecializationType(class_specialization_decl); +return clang_type.GetTypeName(/*BaseOnly*/ true); + } Michael137

[Lldb-commits] [PATCH] D139158: [LLDB][LoongArch] Make software single stepping work

DavidSpickett added a comment. Looks mechanically fine. These classes are all a bit of a copy paste job right now, so if you were going to take inspiration riscv is your best bet. On the subject of coding style, https://lldb.llvm.org/resources/contributing.html. Coding Style: LLDB’s code

[Lldb-commits] [PATCH] D139390: [LLDB][RISCV] Add RV32FC instruction support for EmulateInstructionRISCV

This revision was automatically updated to reflect the committed changes. Closed by commit rGd3628823c96f: [LLDB][RISCV] Add RV32FC instruction support for EmulateInstructionRISCV (authored by Emmmer). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [lldb] d362882 - [LLDB][RISCV] Add RV32FC instruction support for EmulateInstructionRISCV

Author: Emmmer Date: 2022-12-06T22:26:51+08:00 New Revision: d3628823c96f2d29ef8cea28f3b1b60ec670f318 URL: https://github.com/llvm/llvm-project/commit/d3628823c96f2d29ef8cea28f3b1b60ec670f318 DIFF: https://github.com/llvm/llvm-project/commit/d3628823c96f2d29ef8cea28f3b1b60ec670f318.diff LOG: