[Lldb-commits] [PATCH] D142266: [lldb] Add PlatformMetadata for ScriptedPlatform

mib created this revision. mib added reviewers: JDevlieghere, labath. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch is a less intrusive implementation of 2d53527

[Lldb-commits] [PATCH] D141702: [lldb/crashlog] Make module loading use Scripted Process affordance

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:537-543 + for (size_t i = 0; i < loaded_images_sp->GetSize(); i++) +if (loaded_images_sp->GetItemAtIndexAsDictionary(i, item)) + task_group.async(fetch_symbols,

[Lldb-commits] [PATCH] D139957: [LLDB] Change OSO to use DieRef

ayermolo updated this revision to Diff 491009. ayermolo added a comment. Updated based on Gregs suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139957/new/ https://reviews.llvm.org/D139957 Files:

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo updated this revision to Diff 491008. ayermolo added a comment. updated based on Gregs suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138618/new/ https://reviews.llvm.org/D138618 Files: lldb/include/lldb/Core/dwarf.h

[Lldb-commits] [PATCH] D141702: [lldb/crashlog] Make module loading use Scripted Process affordance

mib added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:537-543 + for (size_t i = 0; i < loaded_images_sp->GetSize(); i++) +if (loaded_images_sp->GetItemAtIndexAsDictionary(i, item)) + task_group.async(fetch_symbols, item); +

[Lldb-commits] [PATCH] D141702: [lldb/crashlog] Make module loading use Scripted Process affordance

mib updated this revision to Diff 491007. mib added a comment. Address @JDevlieghere & @bulbazord comments - Use D142059 's ScriptedProcess::GetCapabilities to decide whether we should force symbol lookup. - Make symbol fetching parallel. CHANGES SINCE LAST

[Lldb-commits] [PATCH] D141702: [lldb/crashlog] Make module loading use Scripted Process affordance

mib updated this revision to Diff 491006. mib edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141702/new/ https://reviews.llvm.org/D141702 Files: lldb/examples/python/scripted_process/crashlog_scripted_process.py

[Lldb-commits] [PATCH] D142059: [lldb/Plugins] Add ScriptedProcess::GetCapabilities affordance (NFC)

mib updated this revision to Diff 490997. mib added a comment. Make small adjustments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142059/new/ https://reviews.llvm.org/D142059 Files: lldb/examples/python/scripted_process/scripted_process.py

[Lldb-commits] [PATCH] D142241: Don't use CLANG_LIBS and LINK_COMPONENTS in lldb/tools/lldb-instr/CMakeLists.txt

This revision was automatically updated to reflect the committed changes. Closed by commit rGe12a950d90f8: Remove the LINK_COMPONENTS entry from lldb-instr CMakery (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142241/new/

[Lldb-commits] [lldb] e12a950 - Remove the LINK_COMPONENTS entry from lldb-instr CMakery

Author: Jim Ingham Date: 2023-01-20T15:41:59-08:00 New Revision: e12a950d90f88aeddaa97d6e7c8fd0bfedc42f73 URL: https://github.com/llvm/llvm-project/commit/e12a950d90f88aeddaa97d6e7c8fd0bfedc42f73 DIFF: https://github.com/llvm/llvm-project/commit/e12a950d90f88aeddaa97d6e7c8fd0bfedc42f73.diff

[Lldb-commits] [PATCH] D142260: Actually report an error when `command script add` is passed a non-existent class

jingham created this revision. jingham added a reviewer: JDevlieghere. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Before we were returning a SP with an invalid PythonObject, but the calling code

[Lldb-commits] [PATCH] D142245: [lldb/swig] Remove deprecated flags for generating bindings

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142245/new/ https://reviews.llvm.org/D142245 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D142245: [lldb/swig] Remove deprecated flags for generating bindings

mib updated this revision to Diff 490983. mib retitled this revision from "[lldb/swig] Remove deprecated `-py3` flag to generate bindings" to "[lldb/swig] Remove deprecated flags for generating bindings". mib edited the summary of this revision. mib added a comment. Address @JDevlieghere &

[Lldb-commits] [PATCH] D142150: [lldb] Remove timer from SBModule copy ctor

JDevlieghere reopened this revision. JDevlieghere added a comment. There's two issues with this patch: - `LLDB_INSTRUMENT_VA` is not the same as `LLDB_SCOPED_TIMER`. It's used for logging and tracks ABI boundaries. This breaks boundary tracking. - Next time someone runs `lldb-instr` on this

[Lldb-commits] [PATCH] D141539: [lldb][test] Replace use of p with expression (NFC)

kastiglione updated this revision to Diff 490968. kastiglione added a comment. Add a test for `p`; Replace few instances of `print` with `expression` too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141539/new/ https://reviews.llvm.org/D141539

[Lldb-commits] [PATCH] D142052: [lldb] Implement SymbolFile::CopyType

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG901ba0fcae36: [lldb] Implement SymbolFile::CopyType (authored by

[Lldb-commits] [lldb] 901ba0f - [lldb] Implement SymbolFile::CopyType

Author: Augusto Noronha Date: 2023-01-20T13:02:04-08:00 New Revision: 901ba0fcae3651c81051fd8da2695bbc2bcb3c91 URL: https://github.com/llvm/llvm-project/commit/901ba0fcae3651c81051fd8da2695bbc2bcb3c91 DIFF:

[Lldb-commits] [PATCH] D142052: [lldb] Implement SymbolFile::CopyType

augusto2112 updated this revision to Diff 490951. augusto2112 added a comment. Added check for same symbol file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142052/new/ https://reviews.llvm.org/D142052 Files:

[Lldb-commits] [PATCH] D142150: [lldb] Remove timer from SBModule copy ctor

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG84c6129c9431: [lldb] Remove timer from SBModule copy ctor (authored by kastiglione). Repository: rG LLVM Github

[Lldb-commits] [lldb] 84c6129 - [lldb] Remove timer from SBModule copy ctor

Author: Dave Lee Date: 2023-01-20T12:59:51-08:00 New Revision: 84c6129c943135e2c32b9254f08d0a2e7b21116a URL: https://github.com/llvm/llvm-project/commit/84c6129c943135e2c32b9254f08d0a2e7b21116a DIFF: https://github.com/llvm/llvm-project/commit/84c6129c943135e2c32b9254f08d0a2e7b21116a.diff

[Lldb-commits] [PATCH] D142245: [lldb/swig] Remove deprecated `-py3` flag to generate bindings

mib added inline comments. Comment at: lldb/bindings/python/CMakeLists.txt:11 -c++ -shadow -python kastiglione wrote: > Note that `-shadow` has been deprecated since 2002 and is on by default. I guess that this is a leftover from the time we

[Lldb-commits] [PATCH] D142245: [lldb/swig] Remove deprecated `-py3` flag to generate bindings

kastiglione added inline comments. Comment at: lldb/bindings/python/CMakeLists.txt:11 -c++ -shadow -python Note that `-shadow` has been deprecated since 2002 and is on by default. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D142245: [lldb/swig] Remove deprecated `-py3` flag to generate bindings

mib added a comment. In D142245#4070002 , @kastiglione wrote: > Looks like -py3 was marked deprecated and no-effect in 4.1. Thanks for looking it up Dave :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D142245: [lldb/swig] Remove deprecated `-py3` flag to generate bindings

mib added a comment. In D142245#4069960 , @JDevlieghere wrote: > In what version of SWIG was this deprecated? We officially support SWIG 3 > and later. What happens with SWIG 3 if you omit the flag, is it a NOOP? If so > then this is fine, otherwise

[Lldb-commits] [PATCH] D142245: [lldb/swig] Remove deprecated `-py3` flag to generate bindings

kastiglione added a comment. Looks like -py3 was marked deprecated and no-effect in 4.1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142245/new/ https://reviews.llvm.org/D142245 ___ lldb-commits

[Lldb-commits] [PATCH] D142245: [lldb/swig] Remove deprecated `-py3` flag to generate bindings

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. In what version of SWIG was this deprecated? We officially support SWIG 3 and later. What happens with SWIG 3 if you omit the flag, is it a NOOP? If so then this is

[Lldb-commits] [PATCH] D142245: [lldb/swig] Remove deprecated `-py3` flag to generate bindings

mib created this revision. mib added reviewers: JDevlieghere, bulbazord, LLDB. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch removes the `-py3` swig flag, to generate python3 bindings since it has

[Lldb-commits] [PATCH] D142241: Don't use CLANG_LIBS and LINK_COMPONENTS in lldb/tools/lldb-instr/CMakeLists.txt

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142241/new/ https://reviews.llvm.org/D142241

[Lldb-commits] [PATCH] D142241: Don't use CLANG_LIBS and LINK_COMPONENTS in lldb/tools/lldb-instr/CMakeLists.txt

jingham created this revision. jingham added reviewers: JDevlieghere, labath. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The presence of this entry causes the Xcode generator to produce two

[Lldb-commits] [PATCH] D141539: [lldb][test] Replace use of p with expression (NFC)

aprantl added inline comments. Comment at: lldb/test/API/functionalities/multiple-slides/TestMultipleSlides.py:74 +self.expect("expression/d ((int*))[0]", substrs=['= 5']) +self.expect("expression/d ((int*))[0]", substrs=['= 6'])

[Lldb-commits] [PATCH] D142141: [lldb][test] Skip TestRerunAndExprDylib on Ubuntu 18.04

This revision was automatically updated to reflect the committed changes. Closed by commit rGcd4180dbf90b: [lldb][test] Skip TestRerunAndExprDylib on Ubuntu 18.04 (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142141/new/

[Lldb-commits] [lldb] cd4180d - [lldb][test] Skip TestRerunAndExprDylib on Ubuntu 18.04

Author: Dave Lee Date: 2023-01-20T07:54:32-08:00 New Revision: cd4180dbf90b04014b65ff69c33002806680ced9 URL: https://github.com/llvm/llvm-project/commit/cd4180dbf90b04014b65ff69c33002806680ced9 DIFF: https://github.com/llvm/llvm-project/commit/cd4180dbf90b04014b65ff69c33002806680ced9.diff