[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

clayborg added a comment. Looks good to me. Pavel? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138618/new/ https://reviews.llvm.org/D138618 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D143623: [lldb] Print an error for unsupported combinations of log options

clayborg added inline comments. Comment at: lldb/test/Shell/Log/TestHandlers.test:1-2 +# RUN: %lldb -o 'log enable -h os -f /tmp/foo gdb-remote packets' 2>&1 | FileCheck %s --check-prefix UNSUPPORTED-FILE +# RUN: %lldb -o 'log enable -h os -b 10 gdb-remote packets' 2>&1 |

[Lldb-commits] [PATCH] D143623: [lldb] Print an error for unsupported combinations of log options

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143623/new/ https://reviews.llvm.org/D143623 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D143623: [lldb] Print an error for unsupported combinations of log options

JDevlieghere updated this revision to Diff 496011. JDevlieghere marked 2 inline comments as done. JDevlieghere added a comment. Update error message CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143623/new/ https://reviews.llvm.org/D143623 Files:

[Lldb-commits] [PATCH] D143623: [lldb] Print an error for unsupported combinations of log options

bulbazord requested changes to this revision. bulbazord added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Commands/CommandObjectLog.cpp:180-184 +if ((m_options.handler != eLogHandlerCircular && + m_options.handler !=

[Lldb-commits] [PATCH] D143623: [lldb] Print an error for unsupported combinations of log options

JDevlieghere created this revision. JDevlieghere added reviewers: jingham, clayborg, mib, bulbazord. Herald added a project: All. JDevlieghere requested review of this revision. Print an error for unsupported combinations of log handlers and log options. Only the stream log handler takes a file

[Lldb-commits] [PATCH] D141425: [lldb] Add --gdb-format flag to dwim-print

This revision was automatically updated to reflect the committed changes. Closed by commit rGd160873c03ae: [lldb] Add --gdb-format flag to dwim-print (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141425/new/

[Lldb-commits] [lldb] d160873 - [lldb] Add --gdb-format flag to dwim-print

Author: Dave Lee Date: 2023-02-08T19:16:20-08:00 New Revision: d160873c03aedfcd201851829aa423cc10ef593a URL: https://github.com/llvm/llvm-project/commit/d160873c03aedfcd201851829aa423cc10ef593a DIFF: https://github.com/llvm/llvm-project/commit/d160873c03aedfcd201851829aa423cc10ef593a.diff

[Lldb-commits] [PATCH] D143127: [LLDB] Fix assertion failure by removing `CopyType` in `std::coroutine_handle` pretty printer

avogelsgesang added a comment. @labath @aprantl Thanks for your reviews! I would like to backport this fix together with the fix from https://reviews.llvm.org/D132815 to the 16.0 release branch now. For that I would need your approval on

[Lldb-commits] [PATCH] D141425: [lldb] Add --gdb-format flag to dwim-print

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141425/new/ https://reviews.llvm.org/D141425

[Lldb-commits] [PATCH] D143215: lldb can know architecture-dependent watchpoint behaviors, instead of depending on the remote stub

jasonmolenda updated this revision to Diff 495976. jasonmolenda retitled this revision from "Separate Process::GetWatchpointSupportInfo into two methods to get the two separate pieces of information" to "lldb can know architecture-dependent watchpoint behaviors, instead of depending on the

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

bulbazord added a comment. Not sure how useful it would be but I recorded the full list of methods get added with this change. Take a look and let me know if there are any that you think shouldn't be added. SBAttachInfo::~SBAttachInfo() SBBroadcaster::operator<(const lldb::SBBroadcaster &)

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

bulbazord added a comment. In D142926#4113600 , @clayborg wrote: > In D142926#4111717 , @bulbazord > wrote: > >> Certainly interesting: >> >> - SBListener::StopListeningForEventClass return type conflicts (ABI

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

bulbazord updated this revision to Diff 495978. bulbazord added a comment. - Removed a bunch of header guards effectively adding methods to the python bindings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142926/new/

[Lldb-commits] [PATCH] D143215: Separate Process::GetWatchpointSupportInfo into two methods to get the two separate pieces of information

jasonmolenda added inline comments. Comment at: lldb/source/Target/Process.cpp:2373 +reported_after = false; + return reported_after; +} Emmmer wrote: > DavidSpickett wrote: > > DavidSpickett wrote: > > > Would this be any clearer with multiple returns? Or

[Lldb-commits] [PATCH] D143104: [lldb/Plugins] Add Attach capabilities to ScriptedProcess

mib updated this revision to Diff 495971. mib marked an inline comment as done. mib edited the summary of this revision. mib added a comment. Addressed @JDevlieghere comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143104/new/ https://reviews.llvm.org/D143104 Files:

[Lldb-commits] [PATCH] D143548: [lldb] Add the ability to remove diagnostic callbacks

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143548/new/ https://reviews.llvm.org/D143548 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo updated this revision to Diff 495952. ayermolo marked 2 inline comments as done. ayermolo added a comment. addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138618/new/ https://reviews.llvm.org/D138618 Files:

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo marked 16 inline comments as done. ayermolo added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DIERef.h:32 enum Section : uint8_t { DebugInfo, DebugTypes }; - - DIERef(std::optional dwo_num, Section section, + // Making constructors protected

[Lldb-commits] [PATCH] D141658: [lldb/crashlog] Make interactive mode the new default

mib updated this revision to Diff 495939. mib edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141658/new/ https://reviews.llvm.org/D141658 Files: lldb/examples/python/crashlog.py

[Lldb-commits] [PATCH] D141658: [lldb/crashlog] Make interactive mode the new default

mib updated this revision to Diff 495938. mib added a comment. Address @JDevlieghere feedback: rename `legacy` loading mode into `batch`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141658/new/ https://reviews.llvm.org/D141658 Files: lldb/examples/python/crashlog.py

[Lldb-commits] [PATCH] D141702: [lldb/crashlog] Make module loading use Scripted Process affordance

mib updated this revision to Diff 495933. mib added a comment. Fixed module loading issue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141702/new/ https://reviews.llvm.org/D141702 Files: lldb/examples/python/scripted_process/crashlog_scripted_process.py

[Lldb-commits] [PATCH] D142715: [LLDB] Apply FixCodeAddress to all forms of address arguments

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142715/new/ https://reviews.llvm.org/D142715

[Lldb-commits] [PATCH] D143548: [lldb] Add the ability to remove diagnostic callbacks

JDevlieghere added a comment. In D143548#4113687 , @mib wrote: > LGTM! Is there a simple way to test this ? I considered a unit test, but that would require making everything protected and would basically boil down to testing the implementation of the

[Lldb-commits] [PATCH] D143548: [lldb] Add the ability to remove diagnostic callbacks

mib added a comment. LGTM! Is there a simple way to test this ? Comment at: lldb/source/Utility/Diagnostics.cpp:55-58 + m_callbacks.erase( + std::remove_if(m_callbacks.begin(), m_callbacks.end(), + [id](const CallbackEntry ) { return e.id == id; }), +

[Lldb-commits] [lldb] 785009e - [lldb][test] Fix function references to function calls (NFC)

Author: Dave Lee Date: 2023-02-08T12:12:33-08:00 New Revision: 785009e19fbcbeaca206f7e5a786cb034a374e19 URL: https://github.com/llvm/llvm-project/commit/785009e19fbcbeaca206f7e5a786cb034a374e19 DIFF: https://github.com/llvm/llvm-project/commit/785009e19fbcbeaca206f7e5a786cb034a374e19.diff

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

clayborg added a comment. In D142926#4111717 , @bulbazord wrote: > Potentially interesting: > > - SBData::GetDescription base_addr parameter has default value now > - SBInstructionList::GetInstructionsCount canSetBreakpoint has default value > now > -

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

clayborg added a comment. In D142926#4111717 , @bulbazord wrote: > In addition to what I wrote above, I also fixed several documentation bugs > (putting docstrings on the wrong method). > > I manually audited the generated code before and after this

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

clayborg added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DIERef.h:22-24 +/// - file_index: identifies the dwo file in the Module. If this field is not +/// set, +/// the DIERef references the main, dwo or .o file.

[Lldb-commits] [PATCH] D142715: [LLDB] Apply FixCodeAddress to all forms of address arguments

JDevlieghere added a comment. I left a few nits here and there but overall this LGTM Comment at: lldb/include/lldb/Interpreter/OptionArgParser.h:19-20 struct OptionArgParser { + // Try to parse an address. If it succeeds return the address with the + // non-address bits

[Lldb-commits] [PATCH] D141425: [lldb] Add --gdb-format flag to dwim-print

kastiglione updated this revision to Diff 495899. kastiglione added a comment. replace raise with assertTrue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141425/new/ https://reviews.llvm.org/D141425 Files:

[Lldb-commits] [PATCH] D141425: [lldb] Add --gdb-format flag to dwim-print

kastiglione updated this revision to Diff 495895. kastiglione added a comment. Add a test for display options too (-T) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141425/new/ https://reviews.llvm.org/D141425 Files:

[Lldb-commits] [PATCH] D141425: [lldb] Add --gdb-format flag to dwim-print

kastiglione updated this revision to Diff 495887. kastiglione added a comment. remove unnecessary header addition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141425/new/ https://reviews.llvm.org/D141425 Files:

[Lldb-commits] [PATCH] D143282: [lldb] Accept negative indexes in __getitem__

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ff636729d06: [lldb] Accept negative indexes in __getitem__ (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143282/new/

[Lldb-commits] [lldb] 3ff6367 - [lldb] Accept negative indexes in __getitem__

Author: Dave Lee Date: 2023-02-08T10:46:26-08:00 New Revision: 3ff636729d067801039b3a37618f6ce0dd1c3d24 URL: https://github.com/llvm/llvm-project/commit/3ff636729d067801039b3a37618f6ce0dd1c3d24 DIFF: https://github.com/llvm/llvm-project/commit/3ff636729d067801039b3a37618f6ce0dd1c3d24.diff

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DIERef.h:24 +/// set, +/// the DIERef references the main, dwo or .o file. /// - section: identifies the section of the debug info entry in the given file: I don't understand this

[Lldb-commits] [PATCH] D143501: [WIP][clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

Michael137 added a comment. In D143501#4113347 , @aprantl wrote: > Nice! Does `expr -- std::basic_string s` still work after this change? > Not that anyone would want to type this over `std::string` ... Yup that still works. We would still emit it as

[Lldb-commits] [PATCH] D143501: [WIP][clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

Michael137 added inline comments. Comment at: clang/test/CodeGen/debug-info-preferred-names.cpp:1 +// RUN: %clang_cc1 -emit-llvm -debug-info-kind=limited %s -o - -debugger-tuning=lldb | FileCheck --check-prefixes=COMMON,LLDB %s +// RUN: %clang_cc1 -emit-llvm

[Lldb-commits] [PATCH] D143501: [WIP][clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

Michael137 added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/shared_ptr/TestDataFormatterLibcxxSharedPtr.py:61 if self.expectedCompilerVersion(['>', '16.0']): +string_type = "std::string"

[Lldb-commits] [PATCH] D143127: [LLDB] Fix assertion failure by removing `CopyType` in `std::coroutine_handle` pretty printer

This revision was automatically updated to reflect the committed changes. Closed by commit rG54d4a2550d31: [LLDB] Fix assertion failure by removing `CopyType` in `std::coroutine_handle`… (authored by avogelsgesang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 54d4a25 - [LLDB] Fix assertion failure by removing `CopyType` in `std::coroutine_handle` pretty printer

Author: Adrian Vogelsgesang Date: 2023-02-08T10:22:50-08:00 New Revision: 54d4a2550d3167d51a9d386d9823a06aca459531 URL: https://github.com/llvm/llvm-project/commit/54d4a2550d3167d51a9d386d9823a06aca459531 DIFF:

[Lldb-commits] [PATCH] D143501: [WIP][clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

aprantl added a comment. Nice! Does `expr -- std::basic_string s` still work after this change? Not that anyone would want to type this over `std::string` ... Comment at: clang/test/CodeGen/debug-info-preferred-names.cpp:1 +// RUN: %clang_cc1 -emit-llvm

[Lldb-commits] [PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

akyrtzi added a comment. In D141910#4112144 , @domada wrote: > @akyrtzi Thank you for your feedback. Can I land the patch? Fine be me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141910/new/ https://reviews.llvm.org/D141910

[Lldb-commits] [PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

domada added a comment. In D141910#4112164 , @tschuett wrote: > For AArch64 the default alignment is 0? I would have expected 128. The refactored function `TargetInfo::getSimdDefaultAlign` is used only for calculation of default alignment for `#pragma

[Lldb-commits] [PATCH] D143215: Separate Process::GetWatchpointSupportInfo into two methods to get the two separate pieces of information

Emmmer added inline comments. Comment at: lldb/source/Target/Process.cpp:2373 +reported_after = false; + return reported_after; +} DavidSpickett wrote: > DavidSpickett wrote: > > Would this be any clearer with multiple returns? Or one giant return, but > >

[Lldb-commits] [PATCH] D143564: [LLDB] Add missing newline to "image lookup" output

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When using --name, due to a missing newline, multiple symbol results were not correctly printed: (lldb)

[Lldb-commits] [PATCH] D143215: Separate Process::GetWatchpointSupportInfo into two methods to get the two separate pieces of information

DavidSpickett added a subscriber: Emmmer. DavidSpickett added inline comments. Comment at: lldb/source/Target/Process.cpp:2373 +reported_after = false; + return reported_after; +} DavidSpickett wrote: > Would this be any clearer with multiple returns? Or

[Lldb-commits] [PATCH] D142715: [LLDB] Apply FixCodeAddress to all forms of address arguments

DavidSpickett added a comment. ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142715/new/ https://reviews.llvm.org/D142715 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D143215: Separate Process::GetWatchpointSupportInfo into two methods to get the two separate pieces of information

DavidSpickett added a comment. > Change lldb from depending on the remote gdb stub to tell it whether > watchpoints are received before or after the instruction, to knowing the > architectures where watchpoint exceptions are received before the instruction > executes, and allow the remote gdb

[Lldb-commits] [PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

tschuett added a comment. For AArch64 the default alignment is 0? I would have expected 128. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141910/new/ https://reviews.llvm.org/D141910 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

domada added a comment. @akyrtzi Thank you for your feedback. Can I land the patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141910/new/ https://reviews.llvm.org/D141910 ___ lldb-commits mailing list lldb-commits@lists.llvm.org