[Lldb-commits] [PATCH] D142792: Add SBValue::GetValueAsAddress(), strip off ptrauth, TBI, MTE bits on AArch64 systems

jasonmolenda planned changes to this revision. jasonmolenda added a comment. OK, I understand the objc testsuite failures. ObjC has tagged pointers, where the address of an object is either a virtual address, or a big old bag of bits that can contain a small value, like instead of a pointer to

[Lldb-commits] [PATCH] D145569: [lldb][InstrumentationRuntime] Make 'data' struct anonymous in order to avoid collisions with types in the debuggee

This revision was automatically updated to reflect the committed changes. Closed by commit rGadc5168d7114: [lldb][InstrumentationRuntime] Make 'data' struct anonymous in order to avoid… (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [lldb] adc5168 - [lldb][InstrumentationRuntime] Make 'data' struct anonymous in order to avoid collisions with types in the debuggee

Author: Michael Buch Date: 2023-03-10T00:40:22Z New Revision: adc5168d7114190ec7d931a6c346276e19b0e117 URL: https://github.com/llvm/llvm-project/commit/adc5168d7114190ec7d931a6c346276e19b0e117 DIFF: https://github.com/llvm/llvm-project/commit/adc5168d7114190ec7d931a6c346276e19b0e117.diff LOG:

[Lldb-commits] [PATCH] D145569: [lldb][InstrumentationRuntime] Make 'data' struct anonymous in order to avoid collisions with types in the debuggee

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145569/new/ https://reviews.llvm.org/D145569 _

[Lldb-commits] [PATCH] D145574: [lldb] Read register fields from target XML

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. This looks good to me. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4066 +"ProcessGDBRemote::ParseFlags Invalid start %

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. I'll mark it as accepted, I don't know if Jim or Pavel have any comments. I think this is good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

jasonmolenda added a comment. This all looks good to me. the phab says there's a missing newline at the end of TestXMLRegisterFlags.py. Given that we can construct fake debug sessions with a gdb_remote_client test, do you think it would be worth having a test that's says it's a big-endian tar

[Lldb-commits] [PATCH] D145624: [lldb] Make MemoryCache::Read more resilient

bulbazord marked 11 inline comments as done. bulbazord added inline comments. Comment at: lldb/source/Target/Memory.cpp:255-256 - // We need to read from the process + if (process_bytes_read < cache_line_byte_size) +data_buffer_heap_up->SetByteSize(process_byt

[Lldb-commits] [lldb] 7f25c3e - Slight refinement to a change yesterday in metadata-added binaries

Author: Jason Molenda Date: 2023-03-09T14:56:22-08:00 New Revision: 7f25c3e25f0afa91ae47c7247cca7fabaa2a7dd5 URL: https://github.com/llvm/llvm-project/commit/7f25c3e25f0afa91ae47c7247cca7fabaa2a7dd5 DIFF: https://github.com/llvm/llvm-project/commit/7f25c3e25f0afa91ae47c7247cca7fabaa2a7dd5.diff

[Lldb-commits] [PATCH] D145624: [lldb] Make MemoryCache::Read more resilient

bulbazord updated this revision to Diff 503942. bulbazord added a comment. - Addressed reviewer feedback - Simplified the case where we use L2 cache lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145624/new/ https://reviews.llvm.org/D145624 F

[Lldb-commits] [PATCH] D145566: [lldb] Add RegisterFlags class

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. I'm not really advocating to changing `m_type` to be an enum, but curious how that might fit into the total context of this feature, and if it makes any sense. ==

[Lldb-commits] [PATCH] D145568: [lldb] Add dummy field to RegisterInfo for register flags use later

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145568/new/ https://reviews.llvm.org/D145568 __

[Lldb-commits] [PATCH] D145624: [lldb] Make MemoryCache::Read more resilient

bulbazord added a comment. In D145624#4182424 , @clayborg wrote: > I would suggest checking the google stadia patch for the L1 > and L2 caches: > > https://github.com/googlestadia/vsi-lldb/blob/master/patches/llvm-project/00

[Lldb-commits] [PATCH] D145624: [lldb] Make MemoryCache::Read more resilient

clayborg added a comment. I would suggest checking the google stadia patch for the L1 and L2 caches: https://github.com/googlestadia/vsi-lldb/blob/master/patches/llvm-project/0019-lldb-Fix-incorrect-L1-inferior-memory-cache-flushing.patch Just to see how they did t

[Lldb-commits] [PATCH] D145624: [lldb] Make MemoryCache::Read more resilient

clayborg added a comment. One other optimization we can do is if we read from the process memory and it returns that is read zero bytes, right now we add the range we were trying to read into the m_invalid_ranges member variable. So lets say we were trying to read the range [0x1000-0x2000) on a

[Lldb-commits] [lldb] 7c4e6c9 - [lldb] Skip TestSymbolFileJSON on Windows

Author: Jonas Devlieghere Date: 2023-03-09T11:33:14-08:00 New Revision: 7c4e6c97fb689f8db8ea361fe615fe39eb332610 URL: https://github.com/llvm/llvm-project/commit/7c4e6c97fb689f8db8ea361fe615fe39eb332610 DIFF: https://github.com/llvm/llvm-project/commit/7c4e6c97fb689f8db8ea361fe615fe39eb332610.d

[Lldb-commits] [PATCH] D145624: [lldb] Make MemoryCache::Read more resilient

bulbazord added inline comments. Comment at: lldb/source/Target/Memory.cpp:133-141 // Check the L1 cache for a range that contain the entire memory read. If we - // find a range in the L1 cache that does, we use it. Else we fall back to - // reading memory in m_L2_cache_line

[Lldb-commits] [lldb] e67460c - [lldb] Add nullptr check to SymbolVendorWasm

Author: Jonas Devlieghere Date: 2023-03-09T10:27:18-08:00 New Revision: e67460c974e65aee83d2976226db17d8ffe17cc2 URL: https://github.com/llvm/llvm-project/commit/e67460c974e65aee83d2976226db17d8ffe17cc2 DIFF: https://github.com/llvm/llvm-project/commit/e67460c974e65aee83d2976226db17d8ffe17cc2.d

[Lldb-commits] [PATCH] D145629: When a ValueObjectDynamicValue fails to update, return a not valid ValueObject so the static one is used instead

jingham added inline comments. Comment at: lldb/source/Core/ValueObject.cpp:1862 } - if (m_dynamic_value) + if (m_dynamic_value && m_dynamic_value->GetError().Success()) return m_dynamic_value->GetSP(); mib wrote: > It would be nice if `ValueObjectDynam

[Lldb-commits] [PATCH] D145377: [LLDB] Show sub type of memory tagging SEGV when reading a core file

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:32 + AddSignalCode(11, 8 /*SEGV_MTEAERR*/, "async tag check fault"); + AddSignalCode(11, 9 /*SEGV_MTESERR*/, "sync tag check fault"); AddSignal(12, "SIGUSR2", false