[Lldb-commits] [lldb] 65a2d6d - [lldb] Use *{Set, Map}::contains (NFC)

Author: Kazu Hirata Date: 2023-03-14T21:41:40-07:00 New Revision: 65a2d6d6904f0b06f0d0cfdfbfa67dbe6599f081 URL: https://github.com/llvm/llvm-project/commit/65a2d6d6904f0b06f0d0cfdfbfa67dbe6599f081 DIFF: https://github.com/llvm/llvm-project/commit/65a2d6d6904f0b06f0d0cfdfbfa67dbe6599f081.diff L

[Lldb-commits] [PATCH] D146045: [LLDB] Show sub type of signals when debugging a core file

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Nice. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146045/new/ https://reviews.llvm.org/D146045

Re: [Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

> On Mar 14, 2023, at 12:10 PM, Stefan Gränitz via Phabricator via lldb-commits > wrote: > > sgraenitz marked 2 inline comments as done. > sgraenitz added a comment. > > Soo, @DavidSpickett > > In D146058#4193446 , @DavidSpickett > wrote: > >> I am

[Lldb-commits] [PATCH] D145450: [lldb] Respect empty arguments in target.run-args

labath added inline comments. Comment at: lldb/source/Host/common/ProcessLaunchInfo.cpp:324-325 std::string safe_arg = Args::GetShellSafeArgument(m_shell, argv[i]); + if (safe_arg.empty()) +safe_arg = "\"\""; // Add a space to separate t

[Lldb-commits] [PATCH] D146041: Fix weirdly apologetic diagnostic messages

AryanGodara added a comment. In D146041#4193172 , @junaire wrote: > I'm not certain if it's bad to say 'sorry', IMHO it's fine? > > Anyway, you can't just simply delete those words (in diagnostic messages and > regression tests), that doesn't work. To ve

[Lldb-commits] [PATCH] D146041: Fix weirdly apologetic diagnostic messages

AryanGodara added a comment. In D146041#4193045 , @DavidSpickett wrote: > Is there some standard for writing warning messages? For llvm that is, it > would be worth looking through the getting started guides to see. I think the > majority of warnings a

[Lldb-commits] [PATCH] D146041: Fix weirdly apologetic diagnostic messages

AryanGodara added a comment. In D146041#4192816 , @mehdi_amini wrote: > You should look into the title and description of the commit: > https://cbea.ms/git-commit/ Is the title and description appropriate now? I can add more details to the description,

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

sgraenitz marked 2 inline comments as done. sgraenitz added a comment. Soo, @DavidSpickett In D146058#4193446 , @DavidSpickett wrote: > I am not familiar with Objective C, especially beyond Apple platforms. Are > you aiming to run all the existing Obje

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

sgraenitz added a comment. In D146058#4193795 , @stella.stamenova wrote: > The one I was referring to is https://lab.llvm.org/buildbot/#/builders/219. Ok, thanks for the update. Then we are lacking a Windows x86 build bot for LLDB now! > Also, the one

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

sgraenitz updated this revision to Diff 505189. sgraenitz marked 2 inline comments as done. sgraenitz added a comment. Polish assertion message in build.py Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146058/new/ https://reviews.llvm.org/D146058

[Lldb-commits] [PATCH] D146043: [lldb] Refactor CrashReason

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146043/new/ https://reviews.llvm.org/D146043 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D146044: [lldb] Implement CrashReason using UnixSignals

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM with Pavel's comments. Comment at: lldb/unittests/Signals/UnixSignalsTest.cpp:132-134 + EXPECT_EQ(expected, signals.GetSignalAsString(16, 3)); + EXPECT_EQ(

[Lldb-commits] [PATCH] D145136: Add a Debugger interruption mechanism in parallel to the Command Interpreter interruption

jingham added a comment. polite ping... I think I've addressed all the concerns folks raised. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145136/new/ https://reviews.llvm.org/D145136 ___ lldb-commits

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

bulbazord added inline comments. Comment at: lldb/test/Shell/helper/build.py:254 +if args.objc_gnustep: +assert args.objc_gnustep_dir, "GNUstep libobjc2 runtime for Linux and Windows" +self.objc_gnustep_inc = os.path.join(args.objc_gnustep_dir, '

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

stella.stamenova added a comment. > Oh I still saw that one running a few days back! @stella.stamenova in the > review you mention a second windows lldb bot, is it x86 as well? I don't see > it in https://lab.llvm.org/buildbot/#/console The one I was referring to is https://lab.llvm.org/buildbo

[Lldb-commits] [PATCH] D145450: [lldb] Respect empty arguments in target.run-args

bulbazord added inline comments. Comment at: lldb/source/Host/common/ProcessLaunchInfo.cpp:324-325 std::string safe_arg = Args::GetShellSafeArgument(m_shell, argv[i]); + if (safe_arg.empty()) +safe_arg = "\"\""; // Add a space to separat

[Lldb-commits] [PATCH] D146044: [lldb] Implement CrashReason using UnixSignals

labath added a comment. It's not exactly what I had in mind, but I kinda like it :) Comment at: lldb/include/lldb/Target/UnixSignals.h:127 + struct SignalCode { +ConstString m_description; +SignalCodePrintOption m_print_option; I think we should just m

[Lldb-commits] [PATCH] D145955: Refactor ObjectFilePlaceholder for sharing

labath added a comment. yay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145955/new/ https://reviews.llvm.org/D145955 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi

[Lldb-commits] [PATCH] D144392: [lldb] Skip signal handlers for ignored signals on lldb-server's side when stepping

labath added a comment. In D144392#4188940 , @kpdev42 wrote: > Gdb does this for example: > >> GDB optimizes for stepping the mainline code. If a signal that has handle >> nostop and handle pass set arrives while a stepping command (e.g., stepi, >> step

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

sgraenitz added a subscriber: stella.stamenova. sgraenitz added a comment. In D146058#4193470 , @DavidSpickett wrote: > Myself and Omair both work on Linaro's bots. We run lldb checks on linux > arm/aarch64 and Windows on Arm. We could look at installin

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

sgraenitz updated this revision to Diff 505149. sgraenitz marked 3 inline comments as done. sgraenitz added a comment. Improve help text for the build.py --objc-gnustep option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146058/new/ https://review

[Lldb-commits] [PATCH] D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON

labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/JSON/SymbolFileJSON.cpp:112 +symtab.AddSymbol(Symbol( +/*symID*/ 0, Mangled(symbol.name), eSymbolTypeCode, +/*is_global*/ true, /*is_debug*/ false, clayborg wrote: > JDev

[Lldb-commits] [PATCH] D145450: [lldb] Respect empty arguments in target.run-args

labath added inline comments. Comment at: lldb/source/Host/common/ProcessLaunchInfo.cpp:324-325 std::string safe_arg = Args::GetShellSafeArgument(m_shell, argv[i]); + if (safe_arg.empty()) +safe_arg = "\"\""; // Add a space to separate t

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

theraven added inline comments. Comment at: lldb/test/CMakeLists.txt:39 +if (LLDB_TEST_OBJC_GNUSTEP_DIR) + message(STATUS "Found GNUstep ObjC runtime: ${LLDB_TEST_OBJC_GNUSTEP_DIR}/${gnustep_info}") +endif() DavidSpickett wrote: > sgraenitz wrote: > > Might be

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

DavidSpickett added a comment. > Also, I realise that all this XML substitution with strings is very brittle. > I want to replace that with Python's xml.etree but will do that later in > another patch. Having tried this, it gives you nice indentation but it's not that much different to the raw

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

DavidSpickett added a comment. The Windows x86 bot has in fact been removed: https://github.com/llvm/llvm-zorg/commit/acb6223670a41a7fe5d9846075e6b92bd157d78f Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146058/new/ https://reviews.llvm.org/D1460

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

DavidSpickett added a comment. > I am not in touch with any of the build bot maintainers for Windows/Linux > LLDB. Do you think it's worth asking for mainline test support? They'd > basically need to build and install libobjc2 once. It's a few hundred > kilobytes. Myself and Omair both work on

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added a comment. I am not familiar with Objective C, especially beyond Apple platforms. Are you aiming to run all the existing Objective C test cases with this different runtime or will it be mainly new tests? (would be very neat if yo

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

sgraenitz added a comment. I am not in touch with any of the build bot maintainers for Windows/Linux LLDB. Do you think it's worth asking for mainline test support? They'd basically need to build and install libobjc2 once. It's a few hundred kilobytes. For me the test expectedly fails on Window

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

sgraenitz created this revision. sgraenitz added reviewers: theraven, triplef, mgorny, labath, omjavaid, xiaobai, aleksandr.urakov, zturner. Herald added a project: All. sgraenitz requested review of this revision. Herald added a project: LLDB. We are planning to add basic ObjC debug support for

[Lldb-commits] [PATCH] D146041: Fix weirdly apologetic diagnostic messages

junaire added a comment. I'm not certain if it's bad to say 'sorry', IMHO it's fine? Anyway, you can't just simply delete those words (in diagnostic messages and regression tests), that doesn't work. To verify the patch is good, you can run `ninja check-all` to make sure the testsuite passes.

[Lldb-commits] [PATCH] D146044: [lldb] Implement CrashReason using UnixSignals

emaste added a comment. FreeBSD LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146044/new/ https://reviews.llvm.org/D146044 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [PATCH] D146041: Fix weirdly apologetic diagnostic messages

DavidSpickett added a comment. Ah, here it is: https://llvm.org/docs/CodingStandards.html#error-and-warning-messages Seems to back you up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146041/new/ https://reviews.llvm.org/D146041 ___

[Lldb-commits] [PATCH] D146041: Fix weirdly apologetic diagnostic messages

DavidSpickett added a comment. Is there some standard for writing warning messages? For llvm that is, it would be worth looking through the getting started guides to see. I think the majority of warnings are "formal" in that sense so this seems fine. Personally I agree with making the warnings

[Lldb-commits] [PATCH] D146044: [lldb] Implement CrashReason using UnixSignals

DavidSpickett marked an inline comment as done. DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Utility/FreeBSDSignals.cpp:20 + // SIGILL + AddSignalCode(4, 1 /*ILL_ILLOPC*/, "illegal instruction"); + AddSignalCode(4, 2 /*ILL_ILLOPN*/, "illegal ins

[Lldb-commits] [PATCH] D146044: [lldb] Implement CrashReason using UnixSignals

DavidSpickett updated this revision to Diff 505090. DavidSpickett added a comment. Update the descriptions to match the platform's. Add a couple of FreeBSD signals I missed the first time. We're missing a bunch of Linux ones too but since that file already existed, I don't want to make the diff

[Lldb-commits] [lldb] 55aa4bf - [lldb] Fix -Wswitch in TypeSystemClang.cpp ('SveBoolx2' and 'SveBoolx4' not handled in switch) (NFC)

Author: Jie Fu Date: 2023-03-14T22:24:37+08:00 New Revision: 55aa4bfaee8a2bd5c56765b4d54c4115dcc5d6f3 URL: https://github.com/llvm/llvm-project/commit/55aa4bfaee8a2bd5c56765b4d54c4115dcc5d6f3 DIFF: https://github.com/llvm/llvm-project/commit/55aa4bfaee8a2bd5c56765b4d54c4115dcc5d6f3.diff LOG: [

[Lldb-commits] [PATCH] D146044: [lldb] Implement CrashReason using UnixSignals

DavidSpickett updated this revision to Diff 505082. DavidSpickett added a comment. Corect FreeBSD SIGFPE integer overflow/divide by zero order. FreeBSD is overflow then divide by zero. NetBSD is divide by zero then overflow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[Lldb-commits] [PATCH] D146044: [lldb] Implement CrashReason using UnixSignals

emaste added inline comments. Comment at: lldb/source/Plugins/Process/Utility/FreeBSDSignals.cpp:20 + // SIGILL + AddSignalCode(4, 1 /*ILL_ILLOPC*/, "illegal instruction"); + AddSignalCode(4, 2 /*ILL_ILLOPN*/, "illegal instruction operand"); FreeBSD comment us

[Lldb-commits] [PATCH] D146044: [lldb] Implement CrashReason using UnixSignals

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Utility/FreeBSDSignals.cpp:38 + AddSignalCode(8, 8 /*FPE_FLTSUB*/, "invalid floating point subscript range"); + AddSignalCode(8, 9 /*FPE_FLTIDO*/, "input denormal operation"); + This o

[Lldb-commits] [PATCH] D146044: [lldb] Implement CrashReason using UnixSignals

DavidSpickett added a subscriber: mgorny. DavidSpickett added a comment. @emaste , @mgorny maybe you want to glance at the numbers for the BSDs. I got the codes from the FreeBSD/NetBSD sources, and the signal numbers are as before, using the Darwin numbers. Repository: rG LLVM Github Monorep

[Lldb-commits] [PATCH] D146043: [lldb] Refactor CrashReason

DavidSpickett added reviewers: labath, JDevlieghere. DavidSpickett added a comment. Or in other words "make it look like UnixSignals on the inside". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146043/new/ https://reviews.llvm.org/D146043 ___

[Lldb-commits] [PATCH] D146045: [LLDB] Show sub type of signals when debugging a core file

DavidSpickett created this revision. Herald added subscribers: atanasyan, arichardson, sdardis. Herald added a project: All. DavidSpickett requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. Previously we only looked at the si

[Lldb-commits] [PATCH] D146044: [lldb] Implement CrashReason using UnixSignals

DavidSpickett created this revision. Herald added subscribers: krytarowski, arichardson, emaste. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. By adding signal codes to UnixSignals and adding a n

[Lldb-commits] [PATCH] D146043: [lldb] Refactor CrashReason

DavidSpickett created this revision. Herald added a subscriber: emaste. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. So that there is only one function that NativeThreads call, which takes a sig

[Lldb-commits] [PATCH] D146041: initial commit

mehdi_amini added a comment. Herald added a subscriber: JDevlieghere. You should look into the title and description of the commit: https://cbea.ms/git-commit/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146041/new/ https://reviews.llvm.org/D146

[Lldb-commits] [PATCH] D146041: initial commit

AryanGodara created this revision. Herald added a reviewer: bollu. Herald added subscribers: steakhal, martong, arphaman. Herald added a reviewer: aaron.ballman. Herald added a reviewer: NoQ. Herald added a project: All. AryanGodara requested review of this revision. Herald added projects: clang, L

[Lldb-commits] [PATCH] D145377: [LLDB] Show sub type of memory tagging SEGV when reading a core file

DavidSpickett abandoned this revision. DavidSpickett added a comment. This will be back as part of a series. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145377/new/ https://reviews.llvm.org/D145377 ___

[Lldb-commits] [PATCH] D145950: [lldb] Remove MipsLinuxSignals

DavidSpickett abandoned this revision. DavidSpickett added a comment. Someone else had the same idea: https://github.com/llvm/llvm-project/commit/93a455375c0fa1dd014a3b4571b22e307d15bbf7 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145950/new/ ht