[Lldb-commits] [PATCH] D148400: [lldb] Fix bug to update process public run lock with process state

JDevlieghere added inline comments. Comment at: lldb/source/Target/Process.cpp:404-414 +llvm::StringRef Process::GetAttachSynchronousHijackListenerName() { + return "lldb.internal.Process.AttachSynchronous.hijack"; +} + +llvm::StringRef

[Lldb-commits] [PATCH] D148679: [lldb] Change setting descriptions to use StringRef instead of ConstString

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. These probably do not need to be in the ConstString StringPool

[Lldb-commits] [PATCH] D148400: [lldb] Fix bug to update process public run lock with process state

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148400/new/ https://reviews.llvm.org/D148400 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D148676: [lldb][NFCI] Stop creating additional temporary string in Log::VAPrintf

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. Makes sense. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148676/new/ https://reviews.llvm.org/D148676

[Lldb-commits] [PATCH] D148400: [lldb] Fix bug to update process public run lock with process state

mib updated this revision to Diff 514792. mib marked 3 inline comments as done. mib added a comment. Address @bulbazord comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148400/new/ https://reviews.llvm.org/D148400 Files: lldb/include/lldb/Target/Process.h

[Lldb-commits] [PATCH] D148676: [lldb][NFCI] Stop creating additional temporary string in Log::VAPrintf

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, clayborg. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Instead of creating a std::string from the

[Lldb-commits] [PATCH] D148662: [lldb] Make the libcxx unique_ptr prettyprinter support custom deleters.

jgorbe created this revision. jgorbe added reviewers: shafik, kastiglione. jgorbe added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. The unique_ptr prettyprinter calls `GetValueOfLibCXXCompressedPair`, which looks

[Lldb-commits] [PATCH] D148603: Remove hardcoding of addressing bits in ABIMacOSX_arm64

This revision was automatically updated to reflect the committed changes. Closed by commit rG53430bfd5c9d: Remove hardcoded address bits in ABIMacOS_arm64 (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148603/new/

[Lldb-commits] [lldb] 53430bf - Remove hardcoded address bits in ABIMacOS_arm64

Author: Jason Molenda Date: 2023-04-18T13:01:49-07:00 New Revision: 53430bfd5c9d0074dd6de06dccea366e1d40bce4 URL: https://github.com/llvm/llvm-project/commit/53430bfd5c9d0074dd6de06dccea366e1d40bce4 DIFF: https://github.com/llvm/llvm-project/commit/53430bfd5c9d0074dd6de06dccea366e1d40bce4.diff

[Lldb-commits] [PATCH] D148603: Remove hardcoding of addressing bits in ABIMacOSX_arm64

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148603/new/ https://reviews.llvm.org/D148603

[Lldb-commits] [PATCH] D148650: [lldb] Pass skip_exec=True in TestExec.test_skipping_exec

kastiglione abandoned this revision. kastiglione added a comment. Herald added a subscriber: JDevlieghere. 臘‍♂️ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148650/new/ https://reviews.llvm.org/D148650

[Lldb-commits] [PATCH] D148650: [lldb] Pass skip_exec=True in TestExec.test_skipping_exec

kastiglione created this revision. kastiglione added a reviewer: jingham. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fix the test to match the function name, by passing `skip_exec=True`.

[Lldb-commits] [PATCH] D148546: Reland: [Demangle] replace use of llvm::StringView w/ std::string_view

nickdesaulniers marked 2 inline comments as done. nickdesaulniers added a comment. In D148546#4276926 , @DavidSpickett wrote: > I am confused why startswith is in the itanium demangle namespace but I could > be confusing a specialised function with the

[Lldb-commits] [PATCH] D148541: [lldb] fix build issue on MSVC because of missing byte-swap builtins

ashay-github added a comment. The `llvm::byteswap()` fix is much nicer. Thanks for the change! No, this build error didn't show up on a bot (at least as far as I can tell). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148541/new/

[Lldb-commits] [PATCH] D148546: Reland: [Demangle] replace use of llvm::StringView w/ std::string_view

DavidSpickett added a comment. I am confused why startswith is in the itanium demangle namespace but I could be confusing a specialised function with the generic one that works for any string view. Otherwise looks fine at a glance. Comment at:

[Lldb-commits] [PATCH] D140630: [lldb-vscode] Add data breakpoint support

cimacmillan added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140630/new/ https://reviews.llvm.org/D140630 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D148541: [lldb] fix build issue on MSVC because of missing byte-swap builtins

DavidSpickett added a comment. By the way, did this come up on a bot? Just wondering if I ignored an email, apologies if so. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148541/new/ https://reviews.llvm.org/D148541

[Lldb-commits] [PATCH] D148541: [lldb] fix build issue on MSVC because of missing byte-swap builtins

DavidSpickett added a comment. Thanks for the fix! Made me realise I should have looked harder for an llvm utility in the first place, and it turns out `llvm::byteswap` exists. So I've changed this to use that in

[Lldb-commits] [lldb] 9984cfc - [lldb] Use llvm::byteswap in DumpRegisterValue

Author: David Spickett Date: 2023-04-18T08:18:59Z New Revision: 9984cfc86ed6d5c1558d8dd82d82448e50d704ad URL: https://github.com/llvm/llvm-project/commit/9984cfc86ed6d5c1558d8dd82d82448e50d704ad DIFF: https://github.com/llvm/llvm-project/commit/9984cfc86ed6d5c1558d8dd82d82448e50d704ad.diff