[Lldb-commits] [PATCH] D149719: [LLDB] Add a hook to notify REPLs that an expression was evaluated

wallace created this revision. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. REPL implementations don't have an easy way to know that an expression has been evaluated, so I'm adding a simple function

[Lldb-commits] [PATCH] D149717: [lldb] Make some functions useful to REPLs public

wallace created this revision. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. `StartEventHandlerThread` and `StopEventHandlerThread` are available to the SwiftREPL even though they are protected

[Lldb-commits] [PATCH] D149663: [lldb] Remove FileSpec::GetLastPathComponent

This revision was automatically updated to reflect the committed changes. Closed by commit rGc4f3f5225df7: [lldb] Remove FileSpec::GetLastPathComponent (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149663/new/

[Lldb-commits] [lldb] c4f3f52 - [lldb] Remove FileSpec::GetLastPathComponent

Author: Alex Langford Date: 2023-05-02T17:21:33-07:00 New Revision: c4f3f5225df73cf83042b5e3615549aae0be2422 URL: https://github.com/llvm/llvm-project/commit/c4f3f5225df73cf83042b5e3615549aae0be2422 DIFF: https://github.com/llvm/llvm-project/commit/c4f3f5225df73cf83042b5e3615549aae0be2422.diff

[Lldb-commits] [PATCH] D149671: [lldb] Minor cleanups at callsites of FileSpec::GetFileNameExtension

This revision was automatically updated to reflect the committed changes. Closed by commit rG50e79d725c10: [lldb] Minor cleanups at callsites of FileSpec::GetFileNameExtension (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 50e79d7 - [lldb] Minor cleanups at callsites of FileSpec::GetFileNameExtension

Author: Alex Langford Date: 2023-05-02T17:20:29-07:00 New Revision: 50e79d725c105344e292d1fe8044a69467c20346 URL: https://github.com/llvm/llvm-project/commit/50e79d725c105344e292d1fe8044a69467c20346 DIFF: https://github.com/llvm/llvm-project/commit/50e79d725c105344e292d1fe8044a69467c20346.diff

[Lldb-commits] [PATCH] D149692: Allow scripted thread plans to modify the stop reason shown when the plan completes

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. Alright Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149692/new/ https://reviews.llvm.org/D149692 ___

[Lldb-commits] [lldb] 6ea1a0d - [LLDB] Add/Remove xfail for some API tests on Windows

Author: Muhammad Omair Javaid Date: 2023-05-03T04:45:55+05:00 New Revision: 6ea1a0d4fc3823de143a288df2059b48dc01cf72 URL: https://github.com/llvm/llvm-project/commit/6ea1a0d4fc3823de143a288df2059b48dc01cf72 DIFF:

[Lldb-commits] [PATCH] D149663: [lldb] Remove FileSpec::GetLastPathComponent

mib added a comment. Given the current behavior, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149663/new/ https://reviews.llvm.org/D149663 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D149702: [DebugInfo] Add language code for the new Mojo language

wallace added inline comments. Comment at: lldb/include/lldb/lldb-enumerations.h:493 eLanguageTypeAda2012 = 0x002f, + eLanguageTypeMojo = 0x0030, aprantl wrote: > bulbazord wrote: > > These values correspond to DWARF5's official language codes and `0x0030`

[Lldb-commits] [PATCH] D149702: [DebugInfo] Add language code for the new Mojo language

aprantl added inline comments. Comment at: lldb/include/lldb/lldb-enumerations.h:493 eLanguageTypeAda2012 = 0x002f, + eLanguageTypeMojo = 0x0030, bulbazord wrote: > These values correspond to DWARF5's official language codes and `0x0030` is > technically

[Lldb-commits] [PATCH] D149702: [DebugInfo] Add language code for the new Mojo language

bulbazord added inline comments. Comment at: lldb/include/lldb/lldb-enumerations.h:493 eLanguageTypeAda2012 = 0x002f, + eLanguageTypeMojo = 0x0030, These values correspond to DWARF5's official language codes and `0x0030` is technically already taken. LLDB

[Lldb-commits] [PATCH] D149702: [DebugInfo] Add language code for the new Mojo language

wallace created this revision. Herald added a reviewer: deadalnix. Herald added a subscriber: hiraditya. Herald added a project: All. wallace requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. Modular just announced a new

[Lldb-commits] [PATCH] D149692: Allow scripted thread plans to modify the stop reason shown when the plan completes

jingham added a comment. In D149692#4313715 , @mib wrote: > This looks good to me, although I'm wondering whether instead of passing a > string, we should pass a dictionary. This way the user could either fill the > dictionary with a simple stop reason

[Lldb-commits] [PATCH] D149692: Allow scripted thread plans to modify the stop reason shown when the plan completes

jingham marked an inline comment as done. jingham added inline comments. Comment at: lldb/bindings/python/python-wrapper.swig:390 + if (PyErr_Occurred()) { +printf("Error occured for call to %s.\n", + method_name); mib wrote: > If we passed a

[Lldb-commits] [PATCH] D149692: Allow scripted thread plans to modify the stop reason shown when the plan completes

jingham updated this revision to Diff 518878. jingham added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149692/new/ https://reviews.llvm.org/D149692 Files: lldb/bindings/python/python-wrapper.swig

[Lldb-commits] [PATCH] D149096: [lldb] Speed up looking for dSYM next to executable

bulbazord abandoned this revision. bulbazord added a comment. I'm going to see how we could potentially improve FileSpec's performance rather than go with this approach. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149096/new/

[Lldb-commits] [PATCH] D149697: [lldb] Remove distribution_id from ArchSpec

bulbazord created this revision. bulbazord added reviewers: jasonmolenda, labath, DavidSpickett. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The qHostInfo packet in the gdb-remote communication

[Lldb-commits] [lldb] 2b6c5bb - [lldb-vscode] Implement RestartRequest

Author: Jorge Gorbe Moya Date: 2023-05-02T14:50:39-07:00 New Revision: 2b6c5bb995be1b675c1d92e2d46403c76764e5c7 URL: https://github.com/llvm/llvm-project/commit/2b6c5bb995be1b675c1d92e2d46403c76764e5c7 DIFF:

[Lldb-commits] [PATCH] D147831: [lldb-vscode] Implement RestartRequest

This revision was automatically updated to reflect the committed changes. Closed by commit rG2b6c5bb995be: [lldb-vscode] Implement RestartRequest (authored by jgorbe). Changed prior to commit: https://reviews.llvm.org/D147831?vs=512305=518866#toc Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D149692: Allow scripted thread plans to modify the stop reason shown when the plan completes

mib added a comment. This looks good to me, although I'm wondering whether instead of passing a string, we should pass a dictionary. This way the user could either fill the dictionary with a simple stop reason description or the MachException data What do you think Jim ?

[Lldb-commits] [PATCH] D149692: Allow scripted thread plans to modify the stop reason shown when the plan completes

jingham created this revision. jingham added reviewers: JDevlieghere, delcypher, mib. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We were just printing some fairly ugly boiler plate, for instance:

[Lldb-commits] [lldb] 8b68360 - [lldb] Assert on invalid index in OptionValueProperties (NFC)

Author: Jonas Devlieghere Date: 2023-05-02T12:49:36-07:00 New Revision: 8b6836020464a537c829c56d34ec8f348e1f6056 URL: https://github.com/llvm/llvm-project/commit/8b6836020464a537c829c56d34ec8f348e1f6056 DIFF:

[Lldb-commits] [lldb] ad74df1 - Revert "[lldb][DWARFExpression] Fix DW_OP_div to use signed division"

Author: Michael Buch Date: 2023-05-02T15:36:56-04:00 New Revision: ad74df12b8b2949bd6f45dc469dc41d488e69f78 URL: https://github.com/llvm/llvm-project/commit/ad74df12b8b2949bd6f45dc469dc41d488e69f78 DIFF: https://github.com/llvm/llvm-project/commit/ad74df12b8b2949bd6f45dc469dc41d488e69f78.diff

[Lldb-commits] [PATCH] D147370: [lldb] fixing #61727 fixing incorrect variable displaying with DW_OP_div

Michael137 added a comment. Reverted for now until we find fix for test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147370/new/ https://reviews.llvm.org/D147370 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D147370: [lldb] fixing #61727 fixing incorrect variable displaying with DW_OP_div

Michael137 added a comment. In D147370#4313196 , @asl wrote: > This seems to fail on ARM: > https://lab.llvm.org/buildbot/#/builders/17/builds/37130 Investigating Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D149663: [lldb] Remove FileSpec::GetLastPathComponent

mib added a comment. In D149663#4313123 , @bulbazord wrote: > In D149663#4313112 , @mib wrote: > >> @bulbazord What if the FileSpec is pointing to a directory instead of a file >> ? What would `GetFilename`

[Lldb-commits] [lldb] 419bc85 - Revert "Add amissing REQUIRES: to test"

Author: Adrian Prantl Date: 2023-05-02T11:41:58-07:00 New Revision: 419bc85675fe73f2d19cd3f756cf029248fb4295 URL: https://github.com/llvm/llvm-project/commit/419bc85675fe73f2d19cd3f756cf029248fb4295 DIFF: https://github.com/llvm/llvm-project/commit/419bc85675fe73f2d19cd3f756cf029248fb4295.diff

[Lldb-commits] [PATCH] D147370: [lldb] fixing #61727 fixing incorrect variable displaying with DW_OP_div

asl added a comment. The test seems to rely on the presence of the linker for the desired target platform, so cannot be used on cross-compile environment. TEST 'lldb-shell :: SymbolFile/DWARF/x86/DW_OP_div-with-signed.s' FAILED Script: -- :

[Lldb-commits] [PATCH] D147370: [lldb] fixing #61727 fixing incorrect variable displaying with DW_OP_div

asl added a comment. This seems to fail on ARM: https://lab.llvm.org/buildbot/#/builders/17/builds/37130 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147370/new/ https://reviews.llvm.org/D147370 ___

[Lldb-commits] [PATCH] D149663: [lldb] Remove FileSpec::GetLastPathComponent

bulbazord added a comment. In D149663#4313112 , @mib wrote: > @bulbazord What if the FileSpec is pointing to a directory instead of a file > ? What would `GetFilename` return in that case compared to > `GetLastPathComponent` ? FileSpec chops

[Lldb-commits] [lldb] 1f74964 - Add amissing REQUIRES: to test

Author: Adrian Prantl Date: 2023-05-02T11:16:04-07:00 New Revision: 1f74964b403c615c121c0adbd06661adaae14667 URL: https://github.com/llvm/llvm-project/commit/1f74964b403c615c121c0adbd06661adaae14667 DIFF: https://github.com/llvm/llvm-project/commit/1f74964b403c615c121c0adbd06661adaae14667.diff

[Lldb-commits] [PATCH] D147370: [lldb] fixing #61727 fixing incorrect variable displaying with DW_OP_div

aprantl added a comment. I'll try adding a `# REQUIRES: lld` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147370/new/ https://reviews.llvm.org/D147370 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D149663: [lldb] Remove FileSpec::GetLastPathComponent

mib added a comment. @bulbazord What if the FileSpec is pointing to a directory instead of a file ? What would `GetFilename` return in that case compared to `GetLastPathComponent` ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149663/new/

[Lldb-commits] [PATCH] D147370: [lldb] fixing #61727 fixing incorrect variable displaying with DW_OP_div

aprantl added a comment. This test is failing on Darwin: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/lastFailedBuild/testReport/lldb-shell/SymbolFile_DWARF_x86/DW_OP_div_with_signed_s/ https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/lastFailedBuild/ ld: unknown option:

[Lldb-commits] [lldb] 30c1f31 - [lldb] Fix 8be139fc1251 for propery value changes

Author: Jonas Devlieghere Date: 2023-05-02T11:09:53-07:00 New Revision: 30c1f31274e5abb535387940af2337c2e4fcc8a7 URL: https://github.com/llvm/llvm-project/commit/30c1f31274e5abb535387940af2337c2e4fcc8a7 DIFF:

[Lldb-commits] [PATCH] D149262: [lldb] Add settings for expression evaluation memory allocations.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8be139fc1251: [lldb] Add settings for expression evaluation memory allocations. (authored by kuilpd, committed by asl). Repository: rG LLVM

[Lldb-commits] [lldb] 8be139f - [lldb] Add settings for expression evaluation memory allocations.

Author: Ilya Kuklin Date: 2023-05-02T11:02:44-07:00 New Revision: 8be139fc1251b99316d65403bde9c2326b12da20 URL: https://github.com/llvm/llvm-project/commit/8be139fc1251b99316d65403bde9c2326b12da20 DIFF: https://github.com/llvm/llvm-project/commit/8be139fc1251b99316d65403bde9c2326b12da20.diff

[Lldb-commits] [PATCH] D149262: [lldb] Add settings for expression evaluation memory allocations.

kuilpd updated this revision to Diff 518801. kuilpd added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149262/new/ https://reviews.llvm.org/D149262 Files: lldb/include/lldb/Target/ABI.h lldb/include/lldb/Target/Target.h lldb/source/Expression/IRMemoryMap.cpp

[Lldb-commits] [PATCH] D149671: [lldb] Minor cleanups at callsites of FileSpec::GetFileNameExtension

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, jasonmolenda. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. FileSpec::GetFileNameExtension returns a

[Lldb-commits] [PATCH] D149625: [lldb] Refactor SBFileSpec::GetDirectory

bulbazord added a comment. In D149625#4312838 , @jingham wrote: > The old code had the side-effect of NOT resolving the path of the SBFileSpec > in order to get its directory. I am not sure whether that was on purpose or > not, however. To be more

[Lldb-commits] [PATCH] D149663: [lldb] Remove FileSpec::GetLastPathComponent

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149663/new/ https://reviews.llvm.org/D149663

[Lldb-commits] [PATCH] D149663: [lldb] Remove FileSpec::GetLastPathComponent

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, jasonmolenda. Herald added a subscriber: emaste. Herald added a project: All. bulbazord requested review of this revision. Herald added subscribers: lldb-commits, MaskRay. Herald added a project: LLDB. As far

[Lldb-commits] [PATCH] D149625: [lldb] Refactor SBFileSpec::GetDirectory

jingham added a comment. The old code had the side-effect of NOT resolving the path of the SBFileSpec in order to get its directory. I am not sure whether that was on purpose or not, however. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D149625: [lldb] Refactor SBFileSpec::GetDirectory

This revision was automatically updated to reflect the committed changes. Closed by commit rG2bea2d7b070d: [lldb] Refactor SBFileSpec::GetDirectory (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149625/new/

[Lldb-commits] [lldb] 2bea2d7 - [lldb] Refactor SBFileSpec::GetDirectory

Author: Alex Langford Date: 2023-05-02T10:01:36-07:00 New Revision: 2bea2d7b070dc5df723ce2b92dbc654b8bb1847e URL: https://github.com/llvm/llvm-project/commit/2bea2d7b070dc5df723ce2b92dbc654b8bb1847e DIFF: https://github.com/llvm/llvm-project/commit/2bea2d7b070dc5df723ce2b92dbc654b8bb1847e.diff

[Lldb-commits] [PATCH] D149641: [docs] Hide collaboration and include graphs in doxygen docs

tianshilei1992 added a comment. Looks good on the OpenMP side as we don’t generally have a good API doc anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149641/new/ https://reviews.llvm.org/D149641

[Lldb-commits] [PATCH] D149641: [docs] Hide collaboration and include graphs in doxygen docs

aaron.ballman added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: jplehr, sstefan1, JDevlieghere. I think this is a reasonable change -- I don't see a whole lot of value out from the include or collaboration graphs, so unless someone has strong opinions otherwise, I

[Lldb-commits] [lldb] 73e15b5 - [lldb] Add cstdio include to fix a595b931f1f91897317a4257df313bddfeb029a6

Author: Dmitry Chernenkov Date: 2023-05-02T12:47:37Z New Revision: 73e15b5edb4fa4a77e68c299a6e3b21e610d351f URL: https://github.com/llvm/llvm-project/commit/73e15b5edb4fa4a77e68c299a6e3b21e610d351f DIFF: https://github.com/llvm/llvm-project/commit/73e15b5edb4fa4a77e68c299a6e3b21e610d351f.diff

[Lldb-commits] [PATCH] D147370: [lldb] fixing #61727 fixing incorrect variable displaying with DW_OP_div

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe15d6b520e1e: [lldb][DWARFExpression] Fix DW_OP_div to use signed division (authored by jwnhy, committed by Michael137). Repository: rG LLVM

[Lldb-commits] [lldb] e15d6b5 - [lldb][DWARFExpression] Fix DW_OP_div to use signed division

Author: LU Hongyi Date: 2023-05-02T07:38:52-04:00 New Revision: e15d6b520e1e85d2cdf9ffc66f0c4698390eaa3d URL: https://github.com/llvm/llvm-project/commit/e15d6b520e1e85d2cdf9ffc66f0c4698390eaa3d DIFF: https://github.com/llvm/llvm-project/commit/e15d6b520e1e85d2cdf9ffc66f0c4698390eaa3d.diff

[Lldb-commits] [lldb] 52882de - [lldb][test] TestCPP20Standard.py: make it a libc++ test

Author: Michael Buch Date: 2023-05-02T07:38:53-04:00 New Revision: 52882de0e641487329c9e093a90ea3dad01842c8 URL: https://github.com/llvm/llvm-project/commit/52882de0e641487329c9e093a90ea3dad01842c8 DIFF: https://github.com/llvm/llvm-project/commit/52882de0e641487329c9e093a90ea3dad01842c8.diff

[Lldb-commits] [PATCH] D149641: [docs] Hide collaboration and include graphs in doxygen docs

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, shafik. Herald added a reviewer: bollu. Herald added subscribers: bviyer, Moerafaat, zero9178, bzcheeseman, ayermolo, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1,

[Lldb-commits] [lldb] ddd9358 - [lldb] Remove unused will_modify argument (NFC)

Author: Jonas Devlieghere Date: 2023-05-02T00:20:34-07:00 New Revision: ddd9358bcaef5a348dd387a6a27539f7f49646d1 URL: https://github.com/llvm/llvm-project/commit/ddd9358bcaef5a348dd387a6a27539f7f49646d1 DIFF: